[Bug middle-end/25886] New: almost to 256 tree codes for Objective-C++

[Bug middle-end/25886] New: almost to 256 tree codes for Objective-C++

[pinskia at gcc dot gnu dot org]

Objective-C++ uses 256 tree codes and yes it uses all of them.

So Objective-C++ fails.


-- 
           Summary: almost to 256 tree codes for Objective-C++
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25886

[Bug middle-end/25886] [4.2 Regression] up to 256 tree codes for Objective-C++

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-01-20 19:26 -------
Caused by:
2006-01-19  Diego Novillo  <dnovillo@redhat.com>
        * tree.def (BLOCK): Remove documentation about BLOCK_TYPE_TAGS.
        (OMP_PARALLEL): Add 3 operands.
        (OMP_SECTIONS): Add 1 operand.
        (OMP_RETURN_EXPR): Define.

That last define caused this regression.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dnovillo at gcc dot gnu dot
                   |                            |org
           Keywords|                            |build
            Summary|almost to 256 tree codes for|[4.2 Regression] up to 256
                   |Objective-C++               |tree codes for Objective-C++
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25886

[Bug middle-end/25886] [4.2 Regression] up to 256 tree codes for Objective-C++

[bonzini at gnu dot org]

------- Comment #2 from bonzini at gnu dot org  2006-01-23 15:41 -------
This is nasty.  I think that the easiest codes to remove are PARM_DECL and
RESULT_DECL.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25886

[Bug middle-end/25886] [4.2 Regression] up to 256 tree codes for Objective-C++

[dnovillo at gcc dot gnu dot org]

------- Comment #3 from dnovillo at gcc dot gnu dot org  2006-01-23 17:26 -------

Working on it.


-- 

dnovillo at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |dnovillo at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-01-23 17:26:13
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25886

[Bug middle-end/25886] [4.2 Regression] up to 256 tree codes for Objective-C++

[dnovillo at gcc dot gnu dot org]

------- Comment #4 from dnovillo at gcc dot gnu dot org  2006-01-26 02:53 -------
Subject: Bug 25886

Author: dnovillo
Date: Thu Jan 26 02:53:01 2006
New Revision: 110243

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110243
Log:

        * tree.h (TREE_RANGE_CHECK): Fix range predicate.
        (TREE_BLOCK): Add call to EXPR_CHECK.


        PR 25886
        * tree-dump.c (dequeue_and_dump): Handle OMP_CLAUSE.
        * tree-pretty-print.c (dump_omp_clause): Extract from ...
        (dump_omp_clauses): ... here.
        (dump_generic_node): Handle OMP_CLAUSE.
        * tree.c (omp_clause_num_ops): New.
        (omp_clause_code_name): New.
        (tree_code_size): Handle OMP_CLAUSE.
        (tree_size): Likewise.
        (make_node): Document handling of OMP_CLAUSE.
        (tree_node_structure): Handle OMP_CLAUSE.
        (omp_clause_check_failed): New.
        (omp_clause_range_check_failed): New.
        (omp_clause_operand_check_failed): New.
        (build_omp_clause): New.
        (walk_tree): Adjust handling of OMP_CLAUSE_* nodes.
        * tree.h (enum omp_clause_code): Declare.
        (OMP_CLAUSE_SUBCODE): Define.
        (OMP_CLAUSE_RANGE_CHECK): Define.
        (OMP_CLAUSE_ELT_CHECK): Define.
        (omp_clause_check_failed): Declare.
        (omp_clause_operand_check_failed): Declare.
        (omp_clause_range_check_failed): Declare.
        (OMP_CLAUSE_CHAIN): Do not use TREE_RANGE_CHECK.
        (OMP_CLAUSE_OPERAND): Use OMP_CLAUSE_RANGE_CHECK.
        (OMP_CLAUSE_PRIVATE_DEBUG): Use OMP_CLAUSE_SUBCODE_CHECK.
        (OMP_CLAUSE_LASTPRIVATE): Likewise.
        (OMP_CLAUSE_IF_EXPR): Likewise.
        (OMP_CLAUSE_NUM_THREADS_EXPR): Likewise.
        (OMP_CLAUSE_SCHEDULE_CHUNK_EXPR): Likewise.
        (OMP_CLAUSE_REDUCTION_CODE): Likewise.
        (OMP_CLAUSE_REDUCTION_INIT): Likewise.
        (OMP_CLAUSE_REDUCTION_MERGE): Likewise.
        (OMP_CLAUSE_REDUCTION_PLACEHOLDER): Likewise.
        Use tree_node.omp_clause.subcode instead of TREE_COMPLEXITY.
        (OMP_CLAUSE_SCHEDULE_KIND): Likewise.
        (OMP_CLAUSE_DEFAULT_KIND): Likewise.
        (OMP_CLAUSE_CODE): Define.
        (OMP_CLAUSE_SET_CODE): Define.
        (OMP_CLAUSE_CODE): Define.
        (OMP_CLAUSE_OPERAND): Define.
        (struct tree_omp_clause): Declare.
        (union tree_node): Add field 'omp_clause'.
        * treestruct.def (TS_OMP_CLAUSE): Define.
        * tree.def (OMP_CLAUSE_PRIVATE, OMP_CLAUSE_SHARED
        OMP_CLAUSE_FIRSTPRIVATE, OMP_CLAUSE_LASTPRIVATE,
        OMP_CLAUSE_REDUCTION, OMP_CLAUSE_COPYIN,
        OMP_CLAUSE_COPYPRIVATE, OMP_CLAUSE_IF,
        OMP_CLAUSE_NUM_THREADS, OMP_CLAUSE_SCHEDULE,
        OMP_CLAUSE_NOWAIT, OMP_CLAUSE_ORDERED, OMP_CLAUSE_DEFAULT): Remove.
        (OMP_CLAUSE): Define.
        * print-tree.c (print_node): Handle OMP_CLAUSE.
        * omp-low.c: Adapt all uses of OMP_CLAUSE_* nodes.
        * c-typeck.c: Likewise.
        * gimplify.c: Likewise.
        * c-omp.c: Likewise.
        * tree-nested.c: Likewise.
        * tree-inline.c: Likewise.
        * c-parser.c: Likewise.
        * gimple-low.c (lower_omp_directive): Do not set TREE_BLOCK on
        clauses.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-omp.c
    trunk/gcc/c-parser.c
    trunk/gcc/c-typeck.c
    trunk/gcc/gimple-low.c
    trunk/gcc/gimplify.c
    trunk/gcc/omp-low.c
    trunk/gcc/print-tree.c
    trunk/gcc/tree-dump.c
    trunk/gcc/tree-inline.c
    trunk/gcc/tree-nested.c
    trunk/gcc/tree-pretty-print.c
    trunk/gcc/tree.c
    trunk/gcc/tree.def
    trunk/gcc/tree.h
    trunk/gcc/treestruct.def


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25886

[Bug middle-end/25886] [4.2 Regression] up to 256 tree codes for Objective-C++

[dnovillo at gcc dot gnu dot org]

------- Comment #5 from dnovillo at gcc dot gnu dot org  2006-01-26 02:57 -------

Fixed.  http://gcc.gnu.org/ml/gcc-patches/2006-01/msg01745.html


-- 

dnovillo at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25886

[Bug middle-end/25886] [4.2 Regression] up to 256 tree codes for Objective-C++

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25886

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Thomas Schwinge <tschwinge@gcc.gnu.org>:

https://gcc.gnu.org/g:424e46015762920b37e23670b7c518d9891348ed

commit r12-3293-g424e46015762920b37e23670b7c518d9891348ed
Author: Thomas Schwinge <thomas@codesourcery.com>
Date:   Fri Aug 27 07:49:55 2021 +0200

    Simplify 'gcc/tree.c:walk_tree_1' handling of 'OMP_CLAUSE'

    No behavioral change, other than that for a few clauses, operands are now
    walked in a different order, and 'OMP_CLAUSE_ERROR' now no longer runs into
    'default: gcc_unreachable ();' here (but instead will at some later stage).

    Follow-up for r110243 (commit aaf46ef9792bbc562175b606bd1c3f225ea56924)
    "Fix PR 25886.  Convert OMP_CLAUSE_* into sub-codes".

            gcc/
            * tree.c (walk_tree_1) <OMP_CLAUSE>: Simplify.