[Bug testsuite/25728] New: File descriptor leak in

[Bug testsuite/25728] New: File descriptor leak in

[hjl at lucon dot org]

verify-lines in gcc/testsuite/lib/gcov.exp has

proc verify-lines { testcase file } {
    #send_user "verify-lines\n"
    set failed 0
    set fd [open $file r]
    while { [gets $fd line] >= 0 } {
        if [regexp "^ *(\[^:]*): *(\[0-9\]+):.*count\\((\[0-9\]+)\\)" \
                "$line" all is n shouldbe] {
            if { $is == "" } {
                fail "$n:no data available for this line"
                incr failed
            } elseif { $is != $shouldbe } {
                fail "$n:is $is:should be $shouldbe"
                incr failed
            }
        }
    }
    return $failed
}

There is no "close $fd", which leads to file descriptor leak.


-- 
           Summary: File descriptor leak in
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl at lucon dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25728

[Bug testsuite/25728] File descriptor leak in lib/gcov.exp

[hjl at lucon dot org]

------- Comment #1 from hjl at lucon dot org  2006-01-09 19:59 -------
A patch is posted at

http://gcc.gnu.org/ml/gcc-patches/2006-01/msg00495.html


-- 

hjl at lucon dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
            Summary|File descriptor leak in     |File descriptor leak in
                   |                            |lib/gcov.exp


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25728

[Bug testsuite/25728] File descriptor leak in lib/gcov.exp

[hjl at gcc dot gnu dot org]

------- Comment #2 from hjl at gcc dot gnu dot org  2006-01-12 01:29 -------
Subject: Bug 25728

Author: hjl
Date: Thu Jan 12 01:29:07 2006
New Revision: 109627

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=109627
Log:
2006-01-11  H.J. Lu  <hongjiu.lu@intel.com>

        PR testsuite/25728
        * lib/gcov.exp (verify-lines): Add "close $fd".

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/lib/gcov.exp


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25728

[Bug testsuite/25728] File descriptor leak in lib/gcov.exp

[hjl at gcc dot gnu dot org]

------- Comment #3 from hjl at gcc dot gnu dot org  2006-01-12 01:35 -------
Subject: Bug 25728

Author: hjl
Date: Thu Jan 12 01:35:21 2006
New Revision: 109628

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=109628
Log:
2006-01-11  H.J. Lu  <hongjiu.lu@intel.com>

        PR testsuite/25728
        * lib/gcov.exp (verify-lines): Add "close $fd".

Modified:
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_1-branch/gcc/testsuite/lib/gcov.exp


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25728

[Bug testsuite/25728] File descriptor leak in lib/gcov.exp

[hjl at gcc dot gnu dot org]

------- Comment #4 from hjl at gcc dot gnu dot org  2006-01-12 01:40 -------
Subject: Bug 25728

Author: hjl
Date: Thu Jan 12 01:40:48 2006
New Revision: 109631

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=109631
Log:
2006-01-11  H.J. Lu  <hongjiu.lu@intel.com>

        PR testsuite/25728
        * lib/gcov.exp (verify-lines): Add "close $fd".

Modified:
    branches/gcc-4_0-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_0-branch/gcc/testsuite/lib/gcov.exp


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25728

[Bug testsuite/25728] File descriptor leak in lib/gcov.exp

[hjl at gcc dot gnu dot org]

------- Comment #5 from hjl at gcc dot gnu dot org  2006-01-12 01:45 -------
Subject: Bug 25728

Author: hjl
Date: Thu Jan 12 01:45:54 2006
New Revision: 109632

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=109632
Log:
2006-01-11  H.J. Lu  <hongjiu.lu@intel.com>

        PR testsuite/25728
        * lib/gcov.exp (verify-lines): Add "close $fd".

Modified:
    branches/gcc-3_4-branch/gcc/testsuite/ChangeLog
    branches/gcc-3_4-branch/gcc/testsuite/lib/gcov.exp


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25728

[Bug testsuite/25728] File descriptor leak in lib/gcov.exp

[hjl at lucon dot org]

------- Comment #6 from hjl at lucon dot org  2006-01-12 01:47 -------
Fixed.


-- 

hjl at lucon dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25728

[Bug testsuite/25728] File descriptor leak in lib/gcov.exp

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.0.3 3.4.6 4.1.0 4.2.0
   Target Milestone|---                         |3.4.6


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25728