public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "amylaar at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/26004] [4.1/4.2 Regression] gcc errors on valid code [SVO]
Date: Mon, 30 Jan 2006 18:29:00 -0000	[thread overview]
Message-ID: <20060130182955.27483.qmail@sourceware.org> (raw)
In-Reply-To: <bug-26004-12087@http.gcc.gnu.org/bugzilla/>



------- Comment #4 from amylaar at gcc dot gnu dot org  2006-01-30 18:29 -------
(In reply to comment #3)
> This is caused by the following code in gimplifier:
> 3297                if (use_target)
> 3298                  {
> 3299                    CALL_EXPR_RETURN_SLOT_OPT (*from_p) = 1;
> 3300                    lang_hooks.mark_addressable (*to_p);
> 3301                  }
> 
> 
> Should we really be calling lang_hooks.mark_addressable, here?
> 

I think the problem is actually not testing properly if the value is a
register variable first.

A few lines before in gimplify.c:gimplify_modify_expr_rhs, we have:

            else if (is_gimple_reg_type (TREE_TYPE (*to_p)))
              /* Also don't force regs into memory.  */
              use_target = false;

However, is_gimple_reg_type merely looks if the type is an aggregate.
The test that c-typeck.c:c_mark_addressable uses tests C_DECL_REGISTER .

It appears we actually don't have any way to query from the
frontend-indenpendent code if we can mark something as
safely.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26004


  parent reply	other threads:[~2006-01-30 18:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-28 13:06 [Bug c/26004] New: gcc errors on valid code gcc-bugzilla at gcc dot gnu dot org
2006-01-28 15:17 ` [Bug c/26004] [4.1/4.2 Regression] " pinskia at gcc dot gnu dot org
2006-01-30 17:42 ` amylaar at gcc dot gnu dot org
2006-01-30 18:01 ` [Bug c/26004] [4.1/4.2 Regression] gcc errors on valid code [SVO] pinskia at gcc dot gnu dot org
2006-01-30 18:29 ` amylaar at gcc dot gnu dot org [this message]
2006-01-30 18:32 ` amylaar at gcc dot gnu dot org
2006-01-30 18:38 ` amylaar at gcc dot gnu dot org
2006-02-01  3:14 ` mmitchel at gcc dot gnu dot org
2006-02-15 21:41 ` amylaar at gcc dot gnu dot org
2006-02-15 21:47 ` pinskia at gcc dot gnu dot org
2006-02-15 21:48 ` pinskia at gcc dot gnu dot org
2006-02-24  0:31 ` mmitchel at gcc dot gnu dot org
2006-03-07 12:28 ` pinskia at gcc dot gnu dot org
2006-03-07 19:52 ` [Bug c/26004] [4.1 " pinskia at gcc dot gnu dot org
2006-03-07 19:55 ` pinskia at gcc dot gnu dot org
2006-03-07 21:02 ` [Bug c/26004] [4.1/4.2 " pinskia at gcc dot gnu dot org
2006-03-07 21:06 ` pinskia at gcc dot gnu dot org
2006-03-08  1:34 ` janis at gcc dot gnu dot org
2006-03-09 17:22 ` jason at gcc dot gnu dot org
2006-03-10 22:47 ` jason at gcc dot gnu dot org
2006-03-10 23:20 ` [Bug middle-end/26004] [4.1 " pinskia at gcc dot gnu dot org
2006-03-10 23:42 ` jason at gcc dot gnu dot org
2006-03-11  0:10 ` pinskia at gcc dot gnu dot org
2006-06-07 15:42 ` pinskia at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060130182955.27483.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).