[Bug fortran/25251] New: NIST Failure - FM013.f at -O2

[Bug fortran/25251] New: NIST Failure - FM013.f at -O2

[jvdelisle at gcc dot gnu dot org]

Well now that I have the test suite working easy I decided to explore a little.
 At higher levels of optimization everything works good except:

$ gfc -w -O2 FM013.f
/tmp/ccm7knWJ.o(.text+0x4a3): In function `MAIN__':
FM013.f: undefined reference to `.L3'
/tmp/ccm7knWJ.o(.text+0x598):FM013.f: undefined reference to `.L15'
/tmp/ccm7knWJ.o(.text+0x5c4):FM013.f: undefined reference to `.L15'
/tmp/ccm7knWJ.o(.text+0x68a):FM013.f: undefined reference to `.L27'
collect2: ld returned 1 exit status 

This is not really a Fortran issue.


-- 
           Summary: NIST Failure - FM013.f at -O2
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jvdelisle at gcc dot gnu dot org
  GCC host triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25251

[Bug fortran/25251] NIST Failure - FM013.f at -O2

[steven at gcc dot gnu dot org]

------- Comment #1 from steven at gcc dot gnu dot org  2005-12-04 17:14 -------
.


-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |steven at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-12-04 17:14:01
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25251

[Bug middle-end/25251] NIST Failure - FM013.f at -O2

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2005-12-04 17:23 -------
Hmm, we are removing a reference to a local label, this could either be a tree
level problem (which I thought I fixed) or a rtl level issue which is much
harder to fix.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
          Component|fortran                     |middle-end
           Keywords|                            |assemble-failure, link-
                   |                            |failure


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25251

[Bug middle-end/25251] NIST Failure - FM013.f at -O2

[kargl at gcc dot gnu dot org]

------- Comment #3 from kargl at gcc dot gnu dot org  2006-02-05 03:10 -------
Created an attachment (id=10779)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10779&action=view)
reduced testcase


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25251

[Bug tree-optimization/25251] NIST Failure - FM013.f at -O2

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2006-02-05 03:25 -------
I am going to take this one over.  Final_cleanup is removing the labels for
some reason.  Will look more into why it is removing them.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|steven at gcc dot gnu dot   |pinskia at gcc dot gnu dot
                   |org                         |org
          Component|middle-end                  |tree-optimization


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25251

[Bug tree-optimization/25251] NIST Failure - FM013.f at -O2

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2006-02-05 03:30 -------
In cleanup_dead_labels, we forget to check if the label's address has been
taken.  The reason why this works with a C example is because the labels are
not marked as artificial.

Fixing it now.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25251

[Bug tree-optimization/25251] NIST Failure - FM013.f at -O2

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2006-02-05 03:55 -------
The patch I am testing right now:
Index: tree-cfg.c
===================================================================
--- tree-cfg.c  (revision 110536)
+++ tree-cfg.c  (working copy)
@@ -1108,7 +1108,8 @@ cleanup_dead_labels (void)
   for_each_eh_region (update_eh_label);

   /* Finally, purge dead labels.  All user-defined labels and labels that
-     can be the target of non-local gotos are preserved.  */
+     can be the target of non-local gotos and labels which have their
+     address taken are preserved.  */
   FOR_EACH_BB (bb)
     {
       block_stmt_iterator i;
@@ -1128,7 +1129,8 @@ cleanup_dead_labels (void)

          if (label == label_for_this_bb
              || ! DECL_ARTIFICIAL (label)
-             || DECL_NONLOCAL (label))
+             || DECL_NONLOCAL (label)
+             || FORCED_LABEL (label))
            bsi_next (&i);
          else
            bsi_remove (&i, true);


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25251

[Bug tree-optimization/25251] NIST Failure - FM013.f at -O2

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2006-02-05 19:33 -------
Patch posted:
http://gcc.gnu.org/ml/gcc-patches/2006-02/msg00393.html


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2006-
                   |                            |02/msg00393.html
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25251

[Bug tree-optimization/25251] NIST Failure - FM013.f at -O2

[pinskia at gcc dot gnu dot org]

------- Comment #8 from pinskia at gcc dot gnu dot org  2006-02-05 20:29 -------
Subject: Bug 25251

Author: pinskia
Date: Sun Feb  5 20:29:10 2006
New Revision: 110621

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110621
Log:
2006-02-05  Andrew Pinski  <pinskia@physics.uc.edu>

        PR tree-opt/25251
        * tree-cfg.c (cleanup_dead_labels): Also don't remove
        forced labels.

2006-02-05  Andrew Pinski  <pinskia@physics.uc.edu>

        PR tree-opt/25251
        * gfortran.dg/assign_7.f: New test.


Added:
    trunk/gcc/testsuite/gfortran.dg/assign_7.f
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-cfg.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25251

[Bug tree-optimization/25251] [4.1 only] NIST Failure - FM013.f at -O2

[pinskia at gcc dot gnu dot org]

------- Comment #9 from pinskia at gcc dot gnu dot org  2006-02-05 20:29 -------
Fixed on the mainline will commit to the 4.1 branch in a day or two.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|NIST Failure - FM013.f at - |[4.1 only] NIST Failure -
                   |O2                          |FM013.f at -O2
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25251

[Bug tree-optimization/25251] [4.1 only] NIST Failure - FM013.f at -O2

[pinskia at gcc dot gnu dot org]

------- Comment #11 from pinskia at gcc dot gnu dot org  2006-02-09 14:46 -------
Fixed now in 4.1.0.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25251

[Bug tree-optimization/25251] [4.1 only] NIST Failure - FM013.f at -O2

[pinskia at gcc dot gnu dot org]

------- Comment #10 from pinskia at gcc dot gnu dot org  2006-02-09 14:46 -------
Subject: Bug 25251

Author: pinskia
Date: Thu Feb  9 14:46:04 2006
New Revision: 110802

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110802
Log:
2006-02-09  Andrew Pinski  <pinskia@physics.uc.edu>

        PR tree-opt/25251
        * gfortran.dg/assign_7.f: New test.

2006-02-09  Andrew Pinski  <pinskia@physics.uc.edu>

        PR tree-opt/25251
        * tree-cfg.c (cleanup_dead_labels): Also don't remove
        forced labels.



Added:
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/assign_7.f
      - copied unchanged from r110621,
trunk/gcc/testsuite/gfortran.dg/assign_7.f
Modified:
    branches/gcc-4_1-branch/gcc/ChangeLog
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_1-branch/gcc/tree-cfg.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25251

[Bug tree-optimization/25251] [4.1 only] NIST Failure - FM013.f at -O2

[pinskia at gcc dot gnu dot org]

------- Comment #12 from pinskia at gcc dot gnu dot org  2006-03-08 15:11 -------
*** Bug 20477 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wf_cs at yahoo dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25251