[Bug fortran/26136] New: namelist doesn't work correctly

[Bug fortran/26136] New: namelist doesn't work correctly

[hjl at lucon dot org]

namelist doesn't work correctly


-- 
           Summary: namelist doesn't work correctly
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl at lucon dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug fortran/26136] namelist doesn't work correctly

[hjl at lucon dot org]

------- Comment #1 from hjl at lucon dot org  2006-02-06 19:36 -------
Created an attachment (id=10790)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10790&action=view)
A testcase

I got

/export/build/gnu/gcc/build-x86_64-linux/gcc/gfortran
-B/export/build/gnu/gcc/build-x86_64-linux/gcc/ -O2 -o foo foo.f90
./foo
make: *** [all] Aborted
[hjl@gnu-16 namelist]$


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] arrays in namelist with not finished input does not work correctly

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2006-02-06 20:27 -------
Confirmed.
Simple example:
!{ dg-do run }
! Tests filling variables from a namelist read when object list is
! not complete.
program pr

   implicit none
   integer, parameter :: max_domains = 4
   integer ier
   logical, dimension(max_domains) :: non_hydrostatic
   integer, dimension(max_domains) :: time_step_sound
   namelist /dynamics/ non_hydrostatic
   namelist /dynamics/ time_step_sound

   non_hydrostatic = .true.

   read (5, nml=dynamics, iostat=ier, err = 1000)
   print *, non_hydrostatic
   print *, time_step_sound

   stop
1000 call abort()
end program pr
----
cat a
 &dynamics
 non_hydrostatic                     = .true., .true., .true
 time_step_sound = 4,      4,      4,
 /
--------
./a.out < a
namelist read: missplaced = sign
Cannot match namelist object name 4,
Cannot match namelist object name 4,
Cannot match namelist object name 4,

 T T T T
       19036 -1881089148 -1073742864  1140850722

So what is happening is that we don't recognize the start of the differrent
namelist object.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-02-06 20:27:42
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] 't' in namelist input is treated as logical TRUE

[hjl at lucon dot org]

------- Comment #3 from hjl at lucon dot org  2006-02-06 21:39 -------
The problem is we have

   logical, dimension(max_domains) :: non_hydrostatic
   integer, dimension(max_domains) :: time_step_sound
   namelist /dynamics/ non_hydrostatic
   namelist /dynamics/ time_step_sound

The input is

 &dynamics
 non_hydrostatic                     = .true.,
 time_step_sound                     = 4,      4,      4,
 /

read_logical () thinks the first 't' in time_step_sound is logical TRUE.


-- 

hjl at lucon dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|arrays in namelist with not |'t' in namelist input is
                   |finished input does not work|treated as logical TRUE
                   |correctly                   |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] 't' in namelist input is treated as logical TRUE

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2006-02-06 21:44 -------
The bug is in read_logical.  We eat the 't' and try to find the next seperator.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] 't' in namelist input is treated as logical TRUE

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2006-02-06 22:25 -------
g77 had the same bug until PR 957 was fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |957


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2006-02-06 22:34 -------
This was the patch to libi77 which fixed the problem for g77:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libf2c/libI77/Attic/lread.c.diff?r1=1.4&r2=1.5&only_with_tag=MAIN&f=h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2006-02-06 22:43 -------
Does this code show up in SPEC CPU 2006?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[hjl at lucon dot org]

------- Comment #8 from hjl at lucon dot org  2006-02-06 23:47 -------
This is in SPEC CPU 2006. But it needs a patch to compile with gcc 4.2. Since
I can't verify if gcc 4.2 compiles this benchmark correctly, I am reluctant
to sumbit my patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[jvdelisle at gcc dot gnu dot org]

------- Comment #9 from jvdelisle at gcc dot gnu dot org  2006-02-07 02:42 -------
This is pr 24459, see discussion there.  


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[pinskia at gcc dot gnu dot org]

------- Comment #10 from pinskia at gcc dot gnu dot org  2006-02-07 02:50 -------
(In reply to comment #9)
> This is pr 24459, see discussion there.  

Jerry, I would like to disagree based on the the old bug g77 bug I found which
shows really what is going on here and why this is not really a dup of bug
24459. 


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |19292
              nThis|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[jvdelisle at gcc dot gnu dot org]

------- Comment #11 from jvdelisle at gcc dot gnu dot org  2006-02-07 04:15 -------
(In reply to comment #10)
Yes, After looking at this more closely I agree this is not a dup. First letter
f or t of the next name object is being interpreted as the next logical value
in the incomplete array.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jvdelisle at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[hjl at lucon dot org]

------- Comment #12 from hjl at lucon dot org  2006-02-12 01:31 -------
It looks like that unget_char needs to modified to increase the supported
number
of unget. The current number is 1. We can't do

  unget_char (dtp, c);
  unget_char (dtp, c);
  unget_char (dtp, c);

We can have an unget buffer in st_parameter_dt and change last_char to a
pointer
which indexes to the unget buffer. The unget buffer only needs big enough to
hold the longest logical string we want to support.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[jvdelisle at gcc dot gnu dot org]

------- Comment #13 from jvdelisle at gcc dot gnu dot org  2006-02-12 06:36 -------
Yes, I am working on a scheme that will provide deeper ungets when needed. 
Half way there now.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[jvdelisle at gcc dot gnu dot org]

------- Comment #14 from jvdelisle at gcc dot gnu dot org  2006-02-17 00:07 -------
A patch is testing and I am working up some additional test cases.  The test
case in this PR is working.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[patchapp at dberlin dot org]

------- Comment #15 from patchapp at dberlin dot org  2006-02-17 04:33 -------
Subject: Bug number PR26136

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-02/msg01387.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[hjl at lucon dot org]

------- Comment #16 from hjl at lucon dot org  2006-02-17 18:42 -------
The patch

http://gcc.gnu.org/ml/gcc-patches/2006-02/msg01387.html

is incomplete:

[hjl@gnu-16 namelist-3]$ cat namelist.input.1
 &dynamics
 non_hydrostatic                     = .true.,
 time_step_sound                     = 4,      4,      4,
 /
[hjl@gnu-16 namelist-3]$ ./foo < namelist.input.1
Cannot match namelist object name 4,
Cannot match namelist object name 4,

Aborted
[hjl@gnu-16 namelist-3]$ cat namelist.input.2
 &dynamics
 non_hydrostatic                     = .true., .true.,
 time_step_sound                     = 4,      4,      4,
 /
[hjl@gnu-16 namelist-3]$ ./foo < namelist.input.2
Cannot match namelist object name 4,
Cannot match namelist object name 4,
Cannot match namelist object name 4,

 T T T T
 -1073743496         127 -1073743512         127
[hjl@gnu-16 namelist-3]$ cat namelist.input.3
 &dynamics
 non_hydrostatic                     = .true.,.true., .true.,
 time_step_sound                     = 4,      4,      4,
 /
[hjl@gnu-16 namelist-3]$ ./foo < namelist.input.3
 T T T T
           4           4           4         127
[hjl@gnu-16 namelist-3]$


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[jvdelisle at gcc dot gnu dot org]

------- Comment #17 from jvdelisle at gcc dot gnu dot org  2006-02-18 05:15 -------
Indeed you have found something I missed.  I am on it.  BTW Your
namelist.input.3 is correct, keeping in mind that gfortran does not initialize
variables and the result of an incomplete array is null value, meaning it does
nothing.

Thanks for testing, it helps.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[jvdelisle at gcc dot gnu dot org]

------- Comment #18 from jvdelisle at gcc dot gnu dot org  2006-02-18 07:22 -------
Created an attachment (id=10871)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10871&action=view)
Updated patch.

Updated patch to fix problem found in Comment #16


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[jvdelisle at gcc dot gnu dot org]

------- Comment #19 from jvdelisle at gcc dot gnu dot org  2006-02-18 07:54 -------
Just so everyone understands.  I am working one more modification to this patch
to allow 63 character long names in the tests for logical true or false in
namelist reads.  The patch in Comment #18 works for all cases found so far, but
is limited to 31 character variable name tests.  Testing and expanded test
cases in the queue.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[jvdelisle at gcc dot gnu dot org]

------- Comment #20 from jvdelisle at gcc dot gnu dot org  2006-02-19 20:31 -------
Final patch waiting for review/approval:

http://gcc.gnu.org/ml/fortran/2006-02/msg00421.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[jvdelisle at gcc dot gnu dot org]

------- Comment #21 from jvdelisle at gcc dot gnu dot org  2006-03-01 06:04 -------
Subject: Bug 26136

Author: jvdelisle
Date: Wed Mar  1 06:04:45 2006
New Revision: 111597

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=111597
Log:
2006-02-28  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/26136
        * io/io.h: Add flag for reading from line_buffer.
        * io/list_read.c (l_push_char): New function to save namelist
        input when reading logicals.
        (free_line): New function to free line_buffer memory.
        (next_char): Added feature to read from line_buffer.
        (read_logical): Use new functions to test for '=' after reading a
        logical value, checking for possible variable name.
        (namelist_read): Use free_line when all done.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/io.h
    trunk/libgfortran/io/list_read.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[jvdelisle at gcc dot gnu dot org]

------- Comment #22 from jvdelisle at gcc dot gnu dot org  2006-03-01 06:14 -------
Subject: Bug 26136

Author: jvdelisle
Date: Wed Mar  1 06:14:32 2006
New Revision: 111598

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=111598
Log:
2006-02-28  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/26136
        * gfortran.dg/namelist_23.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/namelist_23.f90
Modified:
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[jvdelisle at gcc dot gnu dot org]

------- Comment #23 from jvdelisle at gcc dot gnu dot org  2006-03-01 06:50 -------
Fixed on 4.2. Pending 4.1.1


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.1.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[jvdelisle at gcc dot gnu dot org]

------- Comment #24 from jvdelisle at gcc dot gnu dot org  2006-03-03 06:00 -------
Subject: Bug 26136

Author: jvdelisle
Date: Fri Mar  3 06:00:08 2006
New Revision: 111672

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=111672
Log:
2006-03-02  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/26136
        * io/io.h: Add flag for reading from line_buffer.
        * io/list_read.c (l_push_char): New function to save namelist
        input when reading logicals.
        (free_line): New function to free line_buffer memory.
        (next_char): Added feature to read from line_buffer.
        (read_logical): Use new functions to test for '=' after reading a
        logical value, checking for possible variable name.
        (namelist_read): Use free_line when all done.

Modified:
    branches/gcc-4_1-branch/libgfortran/ChangeLog
    branches/gcc-4_1-branch/libgfortran/io/io.h
    branches/gcc-4_1-branch/libgfortran/io/list_read.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[jvdelisle at gcc dot gnu dot org]

------- Comment #25 from jvdelisle at gcc dot gnu dot org  2006-03-03 06:03 -------
Subject: Bug 26136

Author: jvdelisle
Date: Fri Mar  3 06:03:01 2006
New Revision: 111673

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=111673
Log:
2006-03-02  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/26136
        * gfortran.dg/namelist_23.f90: New test.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/namelist_23.f90
Modified:
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136

[Bug libfortran/26136] List directed input with underfilled (logicals) array read incorrectly

[jvdelisle at gcc dot gnu dot org]

------- Comment #26 from jvdelisle at gcc dot gnu dot org  2006-03-03 06:04 -------
Fixed on 4.1.1


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26136