[Bug libfortran/24903] New: dotprod should use conj?

[Bug libfortran/24903] New: dotprod should use conj?

[pinskia at gcc dot gnu dot org]

Right now dotprod_c* does:
./generated/dotprod_c4.c:      COMPLEX_ASSIGN(conjga, REALPART (*pa), -IMAGPART
(*pa));
./generated/dotprod_c16.c:      COMPLEX_ASSIGN(conjga, REALPART (*pa),
-IMAGPART (*pa));
./generated/dotprod_c8.c:      COMPLEX_ASSIGN(conjga, REALPART (*pa), -IMAGPART
(*pa));
./generated/dotprod_c10.c:      COMPLEX_ASSIGN(conjga, REALPART (*pa),
-IMAGPART (*pa));


When it should be doing:
conjga = conj(*pa);
or
conjga = conjl(*pa);
or
conjga = conjf(*pa);

Depending on which type it is.

Or it could use the GNU extension which overrides ~ for conjugation.

conjga = ~*pa;


-- 
           Summary: dotprod should use conj?
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libfortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24903

[Bug libfortran/24903] dotprod should use conj?

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2005-11-20 00:40 -------
Confirmed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-11-20 00:40:09
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24903

[Bug libfortran/24903] dotprod should use conj?

[fxcoudert at gcc dot gnu dot org]

------- Comment #2 from fxcoudert at gcc dot gnu dot org  2005-11-21 09:11 -------
(In reply to comment #0)
> conjga = conj(*pa);
> or
> conjga = conjl(*pa);
> or
> conjga = conjf(*pa);

I'm ready to do that, but since complex numbers in C are always a pain, I want
to know: are we sure that conj/conjf/conjl are *always* available? I mean, are
they part of the things gcc provides even if there is no library support for
them in the runtime libm?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24903

[Bug libfortran/24903] dotprod should use conj?

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2005-11-21 22:53 -------
(In reply to comment #2)
> I'm ready to do that, but since complex numbers in C are always a pain, I 
> want to know: are we sure that conj/conjf/conjl are *always* available? I
> mean, are they part of the things gcc provides even if there is no library
> support for them in the runtime libm?

Hmm, I have to think about that but you can always use the GCC extension :) as
mentioned before.

I think the builtin version of conj/conjf/conjl
(__builtin_conj/__builtin_conjf/__builtin_conjl) is always expanded to
CONJ_EXPR but I could be wrong.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24903

[Bug libfortran/24903] dotprod should use conj?

[fxcoudert at gcc dot gnu dot org]

-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |fxcoudert at gcc dot gnu dot
                   |dot org                     |org
                URL|                            |http://gcc.gnu.org/ml/fortra
                   |                            |n/2006-02/msg00112.html
             Status|NEW                         |ASSIGNED
           Keywords|                            |patch
   Last reconfirmed|2005-11-20 00:40:09         |2006-02-06 22:16:16
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24903

[Bug libfortran/24903] dotprod should use conj?

[fxcoudert at gcc dot gnu dot org]

------- Comment #4 from fxcoudert at gcc dot gnu dot org  2006-02-16 07:52 -------
Subject: Bug 24903

Author: fxcoudert
Date: Thu Feb 16 07:52:22 2006
New Revision: 111131

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=111131
Log:
        PR libfortran/24903
        * m4/dotprodc.m4: Use __builtin_conj instead of assigning real
        and imaginary parts separately.
        * generated/dotprod_c4.c: Regenerated.
        * generated/dotprod_c8.c: Regenerated.
        * generated/dotprod_c10.c: Regenerated.
        * generated/dotprod_c16.c: Regenerated.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/generated/dotprod_c10.c
    trunk/libgfortran/generated/dotprod_c16.c
    trunk/libgfortran/generated/dotprod_c4.c
    trunk/libgfortran/generated/dotprod_c8.c
    trunk/libgfortran/m4/dotprodc.m4


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24903

[Bug libfortran/24903] [4.1 only] dotprod should use __builtin_conj

[fxcoudert at gcc dot gnu dot org]

-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
            Summary|dotprod should use conj?    |[4.1 only] dotprod should
                   |                            |use __builtin_conj
   Target Milestone|---                         |4.1.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24903

[Bug libfortran/24903] [4.1 only] dotprod should use __builtin_conj

[fxcoudert at gcc dot gnu dot org]

------- Comment #5 from fxcoudert at gcc dot gnu dot org  2006-03-04 08:53 -------
Subject: Bug 24903

Author: fxcoudert
Date: Sat Mar  4 08:53:18 2006
New Revision: 111708

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=111708
Log:
        PR libfortran/24903
        * m4/dotprodc.m4: Use __builtin_conj instead of assigning real
        and imaginary parts separately.
        * generated/dotprod_c4.c: Regenerated.
        * generated/dotprod_c8.c: Regenerated.
        * generated/dotprod_c10.c: Regenerated.
        * generated/dotprod_c16.c: Regenerated.

Modified:
    branches/gcc-4_1-branch/libgfortran/ChangeLog
    branches/gcc-4_1-branch/libgfortran/generated/dotprod_c10.c
    branches/gcc-4_1-branch/libgfortran/generated/dotprod_c16.c
    branches/gcc-4_1-branch/libgfortran/generated/dotprod_c4.c
    branches/gcc-4_1-branch/libgfortran/generated/dotprod_c8.c
    branches/gcc-4_1-branch/libgfortran/m4/dotprodc.m4


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24903

[Bug libfortran/24903] dotprod should use __builtin_conj

[fxcoudert at gcc dot gnu dot org]

------- Comment #6 from fxcoudert at gcc dot gnu dot org  2006-03-04 08:55 -------
Fix commited to 4.1.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to work|                            |4.1.1 4.2.0
         Resolution|                            |FIXED
            Summary|[4.1 only] dotprod should   |dotprod should use
                   |use __builtin_conj          |__builtin_conj


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24903