public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/26172] generates wrong code for pam_lastlog w/o optimization
Date: Wed, 08 Feb 2006 11:07:00 -0000	[thread overview]
Message-ID: <20060208110729.32682.qmail@sourceware.org> (raw)
In-Reply-To: <bug-26172-12154@http.gcc.gnu.org/bugzilla/>



------- Comment #4 from rguenth at gcc dot gnu dot org  2006-02-08 11:07 -------
    /* copy to last_login */
    last_login.ll_host[0] = '\0';
               ^^^^^^^^^
this should probably be ll_line.  You'll just get uninitialized stack garbage
at -O0.

fprintf(stderr, "tl = %s\n", terminal_line); /* GCC BUG BELOW THIS LINE */
    strncat(last_login.ll_line, terminal_line, sizeof(last_login.ll_line)-1);
fprintf(stderr, "ll = %s\n", last_login.ll_line); /* GCC BUG ABOVE THIS LINE */
    terminal_line = NULL;


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26172


  parent reply	other threads:[~2006-02-08 11:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-08 10:57 [Bug c/26172] New: " egmont at uhulinux dot hu
2006-02-08 10:58 ` [Bug c/26172] " egmont at uhulinux dot hu
2006-02-08 10:58 ` egmont at uhulinux dot hu
2006-02-08 11:03 ` egmont at uhulinux dot hu
2006-02-08 11:07 ` rguenth at gcc dot gnu dot org [this message]
2006-02-08 11:21 ` egmont at uhulinux dot hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060208110729.32682.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).