public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "wilson at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/25603] [4.1/4.2 Regression]: Miscompiled FORTRAN program
Date: Fri, 10 Feb 2006 02:03:00 -0000	[thread overview]
Message-ID: <20060210020342.26278.qmail@sourceware.org> (raw)
In-Reply-To: <bug-25603-682@http.gcc.gnu.org/bugzilla/>



------- Comment #9 from wilson at gcc dot gnu dot org  2006-02-10 02:03 -------
I've looked at the reload-branch also.  I need two patches in order to
bootstrap it.  One trivial obvious patch, and one hacked not technically
correct patch.  It then bootstrapped and compiled this testcase correctly.

Since a major goal of the reload-branch is a complete rewrite of how
inheritance works, it isn't clear that the problem is fixed just because it
happened to work.  So I took a look at the sources.  The key detail here is
that reload-branch uses the scan_rtx function to determine what registers are
inputs and/or outputs of an instruction.  The scan_rtx function does handle
{POST,PRE}_{INC,DEC} correctly, treating them the same as SET, so that the
operand gets marked as an output register.  Although, looking at this, I can't
help but notice that {POST,PRE}_MODIFY do not get equivalent treatment.  I
think this is a bug.  Anyways, I'm convinced that reload-branch has a proper
solution to this bug, and I've got 3 bug reports against reload-branch that I
have to do something with now.

I remain convinced that my earlier suggestion for how to fix current reload is
correct.  I just haven't gotten around to trying to write a patch yet.  In
choose_reload_regs, where it calls regno_clobbered_p, we need an additional
check for registers modified by side-effects, as regno_clobbered_p does not
handle that itself.  This could probably be as simple as checking for a REG_INC
note that mentions the equiv register.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25603


  parent reply	other threads:[~2006-02-10  2:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-30 17:35 [Bug target/25603] New: " hjl at lucon dot org
2005-12-30 17:40 ` [Bug target/25603] " hjl at lucon dot org
2005-12-30 17:53 ` pinskia at gcc dot gnu dot org
2005-12-30 18:42 ` hjl at lucon dot org
2006-01-02 13:57 ` jakub at gcc dot gnu dot org
2006-01-09 22:03 ` steven at gcc dot gnu dot org
2006-01-10 22:07 ` steven at gcc dot gnu dot org
2006-01-23 16:58 ` sje at cup dot hp dot com
2006-01-31  3:49 ` wilson at gcc dot gnu dot org
2006-02-08  6:40 ` grigory_zagorodnev at linux dot intel dot com
2006-02-10  2:03 ` wilson at gcc dot gnu dot org [this message]
2006-02-10  3:37 ` hjl at lucon dot org
2006-02-14 18:56 ` amylaar at gcc dot gnu dot org
2006-02-14 19:33 ` hjl at lucon dot org
2006-02-14 20:04 ` hjl at lucon dot org
2006-02-14 21:15 ` pinskia at gcc dot gnu dot org
2006-02-15 21:29 ` hjl at lucon dot org
2006-02-17  0:03 ` hjl at gcc dot gnu dot org
2006-02-20 17:46 ` [Bug target/25603] [4.1 " hjl at lucon dot org
2006-02-22 16:30 ` rguenth at gcc dot gnu dot org
2006-02-22 16:59 ` hjl at gcc dot gnu dot org
2006-02-22 17:04 ` hjl at lucon dot org
2006-02-22 22:51 ` mmitchel at gcc dot gnu dot org
2006-02-24  1:20 ` mmitchel at gcc dot gnu dot org
2006-02-24  1:37 ` mmitchel at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060210020342.26278.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).