[Bug target/25724] New: Emits call to __cmpdi2 for long long comparison

[Bug target/25724] New: Emits call to __cmpdi2 for long long comparison

[rguenth at gcc dot gnu dot org]

The kernel for s390 (and ppc) currently drags in __cmpdi2 from libgcc with
the following reduced testcase even though s390 is supposed to have an 8
byte comparison opcode and archs such as i686 generate bit-twiddling for
this unsupported case (admittandly not from ifcvt, but from some define-expand
hackery), i.e. ll[0] | ll[1] == 0.

void foo(void);
int dcache_readdir(long long ll)
{
    switch(ll) {
        case 0:
          foo();
    }
}


-- 
           Summary: Emits call to __cmpdi2 for long long comparison
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: critical
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rguenth at gcc dot gnu dot org
GCC target triplet: s390-ibm-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25724

[Bug middle-end/25724] Emits call to __cmpdi2 for long long comparison

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-01-09 14:33 -------
This is no way critical at all.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
           Severity|critical                    |normal
          Component|target                      |middle-end


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25724

[Bug middle-end/25724] Emits call to __cmpdi2 for long long comparison

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2006-01-09 14:38 -------
Confirmed, this is just a missed optimization and not a regression at best.  If
the kernel is using long long on a 32bit target, it needs all support functions
including __cmpdi2.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
      Known to fail|                            |3.3.3 3.4.0 4.0.0 4.1.0
                   |                            |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25724

[Bug middle-end/25724] Emits call to __cmpdi2 for long long comparison

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2006-01-09 14:41 -------
Using

void foo(void);
int dcache_readdir(long long ll)
{
    if (ll == 0)
          foo();
}

the correct bit-twiddling is generated...

So it looks like a generic switch expand issue.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25724

[Bug middle-end/25724] Emits call to __cmpdi2 for long long comparison

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-01-09 15:14:35
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25724

[Bug middle-end/25724] Emits call to __cmpdi2 for long long comparison

[pluto at agmk dot net]

------- Comment #4 from pluto at agmk dot net  2006-01-09 15:46 -------

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21237


-- 

pluto at agmk dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pluto at agmk dot net


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25724

[Bug middle-end/25724] Emits call to __cmpdi2 for long long comparison

[pluto at agmk dot net]

------- Comment #5 from pluto at agmk dot net  2006-01-09 15:48 -------
(In reply to comment #4)
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21237

oops, I accidentally posted this link:(


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25724

[Bug middle-end/25724] Emits call to __cmpdi2 for long long comparison

[krebbel at gcc dot gnu dot org]

------- Comment #6 from krebbel at gcc dot gnu dot org  2006-01-09 18:26 -------
As far as I know the kernel guys rely on the fact that gcc can 
handle DImode operations without calling libgcc. As Richard pointed out 
this only fails in this case because the conditional jump is emitted
differently for case nodes.

A normal DImode compare (on 32bit) is split into SImode compares before 
emit_cmp_and_jump_insns is called. This is done by do_jump_by_parts_equality.

emit_case_nodes in turn calls do_jump_if_equal which calls 
emit_cmp_and_jump_insns with DImode operands.

So I think using the dojump.c machinery in emit_case_nodes should be the
way to go - right?!


-- 

krebbel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |krebbel at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25724

[Bug middle-end/25724] Emits call to __cmpdi2 for long long comparison

[rguenth at gcc dot gnu dot org]

------- Comment #7 from rguenth at gcc dot gnu dot org  2006-01-10 09:27 -------
Yes, this sounds like the way to go.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25724

[Bug middle-end/25724] Emits call to __cmpdi2 for long long comparison in switches

[sayle at gcc dot gnu dot org]

------- Comment #8 from sayle at gcc dot gnu dot org  2006-02-13 01:55 -------
Subject: Bug 25724

Author: sayle
Date: Mon Feb 13 01:55:37 2006
New Revision: 110906

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110906
Log:

        PR middle-end/25724
        * dojump.c (do_jump): Call do_compare_rtx_and_jump.
        (do_jump_parts_zero_rtx): New function renamed from
        do_jump_parts_equality_rtx.  Made static.  Add a mode argument.
        (do_jump_parts_equality_rtx): New function split out from
        do_jump_parts_equality.  Old implementation renamed as above.
        Call do_jump_parts_zero_rtx if either operand is zero.
        (do_jump_parts_equality): Call do_jump_parts_equality_rtx to
        do all of the heavy lifting.
        (do_compare_rtx_and_jump): Handle multi-word comparisons by
        calling either do_jump_by_parts_greater_rtx or
        do_jump_by_parts_equality_rtx.
        * expr.h (do_jump_by_parts_equality_rtx): Remove prototype.
        * expmed.c (do_cmp_and_jump): Now multi-word optimization has
        moved to do_compare_rtx_and_jump, call it directly.
        * stmt.c (do_jump_if_equal): Remove static prototype.  Add a
        mode argument.  Call do_compare_rtx_and_jump.
        (emit_case_nodes): Update calls to do_jump_if_equal.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/dojump.c
    trunk/gcc/expmed.c
    trunk/gcc/expr.h
    trunk/gcc/stmt.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25724

[Bug middle-end/25724] Emits call to __cmpdi2 for long long comparison in switches

[roger at eyesopen dot com]

------- Comment #9 from roger at eyesopen dot com  2006-02-13 18:51 -------
This has now been fixed on mainline.


-- 

roger at eyesopen dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25724