public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/25083] New: better diagnostic needed
@ 2005-11-26 17:59 jv244 at cam dot ac dot uk
2005-11-27 4:20 ` [Bug fortran/25083] " kargl at gcc dot gnu dot org
` (8 more replies)
0 siblings, 9 replies; 10+ messages in thread
From: jv244 at cam dot ac dot uk @ 2005-11-26 17:59 UTC (permalink / raw)
To: gcc-bugs
using GNU Fortran 95 (GCC) 4.1.0 20051126 (prerelease) with '-g -pedantic
-std=f95', I get a bad / no diagnostic for the following invalid code:
BLOCK DATA D
INTEGER I
DATA I /1/
END BLOCK DATA
END
--
Summary: better diagnostic needed
Product: gcc
Version: 4.1.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: jv244 at cam dot ac dot uk
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25083
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25083] better diagnostic needed
2005-11-26 17:59 [Bug fortran/25083] New: better diagnostic needed jv244 at cam dot ac dot uk
@ 2005-11-27 4:20 ` kargl at gcc dot gnu dot org
2006-01-11 14:36 ` [Bug fortran/25083] non-common variable in block data tobi at gcc dot gnu dot org
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: kargl at gcc dot gnu dot org @ 2005-11-27 4:20 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from kargl at gcc dot gnu dot org 2005-11-27 04:20 -------
Details?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25083
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25083] non-common variable in block data
2005-11-26 17:59 [Bug fortran/25083] New: better diagnostic needed jv244 at cam dot ac dot uk
2005-11-27 4:20 ` [Bug fortran/25083] " kargl at gcc dot gnu dot org
@ 2006-01-11 14:36 ` tobi at gcc dot gnu dot org
2006-01-11 15:58 ` jv244 at cam dot ac dot uk
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: tobi at gcc dot gnu dot org @ 2006-01-11 14:36 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from tobi at gcc dot gnu dot org 2006-01-11 14:36 -------
I think the problem is that I does not live in a common block, but i don't have
the standard to check.
--
tobi at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tobi at gcc dot gnu dot org
Summary|better diagnostic needed |non-common variable in block
| |data
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25083
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25083] non-common variable in block data
2005-11-26 17:59 [Bug fortran/25083] New: better diagnostic needed jv244 at cam dot ac dot uk
2005-11-27 4:20 ` [Bug fortran/25083] " kargl at gcc dot gnu dot org
2006-01-11 14:36 ` [Bug fortran/25083] non-common variable in block data tobi at gcc dot gnu dot org
@ 2006-01-11 15:58 ` jv244 at cam dot ac dot uk
2006-01-11 16:00 ` tobi at gcc dot gnu dot org
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: jv244 at cam dot ac dot uk @ 2006-01-11 15:58 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from jv244 at cam dot ac dot uk 2006-01-11 15:58 -------
(In reply to comment #2)
> I think the problem is that I does not live in a common block, but i don't have
> the standard to check.
>
yes
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25083
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25083] non-common variable in block data
2005-11-26 17:59 [Bug fortran/25083] New: better diagnostic needed jv244 at cam dot ac dot uk
` (2 preceding siblings ...)
2006-01-11 15:58 ` jv244 at cam dot ac dot uk
@ 2006-01-11 16:00 ` tobi at gcc dot gnu dot org
2006-01-11 16:38 ` tobi at gcc dot gnu dot org
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: tobi at gcc dot gnu dot org @ 2006-01-11 16:00 UTC (permalink / raw)
To: gcc-bugs
--
tobi at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2006-01-11 16:00:42
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25083
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25083] non-common variable in block data
2005-11-26 17:59 [Bug fortran/25083] New: better diagnostic needed jv244 at cam dot ac dot uk
` (3 preceding siblings ...)
2006-01-11 16:00 ` tobi at gcc dot gnu dot org
@ 2006-01-11 16:38 ` tobi at gcc dot gnu dot org
2006-02-13 21:23 ` pault at gcc dot gnu dot org
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: tobi at gcc dot gnu dot org @ 2006-01-11 16:38 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from tobi at gcc dot gnu dot org 2006-01-11 16:38 -------
I forgot to say that g77 accepts this even with -pedantic. But this is
undocumented and doesn't make much sense, so we can probably do away with it
without alienating anybody.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25083
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25083] non-common variable in block data
2005-11-26 17:59 [Bug fortran/25083] New: better diagnostic needed jv244 at cam dot ac dot uk
` (4 preceding siblings ...)
2006-01-11 16:38 ` tobi at gcc dot gnu dot org
@ 2006-02-13 21:23 ` pault at gcc dot gnu dot org
2006-02-13 21:35 ` pault at gcc dot gnu dot org
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: pault at gcc dot gnu dot org @ 2006-02-13 21:23 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from pault at gcc dot gnu dot org 2006-02-13 21:23 -------
Subject: Bug 25083
Author: pault
Date: Mon Feb 13 21:22:55 2006
New Revision: 110926
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110926
Log:
2006-02-13 Paul Thomas <pault@gcc.gnu.org>
PR fortran/26074
PR fortran/25103
* resolve.c (resolve_symbol): Extend the requirement that module
arrays have constant bounds to those in the main program. At the
same time simplify the array bounds, to avoiding trapping parameter
array references, and exclude automatic character length from main
and modules. Rearrange resolve_symbol and resolve_derived to put as
each flavor together, as much as is possible and move all specific
code for flavors FL_VARIABLE, FL_PROCEDURE and FL_PARAMETER into new
functions.
(resolve_fl_var_and_proc, resolve_fl_variable, resolve_fl_procedure):
New functions to do work of resolve_symbol.
(resolve_index_expr): New function that is called from resolved_symbol
and is extracted from resolve_charlen.
(resolve_charlen): Call this new function.
(resolve_fl_derived): Renamed resolve_derived to be consistent with
the naming of the new functions for the other flavours. Change the
charlen checking so that the style is consistent with other similar
checks. Add the generation of the gfc_dt_list, removed from resolve_
symbol.
PR fortran/20861
* resolve.c (resolve_actual_arglist): Prevent internal procedures
from being dummy arguments.
PR fortran/20871
* resolve.c (resolve_actual_arglist): Prevent pure but non-intrinsic
procedures from being dummy arguments.
PR fortran/25083
* resolve.c (check_data_variable): Add test that data variable is in
COMMON.
PR fortran/25088
* resolve.c (resolve_call): Add test that the subroutine does not
have a type.
2006-02-13 Paul Thomas <pault@gcc.gnu.org>
PR fortran/26074
PR fortran/25103
* gfortran.dg/module_parameter_array_refs_1.f90: New test.
* gfortran.dg/bad_automatic_objects_1.f90: New test.
* gfortran.dg/automatic_module_variable.f90: Change error message.
PR fortran/20861
* gfortran.dg/internal_dummy_1.f90: New test.
PR fortran/20871
* gfortran.dg/elemental_non_intrinsic_dummy_1.f90: New test.
PR fortran/25083
* gfortran.dg/uncommon_block_data_1.f90: New test.
* gfortran.dg/equiv_constraint_7.f90: Correct non-compliance of test
with standard.
PR fortran/25088
* gfortran.dg/typed_subroutine_1.f90: New test.
Added:
trunk/gcc/testsuite/gfortran.dg/bad_automatic_objects_1.f90
trunk/gcc/testsuite/gfortran.dg/elemental_non_intrinsic_dummy_1.f90
trunk/gcc/testsuite/gfortran.dg/internal_dummy_1.f90
trunk/gcc/testsuite/gfortran.dg/module_parameter_array_refs_1.f90
trunk/gcc/testsuite/gfortran.dg/typed_subroutine_1.f90
trunk/gcc/testsuite/gfortran.dg/uncommon_block_data_1.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/resolve.c
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gfortran.dg/automatic_module_variable.f90
trunk/gcc/testsuite/gfortran.dg/equiv_constraint_7.f90
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25083
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25083] non-common variable in block data
2005-11-26 17:59 [Bug fortran/25083] New: better diagnostic needed jv244 at cam dot ac dot uk
` (5 preceding siblings ...)
2006-02-13 21:23 ` pault at gcc dot gnu dot org
@ 2006-02-13 21:35 ` pault at gcc dot gnu dot org
2006-02-13 21:40 ` pault at gcc dot gnu dot org
2006-02-14 7:19 ` pault at gcc dot gnu dot org
8 siblings, 0 replies; 10+ messages in thread
From: pault at gcc dot gnu dot org @ 2006-02-13 21:35 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from pault at gcc dot gnu dot org 2006-02-13 21:35 -------
Subject: Bug 25083
Author: pault
Date: Mon Feb 13 21:35:09 2006
New Revision: 110930
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110930
Log:
2006-02-13 Paul Thomas <pault@gcc.gnu.org>
PR fortran/26074
PR fortran/25103
* resolve.c (resolve_symbol): Extend the requirement that module
arrays have constant bounds to those in the main program. At the
same time simplify the array bounds, to avoiding trapping parameter
array references, and exclude automatic character length from main
and modules. Rearrange resolve_symbol and resolve_derived to put as
each flavor together, as much as is possible and move all specific
code for flavors FL_VARIABLE, FL_PROCEDURE and FL_PARAMETER into new
functions.
(resolve_fl_var_and_proc, resolve_fl_variable, resolve_fl_procedure):
New functions to do work of resolve_symbol.
(resolve_index_expr): New function that is called from resolved_symbol
and is extracted from resolve_charlen.
(resolve_charlen): Call this new function.
(resolve_fl_derived): Renamed resolve_derived to be consistent with
the naming of the new functions for the other flavours. Change the
charlen checking so that the style is consistent with other similar
checks. Add the generation of the gfc_dt_list, removed from resolve_
symbol.
PR fortran/20861
* resolve.c (resolve_actual_arglist): Prevent internal procedures
from being dummy arguments.
PR fortran/20871
* resolve.c (resolve_actual_arglist): Prevent pure but non-intrinsic
procedures from being dummy arguments.
PR fortran/25083
* resolve.c (check_data_variable): Add test that data variable is in
COMMON.
PR fortran/25088
* resolve.c (resolve_call): Add test that the subroutine does not
have a type.
2006-02-13 Paul Thomas <pault@gcc.gnu.org>
PR fortran/26074
PR fortran/25103
* gfortran.dg/module_parameter_array_refs_1.f90: New test.
* gfortran.dg/bad_automatic_objects_1.f90: New test.
* gfortran.dg/automatic_module_variable.f90: Change error message.
PR fortran/20861
* gfortran.dg/internal_dummy_1.f90: New test.
PR fortran/20871
* gfortran.dg/elemental_non_intrinsic_dummy_1.f90: New test.
PR fortran/25083
* gfortran.dg/uncommon_block_data_1.f90: New test.
* gfortran.dg/equiv_constraint_7.f90: Correct non-compliance of test
with standard.
PR fortran/25088
* gfortran.dg/typed_subroutine_1.f90: New test.
Added:
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/bad_automatic_objects_1.f90
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/internal_dummy_1.f90
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/module_parameter_array_refs_1.f90
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/pure_non_intrinsic_dummy_1.f90
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/typed_subroutine_1.f90
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/uncommon_block_data_1.f90
Modified:
branches/gcc-4_1-branch/gcc/fortran/ChangeLog
branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25083
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25083] non-common variable in block data
2005-11-26 17:59 [Bug fortran/25083] New: better diagnostic needed jv244 at cam dot ac dot uk
` (6 preceding siblings ...)
2006-02-13 21:35 ` pault at gcc dot gnu dot org
@ 2006-02-13 21:40 ` pault at gcc dot gnu dot org
2006-02-14 7:19 ` pault at gcc dot gnu dot org
8 siblings, 0 replies; 10+ messages in thread
From: pault at gcc dot gnu dot org @ 2006-02-13 21:40 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from pault at gcc dot gnu dot org 2006-02-13 21:39 -------
Fixed on trunk and 4.1.
Paul
--
pault at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25083
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/25083] non-common variable in block data
2005-11-26 17:59 [Bug fortran/25083] New: better diagnostic needed jv244 at cam dot ac dot uk
` (7 preceding siblings ...)
2006-02-13 21:40 ` pault at gcc dot gnu dot org
@ 2006-02-14 7:19 ` pault at gcc dot gnu dot org
8 siblings, 0 replies; 10+ messages in thread
From: pault at gcc dot gnu dot org @ 2006-02-14 7:19 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from pault at gcc dot gnu dot org 2006-02-14 07:18 -------
Subject: Bug 25083
Author: pault
Date: Tue Feb 14 07:18:44 2006
New Revision: 110960
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110960
Log:
2006-02-13 Paul Thomas <pault@gcc.gnu.org>
PR fortran/26074
PR fortran/25103
PR fortran/20861
PR fortran/20871
PR fortran/25083
PR fortran/25088
* resolve.c (resolve): Actually apply the patch below!
Modified:
branches/gcc-4_1-branch/gcc/fortran/resolve.c
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/automatic_module_variable.f90
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/equiv_constraint_7.f90
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25083
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2006-02-14 7:19 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-26 17:59 [Bug fortran/25083] New: better diagnostic needed jv244 at cam dot ac dot uk
2005-11-27 4:20 ` [Bug fortran/25083] " kargl at gcc dot gnu dot org
2006-01-11 14:36 ` [Bug fortran/25083] non-common variable in block data tobi at gcc dot gnu dot org
2006-01-11 15:58 ` jv244 at cam dot ac dot uk
2006-01-11 16:00 ` tobi at gcc dot gnu dot org
2006-01-11 16:38 ` tobi at gcc dot gnu dot org
2006-02-13 21:23 ` pault at gcc dot gnu dot org
2006-02-13 21:35 ` pault at gcc dot gnu dot org
2006-02-13 21:40 ` pault at gcc dot gnu dot org
2006-02-14 7:19 ` pault at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).