public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug translation/21768] [3.4 regression] ICE in error message due to violation of coding conventions [not found] <bug-21768-1771@http.gcc.gnu.org/bugzilla/> @ 2005-10-07 4:04 ` gdr at gcc dot gnu dot org 2006-02-28 15:38 ` gdr at gcc dot gnu dot org 1 sibling, 0 replies; 5+ messages in thread From: gdr at gcc dot gnu dot org @ 2005-10-07 4:04 UTC (permalink / raw) To: gcc-bugs -- gdr at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.4.5 |3.4.6 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21768 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug translation/21768] [3.4 regression] ICE in error message due to violation of coding conventions [not found] <bug-21768-1771@http.gcc.gnu.org/bugzilla/> 2005-10-07 4:04 ` [Bug translation/21768] [3.4 regression] ICE in error message due to violation of coding conventions gdr at gcc dot gnu dot org @ 2006-02-28 15:38 ` gdr at gcc dot gnu dot org 1 sibling, 0 replies; 5+ messages in thread From: gdr at gcc dot gnu dot org @ 2006-02-28 15:38 UTC (permalink / raw) To: gcc-bugs ------- Comment #11 from gdr at gcc dot gnu dot org 2006-02-28 15:37 ------- The .po file is missing and we haven't received one for a while. This is not a release blocking issue. Closing as essentially fixed. -- gdr at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21768 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug c++/21768] New: [3.4/4.0/4.1 regression] ICE in error message due to violation of coding conventions @ 2005-05-26 14:50 reichelt at gcc dot gnu dot org 2005-07-04 9:53 ` [Bug translation/21768] [3.4 " reichelt at gcc dot gnu dot org ` (2 more replies) 0 siblings, 3 replies; 5+ messages in thread From: reichelt at gcc dot gnu dot org @ 2005-05-26 14:50 UTC (permalink / raw) To: gcc-bugs [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain, Size: 3081 bytes --] Compiling the following code snippet with the German locale enabled causes an ICE: ================================ template<int,int> struct A; template<int> struct A {}; ================================ bug.cc:1: Fehler: previous declaration »template<int <anonymous>, int <anonymous> > struct A« bug.cc:2: Fehler: 2 Template-Parameter bug.cc:2: interner Compiler-Fehler: in pp_base_format_text, bei pretty-print.c:357 Bitte senden Sie einen vollständigen Fehlerbericht auf Englisch ein; bearbeiten Sie die Quellen zunächst mit einem Präprozessor, wenn es dienlich ist. Fehler in der deutschen Übersetzung sind an de@li.org zu melden. Gehen Sie gemäß den Hinweisen in <URL:http://gcc.gnu.org/bugs.html> vor. This is partly due to the fact that the code snippet in cp/pt.c that generates the original message violates the coding conventions (see http://www.gnu.org/prep/standards/standards.html#Internationalization): error ("used %d template parameter%s instead of %d", TREE_VEC_LENGTH (tmpl_parms), TREE_VEC_LENGTH (tmpl_parms) == 1 ? "" : "s", TREE_VEC_LENGTH (parms)); The patch below fixes that by removing the conditional and using "parameter(s)" in the text. This should simplify i18n efforts. ============================================================================= --- gcc/gcc/cp/pt.c 2005-05-25 00:00:57.000000000 +0200 +++ gcc/gcc/cp/pt.c 2005-05-25 00:35:03.000000000 +0200 @@ -3225,10 +3225,9 @@ redeclare_class_template (tree type, tre if (TREE_VEC_LENGTH (parms) != TREE_VEC_LENGTH (tmpl_parms)) { cp_error_at ("previous declaration %qD", tmpl); - error ("used %d template parameter%s instead of %d", - TREE_VEC_LENGTH (tmpl_parms), - TREE_VEC_LENGTH (tmpl_parms) == 1 ? "" : "s", - TREE_VEC_LENGTH (parms)); + error ("used %d template parameter(s) instead of %d", + TREE_VEC_LENGTH (tmpl_parms), + TREE_VEC_LENGTH (parms)); return; } ============================================================================= Alternatively, one could make two messages, one for 1 parameter and one for 0 or more than 1. But I don't think that this is worthwhile. Btw, do all languages use the plural form for 0 parameters? That's an implicit assumption that might not be true. The ICE with the German locale appeared in gcc 3.4.4 (before we did not have a German translation for that error message). Therefore I'd like to apply the patch not only to mainline, but also to the 3.4 and 4.0 branch as a first step towards removing the ICE. -- Summary: [3.4/4.0/4.1 regression] ICE in error message due to violation of coding conventions Product: gcc Version: 4.1.0 Status: UNCONFIRMED Keywords: ice-on-invalid-code Severity: normal Priority: P2 Component: c++ AssignedTo: unassigned at gcc dot gnu dot org ReportedBy: reichelt at gcc dot gnu dot org CC: gcc-bugs at gcc dot gnu dot org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21768 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug translation/21768] [3.4 regression] ICE in error message due to violation of coding conventions 2005-05-26 14:50 [Bug c++/21768] New: [3.4/4.0/4.1 " reichelt at gcc dot gnu dot org @ 2005-07-04 9:53 ` reichelt at gcc dot gnu dot org 2005-08-31 13:47 ` bonzini at gcc dot gnu dot org 2005-08-31 15:43 ` reichelt at igpm dot rwth-aachen dot de 2 siblings, 0 replies; 5+ messages in thread From: reichelt at gcc dot gnu dot org @ 2005-07-04 9:53 UTC (permalink / raw) To: gcc-bugs ------- Additional Comments From reichelt at gcc dot gnu dot org 2005-07-04 09:53 ------- Changing component, since we are only missing the updated .po file. -- What |Removed |Added ---------------------------------------------------------------------------- Component|c++ |translation http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21768 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug translation/21768] [3.4 regression] ICE in error message due to violation of coding conventions 2005-05-26 14:50 [Bug c++/21768] New: [3.4/4.0/4.1 " reichelt at gcc dot gnu dot org 2005-07-04 9:53 ` [Bug translation/21768] [3.4 " reichelt at gcc dot gnu dot org @ 2005-08-31 13:47 ` bonzini at gcc dot gnu dot org 2005-08-31 15:43 ` reichelt at igpm dot rwth-aachen dot de 2 siblings, 0 replies; 5+ messages in thread From: bonzini at gcc dot gnu dot org @ 2005-08-31 13:47 UTC (permalink / raw) To: gcc-bugs ------- Additional Comments From bonzini at gcc dot gnu dot org 2005-08-31 13:36 ------- This ought to use ngettext. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21768 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug translation/21768] [3.4 regression] ICE in error message due to violation of coding conventions 2005-05-26 14:50 [Bug c++/21768] New: [3.4/4.0/4.1 " reichelt at gcc dot gnu dot org 2005-07-04 9:53 ` [Bug translation/21768] [3.4 " reichelt at gcc dot gnu dot org 2005-08-31 13:47 ` bonzini at gcc dot gnu dot org @ 2005-08-31 15:43 ` reichelt at igpm dot rwth-aachen dot de 2 siblings, 0 replies; 5+ messages in thread From: reichelt at igpm dot rwth-aachen dot de @ 2005-08-31 15:43 UTC (permalink / raw) To: gcc-bugs ------- Additional Comments From reichelt at igpm dot rwth-aachen dot de 2005-08-31 15:39 ------- Subject: Re: [3.4 regression] ICE in error message due to violation of coding conventions On 31 Aug, bonzini at gcc dot gnu dot org wrote: > This ought to use ngettext. That's not necessary. The trickery with the plural s that would have made ngettext necessary was a violation of the coding conventions, anyway. This is already fixed by using a different error message. We are just waiting for a new .po file with a suitable translation. This won't arrive until close to the release, however. This PR is just a reminder to test whether the translation really got fixed before spinning the release. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21768 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-02-28 15:37 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <bug-21768-1771@http.gcc.gnu.org/bugzilla/> 2005-10-07 4:04 ` [Bug translation/21768] [3.4 regression] ICE in error message due to violation of coding conventions gdr at gcc dot gnu dot org 2006-02-28 15:38 ` gdr at gcc dot gnu dot org 2005-05-26 14:50 [Bug c++/21768] New: [3.4/4.0/4.1 " reichelt at gcc dot gnu dot org 2005-07-04 9:53 ` [Bug translation/21768] [3.4 " reichelt at gcc dot gnu dot org 2005-08-31 13:47 ` bonzini at gcc dot gnu dot org 2005-08-31 15:43 ` reichelt at igpm dot rwth-aachen dot de
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).