public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/26552] New: gcc.dg/sibcall-6.c fails on x86-darwin with default options
@ 2006-03-03 20:38 pinskia at gcc dot gnu dot org
2006-03-03 23:40 ` [Bug target/26552] " pinskia at gcc dot gnu dot org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-03-03 20:38 UTC (permalink / raw)
To: gcc-bugs
gcc.dg/sibcall-6.c fails on x86-darwin since PIC is enabled by default but on
darwin PIC is handled differently so it should be able to sibcall to the
indirect function.
--
Summary: gcc.dg/sibcall-6.c fails on x86-darwin with default
options
Product: gcc
Version: unknown
Status: UNCONFIRMED
Keywords: missed-optimization
Severity: normal
Priority: P3
Component: target
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: pinskia at gcc dot gnu dot org
GCC target triplet: i686-darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26552
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/26552] gcc.dg/sibcall-6.c fails on x86-darwin with default options
2006-03-03 20:38 [Bug target/26552] New: gcc.dg/sibcall-6.c fails on x86-darwin with default options pinskia at gcc dot gnu dot org
@ 2006-03-03 23:40 ` pinskia at gcc dot gnu dot org
2006-03-03 23:51 ` pinskia at gcc dot gnu dot org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-03-03 23:40 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from pinskia at gcc dot gnu dot org 2006-03-03 23:40 -------
Here is the patch which should fix this bug:
Index: i386.c
===================================================================
--- i386.c (revision 111688)
+++ i386.c (working copy)
@@ -2232,7 +2232,9 @@ ix86_function_ok_for_sibcall (tree decl,
/* If we are generating position-independent code, we cannot sibcall
optimize any indirect call, or a direct call to a global function,
as the PLT requires %ebx be live. */
- if (!TARGET_64BIT && flag_pic && (!decl || !targetm.binds_local_p (decl)))
+ if (!TARGET_MACHO
+ && !TARGET_64BIT
+ && flag_pic && (!decl || !targetm.binds_local_p (decl)))
return false;
if (decl)
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26552
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/26552] gcc.dg/sibcall-6.c fails on x86-darwin with default options
2006-03-03 20:38 [Bug target/26552] New: gcc.dg/sibcall-6.c fails on x86-darwin with default options pinskia at gcc dot gnu dot org
2006-03-03 23:40 ` [Bug target/26552] " pinskia at gcc dot gnu dot org
@ 2006-03-03 23:51 ` pinskia at gcc dot gnu dot org
2007-01-24 12:08 ` fxcoudert at gcc dot gnu dot org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-03-03 23:51 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from pinskia at gcc dot gnu dot org 2006-03-03 23:51 -------
After talking with Eric Christopher, this patch is going to be wrong when he
removes the stubs for x86 as there will be a PLT now so I am not going to
submit the patch and I am removing the missed-optimization.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|missed-optimization |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26552
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/26552] gcc.dg/sibcall-6.c fails on x86-darwin with default options
2006-03-03 20:38 [Bug target/26552] New: gcc.dg/sibcall-6.c fails on x86-darwin with default options pinskia at gcc dot gnu dot org
2006-03-03 23:40 ` [Bug target/26552] " pinskia at gcc dot gnu dot org
2006-03-03 23:51 ` pinskia at gcc dot gnu dot org
@ 2007-01-24 12:08 ` fxcoudert at gcc dot gnu dot org
2010-03-19 23:42 ` howarth at nitro dot med dot uc dot edu
2010-08-30 16:50 ` mrs at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2007-01-24 12:08 UTC (permalink / raw)
To: gcc-bugs
--
fxcoudert at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2007-01-24 12:08:04
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26552
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/26552] gcc.dg/sibcall-6.c fails on x86-darwin with default options
2006-03-03 20:38 [Bug target/26552] New: gcc.dg/sibcall-6.c fails on x86-darwin with default options pinskia at gcc dot gnu dot org
` (2 preceding siblings ...)
2007-01-24 12:08 ` fxcoudert at gcc dot gnu dot org
@ 2010-03-19 23:42 ` howarth at nitro dot med dot uc dot edu
2010-08-30 16:50 ` mrs at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: howarth at nitro dot med dot uc dot edu @ 2010-03-19 23:42 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from howarth at nitro dot med dot uc dot edu 2010-03-19 23:42 -------
Should this bug be closed? I don't every recall seeing it in recent history on
i686-apple-darwin*.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26552
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/26552] gcc.dg/sibcall-6.c fails on x86-darwin with default options
2006-03-03 20:38 [Bug target/26552] New: gcc.dg/sibcall-6.c fails on x86-darwin with default options pinskia at gcc dot gnu dot org
` (3 preceding siblings ...)
2010-03-19 23:42 ` howarth at nitro dot med dot uc dot edu
@ 2010-08-30 16:50 ` mrs at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: mrs at gcc dot gnu dot org @ 2010-08-30 16:50 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from mrs at gcc dot gnu dot org 2010-08-30 16:49 -------
Let us know if there are any remaining issues, thanks.
--
mrs at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26552
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-08-30 16:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-03-03 20:38 [Bug target/26552] New: gcc.dg/sibcall-6.c fails on x86-darwin with default options pinskia at gcc dot gnu dot org
2006-03-03 23:40 ` [Bug target/26552] " pinskia at gcc dot gnu dot org
2006-03-03 23:51 ` pinskia at gcc dot gnu dot org
2007-01-24 12:08 ` fxcoudert at gcc dot gnu dot org
2010-03-19 23:42 ` howarth at nitro dot med dot uc dot edu
2010-08-30 16:50 ` mrs at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).