[Bug middle-end/26635] New: [4.1/4.2 Regression] Bogus Storage_Error warning

[Bug middle-end/26635] New: [4.1/4.2 Regression] Bogus Storage_Error warning

[ebotcazou at gcc dot gnu dot org]

The patch

2006-01-09  Kazu Hirata  <kazu@codesourcery.com>

        PR tree-optimization/25125
        * convert.c (convert_to_integer): Don't narrow the type of a
        PLUX_EXPR or MINUS_EXPR if !flag_wrapv and the unwidened type
        is signed.

has introduced a regression for the Ada testcase that I'm about to attach:

eric@linux:~/gnat/bugs/F217-005> gcc -S p.ads
p.ads:12:03: warning: Storage_Error will be raised at run-time

The testcase should compile silently.

Analysis: http://gcc.gnu.org/ml/gcc-patches/2006-03/msg00198.html

I think Kazu's original patch was the correct fix.


-- 
           Summary: [4.1/4.2 Regression] Bogus Storage_Error warning
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: ebotcazou at gcc dot gnu dot org
 GCC build triplet: *-*-*
  GCC host triplet: *-*-*
GCC target triplet: *-*-*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635

[Bug middle-end/26635] [4.1/4.2 Regression] Bogus Storage_Error warning

[ebotcazou at gcc dot gnu dot org]

------- Comment #1 from ebotcazou at gcc dot gnu dot org  2006-03-10 18:00 -------
Created an attachment (id=11016)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11016&action=view)
Reduced Ada testcase.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635

[Bug middle-end/26635] [4.1/4.2 Regression] Bogus Storage_Error warning

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|wrong-code                  |diagnostic
   Target Milestone|---                         |4.1.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635

[Bug middle-end/26635] [4.1/4.2 Regression] Bogus Storage_Error warning

[ebotcazou at gcc dot gnu dot org]

------- Comment #2 from ebotcazou at gcc dot gnu dot org  2006-03-31 15:01 -------
I'm about to post a fix.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|kazu at gcc dot gnu dot org |ebotcazou at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635

[Bug middle-end/26635] [4.1/4.2 Regression] Bogus Storage_Error warning

[ebotcazou at gcc dot gnu dot org]

-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-03-31 17:24:18
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635

[Bug middle-end/26635] [4.1/4.2 Regression] Bogus Storage_Error warning

[mmitchel at gcc dot gnu dot org]

------- Comment #3 from mmitchel at gcc dot gnu dot org  2006-04-16 18:58 -------
Ada is not release-critical.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635

[Bug middle-end/26635] [4.1/4.2 Regression] Bogus Storage_Error warning

[rguenth at gcc dot gnu dot org]

------- Comment #4 from rguenth at gcc dot gnu dot org  2006-05-22 11:39 -------
It looks like this may be fixed on the mainline?  At least the C testcase from
http://gcc.gnu.org/ml/gcc-patches/2006-03/msg00198.html no longer shows
overflowed constants.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635

[Bug middle-end/26635] [4.1/4.2 Regression] Bogus Storage_Error warning

[mmitchel at gcc dot gnu dot org]

------- Comment #5 from mmitchel at gcc dot gnu dot org  2006-05-25 02:36 -------
Will not be fixed in 4.1.1; adjust target milestone to 4.1.2.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.1                       |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635

[Bug middle-end/26635] [4.1 Regression] Bogus Storage_Error warning

[ebotcazou at gcc dot gnu dot org]

------- Comment #6 from ebotcazou at gcc dot gnu dot org  2006-09-12 11:43 -------
> It looks like this may be fixed on the mainline?  At least the C testcase from
> http://gcc.gnu.org/ml/gcc-patches/2006-03/msg00198.html no longer shows
> overflowed constants.

Right, the warning has disappeared on the mainline but the underlying problem
in convert_to_integer is still there.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|diagnostic                  |wrong-code
   Last reconfirmed|2006-03-31 17:24:18         |2006-09-12 11:43:28
               date|                            |
            Summary|[4.1/4.2 Regression] Bogus  |[4.1 Regression] Bogus
                   |Storage_Error warning       |Storage_Error warning


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635

[Bug middle-end/26635] [4.1 regression] Bogus Storage_Error warning

[ebotcazou at gcc dot gnu dot org]

------- Comment #7 from ebotcazou at gcc dot gnu dot org  2006-10-29 23:10 -------
Probably a lost cause at this point...


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|ebotcazou at gcc dot gnu dot|unassigned at gcc dot gnu
                   |org                         |dot org
             Status|ASSIGNED                    |NEW
            Summary|[4.1 Regression] Bogus      |[4.1 regression] Bogus
                   |Storage_Error warning       |Storage_Error warning


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635

[Bug middle-end/26635] [4.1 regression] Bogus Storage_Error warning

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.2                       |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635

[Bug middle-end/26635] [4.1 regression] Bogus Storage_Error warning

[ebotcazou at gcc dot gnu dot org]

------- Comment #8 from ebotcazou at gcc dot gnu dot org  2007-11-02 07:50 -------
Withdrawn.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635

[Bug middle-end/26635] [4.3/4.4 regression] bogus Storage_Error warning

[ebotcazou at gcc dot gnu dot org]

------- Comment #9 from ebotcazou at gcc dot gnu dot org  2008-05-12 16:42 -------
Testcase for mainline to be attached, same underlying problem.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://gcc.gnu.org/ml/gcc-  |
                   |patches/2006-               |
                   |04/msg00080.html            |
             Status|RESOLVED                    |REOPENED
         Resolution|WONTFIX                     |
            Summary|[4.1 regression] Bogus      |[4.3/4.4 regression] bogus
                   |Storage_Error warning       |Storage_Error warning


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635

[Bug middle-end/26635] [4.3/4.4 regression] bogus Storage_Error warning

[ebotcazou at gcc dot gnu dot org]

------- Comment #10 from ebotcazou at gcc dot gnu dot org  2008-05-12 16:43 -------
Created an attachment (id=15630)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15630&action=view)
New reduced Ada testcase.

eric@linux:~/build/gcc/native32> gcc/xgcc -Bgcc -S p.adb -I gcc/ada/rts
p.adb:20:14: warning: Storage_Error will be raised at run-time
eric@linux:~/build/gcc/native32> gcc/xgcc -v
Using built-in specs.
Target: i586-suse-linux
Configured with: /home/eric/svn/gcc/configure i586-suse-linux
--prefix=/home/eric/install/gcc
--with-as=/home/eric/build/binutils-2_18-branch/native32/gas/as-new
--with-ld=/home/eric/build/binutils-2_18-branch/native32/ld/ld-new
--enable-languages=c,c++,ada --enable-checking=yes,rtl --enable-__cxa_atexit
--disable-nls--disable-libmudflap
Thread model: posix
gcc version 4.4.0 20080506 (experimental) [trunk revision 134981] (GCC)


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11016|0                           |1
        is obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635

[Bug middle-end/26635] [4.3/4.4 regression] bogus Storage_Error warning

[ebotcazou at gcc dot gnu dot org]

------- Comment #11 from ebotcazou at gcc dot gnu dot org  2008-05-12 16:44 -------
I'll do something in Gigi.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |ebotcazou at gcc dot gnu dot
                   |dot org                     |org
             Status|REOPENED                    |ASSIGNED
   Last reconfirmed|2006-09-12 11:43:28         |2008-05-12 16:44:37
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635

[Bug ada/26635] [4.3/4.4 regression] bogus Storage_Error warning

[ebotcazou at gcc dot gnu dot org]

------- Comment #12 from ebotcazou at gcc dot gnu dot org  2008-05-13 08:47 -------
Subject: Bug 26635

Author: ebotcazou
Date: Tue May 13 08:46:18 2008
New Revision: 135257

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=135257
Log:
        PR ada/24880
        PR ada/26635
        * utils.c (convert) <INTEGER_TYPE>: When converting an additive
        expression to an integral type with lower precision, use NOP_EXPR
        directly in a couple of special cases.


Added:
    trunk/gcc/testsuite/gnat.dg/conv_integer.adb
    trunk/gcc/testsuite/gnat.dg/discr7.adb
Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/utils.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635

[Bug ada/26635] [4.3/4.4 regression] bogus Storage_Error warning

[ebotcazou at gcc dot gnu dot org]

------- Comment #13 from ebotcazou at gcc dot gnu dot org  2008-05-13 08:47 -------
Subject: Bug 26635

Author: ebotcazou
Date: Tue May 13 08:46:49 2008
New Revision: 135258

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=135258
Log:
        PR ada/24880
        PR ada/26635
        * utils.c (convert) <INTEGER_TYPE>: When converting an additive
        expression to an integral type with lower precision, use NOP_EXPR
        directly in a couple of special cases.


Added:
    branches/gcc-4_3-branch/gcc/testsuite/gnat.dg/conv_integer.adb
    branches/gcc-4_3-branch/gcc/testsuite/gnat.dg/discr7.adb
Modified:
    branches/gcc-4_3-branch/gcc/ada/ChangeLog
    branches/gcc-4_3-branch/gcc/ada/utils.c
    branches/gcc-4_3-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635

[Bug ada/26635] [4.3/4.4 regression] bogus Storage_Error warning

[ebotcazou at gcc dot gnu dot org]

------- Comment #14 from ebotcazou at gcc dot gnu dot org  2008-05-13 08:53 -------
Fixed in the upcoming 4.3.1 release.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2008-
                   |                            |05/msg00731.html
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|4.1.3                       |4.3.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26635