* [Bug ada/26796] [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error
2006-03-22 7:26 [Bug ada/26796] New: [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error laurent at guerby dot net
@ 2006-03-22 10:32 ` ebotcazou at gcc dot gnu dot org
2006-03-22 19:28 ` ebotcazou at gcc dot gnu dot org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ebotcazou at gcc dot gnu dot org @ 2006-03-22 10:32 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from ebotcazou at gcc dot gnu dot org 2006-03-22 10:32 -------
Not present on 20/03:
http://gcc.gnu.org/ml/gcc-testresults/2006-03/msg01368.html
Present on 21/03: http://gcc.gnu.org/ml/gcc-testresults/2006-03/msg01395.html
--
ebotcazou at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ebotcazou at gcc dot gnu dot
| |org
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2006-03-22 10:32:16
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26796
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug ada/26796] [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error
2006-03-22 7:26 [Bug ada/26796] New: [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error laurent at guerby dot net
2006-03-22 10:32 ` [Bug ada/26796] " ebotcazou at gcc dot gnu dot org
@ 2006-03-22 19:28 ` ebotcazou at gcc dot gnu dot org
2006-03-22 21:08 ` pinskia at gcc dot gnu dot org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ebotcazou at gcc dot gnu dot org @ 2006-03-22 19:28 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from ebotcazou at gcc dot gnu dot org 2006-03-22 19:27 -------
The 2 failures have been introduced by the following change:
2006-03-20 Jeff Law <law@redhat.com>
* tree-pass.h (pass_phi_only_copy_prop): Delete.
(pass_phi_only_cprop): Declare.
* passes.c (init_optimization_passes): Replace pass_phi_only_copy_prop
with phi_only_cprop
* tree-ssa-dom.c (degenerate_phi_result): New function.
(remove_stmt_or_phi, get_lhs_or_phi_result): Likewise.
(get_rhs_or_phi_arg, propagate_rhs_into_lhs): Likewise.
(eliminate_const_or_copy, eliminate_degenerate_phis_1): Likewise.
(eliminate_degenerate_phis): Likewise.
(pass_phi_only_cprop): New pass descriptor.
* tree-ssa-copy.c (init_copy_prop): Lose PHIS_ONLY argument and
support code. Callers updated.
(execute_copy_prop, do_copy_prop): Likewise and corresponding changes.
(store_copy_prop): Likewise.
(do_phi_only_copy_prop, pass_phi_only_copy_prop): Remove.
--
ebotcazou at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |law at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26796
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug ada/26796] [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error
2006-03-22 7:26 [Bug ada/26796] New: [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error laurent at guerby dot net
2006-03-22 10:32 ` [Bug ada/26796] " ebotcazou at gcc dot gnu dot org
2006-03-22 19:28 ` ebotcazou at gcc dot gnu dot org
@ 2006-03-22 21:08 ` pinskia at gcc dot gnu dot org
2006-03-27 17:53 ` [Bug tree-optimization/26796] " law at redhat dot com
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-03-22 21:08 UTC (permalink / raw)
To: gcc-bugs
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pinskia at gcc dot gnu dot
| |org
Target Milestone|--- |4.2.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26796
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug tree-optimization/26796] [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error
2006-03-22 7:26 [Bug ada/26796] New: [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error laurent at guerby dot net
` (2 preceding siblings ...)
2006-03-22 21:08 ` pinskia at gcc dot gnu dot org
@ 2006-03-27 17:53 ` law at redhat dot com
2006-03-28 15:35 ` law at gcc dot gnu dot org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: law at redhat dot com @ 2006-03-27 17:53 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from law at redhat dot com 2006-03-27 17:53 -------
Separate issue than 26797. Not sure how to fix yet, but it's definitely a
bug in the new code.
jeff
--
law at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |law at redhat dot com
|dot org |
Status|NEW |ASSIGNED
Last reconfirmed|2006-03-22 10:32:16 |2006-03-27 17:53:54
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26796
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug tree-optimization/26796] [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error
2006-03-22 7:26 [Bug ada/26796] New: [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error laurent at guerby dot net
` (3 preceding siblings ...)
2006-03-27 17:53 ` [Bug tree-optimization/26796] " law at redhat dot com
@ 2006-03-28 15:35 ` law at gcc dot gnu dot org
2006-03-28 15:38 ` law at redhat dot com
2006-03-30 6:39 ` ebotcazou at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: law at gcc dot gnu dot org @ 2006-03-28 15:35 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from law at gcc dot gnu dot org 2006-03-28 15:35 -------
Subject: Bug 26796
Author: law
Date: Tue Mar 28 15:35:47 2006
New Revision: 112453
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=112453
Log:
PR tree-optimization/26796
* tree-ssa-dom.c (propagate_rhs_into_lhs): Queue blocks which
need EH edge cleanups rather than purging them immediately.
(eliminate_degenerate_phis): Handle queued EH cleanups.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/tree-ssa-dom.c
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26796
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug tree-optimization/26796] [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error
2006-03-22 7:26 [Bug ada/26796] New: [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error laurent at guerby dot net
` (4 preceding siblings ...)
2006-03-28 15:35 ` law at gcc dot gnu dot org
@ 2006-03-28 15:38 ` law at redhat dot com
2006-03-30 6:39 ` ebotcazou at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: law at redhat dot com @ 2006-03-28 15:38 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from law at redhat dot com 2006-03-28 15:38 -------
Subject: Re: [4.2 Regression] ACATS ICE c34002a c52005
spurious storage_error
On Wed, 2006-03-22 at 19:28 +0000, ebotcazou at gcc dot gnu dot org
wrote:
>
> ------- Comment #2 from ebotcazou at gcc dot gnu dot org 2006-03-22 19:27 -------
> The 2 failures have been introduced by the following change:
>
> 2006-03-20 Jeff Law <law@redhat.com>
>
> * tree-pass.h (pass_phi_only_copy_prop): Delete.
> (pass_phi_only_cprop): Declare.
> * passes.c (init_optimization_passes): Replace pass_phi_only_copy_prop
> with phi_only_cprop
> * tree-ssa-dom.c (degenerate_phi_result): New function.
> (remove_stmt_or_phi, get_lhs_or_phi_result): Likewise.
> (get_rhs_or_phi_arg, propagate_rhs_into_lhs): Likewise.
> (eliminate_const_or_copy, eliminate_degenerate_phis_1): Likewise.
> (eliminate_degenerate_phis): Likewise.
> (pass_phi_only_cprop): New pass descriptor.
> * tree-ssa-copy.c (init_copy_prop): Lose PHIS_ONLY argument and
> support code. Callers updated.
> (execute_copy_prop, do_copy_prop): Likewise and corresponding changes.
> (store_copy_prop): Likewise.
> (do_phi_only_copy_prop, pass_phi_only_copy_prop): Remove.
The problem is that phi-cprop managed to perform some propagations
which ultimately led it to proving certain EH edges were not executable.
So we dutifully purged the EH edges, which in turn wiped out the
dominator tree. Opps. I wasn't aware of that little tidbit
(forwprop doesn't use the DOM tree, so it doesn't have this
issue).
As it turns out DOM already has a mechanism to deal with queued
blocks needing EH edge cleanups. So I tweaked the phi-cprop
pass to use that existing mechanism.
Bootstrapped and regression tested on i686-pc-linux-gnu (ada included).
Fixes c340002a and c52005.
------- Comment #6 from law at redhat dot com 2006-03-28 15:38 -------
Created an attachment (id=11137)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11137&action=view)
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26796
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug tree-optimization/26796] [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error
2006-03-22 7:26 [Bug ada/26796] New: [4.2 Regression] ACATS ICE c34002a c52005 spurious storage_error laurent at guerby dot net
` (5 preceding siblings ...)
2006-03-28 15:38 ` law at redhat dot com
@ 2006-03-30 6:39 ` ebotcazou at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: ebotcazou at gcc dot gnu dot org @ 2006-03-30 6:39 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from ebotcazou at gcc dot gnu dot org 2006-03-30 06:39 -------
Jeff, please put PR numbers in your ChangeLog entries, thanks.
--
ebotcazou at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|law at gcc dot gnu dot org |
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26796
^ permalink raw reply [flat|nested] 8+ messages in thread