[Bug libfortran/27360] New: Memory leaks when reading logicals

[Bug libfortran/27360] New: Memory leaks when reading logicals

[eedelman at gcc dot gnu dot org]

It seems that the io library is leaking memory when reading logicals, as
demonstrated by the small program below; when running, the program uses more
and more memory until it's killed.  I don't see this behaviour with data types
other than logicals.

erik:/var/tmp$ cat memoryleak.f90 
program memoryleak

    implicit none
    logical :: foo
    integer :: ios

    ios = 0
    do while (ios == 0)
        read (*, *, iostat=ios) foo
    end do

end program memoryleak
erik:/var/tmp$ gfortran memoryleak.f90 
erik:/var/tmp$ awk 'BEGIN{while (1) print "F"}' | a.out
Killed


-- 
           Summary: Memory leaks when reading logicals
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libfortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: eedelman at gcc dot gnu dot org
  GCC host triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27360

[Bug libfortran/27360] Memory leaks when reading logicals

[jvdelisle at gcc dot gnu dot org]

------- Comment #1 from jvdelisle at gcc dot gnu dot org  2006-04-30 00:12 -------
I will look into this.  Thought we had them all, but maybe not.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27360

[Bug libfortran/27360] Memory leaks when reading logicals

[jvdelisle at gcc dot gnu dot org]

------- Comment #2 from jvdelisle at gcc dot gnu dot org  2006-04-30 01:15 -------
Confirmed and i found the spot in read_logical.  I will have a fix shortly.  My
bad on this one.


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jvdelisle at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-04-30 01:15:06
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27360

[Bug libfortran/27360] Memory leaks when reading logicals

[jvdelisle at gcc dot gnu dot org]

------- Comment #3 from jvdelisle at gcc dot gnu dot org  2006-04-30 03:19 -------
Subject: Bug 27360

Author: jvdelisle
Date: Sun Apr 30 03:19:37 2006
New Revision: 113388

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113388
Log:
2006-04-29  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/27360

        * io/list_read.c (read_logical):  Free line_buffer and free saved.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/list_read.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27360

[Bug libfortran/27360] Memory leaks when reading logicals

[patchapp at dberlin dot org]

------- Comment #4 from patchapp at dberlin dot org  2006-04-30 03:20 -------
Subject: Bug number PR27360

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-04/msg01152.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27360

[Bug libfortran/27360] Memory leaks when reading logicals

[eedelman at gcc dot gnu dot org]

------- Comment #5 from eedelman at gcc dot gnu dot org  2006-04-30 18:05 -------
(In reply to comment #4)
> Subject: Bug number PR27360
> 
> A patch for this bug has been added to the patch tracker.
> The mailing list url for the patch is
> http://gcc.gnu.org/ml/gcc-patches/2006-04/msg01152.html
> 

Works for me. Thanks for the quick fix!


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27360

[Bug libfortran/27360] Memory leaks when reading logicals

[jvdelisle at gcc dot gnu dot org]

------- Comment #6 from jvdelisle at gcc dot gnu dot org  2006-04-30 19:53 -------
Subject: Bug 27360

Author: jvdelisle
Date: Sun Apr 30 19:53:41 2006
New Revision: 113396

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113396
Log:
2006-04-30  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/27360

        * io/list_read.c (read_logical):  Free line_buffer and free saved.

Modified:
    branches/gcc-4_1-branch/libgfortran/ChangeLog
    branches/gcc-4_1-branch/libgfortran/io/list_read.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27360

[Bug libfortran/27360] Memory leaks when reading logicals

[jvdelisle at gcc dot gnu dot org]

------- Comment #7 from jvdelisle at gcc dot gnu dot org  2006-04-30 19:55 -------
Fixed on 4.1 and 4.2


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27360