[Bug c++/27102] New: Semgmentation Fault on Template

[Bug c++/27102] New: Semgmentation Fault on Template

[mmirzaza at cs dot uwaterloo dot ca]

gcc gives segmenation fault on the following code:

template <class T>
void T::foo() {
}


-- 
           Summary: Semgmentation Fault on Template
           Product: gcc
           Version: 4.0.3
            Status: UNCONFIRMED
          Severity: critical
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: mmirzaza at cs dot uwaterloo dot ca


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1/4.2 regression] ICE with invalid class name in function template

[reichelt at gcc dot gnu dot org]

------- Comment #1 from reichelt at gcc dot gnu dot org  2006-04-10 15:01 -------
Confirmed.
We had a similar problem with template classes in PR18731.


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |reichelt at gcc dot gnu dot
                   |                            |org
           Severity|critical                    |normal
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |ice-on-invalid-code,
                   |                            |monitored
   Last reconfirmed|0000-00-00 00:00:00         |2006-04-10 15:01:31
               date|                            |
            Summary|Semgmentation Fault on      |[4.0/4.1/4.2 regression] ICE
                   |Template                    |with invalid class name in
                   |                            |function template
   Target Milestone|---                         |4.1.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1/4.2 regression] ICE with invalid class name in function template

[reichelt at gcc dot gnu dot org]

------- Comment #2 from reichelt at gcc dot gnu dot org  2006-04-10 15:03 -------
Btw, the ICE is a segfault on the 4.0 branch.
On the 4.1 branch and mainline we get:
bug.cc:2: internal compiler error: in is_ancestor, at cp/name-lookup.c:2222


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1/4.2 regression] ICE with invalid class name in function template

[mmitchel at gcc dot gnu dot org]

------- Comment #3 from mmitchel at gcc dot gnu dot org  2006-04-16 18:31 -------
Testing a fix.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |mark at codesourcery dot com
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1/4.2 regression] ICE with invalid class name in function template

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1/4.2 regression] ICE with invalid class name in function template

[reichelt at gcc dot gnu dot org]

------- Comment #4 from reichelt at gcc dot gnu dot org  2006-04-18 10:43 -------
Hi Mark,
I was just testing the following btw.:

===================================================================
--- gcc/gcc/cp/parser.c (revision 112814)
+++ gcc/gcc/cp/parser.c (working copy)
@@ -10930,6 +10930,12 @@ cp_parser_init_declarator (cp_parser* parser,
      we compute it now.  */
   scope = get_scope_of_declarator (declarator);

+  if (scope && TYPE_P (scope) && !CLASS_TYPE_P (scope))
+    {
+      error ("type %qT is not allowed in declaration", scope);
+      return error_mark_node;
+    }
+
   /* If we're allowing GNU extensions, look for an asm-specification
      and attributes.  */
   if (cp_parser_allow_gnu_extensions_p (parser))
===================================================================

This should also fix PR 11471.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1/4.2 regression] ICE with invalid class name in function template

[mark at codesourcery dot com]

------- Comment #5 from mark at codesourcery dot com  2006-04-18 19:41 -------
Subject: Re:  [4.0/4.1/4.2 regression] ICE with invalid class
 name in function template

reichelt at gcc dot gnu dot org wrote:
> ------- Comment #4 from reichelt at gcc dot gnu dot org  2006-04-18 10:43 -------
> Hi Mark,
> I was just testing the following btw.:

Thanks.

I've got a rather more involved changed (with some other good cleanups)
that I think is almost ready.  I'm concerned that your change wouldn't
be correct for friends in templates, which is usually the nasty case for
these kinds of things.

For example, I think "friend void T::f();" is valid, even if "T" is a
template type parameter.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1/4.2 regression] ICE with invalid class name in function template

[reichelt at gcc dot gnu dot org]

------- Comment #6 from reichelt at gcc dot gnu dot org  2006-04-18 21:20 -------
> For example, I think "friend void T::f();" is valid, even if "T" is a
> template type parameter.

Indeed. Ouch...
We probably should have a testcase to cover this. Apparently, we don't have
one yet. Otherwise, my invalid patch wouldn't have passed regtesting.
But I guess, you already took care of this.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1/4.2 regression] ICE with invalid class name in function template

[mmitchel at gcc dot gnu dot org]

------- Comment #7 from mmitchel at gcc dot gnu dot org  2006-04-19 16:58 -------
Subject: Bug 27102

Author: mmitchel
Date: Wed Apr 19 16:58:23 2006
New Revision: 113081

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113081
Log:
        PR c++/27102
        * class.c (currently_open_class): Tidy.
        * decl.c (grokdeclarator): If we encounter an erroneous
        declarator, assume that we have already issued an error message
        and return.  Return error_mark_node instead of NULL_TREE in more
        places.  Issue errors about function definitions that do not have
        a function declarator.  Check for complete types for all function
        definitions. 
        * cp-tree.h (cp_error_declarator): Remove.
        (currently_open_class): Change return type.
        * parser.c (cp_parser_id_expression): Add optional_p parameter.
        (cp_parser_parse_diagnose_invalid_type_name): Adjust calls.
        (cp_parser_id_expression): Likewise.
        (cp_parser_unqualified_id): If the name is optional, return
        NULL_TREE.
        (cp_parser_postfix_dot_deref_expression): Adjust calls.
        (cp_parser_type_parameter): Likewise.
        (cp_parser_unqualified_id): Likewise.
        (cp_parser_direct_declarator): Likewise.
        (cp_parser_declarator_id): Add optional_p parameter.
        (cp_parser_function_definition_from_specifiers_and_declarator):
        Assume that start_function indicates failure only if it has issued
        an error.
        (cp_parser_omp_var_list_no_open): Adjust calls.

        PR c++/27102
        * g++.dg/template/crash35.C: Tweak error markers.
        * g++.dg/template/crash46.C: New test.
        * g++.old-deja/g++.brendan/friend4.C: Tweak error markers.
        * g++.old-deja/g++.pt/incomplete1.C: Likewise.

Added:
    trunk/gcc/testsuite/g++.dg/template/crash46.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/class.c
    trunk/gcc/cp/cp-tree.h
    trunk/gcc/cp/decl.c
    trunk/gcc/cp/parser.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/template/crash35.C
    trunk/gcc/testsuite/g++.old-deja/g++.brendan/friend4.C
    trunk/gcc/testsuite/g++.old-deja/g++.pt/incomplete1.C


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1 regression] ICE with invalid class name in function template

[mmitchel at gcc dot gnu dot org]

------- Comment #8 from mmitchel at gcc dot gnu dot org  2006-04-19 17:01 -------
Fixed in 4.2.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.0/4.1/4.2 regression] ICE|[4.0/4.1 regression] ICE
                   |with invalid class name in  |with invalid class name in
                   |function template           |function template


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1 regression] ICE with invalid class name in function template

[reichelt at gcc dot gnu dot org]

------- Comment #9 from reichelt at gcc dot gnu dot org  2006-04-20 10:45 -------
Mark, your patch doesn't cover the following case which still crashes
on mainline:

===========================================
template<typename T> void T::X::foo() {}
===========================================

The ICE is not in is_ancestor anymore, though:

PR27102B.cc:6: internal compiler error: in cxx_incomplete_type_diagnostic, at
cp/typeck2.c:422
Please submit a full bug report, [etc.]

Would you mind having a look?
Or should I file a different PR for this case?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1 regression] ICE with invalid class name in function template

[mmitchel at gcc dot gnu dot org]

------- Comment #10 from mmitchel at gcc dot gnu dot org  2006-04-27 19:03 -------
Subject: Bug 27102

Author: mmitchel
Date: Thu Apr 27 19:02:54 2006
New Revision: 113320

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113320
Log:
        PR c++/27102
        * typeck2.c (cxx_incomplete_type_diagnostic): Handle
        TYPENAME_TYPE.
        PR c++/27102
        * g++.dg/template/crash47.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/template/crash47.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/typeck2.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1 regression] ICE with invalid class name in function template

[mmitchel at gcc dot gnu dot org]

------- Comment #11 from mmitchel at gcc dot gnu dot org  2006-04-27 19:06 -------
The problem in Comment #9 has been resolved in 4.2.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1 regression] ICE with invalid class name in function template

[reichelt at gcc dot gnu dot org]

------- Comment #12 from reichelt at gcc dot gnu dot org  2006-04-29 21:40 -------
Subject: Bug 27102

Author: reichelt
Date: Sat Apr 29 21:39:54 2006
New Revision: 113382

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113382
Log:
        PR c++/11471
        PR c++/27102
        * g++.dg/template/crash48.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/template/crash48.C
Modified:
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1 regression] ICE with invalid class name in function template

[reichelt at gcc dot gnu dot org]

------- Comment #13 from reichelt at gcc dot gnu dot org  2006-05-02 16:31 -------
Mark, your patch seems to cause some fall-out.
The following testcase now ICEs on mainline:

===================================
template<typename T> void T::foo;
===================================

bug.cc:1: error: variable or field 'foo' declared void
bug.cc:1: internal compiler error: in is_ancestor, at cp/name-lookup.c:2233
Please submit a full bug report, [etc.]


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1 regression] ICE with invalid class name in function template

[mmitchel at gcc dot gnu dot org]

------- Comment #14 from mmitchel at gcc dot gnu dot org  2006-05-03 00:19 -------
Subject: Bug 27102

Author: mmitchel
Date: Wed May  3 00:19:40 2006
New Revision: 113492

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113492
Log:
        PR c++/27102
        * decl.c (grokdeclarator): Robustify checks for defining members
        of incomplete types.
        PR c++/27102
        * g++.dg/template/crash49.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/template/crash49.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/decl.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1 regression] ICE with invalid class name in function template

[mmitchel at gcc dot gnu dot org]

------- Comment #15 from mmitchel at gcc dot gnu dot org  2006-05-25 02:34 -------
Will not be fixed in 4.1.1; adjust target milestone to 4.1.2.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.1                       |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1 regression] ICE with invalid class name in function template

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.2                       |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1 regression] ICE with invalid class name in function template

[rguenth at gcc dot gnu dot org]

------- Comment #16 from rguenth at gcc dot gnu dot org  2007-02-21 11:12 -------
*** Bug 30901 has been marked as a duplicate of this bug. ***


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |grizlyk1 at yandex dot ru


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1 regression] ICE with invalid class name in function template

[bangerth at dealii dot org]

------- Comment #17 from bangerth at dealii dot org  2007-03-26 20:44 -------
*** Bug 31330 has been marked as a duplicate of this bug. ***


-- 

bangerth at dealii dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ilya at broad dot mit dot
                   |                            |edu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.0/4.1 regression] ICE with invalid class name in function template

[reichelt at gcc dot gnu dot org]

------- Comment #18 from reichelt at gcc dot gnu dot org  2007-04-09 15:08 -------
*** Bug 31277 has been marked as a duplicate of this bug. ***


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ineiev at yahoo dot co dot
                   |                            |uk


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.1 regression] ICE with invalid class name in function template

[jsm28 at gcc dot gnu dot org]

------- Comment #19 from jsm28 at gcc dot gnu dot org  2008-07-04 15:27 -------
Closing 4.1 branch.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to fail|4.0.4 4.1.2                 |4.0.4 4.1.2 4.1.3
         Resolution|                            |FIXED
   Target Milestone|4.1.3                       |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102

[Bug c++/27102] [4.1 regression] ICE with invalid class name in function template

[paolo dot carlini at oracle dot com]

------- Comment #20 from paolo dot carlini at oracle dot com  2009-12-31 11:57 -------
*** Bug 42563 has been marked as a duplicate of this bug. ***


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thomasd57 at yahoo dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27102