[Bug middle-end/27428] New: [4.0/4.1/4.2 regression] ICE with goto in erroneous code

[Bug middle-end/27428] New: [4.0/4.1/4.2 regression] ICE with goto in erroneous code

[reichelt at gcc dot gnu dot org]

The following invalid code snippet causes a segfault in main_block_label
in tree-cfg.c:

===========================
void foo()
{
    goto L;
    if (0..) { L: ; }
}
===========================

bug.c:4:9: error: too many decimal points in number
bug.c: In function 'foo':
bug.c:5: internal compiler error: Segmentation fault
Please submit a full bug report, [etc.]

We ICE since GCC 4.0.0.


-- 
           Summary: [4.0/4.1/4.2 regression] ICE with goto in erroneous code
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code, error-recovery, monitored
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: reichelt at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27428

[Bug middle-end/27428] [4.0/4.1/4.2 regression] ICE with goto in erroneous code

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27428

[Bug middle-end/27428] [4.0/4.1/4.2 regression] ICE with goto in erroneous code

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-05-05 08:19 -------
In .orginal:
  goto L;
  if (<<< error >>>)
    {
      L:;
    }

In ,gimple:
foo ()
{
  void L = <<< error >>>;

  goto L;
}

We really should keep the if (error_mark_node)


Confirmed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-05-05 08:19:34
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27428

[Bug middle-end/27428] [4.0/4.1/4.2 regression] ICE with goto in erroneous code

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2006-05-05 08:32 -------
Comment out two lines in the gimplifier like:
Index: gimplify.c
===================================================================
--- gimplify.c  (revision 113452)
+++ gimplify.c  (working copy)
@@ -5655,8 +5655,8 @@ gimplify_expr (tree *expr_p, tree *pre_p
      stub out the statement or propagate the error back out.  */
   if (ret == GS_ERROR)
     {
-      if (is_statement)
-       *expr_p = NULL;
+     // if (is_statement)
+//     *expr_p = NULL;
       goto out;
     }

Works but I don't know if there is any fall out from that because it is going
to be some.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27428

[Bug middle-end/27428] [4.0/4.1/4.2 regression] ICE with goto in erroneous code

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2006-05-29 22:21 -------
(In reply to comment #2)
> Works but I don't know if there is any fall out from that because it is going
> to be some.
There a large number of falls out from that patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27428

[Bug middle-end/27428] [4.0/4.1/4.2 regression] ICE with goto in erroneous code

[mmitchel at gcc dot gnu dot org]

------- Comment #4 from mmitchel at gcc dot gnu dot org  2006-06-04 18:47 -------
Why gimplify at all if an error has occurred?


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27428

[Bug middle-end/27428] [4.0/4.1/4.2 regression] ICE with goto in erroneous code

[sayle at gcc dot gnu dot org]

------- Comment #5 from sayle at gcc dot gnu dot org  2006-06-29 21:58 -------
Subject: Bug 27428

Author: sayle
Date: Thu Jun 29 21:57:23 2006
New Revision: 115080

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=115080
Log:

        PR middle-end/27428
        * c-lex.c (c_lex_with_flags) <CPP_N_INVALID>: Increment errorcount
        to indicate the cpplib has issued an error message for us.

        * gcc.dg/pr27428-1.c: New test case.


Added:
    trunk/gcc/testsuite/gcc.dg/pr27428-1.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-lex.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27428

[Bug middle-end/27428] [4.0/4.1 regression] ICE with goto in erroneous code

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2006-06-30 00:08 -------
Fixed for 4.2 at least.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.0/4.1/4.2 regression] ICE|[4.0/4.1 regression] ICE
                   |with goto in erroneous code |with goto in erroneous code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27428

[Bug middle-end/27428] [4.0/4.1 regression] ICE with goto in erroneous code

[sayle at gcc dot gnu dot org]

------- Comment #7 from sayle at gcc dot gnu dot org  2006-07-01 16:32 -------
Subject: Bug 27428

Author: sayle
Date: Sat Jul  1 16:32:00 2006
New Revision: 115116

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=115116
Log:

        PR middle-end/27428
        * c-lex.c (c_lex_with_flags) <CPP_N_INVALID>: Increment errorcount
        to indicate the cpplib has issued an error message for us.

        * gcc.dg/pr27428-1.c: New test case.


Added:
    branches/gcc-4_1-branch/gcc/testsuite/gcc.dg/pr27428-1.c
Modified:
    branches/gcc-4_1-branch/gcc/ChangeLog
    branches/gcc-4_1-branch/gcc/c-lex.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27428

[Bug middle-end/27428] [4.0/4.1 regression] ICE with goto in erroneous code

[sayle at gcc dot gnu dot org]

------- Comment #8 from sayle at gcc dot gnu dot org  2006-07-02 16:05 -------
Subject: Bug 27428

Author: sayle
Date: Sun Jul  2 16:05:28 2006
New Revision: 115133

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=115133
Log:

        PR middle-end/27428
        * c-lex.c (c_lex_with_flags) <CPP_N_INVALID>: Increment errorcount
        to indicate the cpplib has issued an error message for us.

        * gcc.dg/pr27428-1.c: New test case.


Added:
    branches/gcc-4_0-branch/gcc/testsuite/gcc.dg/pr27428-1.c
Modified:
    branches/gcc-4_0-branch/gcc/ChangeLog
    branches/gcc-4_0-branch/gcc/c-lex.c
    branches/gcc-4_0-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27428

[Bug middle-end/27428] [4.0/4.1 regression] ICE with goto in erroneous code

[pinskia at gcc dot gnu dot org]

------- Comment #9 from pinskia at gcc dot gnu dot org  2006-07-02 16:20 -------
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27428