[Bug fortran/27304] New: gfortran: Warn/abort when format in write does not fit passed arguments

[Bug fortran/27304] New: gfortran: Warn/abort when format in write does not fit passed arguments

[tobias dot burnus at physik dot fu-berlin dot de]

Test case:
---------------------------------
program test
  implicit none
  integer :: n
  n = 1
  write(*,'(''n'')') n
end program test
---------------------------------

gfortran -Wall -o test test1.f90   [4.1.0 (SUSE Linux); 4.2.0 20060423]

Compiles without warning/error and ./test outputs "nn".

Expected:
  During compile: Bail out with an error message or at least show a warning.

The NAGWare Fortran 95 compiler Release 5.0(414)) for comparison:
------------
f95 -o test test1.f90
Error: test1.f90, line 5: No data-edit descriptor for effective item
[f95 error termination]


-- 
           Summary: gfortran: Warn/abort when format in write does not fit
                    passed arguments
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tobias dot burnus at physik dot fu-berlin dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[tobias dot burnus at physik dot fu-berlin dot de]

------- Comment #1 from tobias dot burnus at physik dot fu-berlin dot de  2006-04-25 17:24 -------
Post scriptum:
I actually see two bugs here:

(a) for static format strings, the test should be done at the compile time
(possibly also for  c = '(''n'')'; write(*,c) n )
-> see NAG compiler

(b) for dynamically created format strings, I think one should "crash" with a
meaningful error message. At least that is what ifort, g95, NAG and pgf95 do. I
like the error message of g95:
---------------
At line 5 of file test.f90 (Unit 6)
Fortran runtime error: Exhausted data descriptors in format
('n')
---------------
(other wording in NAG f95: "No data edit descriptor in tail of format
specification after reversion" [and no line number])


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2006-04-25 18:33 -------
Confirmed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-04-25 18:33:43
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[jvdelisle at gcc dot gnu dot org]

------- Comment #3 from jvdelisle at gcc dot gnu dot org  2006-04-26 04:10 -------
I am not sure (emphasis on not sure) I agree with this.  But I can explain what
it is doing.  It is correctly printing out the letter 'n' then its looking for
the first data item and finds the integer in the list, it reverts on the format
statement, performs it and then its done because there are no more data items. 
At least its logical.  :)

I wonder if this is a case of illegal code.  Intel errors on "infinite format".
 In other words it keeps reverting looking for a format specifier.

gfortran is format driven until there is no more data.

g77 exactly matches gfortran in behavior. 

We should check the standard.  Is it required that there is a data format
specifier?

If not, then this could be an enhancement.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[tobias dot burnus at physik dot fu-berlin dot de]

------- Comment #4 from tobias dot burnus at physik dot fu-berlin dot de  2006-04-26 06:22 -------
Subject: Re:  gfortran: Warn/abort when format in write
 does not fit passed arguments

> I wonder if this is a case of illegal code.  Intel errors on "infinite
> format".

Well, current g95, ifort 9/9.1, pgf95 6.0, pathscale and NAG f95 regard
it as such and abort the execution or (NAG, today's g95) error on
compilation.

In the 2004-05 "Fortran 2003" draft (10.3) I find:

"If an input/output list specifies at least one effective list item, at
least
one data edit descriptor shall exist in the format specification."

For the compile-time I thus would really regard it as error.
What the best behaviour for the run time is, is however debatable.
(Abort [most compilers], ignore [g77, gfortran], ignore & warn [no
compiler?].)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[jvdelisle at gcc dot gnu dot org]

------- Comment #5 from jvdelisle at gcc dot gnu dot org  2006-04-26 22:53 -------
The standard reference seems clear.  I will see about giving a runtime error. 
Someone else will have to do the compile time magic.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[patchapp at dberlin dot org]

------- Comment #6 from patchapp at dberlin dot org  2006-04-27 05:50 -------
Subject: Bug number PR27304

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-04/msg01023.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[jvdelisle at gcc dot gnu dot org]

------- Comment #7 from jvdelisle at gcc dot gnu dot org  2006-04-27 06:02 -------
Tobias, I hope this is what you were looking for.  I don't really think we need
a compile time check.  That would be pretty involved to do and the error is
caught at runtime.

What do you think?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[burnus at net-b dot de]

------- Comment #8 from burnus at net-b dot de  2006-04-27 08:09 -------
Subject: Re:  gfortran: Warn/abort when format in write
 does not fit passed arguments

(In reply to comment #7)
> Tobias, I hope this is what you were looking for.  I don't really
think we need
> a compile time check.  That would be pretty involved to do and the
error is
> caught at runtime.
I think it is ok (though Brooks wording is probably better).

Still it would be nice if it would be detected during compile time. In
my case it was burried in an
   if(something that rarely happens) write(*,'(''n'')') n
which I wouldn't have found easily without the compile-time warning of
the NAG compiler.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[jvdelisle at gcc dot gnu dot org]

------- Comment #9 from jvdelisle at gcc dot gnu dot org  2006-04-28 23:55 -------
Subject: Bug 27304

Author: jvdelisle
Date: Fri Apr 28 23:55:30 2006
New Revision: 113363

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113363
Log:
2006-04-28  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/27304
        * io/transfer.c (formatted_transfer_scalar):  Generate error if data
        descriptors are exhausted.
        * io/format.c (next_format0): Fix comment.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/format.c
    trunk/libgfortran/io/transfer.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[jvdelisle at gcc dot gnu dot org]

------- Comment #10 from jvdelisle at gcc dot gnu dot org  2006-04-29 00:02 -------
Subject: Bug 27304

Author: jvdelisle
Date: Sat Apr 29 00:02:10 2006
New Revision: 113364

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113364
Log:
2006-04-28  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/27304
        * gfortran.dg/fmt_exhaust.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/fmt_exhaust.f90
Modified:
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[jvdelisle at gcc dot gnu dot org]

------- Comment #11 from jvdelisle at gcc dot gnu dot org  2006-04-30 20:59 -------
Subject: Bug 27304

Author: jvdelisle
Date: Sun Apr 30 20:59:08 2006
New Revision: 113397

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113397
Log:
2006-04-30  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/27304
        * io/transfer.c (formatted_transfer_scalar):  Generate error if data
        descriptors are exhausted.
        * io/format.c (next_format0): Fix comment.

Modified:
    branches/gcc-4_1-branch/libgfortran/ChangeLog
    branches/gcc-4_1-branch/libgfortran/io/format.c
    branches/gcc-4_1-branch/libgfortran/io/transfer.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[jvdelisle at gcc dot gnu dot org]

------- Comment #12 from jvdelisle at gcc dot gnu dot org  2006-04-30 21:02 -------
Subject: Bug 27304

Author: jvdelisle
Date: Sun Apr 30 21:02:10 2006
New Revision: 113398

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113398
Log:
2006-04-30  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/27304
        * gfortran.dg/fmt_exhaust.f90: New test.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/fmt_exhaust.f90
Modified:
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[jvdelisle at gcc dot gnu dot org]

------- Comment #13 from jvdelisle at gcc dot gnu dot org  2006-04-30 21:02 -------
Fixed on 4.1 and 4.2


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[tobias dot burnus at physik dot fu-berlin dot de]

------- Comment #14 from tobias dot burnus at physik dot fu-berlin dot de  2006-05-02 08:37 -------
> Fixed on 4.1 and 4.2

Thanks for fixing :-)

Still it would be nice if it would be detected during compile time. In
my case it was burried in an
   if(something that rarely happens) write(*,'(''n'')') n
which I wouldn't have found easily without the compile-time warning of
the NAG compiler.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[tobias dot burnus at physik dot fu-berlin dot de]

------- Comment #15 from tobias dot burnus at physik dot fu-berlin dot de  2006-05-04 19:09 -------
I probably do something wrong, but with
  GNU Fortran 95 (GCC) 4.2.0 20060504 (experimental)
from http://quatramaran.ens.fr/~coudert/gfortran/gfortran-x86_64-linux.tar.gz

I still don't get a run-time error message.
Using fmt_exhaust.f90 it crashes (abort()) rather than going to 10 (err=10).
As does my test case.


-- 

tobias dot burnus at physik dot fu-berlin dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[jvdelisle at gcc dot gnu dot org]

------- Comment #16 from jvdelisle at gcc dot gnu dot org  2006-05-05 00:13 -------
I can not reproduce this here.  I don't have that platform.  I am guessing this
is a platform specific problem or a build problem.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[fxcoudert at gcc dot gnu dot org]

------- Comment #17 from fxcoudert at gcc dot gnu dot org  2006-05-05 07:04 -------
(In reply to comment #15)
> I probably do something wrong, but with
>   GNU Fortran 95 (GCC) 4.2.0 20060504 (experimental)
> from http://quatramaran.ens.fr/~coudert/gfortran/gfortran-x86_64-linux.tar.gz
> 
> I still don't get a run-time error message.
> Using fmt_exhaust.f90 it crashes (abort()) rather than going to 10 (err=10).
> As does my test case.

With this exact same package, fmt_exhaust.f90 runs fines (all my nightly builds
are tested, and the results for this one:
http://quatramaran.ens.fr/~coudert/gfortran/test-results/test-x86_64-linux-20060504.log
are completely clean) and your testcase gives:

$ cat a.f90
program test
  implicit none
  integer :: n
  n = 1
  write(*,'(''n'')') n
end program test
$ ./bin/gfortran -static a.f90 && ./a.out
At line 5 of file a.f90
Fortran runtime error: Insufficient data descriptors in format after reversion


This looks like you have an old version of the library around, and that it's
used instead of that of the newer compiler. Try compiling with -static or
setting LD_LIBRARY_PATH before execution.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fxcoudert at gcc dot gnu dot
                   |                            |org
             Status|REOPENED                    |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[tobias dot burnus at physik dot fu-berlin dot de]

------- Comment #18 from tobias dot burnus at physik dot fu-berlin dot de  2006-05-09 20:15 -------
Subject: Re:  gfortran: Warn/abort when format in write
 does not fit passed arguments

@resolution : FIXED
> This looks like you have an old version of the library around, and that it's
> used instead of that of the newer compiler. Try compiling with -static or
> setting LD_LIBRARY_PATH before execution.
>   
I'm an idiot. Generally, I call gfortran via ~/bin/gfortran-4.2 containing
  exec /opt/gcc-4.2-svn/bin/gfortran -Wl,-rpath,/opt/gcc-4.2-svn/lib64 "$@"
but seemingly this time not :-(


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304

[Bug fortran/27304] gfortran: Warn/abort when format in write does not fit passed arguments

[fxcoudert at gcc dot gnu dot org]

------- Comment #19 from fxcoudert at gcc dot gnu dot org  2006-05-09 22:10 -------
OK, closing as fixed, then.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.1.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27304