[Bug objc/27240] New: [4.1/4.2 regression] ICE with invalid fields

[Bug objc/27240] New: [4.1/4.2 regression] ICE with invalid fields

[reichelt at gcc dot gnu dot org]

Compiling the following invalid objc testcase results in an ICE:

============================
void foo()
{
  struct A a;
  a.i;
}
============================

bug1.m: In function 'foo':
bug1.m:3: error: storage size of 'a' isn't known
bug1.m:4: internal compiler error: tree check: expected class 'type', have
'exceptional' (error_mark) in objc_is_public, at objc/objc-act.c:7171
Please submit a full bug report, [etc.]


The following patch fixes the problem for me, but hasn't been bootstrapped yet:

===================================================================
--- gcc/gcc/objc/objc-act.c     (revision 113130)
+++ gcc/gcc/objc/objc-act.c     (working copy)
@@ -7168,6 +7168,9 @@
     return 1;
 #endif

+  if (TREE_TYPE (expr) == error_mark_node)
+    return 1;
+
   basetype = TYPE_MAIN_VARIANT (TREE_TYPE (expr));

   if (basetype && TREE_CODE (basetype) == RECORD_TYPE)
===================================================================


-- 
           Summary: [4.1/4.2 regression] ICE with invalid fields
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code, error-recovery
          Severity: normal
          Priority: P3
         Component: objc
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: reichelt at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27240

[Bug objc/27240] [4.1/4.2 regression] ICE with invalid fields

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-04-21 19:05 -------
Confirmed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-04-21 19:05:35
               date|                            |
   Target Milestone|---                         |4.1.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27240

[Bug objc/27240] [4.1/4.2 regression] ICE with invalid fields

[reichelt at gcc dot gnu dot org]

-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |reichelt at gcc dot gnu dot
                   |dot org                     |org
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2006-
                   |                            |05/msg00159.html
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27240

[Bug objc/27240] [4.1/4.2 regression] ICE with invalid fields

[reichelt at gcc dot gnu dot org]

------- Comment #2 from reichelt at gcc dot gnu dot org  2006-05-05 19:48 -------
Subject: Bug 27240

Author: reichelt
Date: Fri May  5 19:48:26 2006
New Revision: 113559

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113559
Log:
        PR objc/27240
        * objc-act.c (objc_is_public): Return early on invalid type.

        * objc.dg/member-1.m: New test.

Added:
    trunk/gcc/testsuite/objc.dg/member-1.m
Modified:
    trunk/gcc/objc/ChangeLog
    trunk/gcc/objc/objc-act.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27240

[Bug objc/27240] [4.1/4.2 regression] ICE with invalid fields

[reichelt at gcc dot gnu dot org]

------- Comment #3 from reichelt at gcc dot gnu dot org  2006-05-05 19:51 -------
Subject: Bug 27240

Author: reichelt
Date: Fri May  5 19:51:37 2006
New Revision: 113560

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113560
Log:
        PR objc/27240
        * objc-act.c (objc_is_public): Return early on invalid type.

        * objc.dg/member-1.m: New test.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/objc.dg/member-1.m
Modified:
    branches/gcc-4_1-branch/gcc/objc/ChangeLog
    branches/gcc-4_1-branch/gcc/objc/objc-act.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27240

[Bug objc/27240] [4.1/4.2 regression] ICE with invalid fields

[reichelt at gcc dot gnu dot org]

------- Comment #4 from reichelt at gcc dot gnu dot org  2006-05-05 19:54 -------
Fixed on mainline and the 4.1 branch.


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27240

[Bug objc/27240] [4.1/4.2 regression] ICE with invalid fields

[patchapp at dberlin dot org]

------- Comment #5 from patchapp at dberlin dot org  2006-05-15 19:32 -------
Subject: Bug number PR objc/27240

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-05/msg00159.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27240