[Bug testsuite/27476] New: Thousands of run_all.sh[242]: ==: A test command parameter is not valid

[Bug testsuite/27476] New: Thousands of run_all.sh[242]: ==: A test command parameter is not valid

[danglin at gcc dot gnu dot org]

=== acats support ===
Generating support files... done.
Compiling support files... done.

                === acats tests ===
Running chapter a ...
/mnt/gnu/gcc-3.3/gcc/gcc/testsuite/ada/acats/run_all.sh[242]: ==: A test
command
 parameter is not valid.
/mnt/gnu/gcc-3.3/gcc/gcc/testsuite/ada/acats/run_all.sh[242]: ==: A test
command
 parameter is not valid.
...


-- 
           Summary: Thousands of run_all.sh[242]: ==: A test command
                    parameter is not valid
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: testsuite
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: danglin at gcc dot gnu dot org
 GCC build triplet: hppa2.0w-hp-hpux11.11
  GCC host triplet: hppa2.0w-hp-hpux11.11
GCC target triplet: hppa2.0w-hp-hpux11.11


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27476

[Bug testsuite/27476] Thousands of run_all.sh[242]: ==: A test command parameter is not valid

[laurent at guerby dot net]

------- Comment #1 from laurent at guerby dot net  2006-05-08 10:49 -------
This is probably because of my run_all.sh patch, sorry about that.

Could you try replacing testsuite/ada/acats/run_all.sh line 242 by:

if [ -z "$main" ]; then

And tell us wether it fixes the problem or not?

I'm testing it on my Linux box, but I have no access to an hpux box.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27476

[Bug testsuite/27476] ACATS: Ada testsuite Bourne shell compatibility problem on hpux

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #2 from dave at hiauly1 dot hia dot nrc dot ca  2006-05-08 16:18 -------
Subject: Re:  Thousands of run_all.sh[242]: ==: A test command parameter is not
valid

> Could you try replacing testsuite/ada/acats/run_all.sh line 242 by:
> 
> if [ -z "$main" ]; then
> 
> And tell us wether it fixes the problem or not?

It works.

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27476

[Bug testsuite/27476] ACATS: Ada testsuite Bourne shell compatibility problem on hpux

[laurent at guerby dot net]

------- Comment #3 from laurent at guerby dot net  2006-05-08 16:27 -------
Patch submitted.


-- 

laurent at guerby dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2006-
                   |                            |05/msg00304.html


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27476

[Bug testsuite/27476] ACATS: Ada testsuite Bourne shell compatibility problem on hpux

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-05-08 16:31:49
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27476

[Bug testsuite/27476] ACATS: Ada testsuite Bourne shell compatibility problem on hpux

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2006-05-08 16:31 -------
[ "x${main}" != "x" ] should also work and maybe a little more portable.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27476

Re: [Bug testsuite/27476] ACATS: Ada testsuite Bourne shell compatibility problem on hpux

[Arnaud Charlet]

>------ Comment #4 from pinskia at gcc dot gnu dot org  2006-05-08 16:31 -------
> [ "x${main}" != "x" ] should also work and maybe a little more portable.

That's also fine, although overkill these days.

All host OSes supported by GNAT (and more) accept the following simpler
and cleaner syntax:

 if [ "$main" != "" ]; then

or the other way around as needed here:

 if [ "$main" = "" ]; then

Arno

[Bug testsuite/27476] ACATS: Ada testsuite Bourne shell compatibility problem on hpux

[charlet at adacore dot com]

------- Comment #5 from charlet at adacore dot com  2006-05-08 16:35 -------
Subject: Re:  ACATS: Ada testsuite Bourne shell compatibility problem on hpux

>------ Comment #4 from pinskia at gcc dot gnu dot org  2006-05-08 16:31 -------
> [ "x${main}" != "x" ] should also work and maybe a little more portable.

That's also fine, although overkill these days.

All host OSes supported by GNAT (and more) accept the following simpler
and cleaner syntax:

 if [ "$main" != "" ]; then

or the other way around as needed here:

 if [ "$main" = "" ]; then

Arno


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27476

[Bug testsuite/27476] ACATS: Ada testsuite Bourne shell compatibility problem on hpux

[guerby at gcc dot gnu dot org]

------- Comment #6 from guerby at gcc dot gnu dot org  2006-05-08 16:50 -------
Subject: Bug 27476

Author: guerby
Date: Mon May  8 16:50:40 2006
New Revision: 113630

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113630
Log:
2006-05-08  Laurent GUERBY  <laurent@guerby.net>

        PR testsuite/27476
        * ada/acats/run_all.sh: Use test -z.



Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/ada/acats/run_all.sh


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27476

[Bug testsuite/27476] ACATS: Ada testsuite Bourne shell compatibility problem on hpux

[laurent at guerby dot net]

------- Comment #7 from laurent at guerby dot net  2006-05-08 16:51 -------
Should be fixed now.


-- 

laurent at guerby dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27476