[Bug bootstrap/27516] New: install failure due to unconditional invocation of makeinfo for treelang.texi

[Bug bootstrap/27516] New: install failure due to unconditional invocation of makeinfo for treelang.texi

[aldot at gcc dot gnu dot org]

# uname -a
OSF1 tru64.init.at V5.1 1885 alpha
# makeinfo --version 
makeinfo (GNU texinfo) 4.0

Copyright (C) 1999 Free Software Foundation, Inc.
There is NO warranty.  You may redistribute this software
under the terms of the GNU General Public License.
For more information about these matters, see the files named COPYING.


make install erroneously fails since makeinfo is invoked unconditionally for
treelang.info as x$(BUILD_INFO) is not checked there as opposed to the other
info files.


gccint.info does check proper if BUILD_INFO was requested explicitely,
treelang.info does not; e.g.:


if [ x = xinfo ]; then \
        /usr/local/scratch/src/gcc-4.2/missing makeinfo --split-size=5000000
--s
plit-size=5000000 --no-split -I . -I ../../../src/gcc-4.2/gcc/doc \
                -I ../../../src/gcc-4.2/gcc/doc/include -o doc/gccint.info
../..
/../src/gcc-4.2/gcc/doc/gccint.texi; \
fi
rm -f /opt/gcc-4.2//info/gccint.info
if [ -f doc/gccint.info ]; then \
  for f in doc/gccint.info*; do \
    realfile=`echo $f | sed -e 's|.*/\([^/]*\)$|\1|'`; \
    /usr/local/scratch/src/gcc-4.2/install-sh -c -m 644 $f
/opt/gcc-4.2//info/$r
ealfile; \
    chmod a-x /opt/gcc-4.2//info/$realfile; \
  done; \
else true; fi
if /bin/sh -c 'install-info --version' >/dev/null 2>&1; then \
  if [ -f /opt/gcc-4.2//info/gccint.info ]; then \
    install-info --dir-file=/opt/gcc-4.2//info/dir
/opt/gcc-4.2//info/gccint.inf
o; \
  else true; fi; \
else true; fi;
/usr/local/scratch/src/gcc-4.2/missing makeinfo --split-size=5000000
--split-siz
e=5000000 --no-split -I ../../../src/gcc-4.2/gcc/doc/include -o
doc/treelang.inf
o ../../../src/gcc-4.2/gcc/treelang/treelang.texi
WARNING: `makeinfo' is missing on your system.  You should only need it if
         you modified a `.texi' or `.texinfo' file, or any other file
         indirectly affecting the aspect of the manual.  The spurious
         call might also be the consequence of using a buggy `make' (AIX,
         DU, IRIX).  You might want to install the `Texinfo' package or
         the `GNU make' package.  Grab either from any GNU archive site.
gmake[2]: *** [doc/treelang.info] Error 1


-- 
           Summary: install failure due to unconditional invocation of
                    makeinfo for treelang.texi
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: aldot at gcc dot gnu dot org
 GCC build triplet: alphaev56-dec-osf5.1a
  GCC host triplet: alphaev56-dec-osf5.1a
GCC target triplet: alphaev56-dec-osf5.1a


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug treelang/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[aldot at gcc dot gnu dot org]

------- Comment #1 from aldot at gcc dot gnu dot org  2006-05-09 07:58 -------
Created an attachment (id=11418)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11418&action=view)
check if BUILD_INFO was requested explicitely

2006-05-09  Bernhard Fischer  <aldot@gcc.gnu.org>

        PR/27516
        * Make-lang.in (doc/treelang.info): If configure says makeinfo is too
old,
        don't build or install Info documentation.

Testing this patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug treelang/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[aldot at gcc dot gnu dot org]

------- Comment #2 from aldot at gcc dot gnu dot org  2006-05-09 08:13 -------
Created an attachment (id=11419)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11419&action=view)
Don't build info pages if makeinfo is too old

Corrected syntax.


-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11418|0                           |1
        is obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug treelang/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[aldot at gcc dot gnu dot org]

------- Comment #3 from aldot at gcc dot gnu dot org  2006-05-09 15:33 -------
(In reply to comment #2)
> Created an attachment (id=11419)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11419&action=view) [edit]
> Don't build info pages if makeinfo is too old
> 
> Corrected syntax.
> 

With the gcc.correct_treelang.info_building.02.diff patch i can successfully
install the languages c,c++,treelang on OSF5.1a.

Please apply.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug treelang/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[aldot at gcc dot gnu dot org]

------- Comment #4 from aldot at gcc dot gnu dot org  2006-05-19 17:29 -------
This also fails on the gcc-4_1-branch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[aldot at gcc dot gnu dot org]

-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|treelang                    |bootstrap
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-05-20 11:15:36
               date|                            |
   Target Milestone|---                         |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[aldot at gcc dot gnu dot org]

------- Comment #5 from aldot at gcc dot gnu dot org  2006-05-21 12:16 -------
Setting Target Milestone to 4.1.1.

Ok for trunk and the 4.1 branch?


-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mmitchel at gcc dot gnu dot
                   |                            |org
   Target Milestone|4.1.2                       |4.1.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[mark at codesourcery dot com]

------- Comment #6 from mark at codesourcery dot com  2006-05-21 17:07 -------
Subject: Re:  install failure due to unconditional invocation
 of makeinfo for treelang.texi

aldot at gcc dot gnu dot org wrote:
> ------- Comment #5 from aldot at gcc dot gnu dot org  2006-05-21 12:16 -------
> Setting Target Milestone to 4.1.1.
> 
> Ok for trunk and the 4.1 branch?

Wouldn't it be better just to modify gcc/Makefile.in to do:

ifneq($(BUILD_INFO),)
info: $(INFOFILES) lang.info @GENINSRC@ srcinfo lang.srcinfo
else
info:
fi

Then, in the subdirectory Makefiles we can avoid checking BUILD_INFO at all.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[aldot at gcc dot gnu dot org]

------- Comment #7 from aldot at gcc dot gnu dot org  2006-05-21 17:46 -------
> Wouldn't it be better just to modify gcc/Makefile.in to do:
> 
> ifneq($(BUILD_INFO),)
> info: $(INFOFILES) lang.info @GENINSRC@ srcinfo lang.srcinfo
> else
> info:
> fi
> 
> Then, in the subdirectory Makefiles we can avoid checking BUILD_INFO at all.

Agree, but i thought that this may be a bit more intrusive than touching the
one invalid invocation.

Providing an empty info: and perhaps also html: would be the cleanest thing.
>From the looks, html: may also be needed since gcc/Makefile.in reads:
TEXI2HTML = $(MAKEINFO) --html

OTOH, html is apparently not in the default install target, so if somebody
requests it explicitely, it may be ok to fail noisily.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[mark at codesourcery dot com]

------- Comment #8 from mark at codesourcery dot com  2006-05-21 17:58 -------
Subject: Re:  install failure due to unconditional invocation
 of makeinfo for treelang.texi

aldot at gcc dot gnu dot org wrote:
> ------- Comment #7 from aldot at gcc dot gnu dot org  2006-05-21 17:46 -------
>> Wouldn't it be better just to modify gcc/Makefile.in to do:
>>
>> ifneq($(BUILD_INFO),)
>> info: $(INFOFILES) lang.info @GENINSRC@ srcinfo lang.srcinfo
>> else
>> info:
>> fi
>>
>> Then, in the subdirectory Makefiles we can avoid checking BUILD_INFO at all.
> 
> Agree, but i thought that this may be a bit more intrusive than touching the
> one invalid invocation.

Your original patch is OK for 4.1 -- but I would like the fix I
suggested for 4.2.  Also, we don't like to fix a problem on a release
branch without also having a fix in mainline.

Therefore, would you please test:

(a) for 4.1, your original patch

(b) for 4.2/mainline, a patch along the lines I suggested above,
together with removing checks for BUILD_INFO from */Make-lang.in

?

> OTOH, html is apparently not in the default install target, so if somebody
> requests it explicitely, it may be ok to fail noisily.

Yes, I think we can avoid this complication for HTML.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[aldot at gcc dot gnu dot org]

------- Comment #9 from aldot at gcc dot gnu dot org  2006-05-21 20:11 -------

> 
> Your original patch is OK for 4.1 -- but I would like the fix I
> suggested for 4.2.  Also, we don't like to fix a problem on a release
> branch without also having a fix in mainline.
> 
> Therefore, would you please test:
> 
> (a) for 4.1, your original patch
> 
> (b) for 4.2/mainline, a patch along the lines I suggested above,
> together with removing checks for BUILD_INFO from */Make-lang.in
> 
> ?
I will test test the fix you suggested for 4.2 ASAP, but it may take a couple
of  days.

The fix for 4.1 was only tested on 4.2, but should be the same for 4.1.
I can double-check on 4.1 tomorrow and apply it if the fix is identical (else
i'll follow up).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[aldot at gcc dot gnu dot org]

------- Comment #10 from aldot at gcc dot gnu dot org  2006-05-22 17:43 -------
Created an attachment (id=11494)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11494&action=view)
fix MAKEINFO invocation for gcc-4_1-branch

I cannot test this patch right now since i have to bootstrap gcc-4.2 on the
OSF5.1a box first in order to be able to bootstrap 4.1..

gcc-4_1-branch from today fails due to the use of __VA_ARGS__ in the
preprocessor:
cc -c   -O2 -DIN_GCC     -DHAVE_CONFIG_H -I. -I.
-I../../../cvs/alphaev56-dec-osf5.1a/gcc-4.1/gcc
-I../../../cvs/alphaev56-dec-osf5.1a/gcc-4.1/gcc/.
-I../../../cvs/alphaev56-dec-osf5.1a/gcc-4.1/gcc/../include
-I../../../cvs/alphaev56-dec-osf5.1a/gcc-4.1/gcc/../libcpp/include    
../../../cvs/alphaev56-dec-osf5.1a/gcc-4.1/gcc/c-parser.c -o c-parser.o
cc: Warning: ../../../cvs/alphaev56-dec-osf5.1a/gcc-4.1/gcc/tree.h, line 3147:
Formal parameter isn't an identifier. (badformalparm)
#define build(code, ...) \
--------------------^
cc: Warning: ../../../cvs/alphaev56-dec-osf5.1a/gcc-4.1/gcc/tree.h, line 3151:
Formal parameter isn't an identifier. (badformalparm)
#define _buildC1(...)           _buildC2(__VA_ARGS__,9,8,7,6,5,4,3,2,1,0,0)
-----------------^
cc: Warning: ../../../cvs/alphaev56-dec-osf5.1a/gcc-4.1/gcc/tree.h, line 3152:
Formal parameter isn't an identifier. (badformalparm)
#define _buildC2(x,a1,a2,a3,a4,a5,a6,a7,a8,a9,c,...) c
------------------------------------------------^
cc: Warning: ../../../cvs/alphaev56-dec-osf5.1a/gcc-4.1/gcc/c-parser.c, line
3632: Too many actual parameters in macro call. (toomanyactls)
    add_stmt (build (NOP_EXPR, NULL_TREE, NULL_TREE));
---------------------^
cc: Warning: ../../../cvs/alphaev56-dec-osf5.1a/gcc-4.1/gcc/c-parser.c, line
3632: Too many actual parameters in macro call. (toomanyactls)
    add_stmt (build (NOP_EXPR, NULL_TREE, NULL_TREE));
--------------^
cc: Warning: ../../../cvs/alphaev56-dec-osf5.1a/gcc-4.1/gcc/c-parser.c, line
3695: Too many actual parameters in macro call. (toomanyactls)
    add_stmt (build (LABEL_EXPR, void_type_node, c_break_label));
---------------------^
cc: Warning: ../../../cvs/alphaev56-dec-osf5.1a/gcc-4.1/gcc/c-parser.c, line
3695: Too many actual parameters in macro call. (toomanyactls)
    add_stmt (build (LABEL_EXPR, void_type_node, c_break_label));
--------------^
cc: Error: ../../../cvs/alphaev56-dec-osf5.1a/gcc-4.1/gcc/c-parser.c, line
3632: In this statement, "__VA_ARGS__" is not declared. (undeclared)
    add_stmt (build (NOP_EXPR, NULL_TREE, NULL_TREE));
--------------^
cc: Error: ../../../cvs/alphaev56-dec-osf5.1a/gcc-4.1/gcc/c-parser.c, line
3695: In this statement, "__VA_ARGS__" is not declared. (undeclared)
    add_stmt (build (LABEL_EXPR, void_type_node, c_break_label));
--------------^
gmake[2]: *** [c-parser.o] Error 1
gmake[2]: Leaving directory `/usr/local/scratch/obj/gcc-4.1/gcc'

oh joy


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[mmitchel at gcc dot gnu dot org]

------- Comment #11 from mmitchel at gcc dot gnu dot org  2006-05-25 02:34 -------
Will not be fixed in 4.1.1; adjust target milestone to 4.1.2.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.1                       |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[P dot Schaffnit at access dot rwth-aachen dot de]

------- Comment #12 from P dot Schaffnit at access dot rwth-aachen dot de  2006-10-26 06:42 -------
Isn't this also 'Bug#: 27133'?


-- 

P dot Schaffnit at access dot rwth-aachen dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |P dot Schaffnit at access
                   |                            |dot rwth-aachen dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.2                       |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[haubi at gentoo dot org]

------- Comment #13 from haubi at gentoo dot org  2007-12-10 15:40 -------
Just asking for status of this bug:
Seems to be still valid with gcc-4.2.2 - don't (want to) have texinfo
installed.


-- 

haubi at gentoo dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |haubi at gentoo dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[aldot at gcc dot gnu dot org]

------- Comment #14 from aldot at gcc dot gnu dot org  2007-12-11 08:46 -------
(In reply to comment #13)
> Just asking for status of this bug:
> Seems to be still valid with gcc-4.2.2 - don't (want to) have texinfo
> installed.

Please submit a tested patch along the lines of Mark's comment #8


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[haubi at gentoo dot org]

------- Comment #15 from haubi at gentoo dot org  2007-12-11 16:33 -------
Created an attachment (id=14730)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14730&action=view)
patch to avoid installing treelang info without makeinfo

This patch works with gcc-4.2.2, and should apply to trunk/gcc/Makefile.in too,
as the important line looks the same.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[aldot at gcc dot gnu dot org]

------- Comment #16 from aldot at gcc dot gnu dot org  2008-01-25 15:24 -------
Removing alphaev56-dec-osf5.1a since this is not target specific.

The treelang-noinfo.patch looks fine to me, but i cannot approve it (mark?).


-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  GCC build triplet|alphaev56-dec-osf5.1a       |
   GCC host triplet|alphaev56-dec-osf5.1a       |
 GCC target triplet|alphaev56-dec-osf5.1a       |
      Known to fail|4.1.1 4.2.0                 |4.1.1 4.2.0 4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[mmitchel at gcc dot gnu dot org]

------- Comment #17 from mmitchel at gcc dot gnu dot org  2008-01-25 18:54 -------
This patch is OK.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[aldot at gcc dot gnu dot org]

------- Comment #18 from aldot at gcc dot gnu dot org  2008-01-28 17:59 -------
Created an attachment (id=15038)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15038&action=view)
use conditional $(BUILD_INFO) variable for prerequs of info and install-info
targets

Use the variable $(BUILD_INFO) to decide whether or not info-pages are to be
installed.

This follows mark's comment #8 above but does not yet remove the testing of
$(BUILD_INFO) in gcc/*/Make-lang.in . A tested patch which removes these now
superfluous checks will follow.

Michael's treelang-noinfo.patch looks inappropriate (there is no 'install-'
target AFAICS, so install would fail never the less), so i consider the
approval nil, sorry.


-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11419|0                           |1
        is obsolete|                            |
  Attachment #11494|0                           |1
        is obsolete|                            |
  Attachment #14730|0                           |1
        is obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[mmitchel at gcc dot gnu dot org]

------- Comment #19 from mmitchel at gcc dot gnu dot org  2008-01-28 18:12 -------
In your patch, why does install-info still need doc and installdirs
dependencies when BUILD_INFO is not set?  If those things still need to happen,
shouldn't they be dependencies of some other target?  Logically, if BUILD_INFO
is not set, then install-info should be a no-op.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[aldot at gcc dot gnu dot org]

------- Comment #20 from aldot at gcc dot gnu dot org  2008-01-28 20:43 -------
(In reply to comment #19)
> In your patch, why does install-info still need doc and installdirs
> dependencies when BUILD_INFO is not set?  If those things still need to happen,
> shouldn't they be dependencies of some other target?  Logically, if BUILD_INFO
> is not set, then install-info should be a no-op.

I kept them due to precaution but ultimately they shouldn't be needed for
install-info itself, yes. Will test how this works out with MAKEINFO=/bin/false
and an old makeinfo before i attach a complete patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[haubi at gentoo dot org]

------- Comment #21 from haubi at gentoo dot org  2008-01-29 10:22 -------
(In reply to comment #18)
> (there is no 'install-' target AFAICS, so install would fail never the less),

I'm pretty sure there is a target 'install-', already used for empty @POSUB@,
because this inspired me to create the treelang-noinfo.patch the way it is.

However - you're the dev...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[aldot at gcc dot gnu dot org]

------- Comment #22 from aldot at gcc dot gnu dot org  2008-01-29 12:33 -------
Michael,

You are right, sorry :(. I somehow managed not to find them although they are
there!
---8<---
# Dummy rules to deal with dependencies produced by use of
# "build-@POSUB@" and "install-@POSUB@" above, when NLS is disabled.
build-: ; @true
install-: ; @true
---8<---
So for 4.3.0, Michaels patch from comment #15 (treelang-noinfo.patch as
attached) is fine, we can clean this up for real for 4.4.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516

[Bug bootstrap/27516] install failure due to unconditional invocation of makeinfo for treelang.texi

[jsm28 at gcc dot gnu dot org]

------- Comment #23 from jsm28 at gcc dot gnu dot org  2008-07-04 19:29 -------
Closing 4.1 branch.  Removing milestone altogether as it's not clear this is a
regression - and treelang is no longer present on trunk, so if this only
affected treelang then there is no bug on trunk here any more.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.3                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27516