[Bug fortran/25098] New: better diagnostic needed

[Bug fortran/25098] New: better diagnostic needed

[jv244 at cam dot ac dot uk]

using GNU Fortran 95 (GCC) 4.1.0 20051126 (prerelease)  with '-g -pedantic
-std=f95', I get a bad / no diagnostic for the following invalid code:

MODULE M1
CONTAINS
 SUBROUTINE S1(F)
  INTERFACE
   FUNCTION F()
    INTEGER F
   END FUNCTION F
  END INTERFACE
 END SUBROUTINE S1
END MODULE M1
USE M1
INTEGER :: I
I=1
CALL S1(I)
END


-- 
           Summary: better diagnostic needed
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jv244 at cam dot ac dot uk


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25098

[Bug fortran/25098] Variable as actual argument for procedure dummy argument allowed

[eedelman at gcc dot gnu dot org]

-- 

eedelman at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |diagnostic
   Last reconfirmed|0000-00-00 00:00:00         |2005-11-30 13:13:00
               date|                            |
            Summary|better diagnostic needed    |Variable as actual argument
                   |                            |for procedure dummy argument
                   |                            |allowed


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25098

[Bug fortran/25098] Variable as actual argument for procedure dummy argument allowed

[pault at gcc dot gnu dot org]

------- Comment #1 from pault at gcc dot gnu dot org  2006-05-15 18:57 -------
A patch is regtesting right now.

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pault at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25098

[Bug fortran/25098] Variable as actual argument for procedure dummy argument allowed

[patchapp at dberlin dot org]

------- Comment #2 from patchapp at dberlin dot org  2006-05-15 20:20 -------
Subject: Bug number PR25098

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-05/msg00682.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25098

[Bug fortran/25098] Variable as actual argument for procedure dummy argument allowed

[patchapp at dberlin dot org]

------- Comment #3 from patchapp at dberlin dot org  2006-05-28 15:37 -------
Subject: Bug number PR25098

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-05/msg01425.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25098

[Bug fortran/25098] Variable as actual argument for procedure dummy argument allowed

[pault at gcc dot gnu dot org]

------- Comment #4 from pault at gcc dot gnu dot org  2006-06-01 04:35 -------
Subject: Bug 25098

Author: pault
Date: Thu Jun  1 04:35:38 2006
New Revision: 114296

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=114296
Log:
2006-06-01  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/25098
        PR fortran/25147
        * interface.c (compare_parameter): Return 1 if the actual arg
        is external and the formal is a procedure.
        (compare_actual_formal): If the actual argument is a variable
        and the formal a procedure, this an error.  If a gsymbol exists
        for a procedure of the same name, this is not yet resolved and
        the error is cleared.

        * trans-intrinsic.c (gfc_conv_associated): Make provision for
        zero array length or zero string length contingent on presence
        of target, for consistency with standard.

2006-06-01  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/25098
        * gfortran.dg/dummy_procedure_1.f90: New test.

        PR fortran/25147
        * gfortran.dg/dummy_procedure_2.f90: New test.

        * gfortran.dg/associated_2.f90: Correct to make consistent with
        standard.

Added:
    trunk/gcc/testsuite/gfortran.dg/dummy_procedure_1.f90
    trunk/gcc/testsuite/gfortran.dg/dummy_procedure_2.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/interface.c
    trunk/gcc/fortran/trans-intrinsic.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/associated_2.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25098

[Bug fortran/25098] Variable as actual argument for procedure dummy argument allowed

[pault at gcc dot gnu dot org]

------- Comment #5 from pault at gcc dot gnu dot org  2006-06-01 05:56 -------
Subject: Bug 25098

Author: pault
Date: Thu Jun  1 05:56:48 2006
New Revision: 114299

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=114299
Log:
2006-06-01  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/25098
        PR fortran/25147
        * interface.c (compare_parameter): Return 1 if the actual arg
        is external and the formal is a procedure.
        (compare_actual_formal): If the actual argument is a variable
        and the formal a procedure, this an error.  If a gsymbol exists
        for a procedure of the same name, this is not yet resolved and
        the error is cleared.

        * trans-intrinsic.c (gfc_conv_associated): Make provision for
        zero array length or zero string length contingent on presence
        of target, for consistency with standard.

2006-06-01  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/25098
        * gfortran.dg/dummy_procedure_1.f90: New test.

        PR fortran/25147
        * gfortran.dg/dummy_procedure_2.f90: New test.

        * gfortran.dg/associated_2.f90: Correct to make consistent with
        standard.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/dummy_procedure_1.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/dummy_procedure_2.f90
Modified:
    branches/gcc-4_1-branch/gcc/fortran/ChangeLog
    branches/gcc-4_1-branch/gcc/fortran/interface.c
    branches/gcc-4_1-branch/gcc/fortran/trans-intrinsic.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/associated_2.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25098

[Bug fortran/25098] Variable as actual argument for procedure dummy argument allowed

[pault at gcc dot gnu dot org]

------- Comment #6 from pault at gcc dot gnu dot org  2006-06-01 05:57 -------
Fixed on trunk and 4.1.

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25098