[Bug boehm-gc/27963] New: [4.2 Regression] libjava fails to build if it isn't built by default

[Bug boehm-gc/27963] New: [4.2 Regression] libjava fails to build if it isn't built by default

[gcc-bugzilla at gcc dot gnu dot org]

Trying to bootstrap mainline on IRIX 6.5 with java included failed since
boehm-gc (which is required for libjava) isn't built:

In file included from /vol/gcc/src/gcc-dist/libjava/include/jvm.h:25,
                 from /vol/gcc/src/gcc-dist/libjava/include/java-interp.h:14,
                 from /vol/gcc/src/gcc-dist/libjava/defineclass.cc:23:
./include/java-gc.h:30:53: error: gc_ext_config.h: No such file or directory

This happens due to this change:

2006-06-06  David Ayers  <d.ayers@inode.at>

        PR libobjc/13946
        * Makefile.def: Add dependencies for libobjc which boehm-gc.
        * Makefile.in: Regenerate.
        * configure.in: Add --enable-objc-gc at toplevel and have it
        enable boehm-gc for Objective-C.
        Remove target-boehm-gc from libgcj.
        Add target-boehm-gc to target_libraries.
        Add target-boehm-gc to noconfigdirs where ${libgcj}
        is specified.

On platforms (like IRIX 6), where libjava just isn't built *by default*,
unconditionally adding boehm-gc to noconfigdirs inhibits building boehm-gc
completely, though it could build and is required for libjava.

This is a regression from the 4.1 branch.

Environment:
System: IRIX64 columba 6.5 07010238 IP27



host: mips-sgi-irix6.5
build: mips-sgi-irix6.5
target: mips-sgi-irix6.5
configured with: /vol/gcc/src/gcc-dist/configure --prefix=/vol/gcc
--with-local-prefix=/vol/gcc --disable-nls --with-gnu-as
--with-as=/vol/gcc/lib/gas-2.16.1 --enable-libgcj
--with-gmp-dir=/vol/gnu/obj/gmp-4.1.3
--with-mpfr-dir=/vol/gnu/obj/gmp-4.1.3/mpfr
--enable-languages=c,c++,fortran,java,objc,ada --disable-libmudflap

How-To-Repeat:
Bootstrap mainline as described.


-- 
           Summary: [4.2 Regression] libjava fails to build if it isn't
                    built by default
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: boehm-gc
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: ro at techfak dot uni-bielefeld dot de
 GCC build triplet: mips-sgi-irix6.5
  GCC host triplet: mips-sgi-irix6.5
GCC target triplet: mips-sgi-irix6.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27963

[Bug boehm-gc/27963] [4.2 Regression] libjava fails to build if it isn't built by default

[ro at gcc dot gnu dot org]

------- Comment #1 from ro at gcc dot gnu dot org  2006-06-08 18:59 -------
David, your patch caused this regression, so please have a look.


-- 

ro at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |d dot ayers at inode dot at


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27963

[Bug bootstrap/27963] [4.2 Regression] libjava fails to build if it isn't built by default

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2006-06-08 19:11 -------
Maybe it is better to not to disable libjava completely for IRIX.  It seems
like --disable-libjava is out of date and wrong in general now (maybe even has
been for a long time).


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|boehm-gc                    |bootstrap
           Keywords|                            |build


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27963

[Bug bootstrap/27963] [4.2 Regression] libjava fails to build if it isn't built by default

[ro at techfak dot uni-bielefeld dot de]

------- Comment #3 from ro at techfak dot uni-bielefeld dot de  2006-06-08 19:15 -------
Subject: Re:  [4.2 Regression] libjava fails to build if it isn't built by
default

pinskia at gcc dot gnu dot org writes:

> Maybe it is better to not to disable libjava completely for IRIX.  It seems

But it isn't disabled completely (and I've been able to build it at some point
in the past), it's just disabled by default since it requires (or at least
used to require) a larger-than-default limit for the command line length.

> like --disable-libjava is out of date and wrong in general now (maybe even has
> been for a long time).

Do you have any evidence for this?  (Btw., it's --enable/disable-libgcj.)

        Rainer


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27963

[Bug bootstrap/27963] [4.2 Regression] libjava fails to build if it isn't built by default

[ayers at gcc dot gnu dot org]

------- Comment #4 from ayers at gcc dot gnu dot org  2006-06-08 20:18 -------
Hello,
I followed the advice given here:

http://gcc.gnu.org/ml/gcc-patches/2006-05/msg00886.html

I believe "noconfigdir" is supposed to mean "not supported" so in this case the
correct "patch" would be to remove tartget-boehm-gc if in fact it is supported
by the platform, as we will later remove it again if it wasn't requested by
libobjc and not needed by java.

If I get a get a list of targets for which I should re-enable target-boehm-gc
(and possibly pre approval) I can certainly come up with a patch (it's just a
matter of removing target-boehm-gc from the appropriate noconfigdir entry).

Cheers,
David 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27963

[Bug bootstrap/27963] [4.2 Regression] libjava fails to build if it isn't built by default

[ro at techfak dot uni-bielefeld dot de]

------- Comment #5 from ro at techfak dot uni-bielefeld dot de  2006-06-08 20:23 -------
Subject: Re:  [4.2 Regression] libjava fails to build if it isn't built by
default

ayers at gcc dot gnu dot org writes:

> I followed the advice given here:
> 
> http://gcc.gnu.org/ml/gcc-patches/2006-05/msg00886.html

As this PR demonstrates, this advice was wrong wrt. to adding boehm-gc to
noconfigdirs, as this will break any configuration where libjava just isn't
built by default.

> I believe "noconfigdir" is supposed to mean "not supported" so in this case the
> correct "patch" would be to remove tartget-boehm-gc if in fact it is supported
> by the platform, as we will later remove it again if it wasn't requested by
> libobjc and not needed by java.
> 
> If I get a get a list of targets for which I should re-enable target-boehm-gc
> (and possibly pre approval) I can certainly come up with a patch (it's just a
> matter of removing target-boehm-gc from the appropriate noconfigdir entry).

I fear this is the wrong way round: it shouldn't be necessary to unbreak
the affected targets one by one, but boehm-gc should only be included in
noconfigdirs if it is known not to work (which is what noconfigdirs is
for).

        Rainer


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27963

[Bug bootstrap/27963] [4.2 Regression] libjava fails to build if it isn't built by default

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27963

[Bug bootstrap/27963] [4.2 Regression] libjava fails to build if it isn't built by default

[ayers at gcc dot gnu dot org]

-- 

ayers at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |ayers at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-06-09 07:57:39
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27963

[Bug bootstrap/27963] [4.2 Regression] libjava fails to build if it isn't built by default

[ayers at gcc dot gnu dot org]

------- Comment #6 from ayers at gcc dot gnu dot org  2006-06-09 08:01 -------
Patch posted at:

http://gcc.gnu.org/ml/gcc-patches/2006-06/msg00410.html

and waiting for approval.


-- 

ayers at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|d dot ayers at inode dot at |
             Status|ASSIGNED                    |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27963

[Bug bootstrap/27963] [4.2 Regression] libjava fails to build if it isn't built by default

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2006-06-09 13:14 -------
WAITING is used to get feed back from the reporter.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
   Last reconfirmed|2006-06-09 07:57:39         |2006-06-09 13:14:33
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27963

[Bug bootstrap/27963] [4.2 Regression] libjava fails to build if it isn't built by default

[ayers at gcc dot gnu dot org]

------- Comment #8 from ayers at gcc dot gnu dot org  2006-06-12 06:58 -------
Subject: Bug 27963

Author: ayers
Date: Mon Jun 12 06:58:27 2006
New Revision: 114563

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=114563
Log:
2006-06-12  David Ayers  <d.ayers@inode.at>

        PR bootstrap/27963
        PR target/19970
        * configure.in: Remove target-boehm-gc from noconfigdirs where 
        ${libgcj} is specified.
        * configure: Regenerate.


Modified:
    trunk/ChangeLog
    trunk/configure
    trunk/configure.in


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27963

[Bug bootstrap/27963] [4.2 Regression] libjava fails to build if it isn't built by default

[ayers at gcc dot gnu dot org]

------- Comment #9 from ayers at gcc dot gnu dot org  2006-06-12 07:04 -------
Fixed for 4.2.0


-- 

ayers at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27963