public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug other/28083] New: fixincludes generates headers not ending with newline
@ 2006-06-19 12:57 peb at mppmu dot mpg dot de
2006-06-19 14:01 ` [Bug other/28083] " rguenth at gcc dot gnu dot org
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: peb at mppmu dot mpg dot de @ 2006-06-19 12:57 UTC (permalink / raw)
To: gcc-bugs
Some of the headers produces by fixincludes (e.g., asm/posix_types.h) do not
end with a newline.
I'm not sure if this is a bug in autogen, or improper use of autogen (the
autogen-generated replacement text in fixincl.x ends, e.g., with
#endif /* _POSIX_TYPES_H_WRAPPER */"
again without newline), or a bug in the C code processing this replacement
text.
--
Summary: fixincludes generates headers not ending with newline
Product: gcc
Version: 3.4.6
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: other
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: peb at mppmu dot mpg dot de
GCC build triplet: i686-linux-gnu
GCC host triplet: i686-linux-gnu
GCC target triplet: i686-linux-gnu
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28083
^ permalink raw reply [flat|nested] 4+ messages in thread* [Bug other/28083] fixincludes generates headers not ending with newline 2006-06-19 12:57 [Bug other/28083] New: fixincludes generates headers not ending with newline peb at mppmu dot mpg dot de @ 2006-06-19 14:01 ` rguenth at gcc dot gnu dot org 2006-06-19 14:31 ` peb at mppmu dot mpg dot de 2006-06-19 17:25 ` pinskia at gcc dot gnu dot org 2 siblings, 0 replies; 4+ messages in thread From: rguenth at gcc dot gnu dot org @ 2006-06-19 14:01 UTC (permalink / raw) To: gcc-bugs ------- Comment #1 from rguenth at gcc dot gnu dot org 2006-06-19 13:14 ------- Please provide a testcase (the unfixed asm/posix_types.h). Also you should check if using gcc 4.x fixes this, as the 3.x series are no longer maintained. -- rguenth at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |WAITING http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28083 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug other/28083] fixincludes generates headers not ending with newline 2006-06-19 12:57 [Bug other/28083] New: fixincludes generates headers not ending with newline peb at mppmu dot mpg dot de 2006-06-19 14:01 ` [Bug other/28083] " rguenth at gcc dot gnu dot org @ 2006-06-19 14:31 ` peb at mppmu dot mpg dot de 2006-06-19 17:25 ` pinskia at gcc dot gnu dot org 2 siblings, 0 replies; 4+ messages in thread From: peb at mppmu dot mpg dot de @ 2006-06-19 14:31 UTC (permalink / raw) To: gcc-bugs ------- Comment #2 from peb at mppmu dot mpg dot de 2006-06-19 14:24 ------- Created an attachment (id=11703) --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11703&action=view) The file asm/posix_typed.h as produced by fixincludes from gcc-3.4.6 I just checked that the same file created by gcc-4.2.0 does end with a newline (the replacement text in fixincl.x again ends without newline, thus the problem is hidden somewhere in the C code processing fixincl.x). -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28083 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug other/28083] fixincludes generates headers not ending with newline 2006-06-19 12:57 [Bug other/28083] New: fixincludes generates headers not ending with newline peb at mppmu dot mpg dot de 2006-06-19 14:01 ` [Bug other/28083] " rguenth at gcc dot gnu dot org 2006-06-19 14:31 ` peb at mppmu dot mpg dot de @ 2006-06-19 17:25 ` pinskia at gcc dot gnu dot org 2 siblings, 0 replies; 4+ messages in thread From: pinskia at gcc dot gnu dot org @ 2006-06-19 17:25 UTC (permalink / raw) To: gcc-bugs ------- Comment #3 from pinskia at gcc dot gnu dot org 2006-06-19 17:22 ------- Fixed by: 2005-11-24 Bruce Korb <bkorb@gnu.org> * fixincl.c(write_replacement) "here strings" in AutoGen often/generally don't have a terminating newline. Check the last byte for '\n'. -- pinskia at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|WAITING |RESOLVED Resolution| |FIXED Target Milestone|--- |4.2.0 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28083 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-06-19 17:22 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2006-06-19 12:57 [Bug other/28083] New: fixincludes generates headers not ending with newline peb at mppmu dot mpg dot de 2006-06-19 14:01 ` [Bug other/28083] " rguenth at gcc dot gnu dot org 2006-06-19 14:31 ` peb at mppmu dot mpg dot de 2006-06-19 17:25 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).