public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hhinnant at apple dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/28017] lack of guard variables for explicitly instantiated template static data
Date: Mon, 19 Jun 2006 18:22:00 -0000	[thread overview]
Message-ID: <20060619181153.18714.qmail@sourceware.org> (raw)
In-Reply-To: <bug-28017-11686@http.gcc.gnu.org/bugzilla/>



------- Comment #10 from hhinnant at apple dot com  2006-06-19 18:11 -------
It turns out this still isn't quite right.  Looks like we need:

#define NEEDS_GUARD_P(decl) (TREE_PUBLIC (decl) && (DECL_COMMON (decl) \
                                                    || DECL_ONE_ONLY (decl) \
                                                    || DECL_WEAK (decl) \
                                                    ||
(TARGET_WEAK_NOT_IN_ARCHIVE_TOC \
                                                       && DECL_LANG_SPECIFIC
(decl) \
                                                       &&
(DECL_EXPLICIT_INSTANTIATION (decl) \
                                                       || 
DECL_TEMPLATE_SPECIALIZATION (decl)))))

The former solution was dereferencing a null pointer.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28017


  parent reply	other threads:[~2006-06-19 18:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-13 19:13 [Bug c++/28017] New: " hhinnant at apple dot com
2006-06-13 19:15 ` [Bug c++/28017] " pinskia at gcc dot gnu dot org
2006-06-13 19:18 ` pinskia at gcc dot gnu dot org
2006-06-13 19:19 ` pinskia at gcc dot gnu dot org
2006-06-13 19:39 ` pinskia at gcc dot gnu dot org
2006-06-13 21:24 ` hhinnant at apple dot com
2006-06-13 21:25   ` Andrew Pinski
2006-06-13 21:41 ` pinskia at physics dot uc dot edu
2006-06-13 21:47 ` hhinnant at apple dot com
2006-06-13 21:47   ` Andrew Pinski
2006-06-13 22:02 ` pinskia at physics dot uc dot edu
2006-06-13 23:28 ` hhinnant at apple dot com
2006-06-19 18:22 ` hhinnant at apple dot com [this message]
2006-06-21  5:05 ` pinskia at gcc dot gnu dot org
2006-06-21  5:08 ` pinskia at gcc dot gnu dot org
2009-01-27 17:26 ` bkoz at gcc dot gnu dot org
     [not found] <bug-28017-4@http.gcc.gnu.org/bugzilla/>
2024-04-03 23:13 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060619181153.18714.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).