[Bug c/27489] New: [4.1/4.2 regression] ICE on broken switch condition

[Bug c/27489] New: [4.1/4.2 regression] ICE on broken switch condition

[reichelt at gcc dot gnu dot org]

The following invalid code snippet causes an ICE since GCC 4.1.0:

==========================
void foo()
{
  switch (,) { }
}
==========================

bug.c: In function 'foo':
bug.c:3: error: expected expression before ',' token
bug.c:3: internal compiler error: tree check: expected class 'type', have
'exceptional' (error_mark) in c_start_case, at c-typeck.c:7035
Please submit a full bug report, [etc.]


-- 
           Summary: [4.1/4.2 regression] ICE on broken switch condition
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code, error-recovery, monitored
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: reichelt at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489

[Bug c/27489] [4.1/4.2 regression] ICE on broken switch condition

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
   Target Milestone|---                         |4.1.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489

[Bug c/27489] [4.1/4.2 regression] ICE on broken switch condition

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-05-09 08:03 -------
Confirmed.  The compound_expr should not have been created as the RHS is an
error mark nodes.  Fixing that should fix this one without adding a new error
mark check this far done.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-05-09 08:03:28
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489

[Bug c/27489] [4.1/4.2 regression] ICE on broken switch condition

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2006-05-09 08:11 -------
Doing this:
Index: c-typeck.c
===================================================================
--- c-typeck.c  (revision 113594)
+++ c-typeck.c  (working copy)
@@ -3379,6 +3379,9 @@ build_compound_expr (tree expr1, tree ex
   else if (warn_unused_value)
     warn_if_unused_value (expr1, input_location);

+  if (TREE_CODE (expr2) == ERROR_MARK)
+    return error_mark_node;
+
   return build2 (COMPOUND_EXPR, TREE_TYPE (expr2), expr1, expr2);
 }


Fixes the ICE.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489

[Bug c/27489] [4.1/4.2 regression] ICE on broken switch condition

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2006-05-09 08:18 -------
This was caused by the new parser doing a little better error recovery (or at
least trying to).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489

[Bug c/27489] [4.1/4.2 regression] ICE on broken switch condition

[kazu at gcc dot gnu dot org]

------- Comment #4 from kazu at gcc dot gnu dot org  2006-05-10 16:49 -------
Assigning to Volker as he posted a patch.


-- 

kazu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |reichelt at gcc dot gnu dot
                   |dot org                     |org
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2006-
                   |                            |05/msg00337.html
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489

[Bug c/27489] [4.1/4.2 regression] ICE on broken switch condition

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489

[Bug c/27489] [4.1/4.2 regression] ICE on broken switch condition

[mmitchel at gcc dot gnu dot org]

------- Comment #5 from mmitchel at gcc dot gnu dot org  2006-05-14 22:35 -------
Is there a URL for the patch posted for this bug?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489

[Bug c/27489] [4.1/4.2 regression] ICE on broken switch condition

[reichelt at igpm dot rwth-aachen dot de]

------- Comment #6 from reichelt at igpm dot rwth-aachen dot de  2006-05-15 14:31 -------
Subject: Re:  [4.1/4.2 regression] ICE on broken switch condition

On 14 May, mmitchel at gcc dot gnu dot org wrote:
> ------- Comment #5 from mmitchel at gcc dot gnu dot org  2006-05-14 22:35 -------
> Is there a URL for the patch posted for this bug?

http://gcc.gnu.org/ml/gcc-patches/2006-05/msg00337.html

It's just a RFA and not a complete patch, though.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489

[Bug c/27489] [4.1/4.2 regression] ICE on broken switch condition

[mmitchel at gcc dot gnu dot org]

------- Comment #7 from mmitchel at gcc dot gnu dot org  2006-05-25 02:34 -------
Will not be fixed in 4.1.1; adjust target milestone to 4.1.2.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.1                       |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489

[Bug c/27489] [4.1/4.2 regression] ICE on broken switch condition

[jsm28 at gcc dot gnu dot org]

------- Comment #8 from jsm28 at gcc dot gnu dot org  2006-06-04 17:16 -------
The patch in comment#2 is OK for 4.1 and mainline with the change to comparing
expr2 == error_mark_node, provided the testcases from this bug and bug 27490
are added to the testsuite.

Regarding that referenced in comment#6, the test against ERROR_MARK being
removed is probably intended to avoid excess diagnostics in that case.  That
patch is OK for mainline if the error ("switch quantity not an integer"); is
made conditional on (orig_type != error_mark_node).


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org, jsm28 at gcc dot gnu
                   |                            |dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489

[Bug c/27489] [4.1/4.2 regression] ICE on broken switch condition

[pinskia at gcc dot gnu dot org]

------- Comment #9 from pinskia at gcc dot gnu dot org  2006-06-30 06:08 -------
Mine, I will bootstrap and test my patch tomorrow (Friday).


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|reichelt at gcc dot gnu dot |pinskia at gcc dot gnu dot
                   |org                         |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489

[Bug c/27489] [4.1/4.2 regression] ICE on broken switch condition

[pinskia at gcc dot gnu dot org]

------- Comment #10 from pinskia at gcc dot gnu dot org  2006-08-14 02:29 -------
Testing the patch right now.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489

[Bug c/27489] [4.1/4.2 regression] ICE on broken switch condition

[pinskia at gcc dot gnu dot org]

------- Comment #11 from pinskia at gcc dot gnu dot org  2006-08-15 01:43 -------
Subject: Bug 27489

Author: pinskia
Date: Tue Aug 15 01:43:28 2006
New Revision: 116148

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=116148
Log:
2006-07-14  Andrew Pinski  <pinksia@physics.uc.edu>

        PR c/27490
        PR c/27489
        * c-typeck.c (build_compound_expr): If the second expression
        is an error mark, then just return an error mark instead of
        creating a COMPOUND_EXPR.
2006-08-14  Andrew Pinski  <pinskia@physics.uc.edu>

        PR c/27490
        * gcc.dg/sizeof-2.c: New testcase.

        PR c/27489
        * gcc.dg/switch-A.c: New testcase.



Added:
    trunk/gcc/testsuite/gcc.dg/sizeof-2.c
    trunk/gcc/testsuite/gcc.dg/switch-A.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-typeck.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489

[Bug c/27489] [4.1 regression] ICE on broken switch condition

[pinskia at gcc dot gnu dot org]

------- Comment #12 from pinskia at gcc dot gnu dot org  2006-08-15 01:44 -------
Fixed at least on the mainline.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.1/4.2 regression] ICE on |[4.1 regression] ICE on
                   |broken switch condition     |broken switch condition


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489

[Bug c/27489] [4.1 regression] ICE on broken switch condition

[reichelt at gcc dot gnu dot org]

------- Comment #13 from reichelt at gcc dot gnu dot org  2006-08-16 20:50 -------
Subject: Bug 27489

Author: reichelt
Date: Wed Aug 16 20:50:18 2006
New Revision: 116188

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=116188
Log:
        PR c/27489
        * c-typeck.c (c_start_case): Handle invalid orig_type correctly.
        Clean up.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-typeck.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489

[Bug c/27489] [4.1 regression] ICE on broken switch condition

[pinskia at gcc dot gnu dot org]

------- Comment #14 from pinskia at gcc dot gnu dot org  2006-10-05 03:43 -------
Subject: Bug 27489

Author: pinskia
Date: Thu Oct  5 03:43:36 2006
New Revision: 117448

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=117448
Log:
2006-10-04  Andrew Pinski  <pinskia@physics.uc.edu>

        PR c/27490
        PR c/27489
        * c-typeck.c (build_compound_expr): If the second expression
        is an error mark, then just return an error mark instead of
        creating a COMPOUND_EXPR.
2006-10-04  Andrew Pinski  <pinskia@physics.uc.edu>

        PR c/27490
        * gcc.dg/sizeof-2.c: New testcase.

        PR c/27489
        * gcc.dg/switch-A.c: New testcase.


Added:
    branches/gcc-4_1-branch/gcc/testsuite/gcc.dg/sizeof-2.c
      - copied unchanged from r116148, trunk/gcc/testsuite/gcc.dg/sizeof-2.c
    branches/gcc-4_1-branch/gcc/testsuite/gcc.dg/switch-A.c
      - copied unchanged from r116148, trunk/gcc/testsuite/gcc.dg/switch-A.c
Modified:
    branches/gcc-4_1-branch/gcc/ChangeLog
    branches/gcc-4_1-branch/gcc/c-typeck.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489

[Bug c/27489] [4.1 regression] ICE on broken switch condition

[pinskia at gcc dot gnu dot org]

------- Comment #15 from pinskia at gcc dot gnu dot org  2006-10-05 03:45 -------
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27489