public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug other/28251] New: dumped addresses makes diffing dumps unusable
@ 2006-07-04 21:10 amylaar at gcc dot gnu dot org
2006-07-04 21:24 ` [Bug other/28251] " amylaar at gcc dot gnu dot org
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: amylaar at gcc dot gnu dot org @ 2006-07-04 21:10 UTC (permalink / raw)
To: gcc-bugs
The introduction of tree addresses in debugging dumps has caused
most lines of debugging dumps to differ.
What we had before was that ordinary dumps produced with the same input &
options by compilers produced in different stages of a bootstrap were
reasonably diffable; Slightly different compilations where generally reasonably
diffable
with -fdump-unnumbered
--
Summary: dumped addresses makes diffing dumps unusable
Product: gcc
Version: 4.2.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: other
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: amylaar at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28251
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug other/28251] dumped addresses makes diffing dumps unusable
2006-07-04 21:10 [Bug other/28251] New: dumped addresses makes diffing dumps unusable amylaar at gcc dot gnu dot org
@ 2006-07-04 21:24 ` amylaar at gcc dot gnu dot org
2006-07-04 22:51 ` amylaar at gcc dot gnu dot org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: amylaar at gcc dot gnu dot org @ 2006-07-04 21:24 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from amylaar at gcc dot gnu dot org 2006-07-04 21:24 -------
Created an attachment (id=11818)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11818&action=view)
Tentative patch
I'm currently testing this patch. Hopefully this will allow to pinpoint the
insns that stage3 of current mainline fails to eliminate with peephole2.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28251
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug other/28251] dumped addresses makes diffing dumps unusable
2006-07-04 21:10 [Bug other/28251] New: dumped addresses makes diffing dumps unusable amylaar at gcc dot gnu dot org
2006-07-04 21:24 ` [Bug other/28251] " amylaar at gcc dot gnu dot org
@ 2006-07-04 22:51 ` amylaar at gcc dot gnu dot org
2006-07-05 13:42 ` amylaar at gcc dot gnu dot org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: amylaar at gcc dot gnu dot org @ 2006-07-04 22:51 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from amylaar at gcc dot gnu dot org 2006-07-04 22:50 -------
Created an attachment (id=11819)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11819&action=view)
Tentative patch
This one compiles...
--
amylaar at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11818|0 |1
is obsolete| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28251
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug other/28251] dumped addresses makes diffing dumps unusable
2006-07-04 21:10 [Bug other/28251] New: dumped addresses makes diffing dumps unusable amylaar at gcc dot gnu dot org
2006-07-04 21:24 ` [Bug other/28251] " amylaar at gcc dot gnu dot org
2006-07-04 22:51 ` amylaar at gcc dot gnu dot org
@ 2006-07-05 13:42 ` amylaar at gcc dot gnu dot org
2006-07-11 17:24 ` amylaar at gcc dot gnu dot org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: amylaar at gcc dot gnu dot org @ 2006-07-05 13:42 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from amylaar at gcc dot gnu dot org 2006-07-05 13:42 -------
Created an attachment (id=11833)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11833&action=view)
dump diff for mainline r115174 bootstrap failure
The diff with -fdump-noaddr is indeed much more useful to track down make
compare failures that either the diff with full information and the one from
-fdump-unnumbered.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28251
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug other/28251] dumped addresses makes diffing dumps unusable
2006-07-04 21:10 [Bug other/28251] New: dumped addresses makes diffing dumps unusable amylaar at gcc dot gnu dot org
` (2 preceding siblings ...)
2006-07-05 13:42 ` amylaar at gcc dot gnu dot org
@ 2006-07-11 17:24 ` amylaar at gcc dot gnu dot org
2006-07-12 14:15 ` patchapp at dberlin dot org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: amylaar at gcc dot gnu dot org @ 2006-07-11 17:24 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from amylaar at gcc dot gnu dot org 2006-07-11 17:23 -------
Created an attachment (id=11860)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11860&action=view)
patch with test case & unroller fix
I've added a testcase, and it showed failures due to unstable loop unrolling.
It looks like this should be trivial to fix by hashing on insn uids rather
than insn pointers. I'm currently testing this patch.
--
amylaar at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11819|0 |1
is obsolete| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28251
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug other/28251] dumped addresses makes diffing dumps unusable
2006-07-04 21:10 [Bug other/28251] New: dumped addresses makes diffing dumps unusable amylaar at gcc dot gnu dot org
` (3 preceding siblings ...)
2006-07-11 17:24 ` amylaar at gcc dot gnu dot org
@ 2006-07-12 14:15 ` patchapp at dberlin dot org
2006-07-17 14:45 ` amylaar at gcc dot gnu dot org
2006-07-17 16:00 ` amylaar at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: patchapp at dberlin dot org @ 2006-07-12 14:15 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from patchapp at dberlin dot org 2006-07-12 14:15 -------
Subject: Bug number PR other/28251
A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-07/msg00517.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28251
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug other/28251] dumped addresses makes diffing dumps unusable
2006-07-04 21:10 [Bug other/28251] New: dumped addresses makes diffing dumps unusable amylaar at gcc dot gnu dot org
` (4 preceding siblings ...)
2006-07-12 14:15 ` patchapp at dberlin dot org
@ 2006-07-17 14:45 ` amylaar at gcc dot gnu dot org
2006-07-17 16:00 ` amylaar at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: amylaar at gcc dot gnu dot org @ 2006-07-17 14:45 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from amylaar at gcc dot gnu dot org 2006-07-17 14:44 -------
Subject: Bug 28251
Author: amylaar
Date: Mon Jul 17 14:44:48 2006
New Revision: 115519
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=115519
Log:
gcc:
PR other/28251
* tree.h (dump_addr): Declare.
* print-tree.c (dump_addr): New function.
(print_node_brief, print_node): Use it.
* print-rtl.c (print_rtx): Likewise.
* common.opt (-fdump-noaddr): New option.
* doc/invoke.texi (-fdump-noaddr): Document.
* loop-unroll.c (si_info_hash): Make hash independent of addresses.
(ve_info_hash): Likewise.
gcc/testsuite:
PR other/28251
gcc.c-torture/unsorted/dump-noaddr.c: New test.
gcc.c-torture/unsorted/dump-noaddr.x: New driver.
Added:
trunk/gcc/testsuite/gcc.c-torture/unsorted/dump-noaddr.c
trunk/gcc/testsuite/gcc.c-torture/unsorted/dump-noaddr.x
Modified:
trunk/gcc/ChangeLog
trunk/gcc/common.opt
trunk/gcc/doc/invoke.texi
trunk/gcc/loop-unroll.c
trunk/gcc/print-rtl.c
trunk/gcc/print-tree.c
trunk/gcc/testsuite/ChangeLog
trunk/gcc/tree.h
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28251
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug other/28251] dumped addresses makes diffing dumps unusable
2006-07-04 21:10 [Bug other/28251] New: dumped addresses makes diffing dumps unusable amylaar at gcc dot gnu dot org
` (5 preceding siblings ...)
2006-07-17 14:45 ` amylaar at gcc dot gnu dot org
@ 2006-07-17 16:00 ` amylaar at gcc dot gnu dot org
6 siblings, 0 replies; 8+ messages in thread
From: amylaar at gcc dot gnu dot org @ 2006-07-17 16:00 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from amylaar at gcc dot gnu dot org 2006-07-17 16:00 -------
Fixed in mainline.
--
amylaar at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28251
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2006-07-17 16:00 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-07-04 21:10 [Bug other/28251] New: dumped addresses makes diffing dumps unusable amylaar at gcc dot gnu dot org
2006-07-04 21:24 ` [Bug other/28251] " amylaar at gcc dot gnu dot org
2006-07-04 22:51 ` amylaar at gcc dot gnu dot org
2006-07-05 13:42 ` amylaar at gcc dot gnu dot org
2006-07-11 17:24 ` amylaar at gcc dot gnu dot org
2006-07-12 14:15 ` patchapp at dberlin dot org
2006-07-17 14:45 ` amylaar at gcc dot gnu dot org
2006-07-17 16:00 ` amylaar at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).