[Bug c/28287] New: [4.1/4.2 regression] ICE with misplaced attribute weak

[Bug c/28287] New: [4.1/4.2 regression] ICE with misplaced attribute weak

[reichelt at gcc dot gnu dot org]

The following invalid code snippet triggers an ICE since GCC 4.1.0:

=============================================
void foo(int __attribute__((weak)));
=============================================

bug.c:1: error: weak declaration of '({anonymous})' must be public
bug.c:1: internal compiler error: tree check: expected tree that contains 'decl
with visibility' structure, have 'parm_decl'  in mark_weak, at varasm.c:4506
Please submit a full bug report, [etc.]

This happens with the C and C++ frontend.


-- 
           Summary: [4.1/4.2 regression] ICE with misplaced attribute weak
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code, error-recovery, monitored
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: reichelt at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28287

[Bug c/28287] [4.1/4.2 regression] ICE with misplaced attribute weak

[reichelt at gcc dot gnu dot org]

-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28287

[Bug c/28287] [4.1/4.2 regression] ICE with misplaced attribute weak

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28287

[Bug c/28287] [4.1/4.2 regression] ICE with misplaced attribute weak

[janis at gcc dot gnu dot org]

------- Comment #1 from janis at gcc dot gnu dot org  2006-08-11 23:57 -------
A regression hunt on powerpc-linux using a C compiler identified the following
patch:

    http://gcc.gnu.org/viewcvs?view=rev&rev=101799

    r101799 | dberlin | 2005-07-08 23:37:11 +0000 (Fri, 08 Jul 2005)


-- 

janis at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dberlin at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28287

[Bug c/28287] [4.1/4.2 regression] ICE with misplaced attribute weak

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2006-08-12 00:02 -------
The real question is why we even get to that point in mark_weak. 


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-08-12 00:02:25
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28287

[Bug c/28287] [4.1/4.2 regression] ICE with misplaced attribute weak

[dannysmith at users dot sourceforge dot net]

------- Comment #3 from dannysmith at users dot sourceforge dot net  2006-08-14 23:29 -------
Patch at:
http://gcc.gnu.org/ml/gcc-patches/2006-08/msg00473.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28287

[Bug c/28287] [4.1/4.2 regression] ICE with misplaced attribute weak

[patchapp at dberlin dot org]

------- Comment #4 from patchapp at dberlin dot org  2006-08-15 00:45 -------
Subject: Bug number PR c/28287

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-08/msg00473.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28287

[Bug c/28287] [4.1/4.2 regression] ICE with misplaced attribute weak

[jsm28 at gcc dot gnu dot org]

------- Comment #5 from jsm28 at gcc dot gnu dot org  2006-08-15 16:10 -------
The patch is OK.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28287

[Bug c/28287] [4.1/4.2 regression] ICE with misplaced attribute weak

[dannysmith at gcc dot gnu dot org]

------- Comment #6 from dannysmith at gcc dot gnu dot org  2006-08-15 21:46 -------
Subject: Bug 28287

Author: dannysmith
Date: Tue Aug 15 21:46:30 2006
New Revision: 116170

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=116170
Log:
gcc
        PR c/28287
        * c-common.c (handle_weak_attribute): Ignore and warn if
        not a FUNCTION_ or VAR_DECL

testsuite

        * gcc.dg/attr-invalid.c: Add tests for invalid weak attribute.



Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-common.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/attr-invalid.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28287

[Bug c/28287] [4.1/4.2 regression] ICE with misplaced attribute weak

[dannysmith at users dot sourceforge dot net]

------- Comment #7 from dannysmith at users dot sourceforge dot net  2006-08-15 21:48 -------
Assigning to self so...


-- 

dannysmith at users dot sourceforge dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |dannysmith at users dot
                   |dot org                     |sourceforge dot net
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2006-08-12 00:02:25         |2006-08-15 21:48:14
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28287

[Bug c/28287] [4.1 regression] ICE with misplaced attribute weak

[dannysmith at users dot sourceforge dot net]

------- Comment #8 from dannysmith at users dot sourceforge dot net  2006-08-15 21:49 -------
Fixed on trunk


-- 

dannysmith at users dot sourceforge dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.1/4.2 regression] ICE    |[4.1 regression] ICE with
                   |with misplaced attribute    |misplaced attribute weak
                   |weak                        |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28287

[Bug c/28287] [4.1 regression] ICE with misplaced attribute weak

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.2                       |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28287

[Bug c/28287] [4.1 regression] ICE with misplaced attribute weak

[jsm28 at gcc dot gnu dot org]

------- Comment #9 from jsm28 at gcc dot gnu dot org  2008-07-04 15:39 -------
Closing 4.1 branch.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to fail|                            |4.1.3
      Known to work|                            |4.2.0
         Resolution|                            |FIXED
   Target Milestone|4.1.3                       |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28287