public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "kargl at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/28439] Multiple evaluations of arithmetic if condition
Date: Thu, 20 Jul 2006 04:37:00 -0000	[thread overview]
Message-ID: <20060720043749.11750.qmail@sourceware.org> (raw)
In-Reply-To: <bug-28439-12982@http.gcc.gnu.org/bugzilla/>



------- Comment #5 from kargl at gcc dot gnu dot org  2006-07-20 04:37 -------
(In reply to comment #4) 
> My gfortran skills are not what they used to be,

You're always welcomed to spend some quality time with the
gfortran source code :-)

> but I believe this is the fix:
> 
> Index: trans-stmt.c
> ===================================================================
> --- trans-stmt.c        (revision 115467)
> +++ trans-stmt.c        (working copy)
> @@ -663,6 +663,7 @@ gfc_trans_arithmetic_if (gfc_code * code
> 
>    /* Pre-evaluate COND.  */
>    gfc_conv_expr_val (&se, code->expr);
> +  se.expr = gfc_evaluate_now (se.expr, &se.pre);
> 

I think you're on the right track, but shouldn't it be

se.expr = gfc_evaluate_now (code->expr, &se.pre);

I'm not sure of the &se.pre part, yet.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28439


  parent reply	other threads:[~2006-07-20  4:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-19 16:59 [Bug fortran/28439] New: " mfpasik at sandia dot gov
2006-07-19 20:33 ` [Bug fortran/28439] " kargl at gcc dot gnu dot org
2006-07-19 23:03 ` steven at gcc dot gnu dot org
2006-07-19 23:03 ` steven at gcc dot gnu dot org
2006-07-19 23:06 ` pinskia at gcc dot gnu dot org
2006-07-19 23:08 ` steven at gcc dot gnu dot org
2006-07-20  4:37 ` kargl at gcc dot gnu dot org [this message]
2006-07-21 23:39 ` steven at gcc dot gnu dot org
2006-07-22  2:01 ` kargl at gcc dot gnu dot org
2006-07-22 17:55 ` kargl at gcc dot gnu dot org
2006-07-22 17:58 ` [Bug fortran/28439] [4.1 only] " kargl at gcc dot gnu dot org
2006-07-24 16:54 ` kargl at gcc dot gnu dot org
2006-07-25 23:31 ` kargl at gcc dot gnu dot org
2006-07-25 23:32 ` kargl at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060720043749.11750.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).