[Bug target/26877] New: configure switches --with-arch and --with-tune are broken on x86

[Bug target/26877] New: configure switches --with-arch and --with-tune are broken on x86

[lasse dot collin at tukaani dot org]

I was trying to build GCC on x86 so that it would default to -march=i586
-mtune=i686. I specified --with-arch=i586 --with-tune=i686 to configure, but
the resulting gcc still used -mtune=i586 instead of -mtune=i686.

The configure switches --with-arch, --with-cpu and --with-tune write
appropriate values to gcc/configargs.h correctly. However, if --with-arch=foo
has been specified, the cpu and tune values have no effect, because in
gcc/config/i386/i386.h the order of arch/tune/cpu is wrong:

#define OPTION_DEFAULT_SPECS \
  {"arch", "%{!march=*:-march=%(VALUE)}"}, \
  {"tune", "%{!mtune=*:%{!mcpu=*:%{!march=*:-mtune=%(VALUE)}}}" }, \
  {"cpu", "%{!mtune=*:%{!mcpu=*:%{!march=*:-mtune=%(VALUE)}}}" }

Example command line: gcc -o foo foo.c
  "arch": -march= hasn't been given on the command line, append
          -march=%(VALUE). This is correct.
  "tune": -mtune= hasn't been given on the command line, neither
          is -mcpu=. But -march is (we just appended it) so
          -mtune=%(VALUE) does NOT get appended. This is wrong.
  "cpu":  Same as with "tune".

The solution is changing the order from arch/tune/cpu to tune/cpu/arch. This
problem applies to at least GCC 3.4.6 and 4.1.0; probably all versions since
3.4.0.


--- gcc-4.1.0/gcc/config/i386/i386.h.orig       2006-03-24 23:22:04.000000000
+0200
+++ gcc-4.1.0/gcc/config/i386/i386.h    2006-03-24 23:39:30.000000000 +0200
@@ -269,9 +269,9 @@

 /* Support for configure-time defaults of some command line options.  */
 #define OPTION_DEFAULT_SPECS \
-  {"arch", "%{!march=*:-march=%(VALUE)}"}, \
   {"tune", "%{!mtune=*:%{!mcpu=*:%{!march=*:-mtune=%(VALUE)}}}" }, \
-  {"cpu", "%{!mtune=*:%{!mcpu=*:%{!march=*:-mtune=%(VALUE)}}}" }
+  {"cpu", "%{!mtune=*:%{!mcpu=*:%{!march=*:-mtune=%(VALUE)}}}" }, \
+  {"arch", "%{!march=*:-march=%(VALUE)}"}

 /* Specs for the compiler proper */


-- 
           Summary: configure switches --with-arch and --with-tune are
                    broken on x86
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: lasse dot collin at tukaani dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26877

[Bug target/26877] configure switches --with-arch and --with-tune are broken on x86

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|trivial                     |normal


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26877

[Bug target/26877] configure switches --with-arch and --with-tune are broken on x86

[echristo at apple dot com]

------- Comment #1 from echristo at apple dot com  2006-07-19 21:59 -------
I'll take this since I've submitted a patch.


-- 

echristo at apple dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |echristo at apple dot com
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-07-19 21:59:21
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26877

[Bug target/26877] configure switches --with-arch and --with-tune are broken on x86

[echristo at apple dot com]

------- Comment #3 from echristo at apple dot com  2006-07-20 07:40 -------
Fixed thusly:

2006-07-20  Eric Christopher  <echristo@apple.com>                              

        PR target/26877                                                         
        * config/i386/i386.h (OPTION_DEFAULT_SPECS): Reorder.


-- 

echristo at apple dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26877

[Bug target/26877] configure switches --with-arch and --with-tune are broken on x86

[echristo at gcc dot gnu dot org]

------- Comment #2 from echristo at gcc dot gnu dot org  2006-07-20 07:40 -------
Subject: Bug 26877

Author: echristo
Date: Thu Jul 20 07:40:12 2006
New Revision: 115609

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=115609
Log:
2006-07-20  Eric Christopher  <echristo@apple.com>

        PR target/26877
        * config/i386/i386.h (OPTION_DEFAULT_SPECS): Reorder.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26877