[Bug fortran/20892] dummy procedure can't be generic

[Bug fortran/20892] dummy procedure can't be generic

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2005-12-31 19:59 -------
And now just accepts the code without an ICE.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|ice-on-invalid-code         |
   Last reconfirmed|2005-09-30 20:49:19         |2005-12-31 19:59:59
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20892

[Bug fortran/20892] dummy procedure can't be generic

[fxcoudert at gcc dot gnu dot org]

------- Comment #3 from fxcoudert at gcc dot gnu dot org  2006-05-21 20:49 -------
Proposed patch (wording from the g95 error message). With that patch, compiling
the testcase is a bit noisy (additional errors after the first error message),
I'll try to find a cleaner solution.



Index: interface.c
===================================================================
--- interface.c (revision 113849)
+++ interface.c (working copy)
@@ -217,6 +217,13 @@
          && gfc_add_generic (&sym->attr, sym->name, NULL) == FAILURE)
        return MATCH_ERROR;

+      if (sym->attr.dummy)
+       {
+         gfc_error ("Dummy procedure '%s' at %C cannot have a "
+                    "generic interface", sym->name);
+         return MATCH_ERROR;
+       }
+
       current_interface.sym = gfc_new_block = sym;
       break;



-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fxcoudert at gcc dot gnu dot
                   |                            |org
         AssignedTo|unassigned at gcc dot gnu   |fxcoudert at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
           Keywords|                            |patch
   Last reconfirmed|2005-12-31 19:59:59         |2006-05-21 20:49:21
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20892

[Bug fortran/20892] dummy procedure can't be generic

[fxcoudert at gcc dot gnu dot org]

------- Comment #4 from fxcoudert at gcc dot gnu dot org  2006-07-05 15:22 -------
Subject: Bug 20892

Author: fxcoudert
Date: Wed Jul  5 15:22:26 2006
New Revision: 115201

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=115201
Log:
        PR fortran/20892
        * interface.c (gfc_match_interface): Don't allow dummy procedures
        to have a generic interface.

Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/interface.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20892

[Bug fortran/20892] [4.1 only] dummy procedure can't be generic

[fxcoudert at gcc dot gnu dot org]

-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |4.1.2
      Known to work|                            |4.2.0
            Summary|dummy procedure can't be    |[4.1 only] dummy procedure
                   |generic                     |can't be generic
   Target Milestone|---                         |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20892

[Bug fortran/20892] [4.1 only] dummy procedure can't be generic

[fxcoudert at gcc dot gnu dot org]

------- Comment #5 from fxcoudert at gcc dot gnu dot org  2006-07-24 21:02 -------
Subject: Bug 20892

Author: fxcoudert
Date: Mon Jul 24 21:02:39 2006
New Revision: 115722

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=115722
Log:
        PR fortran/28129
        * trans-array.c (gfc_trans_array_bound_check): Add a locus
        argument, and use it in the error messages.
        (gfc_conv_array_index_offset): Donc perform bounds checking on
        the last dimension of assumed-size arrays.
        * gfortran.dg/bounds_check_4.f90: New test.

        PR fortran/27874
        * trans-stmt.c (compute_inner_temp_size): Don't perform bounds
        checking when calculating the bounds of scalarization.

        PR fortran/20892
        * interface.c (gfc_match_interface): Don't allow dummy procedures
        to have a generic interface.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/bounds_check_4.f90
      - copied unchanged from r115231,
trunk/gcc/testsuite/gfortran.dg/bounds_check_4.f90
Modified:
    branches/gcc-4_1-branch/gcc/fortran/ChangeLog
    branches/gcc-4_1-branch/gcc/fortran/interface.c
    branches/gcc-4_1-branch/gcc/fortran/trans-array.c
    branches/gcc-4_1-branch/gcc/fortran/trans-stmt.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20892

[Bug fortran/20892] dummy procedure can't be generic

[fxcoudert at gcc dot gnu dot org]

------- Comment #6 from fxcoudert at gcc dot gnu dot org  2006-07-24 21:03 -------
Fixed.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to fail|4.1.2                       |
      Known to work|4.2.0                       |4.2.0 4.1.2
         Resolution|                            |FIXED
            Summary|[4.1 only] dummy procedure  |dummy procedure can't be
                   |can't be generic            |generic


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20892

[Bug fortran/20892] dummy procedure can't be generic

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-09-30 20:49 -------
Seg fault on the mainline:
#0  resolve_formal_arglist (proc=0x95451c0)
    at /home/peshtigo/pinskia/src/gnu/gcc/src/gcc/fortran/resolve.c:123
#1  0x0808f033 in traverse_ns (st=0x9530aa8, func=0x8081e30 <find_arglists>)
    at /home/peshtigo/pinskia/src/gnu/gcc/src/gcc/fortran/symbol.c:2313
#2  0x080862ee in gfc_resolve (ns=0x9544e68)
    at /home/peshtigo/pinskia/src/gnu/gcc/src/gcc/fortran/resolve.c:247
#3  0x0807dc09 in gfc_parse_file ()
    at /home/peshtigo/pinskia/src/gnu/gcc/src/gcc/fortran/parse.c:2626
#4  0x08097585 in gfc_be_parse_file (set_yydebug=0)
    at /home/peshtigo/pinskia/src/gnu/gcc/src/gcc/fortran/f95-lang.c:256


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
 GCC target triplet|i686-pc-linux-gnu           |
           Keywords|                            |ice-on-invalid-code
   Last reconfirmed|2005-05-19 17:15:52         |2005-09-30 20:49:19
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20892

[Bug fortran/20892] dummy procedure can't be generic

[tobi at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |accepts-invalid
   Last reconfirmed|0000-00-00 00:00:00         |2005-05-19 17:15:52
               date|                            |
            Summary|error needed                |dummy procedure can't be
                   |                            |generic


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20892