[Bug c++/28432] New: [4.0/4.1/4.2 regression] duplicate "no member function declared" message

[Bug c++/28432] New: [4.0/4.1/4.2 regression] duplicate "no member function declared" message

[reichelt at gcc dot gnu dot org]

Since today, I get some duplicate diagnostics:

======================
struct A {};
void A::foo();
======================

bug.cc:2: error: no 'void A::foo()' member function declared in class 'A'
bug.cc:2: error: no 'void A::foo()' member function declared in class 'A'
bug.cc:2: error: declaration of 'void A::foo()' outside of class is not
definition

Apparently we call check_classfn twice.

Steve, the duplicate message appeared with your patch for PR 28304.
But you probably only uncovered a latent problem. Would you mind
taking a look, anyway?


-- 
           Summary: [4.0/4.1/4.2 regression] duplicate "no member function
                    declared" message
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Keywords: diagnostic, monitored
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: reichelt at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28432

[Bug c++/28432] [4.0/4.1/4.2 regression] duplicate "no member function declared" message

[sje at cup dot hp dot com]

------- Comment #1 from sje at cup dot hp dot com  2006-07-19 20:47 -------
Actually, I think my patch may have been wrong.  By adding the return to
check_classfn, what I basically did was to skip the call to add_method, which
according to the comments, is specifically there to add the non-existent method
and thus cause us to not give duplicate messages.  If I undo the patch for PR
28304, we call add_method and the duplicate messages go away but then I have
the ICE again.  I think the ICE needs to be fixed some other way but I am not
sure how to do it. I will think some more but any advice you might have would
be appreciated.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28432

[Bug c++/28432] [4.0/4.1/4.2 regression] duplicate "no member function declared" message

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28432

[Bug c++/28432] [4.0/4.1/4.2 regression] duplicate "no member function declared" message

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28432

[Bug c++/28432] [4.0/4.1/4.2 regression] duplicate "no member function declared" message

[sje at gcc dot gnu dot org]

------- Comment #2 from sje at gcc dot gnu dot org  2006-08-01 16:45 -------
Subject: Bug 28432

Author: sje
Date: Tue Aug  1 16:45:14 2006
New Revision: 115857

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=115857
Log:
        PR c++/28432
        * decl2.c (check_classfn): Remove early return.
        * search.c (lookup_member): Return NULL with bad type.
        * g++.dg/other/pr28304.C: Change expected error message.
        * g++.dg/other/pr28432.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/other/pr28432.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/decl2.c
    trunk/gcc/cp/search.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/other/pr28304.C


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28432

[Bug c++/28432] [4.0/4.1/4.2 regression] duplicate "no member function declared" message

[sje at gcc dot gnu dot org]

------- Comment #3 from sje at gcc dot gnu dot org  2006-08-03 17:10 -------
Subject: Bug 28432

Author: sje
Date: Thu Aug  3 17:09:57 2006
New Revision: 115906

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=115906
Log:
        PR c++/28432
        * decl2.c (check_classfn): Remove early return.
        * search.c (lookup_member): Return NULL with bad type.
        * g++.dg/other/pr28304.C: Change expected error message.
        * g++.dg/other/pr28432.C: New test.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/g++.dg/other/pr28432.C
Modified:
    branches/gcc-4_1-branch/gcc/cp/ChangeLog
    branches/gcc-4_1-branch/gcc/cp/decl2.c
    branches/gcc-4_1-branch/gcc/cp/search.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_1-branch/gcc/testsuite/g++.dg/other/pr28304.C


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28432

[Bug c++/28432] [4.0/4.1/4.2 regression] duplicate "no member function declared" message

[sje at gcc dot gnu dot org]

------- Comment #4 from sje at gcc dot gnu dot org  2006-08-03 17:16 -------
Subject: Bug 28432

Author: sje
Date: Thu Aug  3 17:16:20 2006
New Revision: 115908

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=115908
Log:
        PR c++/28432
        * decl2.c (check_classfn): Remove early return.
        * search.c (lookup_member): Return NULL with bad type.
        * g++.dg/other/pr28304.C: Change expected error message.
        * g++.dg/other/pr28432.C: New test.

Added:
    branches/gcc-4_0-branch/gcc/testsuite/g++.dg/other/pr28432.C
Modified:
    branches/gcc-4_0-branch/gcc/cp/ChangeLog
    branches/gcc-4_0-branch/gcc/cp/decl2.c
    branches/gcc-4_0-branch/gcc/cp/search.c
    branches/gcc-4_0-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_0-branch/gcc/testsuite/g++.dg/other/pr28304.C


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28432

[Bug c++/28432] [4.0/4.1/4.2 regression] duplicate "no member function declared" message

[sje at cup dot hp dot com]

------- Comment #5 from sje at cup dot hp dot com  2006-08-03 17:17 -------
Fixed on mainline, 4.1 branch, and 4.0 branch.


-- 

sje at cup dot hp dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28432