public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/19116] -funsafe-math-optimizations make nan compares equal to one another (-finite-math-only should be doing that)
Date: Fri, 25 Aug 2006 09:01:00 -0000	[thread overview]
Message-ID: <20060825090102.11467.qmail@sourceware.org> (raw)
In-Reply-To: <bug-19116-9515@http.gcc.gnu.org/bugzilla/>



------- Comment #10 from rguenth at gcc dot gnu dot org  2006-08-25 09:01 -------
Mine.  This "regression" was introduced at the time we got rid of
flag_fast_math and changed it to either flag_unsafe_math_optimizations or
flag_trapping_math.

+2001-03-07  Brad Lucier  <lucier@math.purdue.edu>
+
+       * builtins.c (expand_builtin_mathfn): Check
+       flag_unsafe_math_optimizations, not flag_fast_math.
+       (expand_builtin): Likewise
+       * combine.c (combine_simplify_rtx): Likewise.
+       (simplify_if_then_else): Likewise.
+       * cse.c (fold_rtx): Likewise.
+       * flags.h: Remove flag_fast_math.  Add 
+       flag_unsafe_math_optimizations and flag_trapping_math.
+       * fold-const.c (negate_expr): Check
+       flag_unsafe_math_optimizations, not flag_fast_math.
+       (invert_truthvalue): Likewise.
+       (fold): Likewise.  Before associating operands, check that
+       code == MULT_EXPR, not code != MULT_EXPR.
+       * ifcvt.c (noce_try_minmax): Check
+       flag_unsafe_math_optimizations, not flag_fast_math.
+       (noce_operand_ok): Check flag_trapping_math, not flag_fast_math.
+       * invoke.texi: Document -funsafe-math-optimizations and
+       -fno-trapping-math.  Change documentation for -ffast-math.
+       * jump.c (reversed_comparison_code_parts): Likewise.
+       (rtx_equal_for_thread_p): Likewise.
+       * optabs.c (emit_conditional_move): Likewise.
+       * simplify-rtx.c (simplify_binary_operation): Likewise.
+       (simplify_relational_operation): Likewise.
+       (simplify_ternary_operation): Likewise.
+       * toplev.c: Remove flag_fast_math.  Add flag_trapping_math and
+       flag_unsafe_math_optimizations.  Remove fast-math entry from f_options.
+       Add trapping-math and unsafe-math-optimizations entries to f_options.
+       (set_fast_math_flags): New, sets flags for -ffast-math.
+       (set_no_fast_math_flags): New, sets flags for -fno-fast-math.
+       (decode_f_option): Add code to handle -ffast-math and -fno-fast-math.
+       * toplev.h: Declare set_fast_math_flags and set_no_fast_math_flags.
+
+       * config/alpha/alpha.c (alpha_emit_conditional_branch): Likewise.
+       (alpha_emit_conditional_move): Initialize local_fast_math to
+       flag_unsafe_math_optimizations, not flat_fast_math.
+       * config/c4x/c4x.c (c4x_override_options): Call set_fast_math_flags
+       instead of setting flag_fast_math to 1.
+       * config/convex/convex.md: Check flag_unsafe_math_optimizations,
+       not flag_fast_math.
+       * config/i386/i386.c (override_options): Likewise
+       * config/i386/i386.md: Likewise.
+       * config/m68k/m68k.md: Likewise.
+       * config/mips/mips.md: Likewise.
+       * config/rs6000/rs6000.c (validate_condition_mode): Likewise.
+       (rs6000_generate_compare): Likewise.

Later flag_finite_math_only was introduced but not all other places fixed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rguenth at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2005-09-24 16:53:42         |2006-08-25 09:01:01
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19116


       reply	other threads:[~2006-08-25  9:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-19116-9515@http.gcc.gnu.org/bugzilla/>
2006-08-25  9:01 ` rguenth at gcc dot gnu dot org [this message]
2006-10-21 10:41 ` rguenth at gcc dot gnu dot org
2006-10-21 10:42 ` rguenth at gcc dot gnu dot org
2006-11-03 22:35 ` pinskia at gcc dot gnu dot org
2006-11-04 10:54 ` ubizjak at gmail dot com
2006-11-04 13:30 ` rguenth at gcc dot gnu dot org
2006-11-04 16:27 ` james dot me at gmail dot com
2006-11-04 16:32 ` rguenth at gcc dot gnu dot org
2006-11-06  9:33 ` rguenth at gcc dot gnu dot org
2006-11-06  9:34 ` rguenth at gcc dot gnu dot org
2004-12-21 20:36 [Bug driver/19116] New: -fno-finite-math-only does not override -ffast-math Thomas dot Koenig at online dot de
2004-12-27 14:00 ` [Bug target/19116] -funsafe-math-optimizations make nan compares equal to one another (-finite-math-only should be doing that) pinskia at gcc dot gnu dot org
2005-01-17 13:42 ` hunor at cs dot bme dot hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060825090102.11467.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).