[Bug tree-optimization/28906] [4.2 regression] tree check: did not expect class 'type', have 'type' (template_type_parm) in contains_placeholder_p, at tree.c:2223

[Bug tree-optimization/28906] [4.2 regression] tree check: did not expect class 'type', have 'type' (template_type_parm) in contains_placeholder_p, at tree.c:2223

[tbm at cyrius dot com]

------- Comment #1 from tbm at cyrius dot com  2006-08-30 16:16 -------
Created an attachment (id=12156)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12156&action=view)
test case

Testcase from application "texlive-bin".


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug tree-optimization/28906] New: [4.2 regression] tree check: did not expect class 'type', have 'type' (template_type_parm) in contains_placeholder_p, at tree.c:2223

[tbm at cyrius dot com]

Works gcc 4.2 20060806, fails with 20060823:


(sid)579:tbm@usurper: ~] /usr/lib/gcc-snapshot/bin/g++ -c texlive-t1rw.cc
texlive-t1rw.cc:19: error: conflicting declaration 'unsigned char
Efont::Type1Reader::xvalue_store [257]'
texlive-t1rw.cc:5: error: 'Efont::Type1Reader::xvalue_store' has a previous
declaration as 'unsigned char Efont::Type1Reader::xvalue_store [(sizeof (T) *
want)]'
texlive-t1rw.cc:19: error: declaration of 'unsigned char
Efont::Type1Reader::xvalue_store [(sizeof (T) * want)]' outside of class is not
definition
texlive-t1rw.cc:19: internal compiler error: tree check: did not expect class
'type', have 'type' (template_type_parm) in contains_placeholder_p, at
tree.c:2223
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.


-- 
           Summary: [4.2 regression] tree check: did not expect class
                    'type', have 'type' (template_type_parm) in
                    contains_placeholder_p, at tree.c:2223
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tbm at cyrius dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug tree-optimization/28906] [4.2 regression] tree check: did not expect class 'type', have 'type' (template_type_parm) in contains_placeholder_p, at tree.c:2223

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
           Keywords|                            |ice-on-valid-code, rejects-
                   |                            |valid
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug tree-optimization/28906] [4.2 regression] rejects valid arrays

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2006-08-30 16:24 -------
Reduced testcase:
extern unsigned char xvalue_store[];
bool reserve (int want)
{
  new unsigned char[want];
}
unsigned char xvalue_store[257];
----
I almost think this was casued by the patch to fix PR 27184.

Janis,
  Could you do a regression hunt on this bug?
Thanks,
Andrew


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janis at gcc dot gnu dot org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|ice-on-valid-code           |
   Last reconfirmed|0000-00-00 00:00:00         |2006-08-30 16:24:37
               date|                            |
            Summary|[4.2 regression] tree check:|[4.2 regression] rejects
                   |did not expect class 'type',|valid arrays
                   |have 'type'                 |
                   |(template_type_parm) in     |
                   |contains_placeholder_p, at  |
                   |tree.c:2223                 |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug c++/28906] [4.2 regression] rejects valid arrays

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2006-08-30 17:18 -------
*** Bug 28907 has been marked as a duplicate of this bug. ***


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug c++/28906] [4.2 regression] rejects valid arrays

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2006-08-30 17:20 -------
This also causes wrong code:
extern char machineMain[];
void sort (long len)
{
  new char[100];
}
char machineMain[] = "main";
int main(void)
{
  if (sizeof(machineMain)!=sizeof("main"))
    __builtin_abort();
}


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code, wrong-
                   |                            |code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug c++/28906] [4.2 regression] rejects valid arrays

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |blocker


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug c++/28906] [4.2 regression] rejects valid arrays

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2006-08-31 10:59 -------
Yes this was casued by that patch.
Anyways we do:
1627          /* ??? The middle-end will error on us for building a VLA outside
a
1628             function context.  Methinks that's not it's purvey.  So we'll
do
1629             our own VLA layout later.  */
1630          vla_p = true;
(gdb) l
1631          full_type = build_cplus_array_type (type, NULL_TREE);
1632          index = convert (sizetype, nelts);
1633          index = size_binop (MINUS_EXPR, index, size_one_node);
1634          TYPE_DOMAIN (full_type) = build_index_type (index);

Which is the problem.  I will look into this further either this long weekend
or later today.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |27184
              nThis|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug c++/28906] [4.2 regression] rejects valid arrays

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2006-08-31 11:06 -------
Doing:
Index: init.c
===================================================================
--- init.c      (revision 116553)
+++ init.c      (working copy)
@@ -1628,7 +1628,7 @@ build_new_1 (tree placement, tree type,
         function context.  Methinks that's not it's purvey.  So we'll do
         our own VLA layout later.  */
       vla_p = true;
-      full_type = build_cplus_array_type (type, NULL_TREE);
+      full_type = copy_node (build_cplus_array_type (type, NULL_TREE));
       index = convert (sizetype, nelts);
       index = size_binop (MINUS_EXPR, index, size_one_node);
       TYPE_DOMAIN (full_type) = build_index_type (index);

Will fix the problem but I don't know if this is the correct fix.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug c++/28906] [4.2 regression] rejects valid arrays

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2006-08-30 16:24:37         |2006-08-31 11:18:46
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug c++/28906] [4.2 regression] rejects valid arrays

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2006-08-31 11:18 -------
Mine, we want/need to use build_distinct_type_copy instead but other than that
it should be ok.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug c++/28906] [4.2 regression] rejects valid arrays

[tbm at cyrius dot com]

------- Comment #8 from tbm at cyrius dot com  2006-08-31 20:10 -------
Is this the same bug?

(sid)59:tbm@usurper: ~/delta/bin] /usr/lib/gcc-snapshot/bin/g++ -c  mini.c
mini.c:40: error: variable-size type declared outside of any function
mini.c:40: error: variable-size type declared outside of any function


Testcase:

extern "C"
{
  typedef long unsigned int size_t;
  extern size_t strlen (__const char *__s) throw () __attribute__ ((__pure__))
    __attribute__ ((__nonnull__ (1)));
  struct addrinfo
  {
  }
  _G_fpos64_t;
  typedef unsigned char cc_t;
}
extern char *hostname;
extern char NetTraceFile[];
void SetNetTrace (const char *);
typedef struct
{
}
Clocks;
char **genget (const char *, char **, int);
struct setlist
{
  const char *name;
  const char *help;
  void (*handler) (const char *);
  cc_t *charp;
};
static struct setlist Setlist[] = {
  {
     "tracefile", "file to write trace information to", SetNetTrace,
     (cc_t *) NetTraceFile}
};
static struct setlist *
getset (const char *name)
{
  return (struct setlist *) genget (name, (char **) Setlist,
                                    sizeof (struct setlist));
  char *hostp = __null;
    {
      hostname = new char[strlen (hostp) + 1];
    }
}


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug c++/28906] [4.2 regression] rejects valid arrays

[tbm at cyrius dot com]

------- Comment #9 from tbm at cyrius dot com  2006-08-31 20:21 -------
Created an attachment (id=12163)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12163&action=view)
preprocessed source

Actually, can you please check when you get home if this is the same bug?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug c++/28906] [4.2 regression] rejects valid arrays

[pinskia at gcc dot gnu dot org]

------- Comment #10 from pinskia at gcc dot gnu dot org  2006-09-01 04:01 -------
(In reply to comment #9)
> Actually, can you please check when you get home if this is the same bug?
Yes this is the same bug as my patch (which I am about to submut) fixes it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug c++/28906] [4.2 regression] rejects valid arrays

[pinskia at gcc dot gnu dot org]

------- Comment #11 from pinskia at gcc dot gnu dot org  2006-09-01 04:49 -------
I did not add a testcase for one that just ICE but I did add two testcases, one
for the wrong code and one for the rejecting valid.  The ICE is because of
templates which I don't feel like needing a testcase for that really since the
other two should be enough to detect the problem in the future.  I also added a
testcase to make sure that two seperate variables does change the shared
incomplete shared type either.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2006-
                   |                            |09/msg00007.html
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug c++/28906] [4.2 regression] rejects valid arrays

[patchapp at dberlin dot org]

------- Comment #12 from patchapp at dberlin dot org  2006-09-01 04:51 -------
Subject: Bug number PR C++/28906

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-09/msg00007.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug c++/28906] [4.2 regression] rejects valid arrays

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug c++/28906] [4.2 regression] rejects valid arrays

[pinskia at gcc dot gnu dot org]

------- Comment #14 from pinskia at gcc dot gnu dot org  2006-09-08 02:49 -------
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug c++/28906] [4.2 regression] rejects valid arrays

[pinskia at gcc dot gnu dot org]

------- Comment #13 from pinskia at gcc dot gnu dot org  2006-09-08 02:49 -------
Subject: Bug 28906

Author: pinskia
Date: Fri Sep  8 02:49:11 2006
New Revision: 116776

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=116776
Log:
006-09-07  Andrew Pinski  <pinskia@physics.uc.edu>

        PR C++/28906
        * init.c (build_new_1): Build a distinct type copy
        for the array type that was returned from
        build_cplus_array_type.
2006-09-07  Andrew Pinski  <pinskia@physics.uc.edu>

        PR C++/28906
        * g++.dg/other/array3.C: New test.
        * g++.dg/other/array4.C: New test.
        * g++.dg/other/array5.C: New test.


Added:
    trunk/gcc/testsuite/g++.dg/other/array3.C
    trunk/gcc/testsuite/g++.dg/other/array4.C
    trunk/gcc/testsuite/g++.dg/other/array5.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/init.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906

[Bug c++/28906] [4.2 regression] rejects valid arrays

[rguenth at gcc dot gnu dot org]

------- Comment #15 from rguenth at gcc dot gnu dot org  2006-10-17 08:27 -------
Subject: Bug 28906

Author: rguenth
Date: Tue Oct 17 08:27:26 2006
New Revision: 117821

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=117821
Log:
2006-10-17  Richard Guenther  <rguenther@suse.de>

        Backport from mainline:
        2006-09-07  Andrew Pinski  <pinskia@physics.uc.edu>

        PR C++/28906
        * init.c (build_new_1): Build a distinct type copy
        for the array type that was returned from
        build_cplus_array_type.

        * g++.dg/other/array3.C: New test.
        * g++.dg/other/array4.C: New test.
        * g++.dg/other/array5.C: New test.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/g++.dg/other/array3.C
      - copied unchanged from r116776,
trunk/gcc/testsuite/g++.dg/other/array3.C
    branches/gcc-4_1-branch/gcc/testsuite/g++.dg/other/array4.C
      - copied unchanged from r116776,
trunk/gcc/testsuite/g++.dg/other/array4.C
    branches/gcc-4_1-branch/gcc/testsuite/g++.dg/other/array5.C
      - copied unchanged from r116776,
trunk/gcc/testsuite/g++.dg/other/array5.C
Modified:
    branches/gcc-4_1-branch/gcc/cp/ChangeLog
    branches/gcc-4_1-branch/gcc/cp/init.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28906