* [Bug c++/28989] [4.0/4.1/4.2 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
@ 2006-09-08 19:33 ` pinskia at gcc dot gnu dot org
2006-09-09 19:11 ` pinskia at gcc dot gnu dot org
` (16 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-09-08 19:33 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from pinskia at gcc dot gnu dot org 2006-09-08 19:33 -------
Confirmed, though in 3.0.4 to 3.4.0 we gave a weird error for this code:
t.cc: In function `void f()':
t.cc:5: error: assignment of read-only location
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Known to fail| |2.95.3 4.0.0 4.1.0 4.2.0
Known to work| |3.4.0 3.0.4 3.3.3 3.2.3
Last reconfirmed|0000-00-00 00:00:00 |2006-09-08 19:33:14
date| |
Summary|post-increment of bool |[4.0/4.1/4.2 Regression]
|variable accepted as lvalue |post-increment of bool
| |variable accepted as lvalue
Target Milestone|--- |4.0.4
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug c++/28989] [4.0/4.1/4.2 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
2006-09-08 19:33 ` [Bug c++/28989] [4.0/4.1/4.2 Regression] " pinskia at gcc dot gnu dot org
@ 2006-09-09 19:11 ` pinskia at gcc dot gnu dot org
2006-09-09 19:30 ` pinskia at gcc dot gnu dot org
` (15 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-09-09 19:11 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from pinskia at gcc dot gnu dot org 2006-09-09 19:10 -------
I think the problem is that i++ is being replaced with "i = 1" and (i = 1) = 2;
turns out to be legal C++.
If we add to boolean_increment to build a NON_LVALUE_EXPR, we will get an error
at least I hope.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug c++/28989] [4.0/4.1/4.2 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
2006-09-08 19:33 ` [Bug c++/28989] [4.0/4.1/4.2 Regression] " pinskia at gcc dot gnu dot org
2006-09-09 19:11 ` pinskia at gcc dot gnu dot org
@ 2006-09-09 19:30 ` pinskia at gcc dot gnu dot org
2006-09-09 23:34 ` pinskia at gcc dot gnu dot org
` (14 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-09-09 19:30 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from pinskia at gcc dot gnu dot org 2006-09-09 19:29 -------
Yep that worked, testing the fix.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |pinskia at gcc dot gnu dot
|dot org |org
Status|NEW |ASSIGNED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug c++/28989] [4.0/4.1/4.2 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
` (2 preceding siblings ...)
2006-09-09 19:30 ` pinskia at gcc dot gnu dot org
@ 2006-09-09 23:34 ` pinskia at gcc dot gnu dot org
2006-09-10 0:21 ` pinskia at gcc dot gnu dot org
` (13 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-09-09 23:34 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from pinskia at gcc dot gnu dot org 2006-09-09 23:33 -------
Grrr my patch causes a rejects valid to happen.
void
f()
{
bool i = 0;
++i = 6;
}
Is valid code as preincrement is an lvalue.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug c++/28989] [4.0/4.1/4.2 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
` (3 preceding siblings ...)
2006-09-09 23:34 ` pinskia at gcc dot gnu dot org
@ 2006-09-10 0:21 ` pinskia at gcc dot gnu dot org
2006-09-10 22:10 ` mmitchel at gcc dot gnu dot org
` (12 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-09-10 0:21 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from pinskia at gcc dot gnu dot org 2006-09-10 00:20 -------
I have a better fix which does not regress on that valid code.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug c++/28989] [4.0/4.1/4.2 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
` (4 preceding siblings ...)
2006-09-10 0:21 ` pinskia at gcc dot gnu dot org
@ 2006-09-10 22:10 ` mmitchel at gcc dot gnu dot org
2006-09-14 1:34 ` patchapp at dberlin dot org
` (11 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2006-09-10 22:10 UTC (permalink / raw)
To: gcc-bugs
--
mmitchel at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug c++/28989] [4.0/4.1/4.2 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
` (5 preceding siblings ...)
2006-09-10 22:10 ` mmitchel at gcc dot gnu dot org
@ 2006-09-14 1:34 ` patchapp at dberlin dot org
2006-09-23 18:50 ` pinskia at gcc dot gnu dot org
` (10 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: patchapp at dberlin dot org @ 2006-09-14 1:34 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from patchapp at dberlin dot org 2006-09-14 01:34 -------
Subject: Bug number PR C++/28989
A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-09/msg00532.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug c++/28989] [4.0/4.1/4.2 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
` (6 preceding siblings ...)
2006-09-14 1:34 ` patchapp at dberlin dot org
@ 2006-09-23 18:50 ` pinskia at gcc dot gnu dot org
2006-09-26 15:25 ` pinskia at gcc dot gnu dot org
` (9 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-09-23 18:50 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from pinskia at gcc dot gnu dot org 2006-09-23 18:50 -------
I have a new patch, for some reason we are looking through a SAVE_EXPR which is
incorrect really. A SAVE_EXPR can never be a lvalue.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
URL|http://gcc.gnu.org/ml/gcc- |
|patches/2006- |
|09/msg00532.html |
Keywords|patch |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug c++/28989] [4.0/4.1/4.2 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
` (7 preceding siblings ...)
2006-09-23 18:50 ` pinskia at gcc dot gnu dot org
@ 2006-09-26 15:25 ` pinskia at gcc dot gnu dot org
2006-09-27 6:56 ` pinskia at gcc dot gnu dot org
` (8 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-09-26 15:25 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from pinskia at gcc dot gnu dot org 2006-09-26 15:25 -------
Newest patch:
http://gcc.gnu.org/ml/gcc-patches/2006-09/msg01182.html
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |http://gcc.gnu.org/ml/gcc-
| |patches/2006-
| |09/msg01182.html
Keywords| |patch
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug c++/28989] [4.0/4.1/4.2 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
` (8 preceding siblings ...)
2006-09-26 15:25 ` pinskia at gcc dot gnu dot org
@ 2006-09-27 6:56 ` pinskia at gcc dot gnu dot org
2007-02-03 19:45 ` [Bug c++/28989] [4.0/4.1/4.2/4.3 " gdr at gcc dot gnu dot org
` (7 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-09-27 6:56 UTC (permalink / raw)
To: gcc-bugs
------- Comment #9 from pinskia at gcc dot gnu dot org 2006-09-27 06:56 -------
Created an attachment (id=12335)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12335&action=view)
Patch for saying SAVE_EXPRs are not lvalues
I looked into the history of lvalue_p and SAVE_EXPR has been there since day 1.
I cannot think of any corner cases because SAVE_EXPR is only ever used to make
a rlvalue or at least that is what I understand it.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug c++/28989] [4.0/4.1/4.2/4.3 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
` (9 preceding siblings ...)
2006-09-27 6:56 ` pinskia at gcc dot gnu dot org
@ 2007-02-03 19:45 ` gdr at gcc dot gnu dot org
2007-02-03 20:56 ` pinskia at gcc dot gnu dot org
` (6 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: gdr at gcc dot gnu dot org @ 2007-02-03 19:45 UTC (permalink / raw)
To: gcc-bugs
------- Comment #10 from gdr at gcc dot gnu dot org 2007-02-03 19:45 -------
won't fix in GCC-4.0.x. Adjusting milestone.
--
gdr at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.0.4 |4.1.3
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug c++/28989] [4.0/4.1/4.2/4.3 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
` (10 preceding siblings ...)
2007-02-03 19:45 ` [Bug c++/28989] [4.0/4.1/4.2/4.3 " gdr at gcc dot gnu dot org
@ 2007-02-03 20:56 ` pinskia at gcc dot gnu dot org
2007-02-14 9:18 ` mmitchel at gcc dot gnu dot org
` (5 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-02-03 20:56 UTC (permalink / raw)
To: gcc-bugs
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.1.3 |4.1.2
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug c++/28989] [4.0/4.1/4.2/4.3 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
` (11 preceding siblings ...)
2007-02-03 20:56 ` pinskia at gcc dot gnu dot org
@ 2007-02-14 9:18 ` mmitchel at gcc dot gnu dot org
2007-08-17 22:15 ` [Bug c++/28989] [4.0/4.1/4.2 " pinskia at gcc dot gnu dot org
` (4 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2007-02-14 9:18 UTC (permalink / raw)
To: gcc-bugs
--
mmitchel at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.1.2 |4.1.3
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug c++/28989] [4.0/4.1/4.2 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
` (12 preceding siblings ...)
2007-02-14 9:18 ` mmitchel at gcc dot gnu dot org
@ 2007-08-17 22:15 ` pinskia at gcc dot gnu dot org
2007-08-17 22:15 ` pinskia at gcc dot gnu dot org
` (3 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-08-17 22:15 UTC (permalink / raw)
To: gcc-bugs
------- Comment #11 from pinskia at gcc dot gnu dot org 2007-08-17 22:15 -------
Fixed on the trunk.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to work|3.4.0 3.0.4 3.3.3 3.2.3 |3.4.0 3.0.4 3.3.3 3.2.3
| |4.3.0
Summary|[4.0/4.1/4.2/4.3 Regression]|[4.0/4.1/4.2 Regression]
|post-increment of bool |post-increment of bool
|variable accepted as lvalue |variable accepted as lvalue
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug c++/28989] [4.0/4.1/4.2 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
` (13 preceding siblings ...)
2007-08-17 22:15 ` [Bug c++/28989] [4.0/4.1/4.2 " pinskia at gcc dot gnu dot org
@ 2007-08-17 22:15 ` pinskia at gcc dot gnu dot org
2008-01-03 17:45 ` pinskia at gcc dot gnu dot org
` (2 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-08-17 22:15 UTC (permalink / raw)
To: gcc-bugs
------- Comment #11 from pinskia at gcc dot gnu dot org 2007-08-17 22:15 -------
Fixed on the trunk.
------- Comment #12 from pinskia at gcc dot gnu dot org 2007-08-17 22:15 -------
Subject: Bug 28989
Author: pinskia
Date: Fri Aug 17 22:14:47 2007
New Revision: 127603
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=127603
Log:
2007-08-17 Andrew Pinski <andrew_pinski@playstation.sony.com>
PR c++/28989
* tree.c (lvalue_p_1 <case SAVE_EXPR>): SAVE_EXPRs are never
lvalues.
2007-08-17 Andrew Pinski <andrew_pinski@playstation.sony.com>
PR c++/28989
* g++.dg/expr/lval3.C: New test.
* g++.dg/expr/lval4.C: New test.
Added:
trunk/gcc/testsuite/g++.dg/expr/lval3.C
trunk/gcc/testsuite/g++.dg/expr/lval4.C
Modified:
trunk/gcc/cp/ChangeLog
trunk/gcc/cp/tree.c
trunk/gcc/testsuite/ChangeLog
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to work|3.4.0 3.0.4 3.3.3 3.2.3 |3.4.0 3.0.4 3.3.3 3.2.3
| |4.3.0
Summary|[4.0/4.1/4.2/4.3 Regression]|[4.0/4.1/4.2 Regression]
|post-increment of bool |post-increment of bool
|variable accepted as lvalue |variable accepted as lvalue
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug c++/28989] [4.0/4.1/4.2 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
` (14 preceding siblings ...)
2007-08-17 22:15 ` pinskia at gcc dot gnu dot org
@ 2008-01-03 17:45 ` pinskia at gcc dot gnu dot org
2008-07-04 21:30 ` [Bug c++/28989] [4.2 " jsm28 at gcc dot gnu dot org
2009-03-30 17:04 ` jsm28 at gcc dot gnu dot org
17 siblings, 0 replies; 19+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2008-01-03 17:45 UTC (permalink / raw)
To: gcc-bugs
------- Comment #13 from pinskia at gcc dot gnu dot org 2008-01-03 17:40 -------
I am not going to patch 4.2 and before for this, I will let someone else do it.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|pinskia at gcc dot gnu dot |unassigned at gcc dot gnu
|org |dot org
Status|ASSIGNED |NEW
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug c++/28989] [4.2 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
` (15 preceding siblings ...)
2008-01-03 17:45 ` pinskia at gcc dot gnu dot org
@ 2008-07-04 21:30 ` jsm28 at gcc dot gnu dot org
2009-03-30 17:04 ` jsm28 at gcc dot gnu dot org
17 siblings, 0 replies; 19+ messages in thread
From: jsm28 at gcc dot gnu dot org @ 2008-07-04 21:30 UTC (permalink / raw)
To: gcc-bugs
------- Comment #14 from jsm28 at gcc dot gnu dot org 2008-07-04 21:30 -------
Closing 4.1 branch.
--
jsm28 at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[4.1/4.2 Regression] post- |[4.2 Regression] post-
|increment of bool variable |increment of bool variable
|accepted as lvalue |accepted as lvalue
Target Milestone|4.1.3 |4.2.5
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug c++/28989] [4.2 Regression] post-increment of bool variable accepted as lvalue
2006-09-08 19:29 [Bug c++/28989] New: post-increment of bool variable accepted as lvalue amylaar at gcc dot gnu dot org
` (16 preceding siblings ...)
2008-07-04 21:30 ` [Bug c++/28989] [4.2 " jsm28 at gcc dot gnu dot org
@ 2009-03-30 17:04 ` jsm28 at gcc dot gnu dot org
17 siblings, 0 replies; 19+ messages in thread
From: jsm28 at gcc dot gnu dot org @ 2009-03-30 17:04 UTC (permalink / raw)
To: gcc-bugs
------- Comment #15 from jsm28 at gcc dot gnu dot org 2009-03-30 17:04 -------
Closing 4.2 branch, fixed in 4.3.
--
jsm28 at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Known to fail|2.95.3 4.0.0 4.0.4 4.1.0 |2.95.3 4.0.0 4.0.4 4.1.0
|4.2.0 |4.2.0 4.2.5
Resolution| |FIXED
Target Milestone|4.2.5 |4.3.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28989
^ permalink raw reply [flat|nested] 19+ messages in thread