[Bug middle-end/28964] New: partition_stack_vars uses unstable sort

[Bug middle-end/28964] New: partition_stack_vars uses unstable sort

[amylaar at gcc dot gnu dot org]

position_stack_vars sorts stack_vars_sorted in a manner that makes the order
of stack vars with equal size undefined, thus making the compiler output
host dependent.


-- 
           Summary: partition_stack_vars uses unstable sort
           Product: gcc
           Version: 4.1.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: amylaar at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28964

[Bug middle-end/28964] [4.0/4.1/4.2 Regression] partition_stack_vars uses unstable sort

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-09-13 06:21 -------
Confirmed, this is a regression as partition_stack_vars is new in 4.0.x.
I am thinking about either creating a meta-bug or a keyword about all the
problems with unstable sorts/hashing with memory addresses problems.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-09-13 06:21:02
               date|                            |
            Summary|partition_stack_vars uses   |[4.0/4.1/4.2 Regression]
                   |unstable sort               |partition_stack_vars uses
                   |                            |unstable sort
   Target Milestone|---                         |4.0.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28964

[Bug middle-end/28964] [4.0/4.1/4.2 Regression] partition_stack_vars uses unstable sort

[mmitchel at gcc dot gnu dot org]

------- Comment #2 from mmitchel at gcc dot gnu dot org  2006-09-20 22:32 -------
A meta-bug would be helpful.

I've marked this P2, since this bug doesn't actually result in a
user-observable problem on a single host -- but it is extremely desirable from
the point of view of us, as GCC developers, and from the point of view of many
users, that all hosts generate the same code.  So, it would be very good to get
this defect fixed.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28964

[Bug middle-end/28964] [4.0/4.1/4.2 Regression] partition_stack_vars uses unstable sort

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2006-09-22 10:09 -------
I have a patch.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rguenth at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2006-09-13 06:21:02         |2006-09-22 10:09:10
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28964

[Bug middle-end/28964] [4.0/4.1/4.2 Regression] partition_stack_vars uses unstable sort

[patchapp at dberlin dot org]

------- Comment #4 from patchapp at dberlin dot org  2006-09-22 11:25 -------
Subject: Bug number PR28964

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-09/msg00976.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28964

[Bug middle-end/28964] [4.0/4.1/4.2 Regression] partition_stack_vars uses unstable sort

[rguenth at gcc dot gnu dot org]

------- Comment #5 from rguenth at gcc dot gnu dot org  2006-09-22 15:43 -------
Subject: Bug 28964

Author: rguenth
Date: Fri Sep 22 15:43:27 2006
New Revision: 117146

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=117146
Log:
2006-09-22  Richard Guenther  <rguenther@suse.de>

        PR middle-end/28964
        * cfgexpand.c (stack_var_size_cmp): Use DECL_UID to make
        sort of stack variables stable.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cfgexpand.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28964

[Bug middle-end/28964] [4.0/4.1 Regression] partition_stack_vars uses unstable sort

[rguenth at gcc dot gnu dot org]

------- Comment #6 from rguenth at gcc dot gnu dot org  2006-09-22 15:43 -------
Fixed on the mainline.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.0/4.1/4.2 Regression]    |[4.0/4.1 Regression]
                   |partition_stack_vars uses   |partition_stack_vars uses
                   |unstable sort               |unstable sort


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28964

[Bug middle-end/28964] [4.0/4.1 Regression] partition_stack_vars uses unstable sort

[rguenth at gcc dot gnu dot org]

------- Comment #7 from rguenth at gcc dot gnu dot org  2006-09-25 12:04 -------
WONTFIX on 4.0/4.1 branches.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|4.0.4                       |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28964