[Bug c++/28988] New: g++ does not check first type name in pseudo-destructor-name

[Bug c++/28988] New: g++ does not check first type name in pseudo-destructor-name

[amylaar at gcc dot gnu dot org]

The following code is accepted, contrary to clause 5.2.4:

typedef int C;
typedef double D;

void
f ()
{
  C o;

  o.D::~C ();
}


-- 
           Summary: g++ does not check first type name in pseudo-destructor-
                    name
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Keywords: accepts-invalid
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: amylaar at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28988

[Bug c++/28988] [4.0/4.1/4.2 Regression] g++ does not check first type name in pseudo-destructor-name

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-09-09 04:16 -------
Confirmed, another regression from 3.3.3:
t.cc: In function `void f()':
t.cc:9: qualified type `double' does not match destructor name `~C'
t.cc:9: type of `o' does not match destructor type `double' (type was `C'


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
      Known to fail|                            |3.4.0 4.0.0 4.1.0 4.2.0
      Known to work|                            |3.3.3 2.95.3 3.0.4 3.2.3
   Last reconfirmed|0000-00-00 00:00:00         |2006-09-09 04:16:24
               date|                            |
            Summary|g++ does not check first    |[4.0/4.1/4.2 Regression] g++
                   |type name in pseudo-        |does not check first type
                   |destructor-name             |name in pseudo-destructor-
                   |                            |name
   Target Milestone|---                         |4.0.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28988

[Bug c++/28988] [4.0/4.1/4.2 Regression] g++ does not check first type name in pseudo-destructor-name

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2006-09-09 06:40 -------
lookup_destructor has become dead code which did the checking at least on the
mainline.
finish_pseudo_destructor_expr is where the new code is now.
Adding:
      if (scope && !check_dtor_name (scope, destructor))
        {
          error ("qualified type %qT does not match destructor name ~%qT",
                 scope, destructor);
          return error_mark_node;
        }
To finish_pseudo_destructor_expr fixes this bug.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28988

[Bug c++/28988] [4.0/4.1/4.2 Regression] g++ does not check first type name in pseudo-destructor-name

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2006-09-09 21:22 -------
Mine.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28988

[Bug c++/28988] [4.0/4.1/4.2 Regression] g++ does not check first type name in pseudo-destructor-name

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28988

[Bug c++/28988] [4.0/4.1/4.2 Regression] g++ does not check first type name in pseudo-destructor-name

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2006-09-14 06:38 -------
(In reply to comment #2)
> Adding:
....
> To finish_pseudo_destructor_expr fixes this bug.

This caused two regressions which I still need to look into, both are ICEs.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28988

[Bug c++/28988] [4.0/4.1/4.2 Regression] g++ does not check first type name in pseudo-destructor-name

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2006-09-26 16:59 -------
Just needed to add a check for types before calling check_dtor_name.
Testing the new fix right now.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28988

[Bug c++/28988] [4.0/4.1/4.2/4.3 Regression] g++ does not check first type name in pseudo-destructor-name

[steven at gcc dot gnu dot org]

------- Comment #6 from steven at gcc dot gnu dot org  2007-01-27 22:30 -------
Approval of the patch at
http://gcc.gnu.org/ml/gcc-patches/2006-10/msg01429.html was posted today:
http://gcc.gnu.org/ml/gcc-patches/2007-01/msg02253.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28988

[Bug c++/28988] [4.0/4.1/4.2/4.3 Regression] g++ does not check first type name in pseudo-destructor-name

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2007-01-28 18:09 -------
Subject: Bug 28988

Author: pinskia
Date: Sun Jan 28 18:09:25 2007
New Revision: 121261

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=121261
Log:
2007-01-28  Andrew Pinski  <pinskia@gmail.com>

        PR C++/28988
        * semantics.c (finish_pseudo_destructor_expr): Check the
        destrutor name by calling check_dtor_name.

2007-01-28  Andrew Pinski  <pinskia@gmail.com>

        PR C++/28988
        * g++.dg/expr/dtor4.C: New test.




Added:
    trunk/gcc/testsuite/g++.dg/expr/dtor4.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/semantics.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28988

[Bug c++/28988] [4.0/4.1/4.2/4.3 Regression] g++ does not check first type name in pseudo-destructor-name

[pinskia at gcc dot gnu dot org]

------- Comment #8 from pinskia at gcc dot gnu dot org  2007-01-28 18:19 -------
Subject: Bug 28988

Author: pinskia
Date: Sun Jan 28 18:18:54 2007
New Revision: 121263

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=121263
Log:
2007-01-28  Andrew Pinski  <pinskia@gmail.com>

        PR C++/28988
        * semantics.c (finish_pseudo_destructor_expr): Check the
        destrutor name by calling check_dtor_name.

2007-01-28  Andrew Pinski  <pinskia@gmail.com>

        PR C++/28988
        * g++.dg/expr/dtor4.C: New test.



Added:
    branches/gcc-4_1-branch/gcc/testsuite/g++.dg/expr/dtor4.C
      - copied unchanged from r121261, trunk/gcc/testsuite/g++.dg/expr/dtor4.C
Modified:
    branches/gcc-4_1-branch/gcc/cp/ChangeLog
    branches/gcc-4_1-branch/gcc/cp/semantics.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


------- Comment #9 from pinskia at gcc dot gnu dot org  2007-01-28 18:19 -------
Subject: Bug 28988

Author: pinskia
Date: Sun Jan 28 18:18:52 2007
New Revision: 121262

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=121262
Log:
2007-01-28  Andrew Pinski  <pinskia@gmail.com>

        PR C++/28988
        * semantics.c (finish_pseudo_destructor_expr): Check the
        destrutor name by calling check_dtor_name.

2007-01-28  Andrew Pinski  <pinskia@gmail.com>

        PR C++/28988
        * g++.dg/expr/dtor4.C: New test.



Added:
    branches/gcc-4_2-branch/gcc/testsuite/g++.dg/expr/dtor4.C
      - copied unchanged from r121261, trunk/gcc/testsuite/g++.dg/expr/dtor4.C
Modified:
    branches/gcc-4_2-branch/gcc/cp/ChangeLog
    branches/gcc-4_2-branch/gcc/cp/semantics.c
    branches/gcc-4_2-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28988

[Bug c++/28988] [4.0/4.1/4.2/4.3 Regression] g++ does not check first type name in pseudo-destructor-name

[pinskia at gcc dot gnu dot org]

------- Comment #10 from pinskia at gcc dot gnu dot org  2007-01-28 18:19 -------
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|4.0.4                       |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28988

[Bug c++/28988] [4.0/4.1/4.2/4.3 Regression] g++ does not check first type name in pseudo-destructor-name

[pinskia at gcc dot gnu dot org]

------- Comment #8 from pinskia at gcc dot gnu dot org  2007-01-28 18:19 -------
Subject: Bug 28988

Author: pinskia
Date: Sun Jan 28 18:18:54 2007
New Revision: 121263

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=121263
Log:
2007-01-28  Andrew Pinski  <pinskia@gmail.com>

        PR C++/28988
        * semantics.c (finish_pseudo_destructor_expr): Check the
        destrutor name by calling check_dtor_name.

2007-01-28  Andrew Pinski  <pinskia@gmail.com>

        PR C++/28988
        * g++.dg/expr/dtor4.C: New test.



Added:
    branches/gcc-4_1-branch/gcc/testsuite/g++.dg/expr/dtor4.C
      - copied unchanged from r121261, trunk/gcc/testsuite/g++.dg/expr/dtor4.C
Modified:
    branches/gcc-4_1-branch/gcc/cp/ChangeLog
    branches/gcc-4_1-branch/gcc/cp/semantics.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28988