[Bug fortran/29211] New: ICE in FORALL character assignment with dependences

[Bug fortran/29211] New: ICE in FORALL character assignment with dependences

[pault at gcc dot gnu dot org]

$ cat forall.f90
character(12), dimension(2) :: a, b
a= (/"abcdefghijkl","mnopqrstuvwx"/)
! OK because it uses gfc_trans_assignment
forall (i=1:2) b(i) = a(i)
! Broken - gfc_trans_assign_need_temp has no handling of string lengths
forall (i=1:2) a(3-i) = a(i)
end

$ /irun/bin/gfortran forall.f90
forall.f90: In function 'MAIN__':
forall.f90:4: internal compiler error: in gfc_trans_scalar_assign, at
fortran/tr
ans-expr.c:3212
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.


-- 
           Summary: ICE in FORALL character assignment with dependences
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pault at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29211

[Bug fortran/29211] ICE in FORALL character assignment with dependences

[pault at gcc dot gnu dot org]

------- Comment #1 from pault at gcc dot gnu dot org  2006-09-25 16:21 -------
I have had to fix this to get on with the allocatable component patch.  As soon
as I can (~24hrs), I will clear the tree and do a clean diff for this PR.

The principle is simple;
generate_loop_for_rhs_to_temp and generate_loop_for_temp_to_lhs both have calls
to gfc_trans_scalar_assign, where the temporary is not provided with a
string_length field for the gfc_se.  The patch takes the string_length from the
other side.

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pault at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-09-25 16:21:52
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29211

[Bug fortran/29211] ICE in FORALL character assignment with dependences

[pault at gcc dot gnu dot org]

------- Comment #2 from pault at gcc dot gnu dot org  2006-10-08 16:22 -------
Subject: Bug 29211

Author: pault
Date: Sun Oct  8 16:21:55 2006
New Revision: 117558

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=117558
Log:
2006-10-05  Erik Edelmann <edelmann@gcc.gnu.org>
            Paul Thomas <pault@gcc.gnu.org>

        PR fortran/20541
        * interface.c (gfc_compare_derived_types): Add comparison of
        the allocatable field.
        * intrinsic.c (add_subroutines): Add MOVE_ALLOC.
        * trans-expr.c (gfc_conv_aliased_arg, gfc_trans_subarray_assign,
        gfc_trans_subcomponent_assign, gfc_conv_string_parameter,
        gfc_trans_scalar_assign): Add extra arguments l_is_temp
        and r_is_var to references to latter function.
        (gfc_conv_function_call): Add enum for types of argument and
        an associated variable parm_kind. Deallocate components of
        INTENT(OUT) and non-variable arrays.
        (gfc_trans_subcomponent_assign): Add block to assign arrays
        to allocatable components.
        (gfc_trans_scalar_assign): Add block to handle assignments of
        derived types with allocatable components, using the above new
        arguments to control allocation/deallocation of memory and the
        copying of allocated arrays.
        * trans-array.c (gfc_array_allocate): Remove old identification 
        of pointer and replace with that of an allocatable array. Add
        nullify of structures with allocatable components. 
        (gfc_conv_array_initializer): Treat EXPR_NULL.
        (gfc_conv_array_parameter): Deallocate allocatable components
        of non-variable structures.
        (gfc_trans_dealloc_allocated): Use second argument of library
        deallocate to inhibit, without error, freeing NULL pointers.
        (get_full_array_size): New function to return the size of a
        full array.
        (gfc_duplicate_allocatable): New function to allocate and copy
        allocated data.
        (structure_alloc_comps): New recursive function to deallocate,
        nullify or copy allocatable components.
        (gfc_nullify_alloc_comp, gfc_deallocate_alloc_comp,
        gfc_copy_alloc_comp): New interface functions to call previous.
        (gfc_trans_deferred_array): Add the code to nullify allocatable
        components, when entering scope, and to deallocate them on
        leaving. Do not call gfc_trans_static_array_pointer and return
        for structures with allocatable components and default
        initializers.
        * symbol.c (gfc_set_component_attr): Set allocatable field.
        (gfc_get_component_attr): Set the allocatable attribute.
        * intrinsic.h : Prototype for gfc_check_move_alloc.
        * decl.c (build_struct): Apply TR15581 constraints for
        allocatable components.
        (variable_decl): Default initializer is always NULL for
        allocatable components.
        (match_attr_spec): Allow, or not, allocatable components,
        according to the standard in force.
        * trans-array.h : Prototypes for gfc_nullify_alloc_comp,
        gfc_deallocate_alloc_comp, gfc_copy_alloc_comp and
        gfc_duplicate_allocatable.
        * gfortran.texi : Add mention of TR15581 extensions.
        * gfortran.h : Add attribute alloc_comp, add
        gfc_components field allocatable and add the prototype
        for gfc_expr_to_initialize.
        * trans-stmt.c (generate_loop_for_temp_to_lhs,
        generate_loop_for_rhs_to_temp, gfc_trans_where_assign,
        gfc_trans_where_3): Add extra arguments to calls to
        gfc_trans_scalar_assign and set appropriately.
        (gfc_trans_allocate): Nullify allocatable components.
        (gfc_trans_deallocate): Deallocate to ultimate allocatable
        components but stop at ultimate pointer components.
        * module.c (mio_symbol_attribute, mio_symbol_attribute,
        mio_component): Add module support for allocatable
        components.
        * trans-types.c (gfc_get_derived_type): Treat allocatable
        components.
        * trans.h : Add two boolean arguments to
        gfc_trans_scalar_assign.
        * resolve.c (resolve_structure_cons): Check conformance of
        constructor element and the component.
        (resolve_allocate_expr): Add expression to nullify the
        constructor expression for allocatable components.
        (resolve_transfer): Inhibit I/O of derived types with
        allocatable components.
        (resolve_fl_derived): Skip check of bounds of allocatable
        components.
        * trans-decl.c (gfc_get_symbol_decl): Add derived types
        with allocatable components to deferred variable.
        (gfc_trans_deferred_vars): Make calls for derived types
        with allocatable components to gfc_trans_deferred_array.
        (gfc_generate_function_code): Nullify allocatable
        component function result on entry.
        * parse.c (parse_derived): Set symbol attr.allocatable if
        allocatable components are present.
        * check.c (gfc_check_allocated): Enforce attr.allocatable
        for intrinsic arguments.
        (gfc_check_move_alloc): Check arguments of move_alloc.
        * primary.c (gfc_variable_attr): Set allocatable attribute.
        * intrinsic.texi : Add index entry and section for
        for move_alloc.

        PR fortran/29115
        * resolve.c (resolve_structure_cons): It is an error if the
        pointer component elements of a derived type constructor are
        not pointer or target.


        PR fortran/29211
        * trans-stmt.c (generate_loop_for_temp_to_lhs,
        generate_loop_for_rhs_to_temp): Provide a string length for
        the temporary by copying that of the other side of the scalar
        assignment.


2006-10-05  Paul Thomas  <pault@gcc.gnu.org>
            Erik Edelmann  <edelmann@gcc.gnu.org>

        PR libgfortran/20541
        * Makefile.in : Add move_alloc.
        * intrinsics/move_alloc.c: New function.
        * Makefile.am : Add move_alloc.



2006-10-05  Erik Edelmann  <edelmann@gcc.gnu.org>
            Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/20541
        * gfortran.dg/alloc_comp_basics_1.f90: New test.
        * gfortran.dg/alloc_comp_basics_2.f90: New test.
        * gfortran.dg/alloc_comp_assign_1.f90: New test.
        * gfortran.dg/alloc_comp_assign_2.f90: New test.
        * gfortran.dg/alloc_comp_assign_3.f90: New test.
        * gfortran.dg/alloc_comp_assign_4.f90: New test.
        * gfortran.dg/alloc_comp_constraint_1.f90: New test.
        * gfortran.dg/alloc_comp_constraint_2.f90: New test.
        * gfortran.dg/alloc_comp_constraint_3.f90: New test.
        * gfortran.dg/alloc_comp_constructor_1.f90: New test.
        * gfortran.dg/alloc_comp_constructor_2.f90: New test.
        * gfortran.dg/alloc_comp_initializer_1.f90: New test.
        * gfortran.dg/alloc_comp_std.f90: New test.
        * gfortran.dg/move_alloc.f90: New test.

        PR fortran/29115
        * gfortran.dg/derived_constructor_comps_2.f90: New test.

        PR fortran/29211
        * gfortran.dg/forall_char_dependencies_1.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/alloc_comp_assign_1.f90
    trunk/gcc/testsuite/gfortran.dg/alloc_comp_assign_2.f90
    trunk/gcc/testsuite/gfortran.dg/alloc_comp_assign_3.f90
    trunk/gcc/testsuite/gfortran.dg/alloc_comp_assign_4.f90
    trunk/gcc/testsuite/gfortran.dg/alloc_comp_basics_1.f90
    trunk/gcc/testsuite/gfortran.dg/alloc_comp_basics_2.f90
    trunk/gcc/testsuite/gfortran.dg/alloc_comp_constraint_1.f90
    trunk/gcc/testsuite/gfortran.dg/alloc_comp_constraint_2.f90
    trunk/gcc/testsuite/gfortran.dg/alloc_comp_constraint_3.f90
    trunk/gcc/testsuite/gfortran.dg/alloc_comp_constructor_1.f90
    trunk/gcc/testsuite/gfortran.dg/alloc_comp_constructor_2.f90
    trunk/gcc/testsuite/gfortran.dg/alloc_comp_initializer_1.f90
    trunk/gcc/testsuite/gfortran.dg/alloc_comp_initializer_2.f90
    trunk/gcc/testsuite/gfortran.dg/alloc_comp_std.f90
    trunk/gcc/testsuite/gfortran.dg/derived_constructor_comps_2.f90
    trunk/gcc/testsuite/gfortran.dg/forall_char_dependencies_1.f90
    trunk/gcc/testsuite/gfortran.dg/move_alloc.f90
    trunk/libgfortran/intrinsics/move_alloc.c
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/check.c
    trunk/gcc/fortran/decl.c
    trunk/gcc/fortran/expr.c
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/interface.c
    trunk/gcc/fortran/intrinsic.c
    trunk/gcc/fortran/intrinsic.h
    trunk/gcc/fortran/intrinsic.texi
    trunk/gcc/fortran/module.c
    trunk/gcc/fortran/parse.c
    trunk/gcc/fortran/primary.c
    trunk/gcc/fortran/resolve.c
    trunk/gcc/fortran/symbol.c
    trunk/gcc/fortran/trans-array.c
    trunk/gcc/fortran/trans-array.h
    trunk/gcc/fortran/trans-decl.c
    trunk/gcc/fortran/trans-expr.c
    trunk/gcc/fortran/trans-stmt.c
    trunk/gcc/fortran/trans-types.c
    trunk/gcc/fortran/trans.h
    trunk/gcc/testsuite/ChangeLog
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/Makefile.in


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29211

[Bug fortran/29211] ICE in FORALL character assignment with dependences

[pault at gcc dot gnu dot org]

------- Comment #3 from pault at gcc dot gnu dot org  2006-10-08 16:29 -------
Fixed in gcc-4.2

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29211

[Bug fortran/29211] ICE in FORALL character assignment with dependences

[pault at gcc dot gnu dot org]

------- Comment #4 from pault at gcc dot gnu dot org  2006-11-06 17:18 -------
Subject: Bug 29211

Author: pault
Date: Mon Nov  6 17:18:03 2006
New Revision: 118522

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=118522
Log:
2006-11-06  Paul Thomas  <pault@gcc.gnu.org>


        PR fortran/29373
        * decl.c (get_proc_name, gfc_match_function_decl): Add
        attr.implicit_type to conditions that throw error for
        existing explicit interface and that allow new type-
        spec to be applied.

        PR fortran/29407
        * resolve.c (resolve_fl_namelist): Do not check for
        namelist/procedure conflict, if the symbol corresponds
        to a good local variable declaration.

        PR fortran/27701
        * decl.c (get_proc_name): Replace the detection of a declared
        procedure by the presence of a formal argument list by the
        attributes of the symbol and the presence of an explicit
        interface.

        PR fortran/29232
        * resolve.c (resolve_fl_variable): See if the host association
        of a derived type is blocked by the presence of another type I
        object in the current namespace.

        PR fortran/29364
        * resolve.c (resolve_fl_derived): Check for the presence of
        the derived type for a derived type component.

        PR fortran/24398
        * module.c (gfc_use_module): Check that the first words in a
        module file are 'GFORTRAN module'.

        PR fortran/29115
        * resolve.c (resolve_structure_cons): It is an error if the
        pointer component elements of a derived type constructor are
        not pointer or target.

        PR fortran/29211
        * trans-stmt.c (generate_loop_for_temp_to_lhs,
        generate_loop_for_rhs_to_temp): Provide a string length for
        the temporary by copying that of the other side of the scalar
        assignment.

        PR fortran/29098
        * resolve.c (resolve_structure_cons): Do not return FAILURE if
        component expression is NULL.


2006-11-06  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/29373
        * gfortran.dg/implicit_9.f90: New test.

        PR fortran/29407
        * gfortran.dg/namelist_25.f90: New test.

        PR fortran/27701
        * gfortran.dg/same_name_2.f90: New test.

        PR fortran/29232
        * gfortran.dg/host_assoc_types_1.f90: New test.

        PR fortran/29364
        * gfortran.dg/missing_derived_type_1.f90: New test.
        * gfortran.dg/implicit_actual.f90: Comment out USE GLOBAL.

        PR fortran/29115
        * gfortran.dg/derived_constructor_comps_2.f90: New test.

        PR fortran/29211
        * gfortran.dg/forall_char_dependencies_1.f90: New test.

        PR fortran/29098
        * gfortran.dg/default_initialization_2.f90: New test.

Added:
   
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/default_initialization_2.f90
   
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/derived_constructor_comps_2.f90
   
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/forall_char_dependencies_1.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/host_assoc_types_1.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/implicit_9.f90
   
branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/missing_derived_type_1.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/namelist_25.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/same_name_2.f90
Modified:
    branches/gcc-4_1-branch/gcc/fortran/ChangeLog
    branches/gcc-4_1-branch/gcc/fortran/decl.c
    branches/gcc-4_1-branch/gcc/fortran/module.c
    branches/gcc-4_1-branch/gcc/fortran/resolve.c
    branches/gcc-4_1-branch/gcc/fortran/trans-stmt.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/implicit_actual.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29211