[Bug c++/29435] New: [4.1 Regression] segmentation fault

[Bug c++/29435] New: [4.1 Regression] segmentation fault

[tbm at cyrius dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]

I get a segmentation fault compiling the attached testcase with gcc 4.1.  4.0
and 4.2 seem to work.   4.1.2 20060901 (Debian 4.1.1-13) also worked but
4.1.2 20061007 (Debian 4.1.1-16) fails, at least on x86_64.



(sid)1142:tbm@em64t: ~] g++-4.1 -c cinepaint-plugin_main.cpp
cinepaint-plugin_main.cpp: In constructor ‘Camera<Unsign,
Real>::Camera(Br_ImageVec&, std::vector<TNT::Array2D<Rgb<Unsign> >,
std::allocator<TNT::Array2D<Rgb<Unsign> > > >&, unsigned int,
ProgressInfo*)’:
cinepaint-plugin_main.cpp:76: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.


-- 
           Summary: [4.1 Regression] segmentation fault
           Product: gcc
           Version: 4.1.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tbm at cyrius dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1 Regression] segmentation fault

[tbm at cyrius dot com]

------- Comment #1 from tbm at cyrius dot com  2006-10-11 23:01 -------
Created an attachment (id=12413)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12413&action=view)
testcase


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1 Regression] segmentation fault

[tbm at cyrius dot com]

------- Comment #2 from tbm at cyrius dot com  2006-10-11 23:02 -------
Ignore my comment about x86_64.  I also see this on mips.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1 Regression] segmentation fault

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2006-10-11 23:05 -------
I think this is a sizeof issue:
sizeof (Rgb < XYindex >)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1 Regression] segmentation fault

[tbm at cyrius dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]



------- Comment #4 from tbm at cyrius dot com  2006-10-11 23:19 -------
(gdb) where
#0  0x000000000045a5ce in cxx_sizeof_or_alignof_type (type=0x2b29cf3e6b00,
op=214, complain=1 '\001')
    at /home/tbm/scratch/gcc-4.1/gcc/cp/typeck.c:1251
#1  0x000000000044a947 in cp_parser_unary_expression (parser=0x2b29cf261460,
address_p=0 '\0',
    cast_p=0 '\0') at /home/tbm/scratch/gcc-4.1/gcc/cp/parser.c:4850
#2  0x000000000044ae15 in cp_parser_assignment_expression
(parser=0x2b29cf261460, cast_p=Variable "cast_p" is not available.
)
    at /home/tbm/scratch/gcc-4.1/gcc/cp/parser.c:5579
#3  0x000000000044ba72 in cp_parser_parenthesized_expression_list
(parser=0x2b29cf261460,
    is_attribute_list=240 'â–’', cast_p=0 '\0', non_constant_p=0x0)
    at /home/tbm/scratch/gcc-4.1/gcc/cp/parser.c:4659
#4  0x000000000044a324 in cp_parser_unary_expression (parser=0x2b29cf261460,
address_p=0 '\0',
    cast_p=1 '\001') at /home/tbm/scratch/gcc-4.1/gcc/cp/parser.c:4204
#5  0x000000000044ac41 in cp_parser_cast_expression (parser=0x2b29cf261460,
address_p=0 '\0',
    cast_p=0 '\0') at /home/tbm/scratch/gcc-4.1/gcc/cp/parser.c:5455
...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1 Regression] segmentation fault

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2006-10-12 03:36 -------
Reduced testcase:
template < class T > struct Rgb;
template < int>int Camera1 ()
{
sizeof (Rgb < int>);
}


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |ice-on-invalid-code, ice-on-
                   |                            |valid-code
   Last reconfirmed|0000-00-00 00:00:00         |2006-10-12 03:36:29
               date|                            |
   Target Milestone|---                         |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1 Regression] segmentation fault

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2006-10-12 03:37 -------
The code in comment # 5 is invalid but even if we make it valid like below, it
still ICEs:
template < class T > struct Rgb{};
template < int>int Camera1 ()
{
sizeof (Rgb < int>);
}


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1 Regression] segmentation fault

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2006-10-12 03:39 -------
Works in 4.0.4 20061011.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.0.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1 Regression] segmentation fault

[pinskia at gcc dot gnu dot org]

------- Comment #8 from pinskia at gcc dot gnu dot org  2006-10-12 03:44 -------
I think this was caused by PR 29226.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |29226


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1/4.2 Regression] segmentation fault

[pinskia at gcc dot gnu dot org]

------- Comment #9 from pinskia at gcc dot gnu dot org  2006-10-12 03:48 -------
Also ICEs with 4.2.0 20061012 but did not with 4.2.0 20061002 (which I think
was built before PR 29226 came in).


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |blocker
      Known to fail|4.1.2                       |4.1.2 4.2.0
            Summary|[4.1 Regression]            |[4.1/4.2 Regression]
                   |segmentation fault          |segmentation fault


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1/4.2 Regression] segmentation fault

[pinskia at gcc dot gnu dot org]

------- Comment #10 from pinskia at gcc dot gnu dot org  2006-10-12 03:57 -------
The problem is that we have not layouted out the type yet, if we had with
something like:
template < class T >
struct Rgb{};
Rgb<int> t;
template < int>int Camera1 ()
{
sizeof (Rgb < int>);
}

We don't crash.
Something like this fixes the ICE but I don't know if we should not call
dependent_type_p twice or not, I have not checked if does causes an ICE for the
testcase of PR 29226 or not:
Index: ../../gcc/cp/typeck.c
===================================================================
--- ../../gcc/cp/typeck.c       (revision 117656)
+++ ../../gcc/cp/typeck.c       (working copy)
@@ -1256,6 +1256,9 @@ cxx_sizeof_or_alignof_type (tree type, e
       value = size_one_node;
     }

+  if (!dependent_type_p (type))
+    type = complete_type (type);
+
   if (dependent_type_p (type)
       /* VLA types will have a non-constant size.  In the body of an
         uninstantiated template, we don't need to try to compute the
@@ -1271,7 +1274,7 @@ cxx_sizeof_or_alignof_type (tree type, e
       return value;
     }

-  return c_sizeof_or_alignof_type (complete_type (type),
+  return c_sizeof_or_alignof_type (type,
                                   op == SIZEOF_EXPR,
                                   complain);
 }


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mmitchel at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1/4.2 Regression] segmentation fault

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1/4.2 Regression] seg fault with sizeof and templates

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |mark at codesourcery dot com
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1/4.2 Regression] seg fault with sizeof and templates

[mmitchel at gcc dot gnu dot org]

------- Comment #11 from mmitchel at gcc dot gnu dot org  2006-10-16 23:06 -------
Subject: Bug 29435

Author: mmitchel
Date: Mon Oct 16 23:06:35 2006
New Revision: 117799

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=117799
Log:
        PR c++/29435
        * typeck.c (cxx_sizeof_or_alignof_type): Complete non-dependent
        types when their sizes are required.  Refine test for VLAs.
        PR c++/29435
        * g++.dg/template/sizeof11.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/template/sizeof11.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/typeck.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1 Regression] seg fault with sizeof and templates

[mmitchel at gcc dot gnu dot org]

------- Comment #12 from mmitchel at gcc dot gnu dot org  2006-10-16 23:11 -------
Fixed in 4.2.0.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.1/4.2 Regression] seg    |[4.1 Regression] seg fault
                   |fault with sizeof and       |with sizeof and templates
                   |templates                   |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1 Regression] seg fault with sizeof and templates

[mmitchel at gcc dot gnu dot org]

------- Comment #13 from mmitchel at gcc dot gnu dot org  2006-10-17 01:56 -------
Subject: Bug 29435

Author: mmitchel
Date: Tue Oct 17 01:56:23 2006
New Revision: 117813

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=117813
Log:
        PR c++/29435
        * typeck.c (cxx_sizeof_or_alignof_type): Complete non-dependent
        types when their sizes are required.  Refine test for VLAs.
        PR c++/29435
        * g++.dg/template/sizeof11.C: New test.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/g++.dg/template/sizeof11.C
Modified:
    branches/gcc-4_1-branch/gcc/cp/ChangeLog
    branches/gcc-4_1-branch/gcc/cp/typeck.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1 Regression] seg fault with sizeof and templates

[mmitchel at gcc dot gnu dot org]

------- Comment #14 from mmitchel at gcc dot gnu dot org  2006-10-17 01:56 -------
Fixed in 4.1.2.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1 Regression] seg fault with sizeof and templates

[pinskia at gcc dot gnu dot org]

------- Comment #15 from pinskia at gcc dot gnu dot org  2006-11-03 18:29 -------
*** Bug 29698 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |skalaren_alpinist at abv dot
                   |                            |bg


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435

[Bug c++/29435] [4.1 Regression] seg fault with sizeof and templates

[pinskia at gcc dot gnu dot org]

------- Comment #16 from pinskia at gcc dot gnu dot org  2006-12-02 07:35 -------
*** Bug 30042 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bagnara at cs dot unipr dot
                   |                            |it


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29435