[Bug tree-optimization/26969] New: ICE with -O3 -ftree-vectorize

[Bug tree-optimization/26969] New: ICE with -O3 -ftree-vectorize

[halcy0n at gentoo dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1485 bytes --]

With the following code gcc-4.1 and 4.2 ICE when using "-O3 -ftree-vectorize". 
The latest checkout I have of 4.0 worked just fine.

struct re_pattern_buffer
{
  char *buffer;
  char *fastmap;
  long options;
};
void
ruby_re_compile_fastmap (struct re_pattern_buffer *bufp)
{
  unsigned char *pattern = (unsigned char *) bufp->buffer;
  register char *fastmap = bufp->fastmap;
  register unsigned char *p = pattern;
  register int j;
  int options = bufp->options;
  while (p)
    {
      switch (*p++)
    {
    case 0:
      for (j = 0; j < (1 << 8); j++)
        {
          if (j != '\n' || (options & (((1L) << 1) << 1)))
        fastmap[j] = 1;
        }
    }
    }
}

gcc version 4.2.0 20060331 (experimental)

gcc -O3 -ftree-vectorize ruby.c -c

ruby.x.i: In function ‘ruby_re_compile_fastmap’:
ruby.x.i:9: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions


-- 
           Summary: ICE with -O3 -ftree-vectorize
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: halcy0n at gentoo dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1/4.2 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-04-01 00:52 -------
Confirmed, reduced testcase:
void
ruby_re_compile_fastmap (char *fastmap, int options)
{
  int j;
  for (j = 0; j < (1 << 8); j++)
   {
     if (j != '\n' || (options & 4))
        fastmap[j] = 1;
   }
}

-----
you can get the error with -O1 -funswitch-loops -ftree-vectorize


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
  GCC build triplet|i686-pc-linux-gnu           |
   GCC host triplet|i686-pc-linux-gnu           |
 GCC target triplet|i686-pc-linux-gnu           |
   Last reconfirmed|0000-00-00 00:00:00         |2006-04-01 00:52:54
               date|                            |
            Summary|ICE with -O3 -ftree-        |[4.1/4.2 Regression] ICE
                   |vectorize                   |with -O1 -funswitch-loops -
                   |                            |ftree-vectorize
   Target Milestone|---                         |4.1.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1/4.2 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1/4.2 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2006-04-27 10:38 -------
We ICE in rename_use_op on

  if (TREE_CODE (USE_FROM_PTR (op_p)) != SSA_NAME)
    return;

because *op_p->use is NULL and the stmt is broken:

(gdb) call debug_generic_expr(op_p->stmt)
SMT.6D.1867_40 = PHI <(13)>;

#0  0x081ed569 in rename_use_op (op_p=0xb7de40a0)
    at /space/rguenther/src/svn/trunk/gcc/tree-vectorizer.c:201
#1  0x081ed840 in rename_variables_in_bb (bb=0xb7d35a50)
    at /space/rguenther/src/svn/trunk/gcc/tree-vectorizer.c:243
#2  0x081ee0d4 in rename_variables_in_loop (loop=0x896e8f0)
    at /space/rguenther/src/svn/trunk/gcc/tree-vectorizer.c:259
#3  0x081eff18 in slpeel_tree_peel_loop_to_edge (loop=0x8961658, 
    loops=0x8948690, e=0xb7dd6820, first_niters=0xb7de3138, niters=0xb7dded68, 
    update_first_loop_count=1 '\001')
    at /space/rguenther/src/svn/trunk/gcc/tree-vectorizer.c:1135
#4  0x08203066 in vect_do_peeling_for_alignment (loop_vinfo=0x895ff18, 
    loops=0x8948690)
    at /space/rguenther/src/svn/trunk/gcc/tree-vect-transform.c:2813
#5  0x08203978 in vect_transform_loop (loop_vinfo=0x895ff18, loops=0x8948690)
    at /space/rguenther/src/svn/trunk/gcc/tree-vect-transform.c:3045
#6  0x081f29e5 in vectorize_loops (loops=0x8948690)
    at /space/rguenther/src/svn/trunk/gcc/tree-vectorizer.c:2046
#7  0x081dbdf1 in tree_vectorize ()


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1/4.2 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2006-04-27 11:05 -------
slpeel_update_phis_for_duplicate_loop does not do its job properly.  It fails
to
update the PHI nodes of at least the new loops latch block:

(gdb) call debug_bb (new_loop->latch)
;; basic block 14, loop depth 1, count 0
;; prev block 13, next block 4
;; pred:       13 [98.8%]  (dfs_back,true,exec)
;; succ:       13 [100.0%]  (fallthru,exec)
# SMT.6_40 = PHI <(13)>;
# j_41 = PHI <(13)>;
<L23>:;
goto <bb 13> (<L24>);


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1/4.2 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[mmitchel at gcc dot gnu dot org]

------- Comment #4 from mmitchel at gcc dot gnu dot org  2006-05-25 02:31 -------
Will not be fixed in 4.1.1; adjust target milestone to 4.1.2.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.1                       |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1/4.2 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[victork at il dot ibm dot com]

------- Comment #5 from victork at il dot ibm dot com  2006-06-07 20:47 -------
This happens because (vect_do_peeling_for_alignment) was designed in an
assumption that latch is empty. Thus it doesn't handle PHIs in latches.
(vect_analyze_loop_form) checks the latch is empty, but doesn't check that list
of
its PHIs is empty as too.


-- 

victork at il dot ibm dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victork at il dot ibm dot
                   |                            |com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1/4.2 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[victork at il dot ibm dot com]

------- Comment #6 from victork at il dot ibm dot com  2006-06-07 21:29 -------
patch: http://gcc.gnu.org/ml/gcc-patches/2006-06/msg00376.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1/4.2 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[patchapp at dberlin dot org]

------- Comment #7 from patchapp at dberlin dot org  2006-06-08 02:48 -------
Subject: Bug number PR tree-optimizations/26969

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-06/msg00376.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1/4.2 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[patchapp at dberlin dot org]

------- Comment #8 from patchapp at dberlin dot org  2006-08-01 11:45 -------
Subject: Bug number PR tree-optimizations/26969

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-08/msg00006.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1/4.2 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[victork at gcc dot gnu dot org]

------- Comment #9 from victork at gcc dot gnu dot org  2006-08-07 11:28 -------
Subject: Bug 26969

Author: victork
Date: Mon Aug  7 11:28:31 2006
New Revision: 115995

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=115995
Log:
ChangeLog
        PR tree-optimization/26969
        * tree-vect-analyze.c (vect_analyze_loop_form): Add check of latch
         witch an empty list of PHIs.

testsuite/Changelog:
        PR tree-optimizations/26969
        * gcc.dg/vect/vect.exp: Compile tests prefixed with
        "unswitch-loops" with -funswitch-loops.
        * gcc.dg/vect/unswitch-loops-pr26969.c: New test.


Added:
    trunk/gcc/testsuite/gcc.dg/vect/unswitch-loops-pr26969.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/vect/vect.exp
    trunk/gcc/tree-vect-analyze.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[dorit at il dot ibm dot com]

------- Comment #10 from dorit at il dot ibm dot com  2006-08-31 08:22 -------
I think this can be closed?
(I opened a missed-optimization PR instead - PR28643)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[pinskia at gcc dot gnu dot org]

------- Comment #11 from pinskia at gcc dot gnu dot org  2006-08-31 10:34 -------
(In reply to comment #10)
> I think this can be closed?
Except we still crash on the 4.1 branch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[dorit at il dot ibm dot com]

------- Comment #12 from dorit at il dot ibm dot com  2006-09-01 05:43 -------
oops - I didn't notice it was open against 4.1.
So hopefully porting Victor's patch to 4.1 would fix it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[victork at il dot ibm dot com]

------- Comment #13 from victork at il dot ibm dot com  2006-09-03 07:51 -------
this bug looks very similar to PR28839 which already have a fix in
patch http://gcc.gnu.org/ml/gcc-patches/2006-08/msg01171.html

We need to check if above patch fixes PR26969 as well.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[victork at il dot ibm dot com]

------- Comment #14 from victork at il dot ibm dot com  2006-09-11 08:16 -------
I will look if patch http://gcc.gnu.org/ml/gcc-patches/2006-08/msg01171.html
fixes this one too and will remap it to 4.1


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[irar at il dot ibm dot com]

------- Comment #15 from irar at il dot ibm dot com  2006-10-18 11:03 -------
(In reply to comment #13)
> We need to check if above patch fixes PR26969 as well.

Checked, it does not.


-- 

irar at il dot ibm dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |irar at il dot ibm dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[irar at gcc dot gnu dot org]

------- Comment #16 from irar at gcc dot gnu dot org  2006-10-19 11:18 -------
Subject: Bug 26969

Author: irar
Date: Thu Oct 19 11:18:25 2006
New Revision: 117883

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=117883
Log:
        Backport from mainline:
        2006-08-07  Victor Kaplansky <victork@il.ibm.com>

        PR tree-optimization/26969
        * tree-vect-analyze.c (vect_analyze_loop_form): Add check of latch
        with an empty list of PHIs.


Added:
    branches/gcc-4_1-branch/gcc/testsuite/gcc.dg/vect/unswitch-loops-pr26969.c
Modified:
    branches/gcc-4_1-branch/gcc/ChangeLog
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_1-branch/gcc/testsuite/gcc.dg/vect/vect.exp
    branches/gcc-4_1-branch/gcc/tree-vect-analyze.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969

[Bug tree-optimization/26969] [4.1 Regression] ICE with -O1 -funswitch-loops -ftree-vectorize

[pinskia at gcc dot gnu dot org]

------- Comment #17 from pinskia at gcc dot gnu dot org  2006-10-19 14:58 -------
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26969