public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jvdelisle at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/27954] ICE on garbage in DATA statement
Date: Fri, 20 Oct 2006 03:24:00 -0000	[thread overview]
Message-ID: <20061020032446.21856.qmail@sourceware.org> (raw)
In-Reply-To: <bug-27954-1771@http.gcc.gnu.org/bugzilla/>



------- Comment #12 from jvdelisle at gcc dot gnu dot org  2006-10-20 03:24 -------
I believe this is a duplicate of PR18923.  What I am finding is that under some
error conditions, we end up with empty symbols.  When gfc resolve is executed
we are bumping into this arror because the sym->name is equal to '\0'.  With
this patch the call to gfc_get_default_type is avoided and we get a clean exit.
 This begs the question, should these empty symbols be left to begin with. 
This "fixes" both bugs.  I have found another bug, playing with variations on
the test case that gives a similar error in gfc_typename.

Index: symbol.c
===================================================================
--- symbol.c    (revision 117876)
+++ symbol.c    (working copy)
@@ -223,6 +223,9 @@ gfc_set_default_type (gfc_symbol * sym,

   if (sym->ts.type != BT_UNKNOWN)
     gfc_internal_error ("gfc_set_default_type(): symbol already has a type");
+
+  if (*sym->name == '\0')
+    return FAILURE;

   ts = gfc_get_default_type (sym, ns);


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27954


  parent reply	other threads:[~2006-10-20  3:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-08 11:00 [Bug fortran/27954] New: " reichelt at gcc dot gnu dot org
2006-06-12  0:14 ` [Bug fortran/27954] " kargl at gcc dot gnu dot org
2006-06-12 12:51 ` reichelt at gcc dot gnu dot org
2006-06-12 14:41 ` kargl at gcc dot gnu dot org
2006-06-12 15:34 ` reichelt at gcc dot gnu dot org
2006-06-12 23:07 ` sgk at troutmask dot apl dot washington dot edu
2006-06-13  0:10 ` reichelt at gcc dot gnu dot org
2006-06-13  0:56 ` sgk at troutmask dot apl dot washington dot edu
2006-06-13  1:56 ` sgk at troutmask dot apl dot washington dot edu
2006-06-16  2:33 ` reichelt at gcc dot gnu dot org
2006-09-11  1:34 ` jvdelisle at gcc dot gnu dot org
2006-09-11  1:40 ` jvdelisle at gcc dot gnu dot org
2006-10-20  3:24 ` jvdelisle at gcc dot gnu dot org [this message]
2006-10-20  3:26 ` jvdelisle at gcc dot gnu dot org
2006-10-20  3:54 ` jvdelisle at gcc dot gnu dot org
2006-10-20  4:50 ` pault at gcc dot gnu dot org
2006-10-20  9:20 ` pault at gcc dot gnu dot org
2006-10-20 14:28 ` jvdelisle at gcc dot gnu dot org
2006-10-20 14:33 ` jvdelisle at gcc dot gnu dot org
2006-10-20 14:35 ` pault at gcc dot gnu dot org
2006-10-20 16:25 ` jvdelisle at gcc dot gnu dot org
2006-10-27 20:47 ` jvdelisle at gcc dot gnu dot org
2006-10-27 20:55 ` jvdelisle at gcc dot gnu dot org
2006-10-27 20:59 ` jvdelisle at gcc dot gnu dot org
2007-02-04 20:11 ` jvdelisle at gcc dot gnu dot org
2007-09-25 10:26 ` jakub at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061020032446.21856.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).