public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/28909] New: Missed optimization with x86 sync builtins
@ 2006-08-30 21:06 nmiell at comcast dot net
2006-08-31 3:13 ` [Bug target/28909] " pinskia at gcc dot gnu dot org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: nmiell at comcast dot net @ 2006-08-30 21:06 UTC (permalink / raw)
To: gcc-bugs
"(void) __sync_fetch_and_add(d, 1)" and variations on that theme (i.e. the sync
sub builtins and -1/1) should be generating "lock inc" and "lock dec" instead
of "lock add" and "lock sub"
--
Summary: Missed optimization with x86 sync builtins
Product: gcc
Version: unknown
Status: UNCONFIRMED
Severity: minor
Priority: P3
Component: target
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: nmiell at comcast dot net
GCC target triplet: i?86-*-*
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28909
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/28909] Missed optimization with x86 sync builtins
2006-08-30 21:06 [Bug target/28909] New: Missed optimization with x86 sync builtins nmiell at comcast dot net
@ 2006-08-31 3:13 ` pinskia at gcc dot gnu dot org
2006-09-01 10:18 ` uros at kss-loka dot si
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-08-31 3:13 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from pinskia at gcc dot gnu dot org 2006-08-31 03:13 -------
Confirmed, the special casing for inc/dec should be added to the sync_add
patterns also.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|minor |enhancement
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Keywords| |missed-optimization
Last reconfirmed|0000-00-00 00:00:00 |2006-08-31 03:13:03
date| |
Version|unknown |4.1.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28909
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/28909] Missed optimization with x86 sync builtins
2006-08-30 21:06 [Bug target/28909] New: Missed optimization with x86 sync builtins nmiell at comcast dot net
2006-08-31 3:13 ` [Bug target/28909] " pinskia at gcc dot gnu dot org
@ 2006-09-01 10:18 ` uros at kss-loka dot si
2006-09-01 15:45 ` patchapp at dberlin dot org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: uros at kss-loka dot si @ 2006-09-01 10:18 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from uros at kss-loka dot si 2006-09-01 10:18 -------
Patch at http://gcc.gnu.org/ml/gcc-patches/2006-09/msg00010.html
--
uros at kss-loka dot si changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |uros at kss-loka dot si
|dot org |
URL| |http://gcc.gnu.org/ml/gcc-
| |patches/2006-
| |09/msg00010.html
Status|NEW |ASSIGNED
Last reconfirmed|2006-08-31 03:13:03 |2006-09-01 10:18:03
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28909
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/28909] Missed optimization with x86 sync builtins
2006-08-30 21:06 [Bug target/28909] New: Missed optimization with x86 sync builtins nmiell at comcast dot net
2006-08-31 3:13 ` [Bug target/28909] " pinskia at gcc dot gnu dot org
2006-09-01 10:18 ` uros at kss-loka dot si
@ 2006-09-01 15:45 ` patchapp at dberlin dot org
2006-10-25 10:15 ` uros at gcc dot gnu dot org
2006-10-26 12:54 ` pinskia at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: patchapp at dberlin dot org @ 2006-09-01 15:45 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from patchapp at dberlin dot org 2006-09-01 15:45 -------
Subject: Bug number PR target/28909
A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-09/msg00010.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28909
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/28909] Missed optimization with x86 sync builtins
2006-08-30 21:06 [Bug target/28909] New: Missed optimization with x86 sync builtins nmiell at comcast dot net
` (2 preceding siblings ...)
2006-09-01 15:45 ` patchapp at dberlin dot org
@ 2006-10-25 10:15 ` uros at gcc dot gnu dot org
2006-10-26 12:54 ` pinskia at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: uros at gcc dot gnu dot org @ 2006-10-25 10:15 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from uros at gcc dot gnu dot org 2006-10-25 10:14 -------
Subject: Bug 28909
Author: uros
Date: Wed Oct 25 10:14:41 2006
New Revision: 118028
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=118028
Log:
PR target/28909
* config/i386/sync.md ("sync_add<mode>", "sync_sub<mode>"):
Use inc and dec instructions for TARGET_USE_INCDEC.
("*sync_compare_and_swap<mode>"): Fix -masm=intel template.
("sync_double_compare_and_swap<mode>"): Likewise.
("*sync_double_compare_and_swapdi_pic"): Likewise.
("*sync_compare_and_swap_cc<mode>"): Likewise.
("sync_double_compare_and_swap_cc<mode>"): Likewise.
("*sync_double_compare_and_swap_ccdi_pic"): Likewise.
("sync_old_add<mode>"): Likewise.
("sync_lock_test_and_set<mode>"): Likewise.
("sync_lock_test_and_set<mode>"): Likewise.
("sync_add<mode>"): Likewise.
("sync_sub<mode>"): Likewise.
("sync_ior<mode>"): Likewise.
("sync_and<mode>"): Likewise.
("sync_xor<mode>"): Likewise.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/i386/sync.md
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28909
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/28909] Missed optimization with x86 sync builtins
2006-08-30 21:06 [Bug target/28909] New: Missed optimization with x86 sync builtins nmiell at comcast dot net
` (3 preceding siblings ...)
2006-10-25 10:15 ` uros at gcc dot gnu dot org
@ 2006-10-26 12:54 ` pinskia at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-10-26 12:54 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from pinskia at gcc dot gnu dot org 2006-10-26 12:54 -------
Fixed.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
Target Milestone|--- |4.3.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28909
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-10-26 12:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-08-30 21:06 [Bug target/28909] New: Missed optimization with x86 sync builtins nmiell at comcast dot net
2006-08-31 3:13 ` [Bug target/28909] " pinskia at gcc dot gnu dot org
2006-09-01 10:18 ` uros at kss-loka dot si
2006-09-01 15:45 ` patchapp at dberlin dot org
2006-10-25 10:15 ` uros at gcc dot gnu dot org
2006-10-26 12:54 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).