[Bug fortran/29537] New: ICE in gfc_match_common

[Bug fortran/29537] New: ICE in gfc_match_common

[aldot at gcc dot gnu dot org]

$ cat foo.f90 
! { dg-compile }
! { dg-options "-W -Wall" }

type a_t
  sequence
  integer i
end type a_t

block data bd
  sequence
  common c
  type c_t
    sequence
    integer i
  end type c_t
end block data bd

common /a_t/ c
end
$ gfortran-4.1 --version
GNU Fortran 95 (GCC) 4.1.2 20060901 (prerelease) (Debian 4.1.1-13)
$ gfortran-4.1 -S -o foo.s foo.f90 
 In file foo.f90:9

block data bd
            1
Error: Unexpected BLOCK DATA statement at (1)
 In file foo.f90:10

  sequence
         1
Error: Unexpected SEQUENCE statement at (1)
 In file foo.f90:11

  common c
         1
Error: Unexpected COMMON statement at (1)
 In file foo.f90:12

  type c_t
         1
Error: Unexpected derived type declaration statement at (1)
 In file foo.f90:13

    sequence
           1
Error: Unexpected SEQUENCE statement at (1)
 In file foo.f90:14

    integer i
            1
Error: Unexpected data declaration statement at (1)
 In file foo.f90:15

  end type c_t
    1
Error: Expecting END PROGRAM statement at (1)
 In file foo.f90:16

end block data bd
  1
Error: Expecting END PROGRAM statement at (1)
foo.f90:0: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.
For Debian GNU/Linux specific bug reporting instructions,
see <URL:file:///usr/share/doc/gcc-4.1/README.Bugs>.


With trunk from 20061018
this gives:

Program received signal SIGSEGV, Segmentation fault.
0x08078b1a in gfc_match_common ()
    at ../../../src/gcc-4.2.orig/gcc/fortran/match.c:2299
2299          while (old_blank_common->common_next)
(gdb) bt
#0  0x08078b1a in gfc_match_common ()
    at ../../../src/gcc-4.2.orig/gcc/fortran/match.c:2299
#1  0x08083489 in match_word (
    str=0x6e656d65 <Address 0x6e656d65 out of bounds>, 
    subr=0x8078af7 <gfc_match_common>, old_locus=0xafcfc614)
    at ../../../src/gcc-4.2.orig/gcc/fortran/parse.c:65
#2  0x0808402e in decode_statement ()
    at ../../../src/gcc-4.2.orig/gcc/fortran/parse.c:193
#3  0x0808439b in next_statement ()
    at ../../../src/gcc-4.2.orig/gcc/fortran/parse.c:493
#4  0x0808630a in parse_progunit (st=<value optimized out>)
    at ../../../src/gcc-4.2.orig/gcc/fortran/parse.c:2910
#5  0x0808675b in gfc_parse_file ()
    at ../../../src/gcc-4.2.orig/gcc/fortran/parse.c:3206
#6  0x080a5b29 in gfc_be_parse_file (set_yydebug=0)
    at ../../../src/gcc-4.2.orig/gcc/fortran/f95-lang.c:303
#7  0x082f542d in toplev_main (argc=13, argv=0xafcfc7f4)
    at ../../../src/gcc-4.2.orig/gcc/toplev.c:1033
#8  0x080cfc26 in main (argc=1630478446, argv=0x202f745f)
    at ../../../src/gcc-4.2.orig/gcc/main.c:35


-- 
           Summary: ICE in gfc_match_common
           Product: gcc
           Version: 4.1.2
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code
          Severity: minor
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: aldot at gcc dot gnu dot org
 GCC build triplet: i686-linux-gnu
  GCC host triplet: i686-linux-gnu
GCC target triplet: i686-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537

[Bug fortran/29537] ICE in gfc_match_common

[aldot at gcc dot gnu dot org]

------- Comment #1 from aldot at gcc dot gnu dot org  2006-10-21 17:42 -------
Shorter testcase:
$ egrep -v "(^\!|^$)" foo2.f90
block data
  common c
end


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537

[Bug fortran/29537] ICE in gfc_match_common

[aldot at gcc dot gnu dot org]

------- Comment #2 from aldot at gcc dot gnu dot org  2006-10-21 18:04 -------
(In reply to comment #1)
> Shorter testcase:
> $ egrep -v "(^\!|^$)" foo2.f90
> block data
>   common c
> end
> 
According to lahey's checker, this code is valid. Still it ICEs


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537

[Bug fortran/29537] ICE in gfc_match_common

[aldot at gcc dot gnu dot org]

------- Comment #3 from aldot at gcc dot gnu dot org  2006-10-21 18:05 -------
(In reply to comment #2)
> (In reply to comment #1)
> > Shorter testcase:
> > $ egrep -v "(^\!|^$)" foo2.f90
> > block data
> >   common c
> > end
> > 
> According to lahey's checker, this code is valid. Still it ICEs

Program received signal SIGSEGV, Segmentation fault.
0x080b0982 in gfc_trans_common (ns=0x85e2f20)
    at ../../../src/gcc-4.2/gcc/fortran/trans-common.c:1059
1059          c->where = ns->proc_name->declared_at;
(gdb) bt
#0  0x080b0982 in gfc_trans_common (ns=0x85e2f20)
    at ../../../src/gcc-4.2/gcc/fortran/trans-common.c:1059
#1  0x080b15a4 in gfc_generate_block_data (ns=0x85e2f20)
    at ../../../src/gcc-4.2/gcc/fortran/trans-decl.c:3316
#2  0x08086b25 in gfc_parse_file ()
    at ../../../src/gcc-4.2/gcc/fortran/parse.c:3237
#3  0x080a5db9 in gfc_be_parse_file (set_yydebug=0)
    at ../../../src/gcc-4.2/gcc/fortran/f95-lang.c:303
#4  0x082f5d6d in toplev_main (argc=15, argv=0xaffe1ad4)
    at ../../../src/gcc-4.2/gcc/toplev.c:1033
#5  0x080cffe6 in main (argc=Cannot access memory at address 0x0
) at ../../../src/gcc-4.2/gcc/main.c:35


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537

[Bug fortran/29537] ICE in gfc_match_common

[aldot at gcc dot gnu dot org]

-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|ice-on-invalid-code         |
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537

[Bug fortran/29537] ICE in gfc_match_common

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal
   Target Milestone|4.2.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537

[Bug fortran/29537] ICE in gfc_match_common

[kargl at gcc dot gnu dot org]

------- Comment #4 from kargl at gcc dot gnu dot org  2006-10-21 22:04 -------
First, I agree there is a bug because gfortran should not have an
ICE.  However, I believe the code is invalid.  The Fortran 95
standard specifically mentions "named common blocks" in the 
description of "block data".  "common c" is a blank common block.


-- 

kargl at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kargl at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537

[Bug fortran/29537] ICE in gfc_match_common for blank common in BLOCK DATA unit

[aldot at gcc dot gnu dot org]

------- Comment #5 from aldot at gcc dot gnu dot org  2006-10-22 11:36 -------
I think the code in comment #1 is valid.

f95, 5.5.2.4 Differences between named common and blank common
reads:
A blank common block has the same properties as a named common block except
(iii) [...] objects in blank common shall not be initially defined.


11.8 defines BLOCK DATA as

block-data-stmt
  [specification-part]
end-block-data-stmt

where [specification-part] lists no further constrained (wrt blank common).
blank-common imposed constraints seem to include
- 5.1 Type decl stmts: [initialization] shall not appear if obj-name is [...]
an object in blank common


So i don't really see why the testcase in Comment #1 is invalid.

I do, however, consider the snippet below to be invalid (initialization seems
forbidden by the above):
 Block data "__BLKDT__"
  (line-no.)(nest)
          1        block data
          2          common c
          3          data c /1/
          4        end !block data

 Diagnostic messages: program name(__BLKDT__)
   8657-W: "SOURCE.F90", line 3: Element 'c' of blank common block cannot be
initialized.

 Procedure information
   Lines      : 4
   Statements : 4

 Scoping unit of blockdata : __BLKDT__
   Attribute and Cross reference of name
     c
      |(Class and Type) : variable name, REAL(4)-implicit
      |(Attributes)     : common-block-object, initialized
      |(Declaration)    : 2  3
      |(Definition)     : 
      |(Reference)      : 


-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
            Summary|ICE in gfc_match_common     |ICE in gfc_match_common for
                   |                            |blank common in BLOCK DATA
                   |                            |unit


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537

[Bug fortran/29537] ICE in gfc_match_common for blank common in BLOCK DATA unit

[aldot at gcc dot gnu dot org]

------- Comment #6 from aldot at gcc dot gnu dot org  2006-10-22 11:50 -------
> I think the code in comment #1 is valid.

Rejecting blank common in block data stmts would add a regression in
testsuite's blockdata_1.f90 like so:
me@s37:~/src/gcc-4.2/gcc/testsuite/gfortran.dg$ gfortran-4.2-HEAD -S -o foo.s
-W -Wall blockdata_1.f90 
 In file blockdata_1.f90:17

 common j
      1
Error: BLOCK DATA unit cannot contain blank COMMON at (1)
 In file blockdata_1.f90:18

 data j /1/
      1
Error: BLOCK DATA element 'j' at (1) must be in COMMON

So rejecting the blank common must be wrong, fwiw :)
--- match.c     (revision 117934)
+++ match.c     (working copy)
@@ -2327,16 +2328,20 @@ gfc_match_common (void)

       if (name[0] == '\0')
        {
+         if (gfc_current_ns->is_block_data)
+           {
+             gfc_error ("BLOCK DATA unit cannot contain blank COMMON at %C");
+             goto cleanup;
+           }
          t = &gfc_current_ns->blank_common;
          if (t->head == NULL)
            t->where = gfc_current_locus;
-         head = &t->head;
        }
       else
        {
          t = gfc_get_common (name, 0);
-         head = &t->head;
        }
+      head = &t->head;

       if (*head == NULL)
        tail = NULL;


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537

[Bug fortran/29537] ICE in gfc_match_common for blank common in BLOCK DATA unit

[sgk at troutmask dot apl dot washington dot edu]

------- Comment #7 from sgk at troutmask dot apl dot washington dot edu  2006-10-22 15:00 -------
Subject: Re:  ICE in gfc_match_common for blank common in BLOCK DATA unit

On Sun, Oct 22, 2006 at 11:36:15AM -0000, aldot at gcc dot gnu dot org wrote:
> 
> ------- Comment #5 from aldot at gcc dot gnu dot org  2006-10-22 11:36 -------
> I think the code in comment #1 is valid.
> 
> f95, 5.5.2.4 Differences between named common and blank common
> reads:
> A blank common block has the same properties as a named common block except
> (iii) [...] objects in blank common shall not be initially defined.
> 
> 
> 11.8 defines BLOCK DATA as
> 
> block-data-stmt
>   [specification-part]
> end-block-data-stmt
> 
> where [specification-part] lists no further constrained (wrt blank common).
> blank-common imposed constraints seem to include
> - 5.1 Type decl stmts: [initialization] shall not appear if obj-name is [...]
> an object in blank common
> 

You're reading the wrong standard.  The final committe draft of
Fortran 95 states:

11.4    Block data program units
   A block data program unit is used to provide initial values for
   data objects in named common blocks.

I'll note that NAG's compiler only issues a warning.

laptop:kargl[212] cat l.f90
block data a
  common c
end block data a
laptop:kargl[213] f95 -c l.f90
Warning: l.f90, line 2: Blank common appears in BLOCK DATA A

If F2003 removes the "named" modifier from common blocks in 
its discussion on block data, then gfortran should probably
implement the F2003 behavior with the caveat that -std=f95
should issue a warning.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537

[Bug fortran/29537] ICE in gfc_match_common for blank common in BLOCK DATA unit

[aldot at gcc dot gnu dot org]

------- Comment #8 from aldot at gcc dot gnu dot org  2006-10-22 21:08 -------
Created an attachment (id=12476)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12476&action=view)
untested proposed fix

I hope to test this patch soon.

Note that it adds a warning about blank common in block data but -- unlike the
patch in the previous comment -- does accept the common instead of abandoning
it via goto cleanup. Please advise if not cleaning this up is acceptable or if
blank commons should be ignored there.

fortran/ChangeLog:
2006-10-22  Bernhard Fischer  <aldot@gcc.gnu.org>

        PR fortran/29537
        * trans-common.c (gfc_trans_common): For unnamed block data the
        proc_name is null, so use the locus of the common.
        (gfc_sym_mangled_common_id): Fix whitespace.
        * match.c (gfc_match_common): Emit warning about blank common in
        block data.

testsuite/ChangeLog:
2006-10-22  Bernhard Fischer  <aldot@gcc.gnu.org>

        PR fortran/29537
        * blockdata_1.f90: Add warning about blank common in block data.
        * blockdata_2.f90: New testcase.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537

[Bug fortran/29537] ICE in gfc_match_common for blank common in BLOCK DATA unit

[aldot at gcc dot gnu dot org]

------- Comment #9 from aldot at gcc dot gnu dot org  2006-10-26 12:59 -------
(In reply to comment #8)
> Created an attachment (id=12476)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12476&action=view) [edit]
> untested proposed fix
> 
> I hope to test this patch soon.

bootstrapped and regtested with no additional regression on i686-linux-gnu.
> 
> Note that it adds a warning about blank common in block data but -- unlike the
> patch in the previous comment -- does accept the common instead of abandoning
> it via goto cleanup. Please advise if not cleaning this up is acceptable or if
> blank commons should be ignored there.

The symbol needs to be retained, AFAIU.
With the proposed patch, we have:
$ nm blockdata_2.o
00000004 C __BLNK__
00000000 B __BLOCK_DATA__
         U _gfortran_set_std
00000000 T MAIN__

> 
> fortran/ChangeLog:
> 2006-10-22  Bernhard Fischer  <aldot@gcc.gnu.org>
> 
>         PR fortran/29537
>        * trans-common.c (gfc_trans_common): For unnamed block data the
>        proc_name is null, so use the locus of the common.
>        (gfc_sym_mangled_common_id): Fix whitespace.
>         * match.c (gfc_match_common): Emit warning about blank common in
>         block data.

Rephrasing to
        * trans-common.c (gfc_trans_common): If the blank common is 
        in a procedure or program without a name then proc_name is null, so use
        the locus of the common.

> testsuite/ChangeLog:
> 2006-10-22  Bernhard Fischer  <aldot@gcc.gnu.org>
> 
>         PR fortran/29537
>         * blockdata_1.f90: Add warning about blank common in block data.
>         * blockdata_2.f90: New testcase.
> 


-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537

[Bug fortran/29537] ICE in gfc_match_common for blank common in BLOCK DATA unit

[sgk at troutmask dot apl dot washington dot edu]

------- Comment #10 from sgk at troutmask dot apl dot washington dot edu  2006-10-28 23:56 -------
Subject: Re:  ICE in gfc_match_common for blank common in BLOCK DATA unit

On Sun, Oct 22, 2006 at 09:08:02PM -0000, aldot at gcc dot gnu dot org wrote:
> 
> Created an attachment (id=12476)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12476&action=view)
>  --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12476&action=view)
> untested proposed fix
> 
> I hope to test this patch soon.
> 
> Note that it adds a warning about blank common in block data but -- unlike the
> patch in the previous comment -- does accept the common instead of abandoning
> it via goto cleanup. Please advise if not cleaning this up is acceptable or if
> blank commons should be ignored there.
> 
> fortran/ChangeLog:
> 2006-10-22  Bernhard Fischer  <aldot@gcc.gnu.org>
> 
>         PR fortran/29537
>         * trans-common.c (gfc_trans_common): For unnamed block data the
>         proc_name is null, so use the locus of the common.
>         (gfc_sym_mangled_common_id): Fix whitespace.
>         * match.c (gfc_match_common): Emit warning about blank common in
>         block data.
> 
> testsuite/ChangeLog:
> 2006-10-22  Bernhard Fischer  <aldot@gcc.gnu.org>
> 
>         PR fortran/29537
>         * blockdata_1.f90: Add warning about blank common in block data.
>         * blockdata_2.f90: New testcase.
> 
> 

Bernhard, 

This is ok for trunk.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537

[Bug fortran/29537] ICE in gfc_match_common for blank common in BLOCK DATA unit

[aldot at gcc dot gnu dot org]

------- Comment #11 from aldot at gcc dot gnu dot org  2006-10-31 23:39 -------
Subject: Bug 29537

Author: aldot
Date: Tue Oct 31 23:38:58 2006
New Revision: 118347

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=118347
Log:
fortran/ChangeLog:
2006-11-01  Bernhard Fischer  <aldot@gcc.gnu.org>

        PR fortran/29537
        * trans-common.c (gfc_trans_common): If the blank common is
        in a procedure or program without a name then proc_name is null, so use
        the locus of the common.
        (gfc_sym_mangled_common_id): Fix whitespace.
        * match.c (gfc_match_common): Emit warning about blank common in
        block data.

testsuite/ChangeLog:
2006-11-01  Bernhard Fischer  <aldot@gcc.gnu.org>

        PR fortran/29537
        * gfortran.dg/blockdata_1.f90: Add warning about blank common in block
        data.
        * gfortran.dg/blockdata_2.f90: New testcase.


Added:
    trunk/gcc/testsuite/gfortran.dg/blockdata_2.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/match.c
    trunk/gcc/fortran/trans-common.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/blockdata_1.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537

[Bug fortran/29537] ICE in gfc_match_common for blank common in BLOCK DATA unit

[aldot at gcc dot gnu dot org]

------- Comment #12 from aldot at gcc dot gnu dot org  2006-10-31 23:42 -------
(In reply to comment #10)

> Bernhard, 
> 
> This is ok for trunk.

Thanks. Worth backporting this to 4.2 (and 4.1) in a week or two? 


-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |aldot at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-10-31 23:42:41
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537

[Bug fortran/29537] ICE in gfc_match_common for blank common in BLOCK DATA unit

[sgk at troutmask dot apl dot washington dot edu]

------- Comment #13 from sgk at troutmask dot apl dot washington dot edu  2006-10-31 23:47 -------
Subject: Re:  ICE in gfc_match_common for blank common in BLOCK DATA unit

On Tue, Oct 31, 2006 at 11:42:42PM -0000, aldot at gcc dot gnu dot org wrote:
> 
> > Bernhard, 
> > 
> > This is ok for trunk.
> 
> Thanks. Worth backporting this to 4.2 (and 4.1) in a week or two? 
> 

Sure.  If you're willing to spend the time and effort to 
regression test the patch.  However, I fear 4.1 is going to
become like 4.0.x.  Too few people too many branches. 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537

[Bug fortran/29537] ICE in gfc_match_common for blank common in BLOCK DATA unit

[aldot at gcc dot gnu dot org]

------- Comment #14 from aldot at gcc dot gnu dot org  2006-11-01 19:30 -------
Fixed on trunk.


-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537

[Bug fortran/29537] ICE in gfc_match_common for blank common in BLOCK DATA unit

[chaoyingfu at gcc dot gnu dot org]

------- Comment #15 from chaoyingfu at gcc dot gnu dot org  2006-11-30 19:25 -------
Subject: Bug 29537

Author: chaoyingfu
Date: Thu Nov 30 19:24:37 2006
New Revision: 119373

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=119373
Log:
Merged revisions 118337-118377 via svnmerge from 
svn+ssh://chaoyingfu@sources.redhat.com/svn/gcc/trunk

........
  r118337 | charlet | 2006-10-31 12:11:46 -0800 (Tue, 31 Oct 2006) | 2 lines

  Resync.
........
  r118338 | fxcoudert | 2006-10-31 12:15:22 -0800 (Tue, 31 Oct 2006) | 12 lines

        PR fortran/29067

        * decl.c (gfc_set_constant_character_len): NULL-terminate the
        character constant string.
        * data.c (create_character_intializer): Likewise.
        * expr.c (gfc_simplify_expr): NULL-terminate the substring
        character constant.
        * primary.c (match_hollerith_constant): NULL-terminate the
        character constant string.

        * gfortran.dg/pr29067.f: New test.
........
  r118339 | fxcoudert | 2006-10-31 12:17:11 -0800 (Tue, 31 Oct 2006) | 2 lines

        * ChangeLog: Forgotten ChangeLog entry for previous commit.
........
  r118340 | charlet | 2006-10-31 12:43:39 -0800 (Tue, 31 Oct 2006) | 2 lines

  Fix typo.
........
  r118341 | tkoenig | 2006-10-31 12:58:26 -0800 (Tue, 31 Oct 2006) | 18 lines

  2006-10-31  Thomas Koenig  <Thomas.Koenig@online.de>

        PR libfortran/29627
        * libgfortran.h: Add ERROR_SHORT_RECORD
        * runtime/error.c (translate_error): Add case
        for ERROR_SHORT_RECORD.
        * io/transfer.c (read_block_direct):  Separate codepaths
        for stream and record unformatted I/O.  Remove unneeded
        tests for standard input, padding and formatted I/O.
        If the record is short, read in as much data as possible,
        then raise the error.

  2006-10-31  Thomas Koenig  <Thomas.Koenig@online.de>

        PR libfortran/29627
        * gfortran.dg/unf_short_record_1.f90:  New test.
........
  r118343 | sje | 2006-10-31 14:28:18 -0800 (Tue, 31 Oct 2006) | 4 lines

        * inclhack.def (hpux11_extern_sendfile): New.
        (hpux11_extern_sendpath): New.
        * fixincl.x: Regenerate.
........
  r118344 | ebotcazou | 2006-10-31 15:29:06 -0800 (Tue, 31 Oct 2006) | 3 lines

          * gcc.c-torture/execute/20061031-1.c: New test.
........
  r118347 | aldot | 2006-10-31 15:38:58 -0800 (Tue, 31 Oct 2006) | 20 lines

  fortran/ChangeLog:
  2006-11-01  Bernhard Fischer  <aldot@gcc.gnu.org>

          PR fortran/29537
          * trans-common.c (gfc_trans_common): If the blank common is
          in a procedure or program without a name then proc_name is null, so
use
          the locus of the common.
          (gfc_sym_mangled_common_id): Fix whitespace.
          * match.c (gfc_match_common): Emit warning about blank common in
          block data.

  testsuite/ChangeLog:
  2006-11-01  Bernhard Fischer  <aldot@gcc.gnu.org>

          PR fortran/29537
          * gfortran.dg/blockdata_1.f90: Add warning about blank common in
block
        data.
          * gfortran.dg/blockdata_2.f90: New testcase.
........
  r118353 | gccadmin | 2006-10-31 16:17:53 -0800 (Tue, 31 Oct 2006) | 1 line

  Daily bump.
........
  r118355 | sayle | 2006-10-31 18:56:45 -0800 (Tue, 31 Oct 2006) | 10 lines


        PR middle-end/23470
        * tree.h (tree_expr_nonnegative_p): Return "bool" instead of "int".
        * fold-const.c (tree_expr_nonnegative_p): Likewise.  Consider
        pow(x,y) and powi(x,y) to be nonnegative if either x is nonnegative
        or y is an even integer.

        * gcc.dg/pr23470-1.c: New test case.
........
  r118356 | geoffk | 2006-10-31 20:47:30 -0800 (Tue, 31 Oct 2006) | 27 lines

        * c-decl.c (grokdeclarator): Don't set DECL_EXTERNAL on
        inline static functions in c99 mode.

        PR 16622
        * doc/extend.texi (Inline): Update.
        * c-tree.h (struct language_function): Remove field 'extern_inline'.
        * c-decl.c (current_extern_inline): Delete.
        (pop_scope): Adjust test for an undefined nested function.
        Add warning about undeclared inline function.
        (diagnose_mismatched_decls): Update comments.  Disallow overriding
        of inline functions in a translation unit in C99.  Allow inline
        declarations in C99 at any time.
        (merge_decls): Boolize variables.  Handle C99 'extern inline'
        semantics.
        (grokdeclarator): Set DECL_EXTERNAL here for functions.  Handle
        C99 inline semantics.
        (start_function): Don't clear current_extern_inline.  Don't set
        DECL_EXTERNAL.
        (c_push_function_context): Don't push current_extern_inline.
        (c_pop_function_context): Don't restore current_extern_inline.

        PR 11377
        * c-typeck.c (build_external_ref): Warn about static variables
        used in extern inline functions.
        * c-decl.c (start_decl): Warn about static variables declared
        in extern inline functions.
........
  r118357 | geoffk | 2006-10-31 20:48:15 -0800 (Tue, 31 Oct 2006) | 27 lines

        * c-decl.c (grokdeclarator): Don't set DECL_EXTERNAL on
        inline static functions in c99 mode.

        PR 16622
        * doc/extend.texi (Inline): Update.
        * c-tree.h (struct language_function): Remove field 'extern_inline'.
        * c-decl.c (current_extern_inline): Delete.
        (pop_scope): Adjust test for an undefined nested function.
        Add warning about undeclared inline function.
        (diagnose_mismatched_decls): Update comments.  Disallow overriding
        of inline functions in a translation unit in C99.  Allow inline
        declarations in C99 at any time.
        (merge_decls): Boolize variables.  Handle C99 'extern inline'
        semantics.
        (grokdeclarator): Set DECL_EXTERNAL here for functions.  Handle
        C99 inline semantics.
        (start_function): Don't clear current_extern_inline.  Don't set
        DECL_EXTERNAL.
        (c_push_function_context): Don't push current_extern_inline.
        (c_pop_function_context): Don't restore current_extern_inline.

        PR 11377
        * c-typeck.c (build_external_ref): Warn about static variables
        used in extern inline functions.
        * c-decl.c (start_decl): Warn about static variables declared
        in extern inline functions.
........
  r118358 | geoffk | 2006-10-31 20:53:33 -0800 (Tue, 31 Oct 2006) | 3 lines

        PR 15834
        * config/darwin.h (NO_IMPLICIT_EXTERN_C): Define.
........
  r118359 | geoffk | 2006-10-31 20:55:19 -0800 (Tue, 31 Oct 2006) | 7 lines

        * config/i386/darwin.h (PREFERRED_DEBUGGING_TYPE): Remove.
        * config/darwin.h (PREFERRED_DEBUGGING_TYPE): Set to DWARF2_DEBUG.

        * config/darwin.h (LINK_COMMAND_SPEC): Don't do weird things with -@.
        Call dsymutil when compiling and linking one or more source files
        in one step.
........
  r118360 | geoffk | 2006-10-31 21:06:12 -0800 (Tue, 31 Oct 2006) | 23 lines

  In gcc/:
        * coverage.c (coverage_checksum_string): Update comment.
        * dwarf2out.c (switch_to_eh_frame_section): Update for removal
        of get_file_function_name.
        * cgraphunit.c (cgraph_build_static_cdtor): Update for rename
        of get_file_function_name_long.
        * tree.c (get_file_function_name): Rename from
        get_file_function_name_long; improve comment; handle 'I' and 'D'
        specially when the target has ctor/dtor support; remove special
        handling for 'F'.
        (get_file_function_name): Remove.
        * tree.h (get_file_function_name): Rename from
          get_file_function_name_long.
        (get_file_function_name): Remove prototype.
  In gcc/cp/:
        * name-lookup.c (get_anonymous_namespace_name): New.
        (push_namespace_with_attribs): Use get_anonymous_namespace_name.
        * decl2.c (start_objects): Update for rename of
        get_file_function_name_long.
  In gcc/fortran/:
        * trans-decl.c (gfc_generate_constructors): Update for removal
        of get_file_function_name.
........
  r118361 | geoffk | 2006-10-31 21:14:40 -0800 (Tue, 31 Oct 2006) | 49 lines

  2006-09-07  Eric Christopher  <echristo@apple.com>
            Falk Hueffner  <falk@debian.org>

        * doc/extend.texi (__builtin_bswap32): Document.
        (__builtin_bswap64): Ditto.
        * doc/libgcc.texi (bswapsi2): Document.
        (bswapdi2): Ditto.
        * doc/rtl.texi (bswap): Document.
        * optabs.c (expand_unop): Don't widen a bswap.
        (init_optabs): Init bswap. Set libfuncs explicitly
        for bswapsi2 and bswapdi2.
        * optabs.h (OTI_bswap): New.
        (bswap_optab): Ditto.
        * genopinit.c (optabs): Handle bswap_optab.
        * tree.h (tree_index): Add TI_UINT32_TYPE and
        TI_UINT64_TYPE.
        (uint32_type_node): New.
        (uint64_type_node): Ditto.
        * tree.c (build_common_tree_nodes_2): Initialize
        uint32_type_node and uint64_type_node.
        * builtins.c (expand_builtin_bswap): New.
        (expand_builtin): Call.
        (fold_builtin_bswap): New.
        (fold_builtin_1): Call.
        * fold-const.c (tree_expr_nonnegative_p): Return true
        for bswap.
        * builtin-types.def (BT_UINT32): New.
        (BT_UINT64): Ditto.
        (BT_FN_UINT32_UINT32): Ditto.
        (BT_FN_UINT64_UINT64): Ditto.
        * builtins.def (BUILT_IN_BSWAP32): New.
        (BUILT_IN_BSWAP64): Ditto.
        * rtl.def (BSWAP): New.
        * genattrtab.c (check_attr_value): New.
        * libgcc2.c (__bswapSI2): New.
        (__bswapDI2): Ditto.
        * libgcc2.h (__bswapSI2): Declare.
        (__bswapDI2): Ditto.
        * mklibgcc.in (lib2funcs): Add _bswapsi2 and _bswapdi2.
        * simplify-rtx.c (simplify_const_unary_operation): Return
        0 for BSWAP.
        * libgcc-std.ver (__bwapsi2): Add.
        (__bswapdi2): Ditto.
        * reload1.c (eliminate_regs_1): Add bswap.
        (elimination_effects): Ditto.
        * config/i386/i386.h (x86_bswap): New.
        (TARGET_BSWAP): Use.
        * config/i386/i386.c (x86_bswap): Set.
........
  r118362 | geoffk | 2006-10-31 21:16:14 -0800 (Tue, 31 Oct 2006) | 12 lines

  In gcc/:
        * toplev.c (compile_file): Call final_write_globals
        even if there have been errors.
  In gcc/cp/:
        * decl2.c (cp_write_global_declarations): Rename from
        cp_finish_file.
        * cp-lang.c (finish_file): Don't call cp_finish_file.
        * cp-tree.h (cp_write_global_declarations): Rename from
        cp_finish_file.
        * cp-objcp-common.h (LANG_HOOKS_WRITE_GLOBALS): Define to
        cp_write_global_declarations.
........
  r118363 | geoffk | 2006-10-31 21:17:14 -0800 (Tue, 31 Oct 2006) | 1 line

  Add missing genopinit.c change for revision 118361.
........
  r118364 | geoffk | 2006-10-31 21:20:05 -0800 (Tue, 31 Oct 2006) | 10 lines

  2006-10-31  Eric Christopher  <echristo@apple.com>
            Falk Hueffner  <falk@debian.org>

        * gcc.dg/builtin-bswap-1.c: New.
        * gcc.dg/builtin-bswap-2.c: New.
        * gcc.dg/builtin-bswap-3.c: New.
        * gcc.dg/builtin-bswap-4.c: New.
        * gcc.dg/builtin-bswap-5.c: New.
        * gcc.target/i386/builtin-bswap-1.c: New.
........
  r118365 | geoffk | 2006-10-31 21:28:41 -0800 (Tue, 31 Oct 2006) | 28 lines

  In gcc/:
        PR 23067
        * c-decl.c (start_struct): Don't create self-containing
        structures.
        * config/rs6000/rs6000.c (darwin_rs6000_special_round_type_align):
        New.
        * config/rs6000/rs6000-protos.h
        (darwin_rs6000_special_round_type_align): New.
        * config/rs6000/darwin.h (ADJUST_FIELD_ALIGN): Rewrite.
        (ROUND_TYPE_ALIGN): Use darwin_rs6000_special_round_type_align.
  In gcc/testsuite/:
        PR 23067
        * gcc.target/powerpc/darwin-abi-3.c: Remove XFAIL.
        * gcc.target/powerpc/darwin-abi-6.c: Remove XFAIL.
        * gcc.target/powerpc/darwin-abi-7.c: Remove XFAIL.
        * gcc.target/powerpc/darwin-abi-8.c: Remove XFAIL.
        * gcc.target/powerpc/darwin-abi-9.c: Remove XFAIL.
        * gcc.target/powerpc/darwin-abi-10.c: Remove XFAIL.
        * gcc.target/powerpc/darwin-abi-11.c: Remove XFAIL.
  In libobjc/:
        * encoding.c (darwin_rs6000_special_round_type_align): New.
  In libffi/:
        * src/powerpc/ffi_darwin.c (darwin_adjust_aggregate_sizes): New.
        (ffi_prep_cif_machdep): Call darwin_adjust_aggregate_sizes for
        Darwin.
        * testsuite/libffi.call/nested_struct4.c: Remove Darwin XFAIL.
        * testsuite/libffi.call/nested_struct6.c: Remove Darwin XFAIL.
........
  r118366 | ghazi | 2006-10-31 21:38:21 -0800 (Tue, 31 Oct 2006) | 7 lines

        * builtins.def (gamma, lgamma): Use ATTR_MATHFN_FPROUNDING_STORE.

  testsuite:
        * gcc.dg/torture/builtin-attr-1.c: Don't test gamma/lgamma.
        * gcc.dg/torture/builtin-convert-1.c: Don't test lgamma.
........
  r118367 | geoffk | 2006-10-31 21:42:01 -0800 (Tue, 31 Oct 2006) | 1 line

  Fix date on ChangeLog entry
........
  r118371 | dannysmith | 2006-10-31 22:23:12 -0800 (Tue, 31 Oct 2006) | 22
lines

        * target.h (targetm.cxx.use_atexit_for_cxa_atexit): New target
        hook.
        * target-def.h: (TARGET_CXX_USE_ATEXIT_FOR_CXA_ATEXIT): Define
        default.
        * config/i386/mingw32.h (TARGET_CXX_USE_ATEXIT_FOR_CXA_ATEXIT):
        Override default.
        * doc/tm.texi (TARGET_CXX_USE_ATEXIT_FOR_CXA_ATEXIT): Document.
        * configure.ac (use_cxa_atexit): As a special case, don't test
        for libc definition of __cxa_atexit on mingw32
        * configure: Regenerate.
        * config.gcc (i[34567]86-pc-mingw32): Default to
        enable__cxa_atexit=yes.

  cp

        * decl.c (get_atexit_node): Reference atexit, not __cxa_exit.
        if targetm.cxx.use_atexit_for cxa_atexit.
        (start_cleanup_fn): Likewise.
        (register_dtor_fn): Likewise.
........
  r118372 | pinskia | 2006-10-31 23:28:53 -0800 (Tue, 31 Oct 2006) | 7 lines

  2006-10-31  Andrew Pinski  <pinskia@gmail.com>

          * doc/invoke.texi (-fkeep-inline-functions): Change "GNU C"
          to "GNU C89".
........
  r118373 | rguenth | 2006-11-01 03:38:06 -0800 (Wed, 01 Nov 2006) | 10 lines

  2006-11-01  Richard Guenther  <rguenther@suse.de>

        * config/i386/i386.c (ix86_expand_rint): Fix issues with
        signed zeros.
        (ix86_expand_floorceildf_32): Likewise.
        (ix86_expand_floorceil): Likewise.
        (ix86_expand_trunc): Likewise.

        * testsuite/gcc.target/i386/fpprec-1.c: New testcase.
........
  r118374 | ebotcazou | 2006-11-01 03:58:18 -0800 (Wed, 01 Nov 2006) | 1 line

  Fix asm string.
........
  r118377 | ebotcazou | 2006-11-01 04:09:25 -0800 (Wed, 01 Nov 2006) | 3 lines

        * gcc.c-torture/execute/20061101-1.c: New test.
........

Modified:
    branches/fixed-point/   (props changed)
    branches/fixed-point/fixincludes/ChangeLog
    branches/fixed-point/fixincludes/fixincl.x
    branches/fixed-point/fixincludes/inclhack.def
    branches/fixed-point/gcc/ChangeLog
    branches/fixed-point/gcc/DATESTAMP
    branches/fixed-point/gcc/ada/ChangeLog
    branches/fixed-point/gcc/ada/a-rbtgso.ads
    branches/fixed-point/gcc/builtin-types.def
    branches/fixed-point/gcc/builtins.c
    branches/fixed-point/gcc/builtins.def
    branches/fixed-point/gcc/c-decl.c
    branches/fixed-point/gcc/c-tree.h
    branches/fixed-point/gcc/c-typeck.c
    branches/fixed-point/gcc/cgraphunit.c
    branches/fixed-point/gcc/config.gcc
    branches/fixed-point/gcc/config/darwin.h
    branches/fixed-point/gcc/config/i386/darwin.h
    branches/fixed-point/gcc/config/i386/i386.c
    branches/fixed-point/gcc/config/i386/i386.h
    branches/fixed-point/gcc/config/i386/mingw32.h
    branches/fixed-point/gcc/config/rs6000/darwin.h
    branches/fixed-point/gcc/config/rs6000/rs6000-protos.h
    branches/fixed-point/gcc/config/rs6000/rs6000.c
    branches/fixed-point/gcc/configure
    branches/fixed-point/gcc/configure.ac
    branches/fixed-point/gcc/coverage.c
    branches/fixed-point/gcc/cp/ChangeLog
    branches/fixed-point/gcc/cp/cp-lang.c
    branches/fixed-point/gcc/cp/cp-objcp-common.h
    branches/fixed-point/gcc/cp/cp-tree.h
    branches/fixed-point/gcc/cp/decl.c
    branches/fixed-point/gcc/cp/decl2.c
    branches/fixed-point/gcc/cp/name-lookup.c
    branches/fixed-point/gcc/doc/extend.texi
    branches/fixed-point/gcc/doc/invoke.texi
    branches/fixed-point/gcc/doc/libgcc.texi
    branches/fixed-point/gcc/doc/rtl.texi
    branches/fixed-point/gcc/doc/tm.texi
    branches/fixed-point/gcc/dwarf2out.c
    branches/fixed-point/gcc/fold-const.c
    branches/fixed-point/gcc/fortran/ChangeLog
    branches/fixed-point/gcc/fortran/data.c
    branches/fixed-point/gcc/fortran/decl.c
    branches/fixed-point/gcc/fortran/expr.c
    branches/fixed-point/gcc/fortran/match.c
    branches/fixed-point/gcc/fortran/primary.c
    branches/fixed-point/gcc/fortran/trans-common.c
    branches/fixed-point/gcc/fortran/trans-decl.c
    branches/fixed-point/gcc/genattrtab.c
    branches/fixed-point/gcc/genopinit.c
    branches/fixed-point/gcc/libgcc-std.ver
    branches/fixed-point/gcc/libgcc2.c
    branches/fixed-point/gcc/libgcc2.h
    branches/fixed-point/gcc/mklibgcc.in
    branches/fixed-point/gcc/optabs.c
    branches/fixed-point/gcc/optabs.h
    branches/fixed-point/gcc/reload1.c
    branches/fixed-point/gcc/rtl.def
    branches/fixed-point/gcc/simplify-rtx.c
    branches/fixed-point/gcc/target-def.h
    branches/fixed-point/gcc/target.h
    branches/fixed-point/gcc/testsuite/ChangeLog
    branches/fixed-point/gcc/testsuite/gcc.dg/inline-10.c
    branches/fixed-point/gcc/testsuite/gcc.dg/torture/builtin-attr-1.c
    branches/fixed-point/gcc/testsuite/gcc.dg/torture/builtin-convert-1.c
    branches/fixed-point/gcc/testsuite/gcc.target/powerpc/darwin-abi-10.c
    branches/fixed-point/gcc/testsuite/gcc.target/powerpc/darwin-abi-11.c
    branches/fixed-point/gcc/testsuite/gcc.target/powerpc/darwin-abi-3.c
    branches/fixed-point/gcc/testsuite/gcc.target/powerpc/darwin-abi-6.c
    branches/fixed-point/gcc/testsuite/gcc.target/powerpc/darwin-abi-7.c
    branches/fixed-point/gcc/testsuite/gcc.target/powerpc/darwin-abi-8.c
    branches/fixed-point/gcc/testsuite/gcc.target/powerpc/darwin-abi-9.c
    branches/fixed-point/gcc/testsuite/gfortran.dg/blockdata_1.f90
    branches/fixed-point/gcc/toplev.c
    branches/fixed-point/gcc/tree.c
    branches/fixed-point/gcc/tree.h
    branches/fixed-point/libffi/ChangeLog
    branches/fixed-point/libffi/src/powerpc/ffi_darwin.c
    branches/fixed-point/libffi/testsuite/libffi.call/nested_struct4.c
    branches/fixed-point/libffi/testsuite/libffi.call/nested_struct6.c
    branches/fixed-point/libgfortran/ChangeLog
    branches/fixed-point/libgfortran/io/transfer.c
    branches/fixed-point/libgfortran/libgfortran.h
    branches/fixed-point/libgfortran/runtime/error.c
    branches/fixed-point/libobjc/ChangeLog
    branches/fixed-point/libobjc/encoding.c

Propchange: branches/fixed-point/
            ('svnmerge-integrated' modified)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29537