* [Bug fortran/29410] [Optimization] bug with TRANSFER() and -O2
2006-10-10 9:13 [Bug fortran/29410] New: [Optimization] bug with TRANSFER() and -O2 dominiq at lps dot ens dot fr
@ 2006-10-18 20:50 ` fxcoudert at gcc dot gnu dot org
2006-10-18 20:50 ` fxcoudert at gcc dot gnu dot org
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2006-10-18 20:50 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from fxcoudert at gcc dot gnu dot org 2006-10-18 20:50 -------
Confirmed, and Andrew will soon have a patch for this.
--
fxcoudert at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |pinskia at gcc dot gnu dot
|dot org |org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29410
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/29410] [Optimization] bug with TRANSFER() and -O2
2006-10-10 9:13 [Bug fortran/29410] New: [Optimization] bug with TRANSFER() and -O2 dominiq at lps dot ens dot fr
2006-10-18 20:50 ` [Bug fortran/29410] " fxcoudert at gcc dot gnu dot org
@ 2006-10-18 20:50 ` fxcoudert at gcc dot gnu dot org
2006-10-29 22:16 ` pinskia at gcc dot gnu dot org
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2006-10-18 20:50 UTC (permalink / raw)
To: gcc-bugs
--
fxcoudert at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2006-10-18 20:50:31
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29410
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/29410] [Optimization] bug with TRANSFER() and -O2
2006-10-10 9:13 [Bug fortran/29410] New: [Optimization] bug with TRANSFER() and -O2 dominiq at lps dot ens dot fr
2006-10-18 20:50 ` [Bug fortran/29410] " fxcoudert at gcc dot gnu dot org
2006-10-18 20:50 ` fxcoudert at gcc dot gnu dot org
@ 2006-10-29 22:16 ` pinskia at gcc dot gnu dot org
2006-10-29 22:36 ` pinskia at gcc dot gnu dot org
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-10-29 22:16 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from pinskia at gcc dot gnu dot org 2006-10-29 22:15 -------
The problem is that gfc_conv_intrinsic_transfer does *(int*)&float_var which
causes a violation of aliasing rules.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
GCC target triplet|powerpc-apple-darwin7 |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29410
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/29410] [Optimization] bug with TRANSFER() and -O2
2006-10-10 9:13 [Bug fortran/29410] New: [Optimization] bug with TRANSFER() and -O2 dominiq at lps dot ens dot fr
` (2 preceding siblings ...)
2006-10-29 22:16 ` pinskia at gcc dot gnu dot org
@ 2006-10-29 22:36 ` pinskia at gcc dot gnu dot org
2006-10-30 16:15 ` pinskia at gcc dot gnu dot org
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-10-29 22:36 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from pinskia at gcc dot gnu dot org 2006-10-29 22:36 -------
Here is the fix which I am testing right now:
Index: trans-intrinsic.c
===================================================================
--- trans-intrinsic.c (revision 118159)
+++ trans-intrinsic.c (working copy)
@@ -2914,7 +2914,7 @@ gfc_conv_intrinsic_array_transfer (gfc_s
/* Scalar transfer statement.
- TRANSFER (source, mold) = *(typeof<mold> *)&source. */
+ TRANSFER (source, mold) = VIEW_CONVERT_EXPR<typeof<mold> >source. */
static void
gfc_conv_intrinsic_transfer (gfc_se * se, gfc_expr * expr)
@@ -2939,9 +2939,9 @@ gfc_conv_intrinsic_transfer (gfc_se * se
arg = arg->next;
type = gfc_typenode_for_spec (&expr->ts);
- ptr = convert (build_pointer_type (type), ptr);
if (expr->ts.type == BT_CHARACTER)
{
+ ptr = convert (build_pointer_type (type), ptr);
gfc_init_se (&argse, NULL);
gfc_conv_expr (&argse, arg->expr);
gfc_add_block_to_block (&se->pre, &argse.pre);
@@ -2951,7 +2951,8 @@ gfc_conv_intrinsic_transfer (gfc_se * se
}
else
{
- se->expr = build_fold_indirect_ref (ptr);
+ tree tmp = build_fold_indirect_ref (ptr);
+ se->expr = fold_build1 (VIEW_CONVERT_EXPR, type, tmp);
}
}
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29410
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/29410] [Optimization] bug with TRANSFER() and -O2
2006-10-10 9:13 [Bug fortran/29410] New: [Optimization] bug with TRANSFER() and -O2 dominiq at lps dot ens dot fr
` (3 preceding siblings ...)
2006-10-29 22:36 ` pinskia at gcc dot gnu dot org
@ 2006-10-30 16:15 ` pinskia at gcc dot gnu dot org
2006-11-07 19:34 ` [Bug fortran/29410] [4.2 only] " pinskia at gcc dot gnu dot org
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-10-30 16:15 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from pinskia at gcc dot gnu dot org 2006-10-30 16:15 -------
Subject: Bug 29410
Author: pinskia
Date: Mon Oct 30 16:15:09 2006
New Revision: 118186
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=118186
Log:
2006-10-30 Andrew Pinski <pinskia@gmail.com>
PR fortran/29410
* trans-intrinsic.c (gfc_conv_intrinsic_array_transfer):
Change over to create VIEW_CONVERT_EXPR instead of using an
ADDR_EXPR, a cast and then an indirect reference
2006-10-30 Andrew Pinski <pinskia@gmail.com>
PR Fortran/29410
* gfortran.fortran-torture/execute/transfer1.f90: New test.
Added:
trunk/gcc/testsuite/gfortran.fortran-torture/execute/transfer1.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/trans-intrinsic.c
trunk/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29410
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/29410] [4.2 only] bug with TRANSFER() and -O2
2006-10-10 9:13 [Bug fortran/29410] New: [Optimization] bug with TRANSFER() and -O2 dominiq at lps dot ens dot fr
` (4 preceding siblings ...)
2006-10-30 16:15 ` pinskia at gcc dot gnu dot org
@ 2006-11-07 19:34 ` pinskia at gcc dot gnu dot org
2006-11-07 19:34 ` [Bug fortran/29410] " pinskia at gcc dot gnu dot org
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-11-07 19:34 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from pinskia at gcc dot gnu dot org 2006-11-07 19:34 -------
apinski hi
apinski PaulT: VCE means *(type*)&a without the need for addressable and does
not confuse aliasing
PaulT apinski: Hi, yes I answered the question myself - I missed it in tree.def
by only looking in tree.h
apinski PaulT: this is mention in tree.def :)
PaulT apinski: It's undefined if the types have different lengths?
apinski yes
apinski actually is transfer ok for different size types?
PaulT Yes, I was just racing for the standard.
apinski ok
apinski I guess I have to change my patch then
apinski to include a size comparision
apinski The physical representation of the result is the same as SOURCE,
truncated if the result is smaller or with an undefined trailing portion if the
result is larger.
apinski that is from IBM's docs about transfer
PaulT apinski: Gee, yes. I missed that completely.
apinski I can improve the truncated part also
PaulT If I change the integers in your example to integer(8), I get a core
dump.
apinski during running?
PaulT g95 and ifort do the right thing.
PaulT Shucks, I'm sorry about that Andrew, I missed it completely.
apinski I figured it was going to be wrong
apinski lucky I only applied to the mainline :)
apinski can you write something in the bug report so I don't forget to fix it
this weekend?
PaulT apinski: I keep telling people that that is what it is for!
PaulT apinski: Sure thing - I suppose that you can safely do a kind conversion?
apinski I know how to fix this correctly now
apinski use __builtin_memcpy and hope that gets optimized correctly in the
future :)
PaulT apinski: make type of the same length as source, so that the assignment
does the rest?
apinski no
apinski PaulT: do memcpy (dst, src, min(size1, size0))
PaulT apinski: No... you're right that won't present a bit-wise transfer.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29410
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/29410] bug with TRANSFER() and -O2
2006-10-10 9:13 [Bug fortran/29410] New: [Optimization] bug with TRANSFER() and -O2 dominiq at lps dot ens dot fr
` (5 preceding siblings ...)
2006-11-07 19:34 ` [Bug fortran/29410] [4.2 only] " pinskia at gcc dot gnu dot org
@ 2006-11-07 19:34 ` pinskia at gcc dot gnu dot org
2006-11-07 19:35 ` pinskia at gcc dot gnu dot org
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-11-07 19:34 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from pinskia at gcc dot gnu dot org 2006-11-07 19:34 -------
My patch is incorrect for transfer with different sizes.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
URL|http://gcc.gnu.org/ml/gcc- |
|patches/2006- |
|10/msg01536.html |
Keywords|patch |
Summary|[4.2 only] bug with |bug with TRANSFER() and -O2
|TRANSFER() and -O2 |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29410
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/29410] bug with TRANSFER() and -O2
2006-10-10 9:13 [Bug fortran/29410] New: [Optimization] bug with TRANSFER() and -O2 dominiq at lps dot ens dot fr
` (6 preceding siblings ...)
2006-11-07 19:34 ` [Bug fortran/29410] " pinskia at gcc dot gnu dot org
@ 2006-11-07 19:35 ` pinskia at gcc dot gnu dot org
2006-11-12 1:31 ` [Bug fortran/29410] [4.2 only] " pinskia at gcc dot gnu dot org
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-11-07 19:35 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from pinskia at gcc dot gnu dot org 2006-11-07 19:35 -------
In fact I think the orginal way is incorrect for cases where the transfer size
is larger than the orginal size of the decl.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29410
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/29410] [4.2 only] bug with TRANSFER() and -O2
2006-10-10 9:13 [Bug fortran/29410] New: [Optimization] bug with TRANSFER() and -O2 dominiq at lps dot ens dot fr
` (7 preceding siblings ...)
2006-11-07 19:35 ` pinskia at gcc dot gnu dot org
@ 2006-11-12 1:31 ` pinskia at gcc dot gnu dot org
2006-11-24 22:48 ` pinskia at gcc dot gnu dot org
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-11-12 1:31 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from pinskia at gcc dot gnu dot org 2006-11-12 01:31 -------
Actually it turns out using VIEW_CONVERT_EXPR is ok and works correctly as far
as I can tell.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|bug with TRANSFER() and -O2 |[4.2 only] bug with
| |TRANSFER() and -O2
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29410
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/29410] [4.2 only] bug with TRANSFER() and -O2
2006-10-10 9:13 [Bug fortran/29410] New: [Optimization] bug with TRANSFER() and -O2 dominiq at lps dot ens dot fr
` (8 preceding siblings ...)
2006-11-12 1:31 ` [Bug fortran/29410] [4.2 only] " pinskia at gcc dot gnu dot org
@ 2006-11-24 22:48 ` pinskia at gcc dot gnu dot org
2007-01-14 11:19 ` pault at gcc dot gnu dot org
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-11-24 22:48 UTC (permalink / raw)
To: gcc-bugs
------- Comment #9 from pinskia at gcc dot gnu dot org 2006-11-24 22:48 -------
It turns out my fix caused PR 29951 which I am testing a fix for PR 29951 now.
My new patch does not break this testcase which is a good sign.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
BugsThisDependsOn| |29951
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29410
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/29410] [4.2 only] bug with TRANSFER() and -O2
2006-10-10 9:13 [Bug fortran/29410] New: [Optimization] bug with TRANSFER() and -O2 dominiq at lps dot ens dot fr
` (9 preceding siblings ...)
2006-11-24 22:48 ` pinskia at gcc dot gnu dot org
@ 2007-01-14 11:19 ` pault at gcc dot gnu dot org
2007-01-22 1:08 ` pinskia at gmail dot com
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: pault at gcc dot gnu dot org @ 2007-01-14 11:19 UTC (permalink / raw)
To: gcc-bugs
------- Comment #10 from pault at gcc dot gnu dot org 2007-01-14 11:19 -------
(In reply to comment #9)
> It turns out my fix caused PR 29951 which I am testing a fix for PR 29951 now.
> My new patch does not break this testcase which is a good sign.
>
Andrew,
Were you going to apply this to 4.2, together with revision 119211, or will you
close them as fixed on 4.3?
Paul
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29410
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/29410] [4.2 only] bug with TRANSFER() and -O2
2006-10-10 9:13 [Bug fortran/29410] New: [Optimization] bug with TRANSFER() and -O2 dominiq at lps dot ens dot fr
` (10 preceding siblings ...)
2007-01-14 11:19 ` pault at gcc dot gnu dot org
@ 2007-01-22 1:08 ` pinskia at gmail dot com
2007-01-23 5:13 ` pinskia at gcc dot gnu dot org
2007-01-23 5:15 ` pinskia at gcc dot gnu dot org
13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gmail dot com @ 2007-01-22 1:08 UTC (permalink / raw)
To: gcc-bugs
------- Comment #11 from pinskia at gmail dot com 2007-01-22 01:08 -------
Subject: Re: [4.2 only] bug with TRANSFER() and -O2
On Sun, 2007-01-14 at 11:19 +0000, pault at gcc dot gnu dot org wrote:
>
> Were you going to apply this to 4.2, together with revision 119211, or
> will you
> close them as fixed on 4.3?
I am going to test it for 4.2 once I finish testing an objective-C
patch.
-- Pinski
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29410
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/29410] [4.2 only] bug with TRANSFER() and -O2
2006-10-10 9:13 [Bug fortran/29410] New: [Optimization] bug with TRANSFER() and -O2 dominiq at lps dot ens dot fr
` (11 preceding siblings ...)
2007-01-22 1:08 ` pinskia at gmail dot com
@ 2007-01-23 5:13 ` pinskia at gcc dot gnu dot org
2007-01-23 5:15 ` pinskia at gcc dot gnu dot org
13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-01-23 5:13 UTC (permalink / raw)
To: gcc-bugs
------- Comment #12 from pinskia at gcc dot gnu dot org 2007-01-23 05:13 -------
Fixed.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
Target Milestone|--- |4.2.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29410
^ permalink raw reply [flat|nested] 15+ messages in thread* [Bug fortran/29410] [4.2 only] bug with TRANSFER() and -O2
2006-10-10 9:13 [Bug fortran/29410] New: [Optimization] bug with TRANSFER() and -O2 dominiq at lps dot ens dot fr
` (12 preceding siblings ...)
2007-01-23 5:13 ` pinskia at gcc dot gnu dot org
@ 2007-01-23 5:15 ` pinskia at gcc dot gnu dot org
13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-01-23 5:15 UTC (permalink / raw)
To: gcc-bugs
------- Comment #13 from pinskia at gcc dot gnu dot org 2007-01-23 05:15 -------
Subject: Bug 29410
Author: pinskia
Date: Tue Jan 23 05:15:21 2007
New Revision: 121076
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=121076
Log:
2007-01-22 Andrew Pinski <pinskia@gmail.com>
PR fortran/29951
* gfortran.fortran-torture/execute/transfer2.f90: New test.
PR Fortran/29410
* gfortran.fortran-torture/execute/transfer1.f90: New test.
2007-01-22 Andrew Pinski <pinskia@gmail.com>
PR fortran/29951
* trans-intrinsic.c (gfc_conv_intrinsic_transfer): Change to
call memcpy instead of creating a VIEW_CONVERT_EXRP.
PR fortran/29410
* trans-intrinsic.c (gfc_conv_intrinsic_array_transfer):
Change over to create VIEW_CONVERT_EXPR instead of using an
ADDR_EXPR, a cast and then an indirect reference.
Added:
branches/gcc-4_2-branch/gcc/testsuite/gfortran.fortran-torture/execute/transfer1.f90
- copied unchanged from r118186,
trunk/gcc/testsuite/gfortran.fortran-torture/execute/transfer1.f90
branches/gcc-4_2-branch/gcc/testsuite/gfortran.fortran-torture/execute/transfer2.f90
- copied unchanged from r119211,
trunk/gcc/testsuite/gfortran.fortran-torture/execute/transfer2.f90
Modified:
branches/gcc-4_2-branch/gcc/fortran/ChangeLog
branches/gcc-4_2-branch/gcc/fortran/trans-intrinsic.c
branches/gcc-4_2-branch/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29410
^ permalink raw reply [flat|nested] 15+ messages in thread