[Bug fortran/29711] New: error_print produces useless error message for LANG != C

[Bug fortran/29711] New: error_print produces useless error message for LANG != C

[burnus at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

error_print parses the error message and replaces %L and %C by the special
string.

However, this clashes with translations, if the order of arguments is changed:

>From gcc/po/de.po:
#: fortran/module.c:3369
#, no-c-format
msgid "Symbol '%s' referenced at %L not found in module '%s'"
msgstr "Bei %2$L referenziertes Symbol »%1$s« nicht im Modul »%3$s« gefunden"

Here, the order of %s and %L is changed. The result at runtime is:

Fehler: Bei $L referenziertes Symbol »$s« nicht im Modul »$s« gefunden

Which renders the error message useless.


-- 
           Summary: error_print produces useless error message for LANG != C
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: burnus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29711

[Bug fortran/29711] error_print produces useless error message for LANG != C

[burnus at gcc dot gnu dot org]

-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-11-04 13:28:03
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29711

[Bug fortran/29711] error_print does not support %N$X

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-11-04 17:22 -------
This is just a case of error_print not understanding that syntax unlike the
rest of GCC which does.  The translators should be told it does not support it
but we don't control them.  This is an enhancement for supporting that syntax.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
            Summary|error_print produces useless|error_print does not support
                   |error message for LANG != C |%N$X


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29711

[Bug fortran/29711] error_print does not support %N$X

[fxcoudert at gcc dot gnu dot org]

------- Comment #2 from fxcoudert at gcc dot gnu dot org  2006-11-14 10:39 -------
I'll take that one.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |fxcoudert at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2006-11-04 13:28:03         |2006-11-14 10:39:46
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29711

[Bug fortran/29711] error_print does not support %N$X

[fxcoudert at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]



------- Comment #3 from fxcoudert at gcc dot gnu dot org  2006-11-14 16:44 -------
What about:

de.f90:4:

use foo, only : bar
              1
Fehler: Bei (1) referenziertes Symbol »bar« nicht im Modul »foo« gefunden

My limited german knowledge seems to indicate that it's OK, but I'm not sure.
Could you try the attached patch on a few cases (possibly including multiple
loci and such arguments reorganizations)?


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29711

[Bug fortran/29711] error_print does not support %N$X

[fxcoudert at gcc dot gnu dot org]

------- Comment #4 from fxcoudert at gcc dot gnu dot org  2006-11-14 16:44 -------
Created an attachment (id=12618)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12618&action=view)
Patch mentionned in previous comment


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29711

[Bug fortran/29711] error_print does not support %N$X

[burnus at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]



------- Comment #5 from burnus at gcc dot gnu dot org  2006-11-14 17:16 -------
> Fehler: Bei (1) referenziertes Symbol »bar« nicht im Modul »foo« gefunden
>
> My limited german knowledge seems to indicate that it's OK, but I'm not sure.
Looks ok.

> Could you try the attached patch on a few cases (possibly including multiple
> loci and such arguments reorganizations)?

I will try. It actually effects the following strings in the following
languages (see gcc/po/):

de.po-msgid "Symbol '%s' referenced at %L not found in module '%s'"
de.po-msgid "User operator '%s' referenced at %L not found in module '%s'"
de.po-msgid "Intrinsic operator '%s' referenced at %L not found in module '%s'"
de.po-msgid "The equivalence set for variable '%s' declared at %L violates
alignment requirents"

tr.po-msgid "Processing spec %c%s%c, which is '%s'\n"
tr.po:msgstr "'%4$s' %1$c%2$s%3$c ozelligi isleniyor\n"
^ This could be a challenge!
tr.po-msgid "%s: warning: using formals list from %s(%d) for function '%s'\n"
tr.po-msgid "collect: tweaking %s in %s\n"

zh_TW.po-msgid "Assumed size array '%s' in namelist '%s'at %C is not allowed."
zh_TW.po-msgid "Assumed shape array '%s' in namelist '%s' at %C is an
extension."
zh_TW.po-msgid "Argument '%s' of pure function '%s' at %L must be INTENT(IN)"

(Reminder to self: test also "%s does not support %%n$ operand number
formats".)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29711

[Bug fortran/29711] error_print does not support %N$X

[burnus at gcc dot gnu dot org]

------- Comment #6 from burnus at gcc dot gnu dot org  2006-11-19 18:19 -------
I though I had replyed to my last comment, but seemingly I forget to "Commit"
the comment.
I tested with de and zh_TW (Zhonghua/Taiwan alias Guoyu) locale and the result
is ok. [Well, in Chinese it least it looks as if it were correct.]
The strings in Turkish are not part of gfortran.
Also from looking at diff, this patch seems to be ok.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29711

[Bug fortran/29711] error_print does not support %N$X

[fxcoudert at gcc dot gnu dot org]

------- Comment #7 from fxcoudert at gcc dot gnu dot org  2006-11-25 16:57 -------
Subject: Bug 29711

Author: fxcoudert
Date: Sat Nov 25 16:57:25 2006
New Revision: 119203

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=119203
Log:
        PR fortran/29711
        * error.c (error_print): Handle printf-style position specifiers,
        of the form "%3$d".

Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/error.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29711

[Bug fortran/29711] [4.2 only] error_print does not support %N$X

[fxcoudert at gcc dot gnu dot org]

------- Comment #8 from fxcoudert at gcc dot gnu dot org  2006-11-25 17:00 -------
Fixed on mainline. I will wait for some time before commiting on 4.2.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://gcc.gnu.org/ml/gcc-  |
                   |patches/2006-               |
                   |11/msg01351.html            |
           Severity|enhancement                 |normal
      Known to fail|                            |4.2.0
      Known to work|                            |4.3.0
            Summary|error_print does not support|[4.2 only] error_print does
                   |%N$X                        |not support %N$X
   Target Milestone|4.3.0                       |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29711

[Bug fortran/29711] [4.2 only] error_print does not support %N$X

[burnus at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]



------- Comment #9 from burnus at gcc dot gnu dot org  2006-12-06 20:14 -------
I don't know why, but I got again:

   Fehler: Bei L referenziertes Symbol »s« nicht im Modul »s« gefunden

for

  Error: Symbol 'generic' referenced at (1) not found in module 'mod1'

This is with the current SVN version. The string in the .po file is:

  msgstr "Bei %2$L referenziertes Symbol »%1$s« nicht im Modul »%3$s« gefunden"

I currently don't understand why this happens (and I want to trace an ICE
first).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29711

[Bug fortran/29711] [4.2 only] error_print does not support %N$X

[burnus at gcc dot gnu dot org]

------- Comment #10 from burnus at gcc dot gnu dot org  2006-12-06 22:58 -------
Ok, it is simple why it does not work.

In the attached and tested patch:
+         while (ISDIGIT(*format))
+           format++;
+         format++;

In SVN:
          while (ISDIGIT(*format))

          /* Skip over the dollar sign.  */
          format++;


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29711

[Bug fortran/29711] [4.2 only] error_print does not support %N$X

[patchapp at dberlin dot org]

------- Comment #11 from patchapp at dberlin dot org  2006-12-07 00:05 -------
Subject: Bug number PR29711

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-12/msg00430.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29711

[Bug fortran/29711] [4.2 only] error_print does not support %N$X

[burnus at gcc dot gnu dot org]

------- Comment #12 from burnus at gcc dot gnu dot org  2006-12-07 09:15 -------
Subject: Bug 29711

Author: burnus
Date: Thu Dec  7 09:15:41 2006
New Revision: 119609

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=119609
Log:
2006-12-06  Tobias Burnus  <burnus@net-b.de>

       PR fortran/29711
       * error.c (error_print): Fix handling of printf-style position
specifiers
         of the form "%3$d"


Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/error.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29711

[Bug fortran/29711] [4.2 only] error_print does not support %N$X

[fxcoudert at gcc dot gnu dot org]

------- Comment #13 from fxcoudert at gcc dot gnu dot org  2006-12-11 20:57 -------
Subject: Bug 29711

Author: fxcoudert
Date: Mon Dec 11 20:57:10 2006
New Revision: 119747

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=119747
Log:
        PR fortran/29892
        * trans-intrinsic.c (gfc_conv_intrinsic_bound): Use a locus in
        the call to gfc_trans_runtime_check.
        * trans-array.c (gfc_trans_array_bound_check): Try harder to find
        the variable or function name for the runtime error message.
        (gfc_trans_dummy_array_bias): Use a locus in the call to
        gfc_trans_runtime_check

        PR fortran/29973
        * resolve.c (resolve_actual_arglist): Remove the special case for
        CHAR.
        * intrinsic.c (add_functions): Remove the special case for CHAR.

        PR fortran/29711
        * error.c (error_print): Handle printf-style position specifiers,
        of the form "%3$d".

        PR fortran/29973
        * gfortran.dg/specifics_1.f90: Remove check for CHAR.
        * gfortran.dg/specifics_2.f90: Remove check for CHAR.
        * gfortran.dg/specifics_3.f90: Remove.
        * gfortran.fortran-torture/execute/specifics.f90: Remove test
        for CHAR.

Removed:
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/specifics_3.f90
Modified:
    branches/gcc-4_2-branch/gcc/fortran/ChangeLog
    branches/gcc-4_2-branch/gcc/fortran/error.c
    branches/gcc-4_2-branch/gcc/fortran/intrinsic.c
    branches/gcc-4_2-branch/gcc/fortran/resolve.c
    branches/gcc-4_2-branch/gcc/fortran/trans-array.c
    branches/gcc-4_2-branch/gcc/fortran/trans-intrinsic.c
    branches/gcc-4_2-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/specifics_1.f90
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/specifics_2.f90
   
branches/gcc-4_2-branch/gcc/testsuite/gfortran.fortran-torture/execute/specifics.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29711

[Bug fortran/29711] [4.2 only] error_print does not support %N$X

[fxcoudert at gcc dot gnu dot org]

------- Comment #14 from fxcoudert at gcc dot gnu dot org  2006-12-11 20:58 -------
Commited to 4.2, both my patch and Tobias' fix. Thanks Tobias for fixing it!


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29711