[Bug fortran/30200] New: valgrind errors for write statement

[Bug fortran/30200] New: valgrind errors for write statement

[jv244 at cam dot ac dot uk]

vondele@pcihopt1:/scratch/vondele/clean/cp2k/tests/QS/regtest-gpw-2> gfortran
test.f90
vondele@pcihopt1:/scratch/vondele/clean/cp2k/tests/QS/regtest-gpw-2> ./a.out
 avondele@pcihopt1:/scratch/vondele/clean/cp2k/tests/QS/regtest-gpw-2> valgrind
--tool=memcheck ./a.out
==16188== Memcheck, a memory error detector.
==16188== Copyright (C) 2002-2005, and GNU GPL'd, by Julian Seward et al.
==16188== Using LibVEX rev 1575, a library for dynamic binary translation.
==16188== Copyright (C) 2004-2005, and GNU GPL'd, by OpenWorks LLP.
==16188== Using valgrind-3.1.1, a dynamic binary instrumentation framework.
==16188== Copyright (C) 2000-2005, and GNU GPL'd, by Julian Seward et al.
==16188== For more details, rerun with: -v
==16188==
==16188== Invalid read of size 1
==16188==    at 0x4B93D8D: formatted_transfer_scalar (transfer.c:834)
==16188==    by 0x4B94182: formatted_transfer (transfer.c:1355)
==16188==    by 0x400CF2: MAIN__ (in
/scratch/vondele/clean/cp2k/tests/QS/regtest-gpw-2/a.out)
==16188==    by 0x400D2D: main (fmain.c:18)
==16188==  Address 0x5148646 is 6 bytes inside a block of size 10 free'd
==16188==    at 0x4A1984D: free (vg_replace_malloc.c:235)
==16188==    by 0x400CC6: MAIN__ (in
/scratch/vondele/clean/cp2k/tests/QS/regtest-gpw-2/a.out)
==16188==    by 0x400D2D: main (fmain.c:18)
==16188==
==16188== Invalid read of size 1
==16188==    at 0x4B93DA9: formatted_transfer_scalar (transfer.c:838)
==16188==    by 0x4B94182: formatted_transfer (transfer.c:1355)
==16188==    by 0x400CF2: MAIN__ (in
/scratch/vondele/clean/cp2k/tests/QS/regtest-gpw-2/a.out)
==16188==    by 0x400D2D: main (fmain.c:18)
==16188==  Address 0x5148647 is 7 bytes inside a block of size 10 free'd
==16188==    at 0x4A1984D: free (vg_replace_malloc.c:235)
==16188==    by 0x400CC6: MAIN__ (in
/scratch/vondele/clean/cp2k/tests/QS/regtest-gpw-2/a.out)
==16188==    by 0x400D2D: main (fmain.c:18)
 a ==16188==
==16188== ERROR SUMMARY: 2 errors from 2 contexts (suppressed: 3 from 2)
==16188== malloc/free: in use at exit: 0 bytes in 0 blocks.
==16188== malloc/free: 11 allocs, 11 frees, 29,400 bytes allocated.
==16188== For counts of detected errors, rerun with: -v
==16188== All heap blocks were freed -- no leaks are possible.
vondele@pcihopt1:/scratch/vondele/clean/cp2k/tests/QS/regtest-gpw-2> cat
test.f90
   character(len=100) myfmt
   type test
    character(len=100) :: names(5)
   end type test
   type(test) :: keyword
   keyword%names=(/"a","b","c","d","e"/)
   myfmt="1X"
   WRITE(unit=6,fmt="("//TRIM(myfmt)//",a,' ')",advance="NO")
TRIM(keyword%names(1))
   END


-- 
           Summary: valgrind errors for write statement
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jv244 at cam dot ac dot uk


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug fortran/30200] valgrind errors for write statement

[jv244 at cam dot ac dot uk]

------- Comment #1 from jv244 at cam dot ac dot uk  2006-12-13 19:28 -------
This problem seems to be at the root of most CP2K regtest failures described in
PR29975


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug fortran/30200] valgrind errors for write statement

[burnus at gcc dot gnu dot org]

------- Comment #2 from burnus at gcc dot gnu dot org  2006-12-13 19:47 -------
Simplified version (might not cover all problems):
   character(len=20) myfmt
   myfmt="(1X,a,'x')"
   WRITE(*,fmt=trim(myfmt)) "y"
   END

If one looks now at the dump:
    _gfortran_string_trim (&len.2, (void * *) &pstr.1, 20, &myfmt);
    dt_parm.0.format = pstr.1;
    dt_parm.0.format_len = len.2;
    _gfortran_st_write (&dt_parm.0);
        _gfortran_internal_free (pstr.1);
    _gfortran_transfer_character (&dt_parm.0, "y", 1);
    _gfortran_st_write_done (&dt_parm.0);

I'm not sure whether this is the problem, but pstr.1 is freed before "y" is
send to "write" - but the string has to be written after "y".


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |wrong-code
   Last reconfirmed|0000-00-00 00:00:00         |2006-12-13 19:47:50
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug libfortran/30200] write(*,myfmt="(1X,a,'xyz')") "A" prints Az' instead of Axyz

[burnus at gcc dot gnu dot org]

------- Comment #3 from burnus at gcc dot gnu dot org  2006-12-13 20:11 -------
CC: some more libgfortran/io experienced persons.

There seems to go something wrong when one uses
  format = "(1X,a,'xyz')"
  write(*,fmt=trim(format)) "A"
The result is:
 Az'

Expected:
 Axyz

The values in write_constant_string are:
  length = 3       // ok
  q[-1] = '' (0)   // should be  '
  q[0] = '' (0)    // should be  x
  q[1] = 'y' (121) 
  q[2] = 'z' (122)

The following works:
- no trim
- format = "(1X,'abc',a,'xyz')"
- format = "(1X,'abc',a)"
- format = "(1X,'xyz')"


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jvdelisle at gcc dot gnu dot
                   |                            |org, Thomas dot Koenig at
                   |                            |online dot de
          Component|fortran                     |libfortran
            Summary|valgrind errors for write   |write(*,myfmt="(1X,a,'xyz')"
                   |statement                   |) "A"  prints  Az' instead
                   |                            |of Axyz


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug libfortran/30200] write(*,myfmt="(1X,a,'xyz')") "A" prints Az' instead of Axyz

[tkoenig at gcc dot gnu dot org]

------- Comment #4 from tkoenig at gcc dot gnu dot org  2006-12-13 21:12 -------
(In reply to comment #3)
> CC: some more libgfortran/io experienced persons.
> 
> There seems to go something wrong when one uses
>   format = "(1X,a,'xyz')"
>   write(*,fmt=trim(format)) "A"
> The result is:
>  Az'

WORKSFORME:

$ cat foo.f90
program main
  character (len=20) format
  format = "(1X,a,'xyz')"
  write(*,fmt=trim(format)) "A"
end
$ gfortran foo.f90
$ ./a.out
 Axyz
$ gfortran -v
Using built-in specs.
Target: i686-pc-linux-gnu
Configured with: ../../gcc/trunk/configure --prefix=/home/ig25
--enable-languages=c,fortran
Thread model: posix
gcc version 4.3.0 20061127 (experimental)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug libfortran/30200] write(*,myfmt="(1X,a,'xyz')") "A" prints Az' instead of Axyz

[jvdelisle at verizon dot net]

------- Comment #5 from jvdelisle at verizon dot net  2006-12-14 00:26 -------
Subject: Re:  write(*,myfmt="(1X,a,'xyz')") "A"  prints
 Az' instead of Axyz

I wonder if this is not a case of the io.h dependency bug hitting yet again.  I 
would fix it if I knew how.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug libfortran/30200] write(*,myfmt="(1X,a,'xyz')") "A" prints Az' instead of Axyz

[jvdelisle at gcc dot gnu dot org]

------- Comment #6 from jvdelisle at gcc dot gnu dot org  2006-12-14 02:29 -------
More information.  I get Tobias bad result with -m64 on x86-64-Linux.  The
problem goes away with -m32.

$ gfortran -m32 pr30200-2.f90 
$ ./a.out
 Axyz
$ gfortran -m64 pr30200-2.f90 
$ ./a.out
 Az'

I get a similar result with the orginal test case from Joost.  The problem is
-m64 specific.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug libfortran/30200] write(*,myfmt="(1X,a,'xyz')") "A" prints Az' instead of Axyz

[jv244 at cam dot ac dot uk]

------- Comment #7 from jv244 at cam dot ac dot uk  2006-12-14 06:41 -------
(In reply to comment #6)
> More information.  I get Tobias bad result with -m64 on x86-64-Linux.  The
> problem goes away with -m32.
> 
> $ gfortran -m32 pr30200-2.f90 
> $ ./a.out
>  Axyz
> $ gfortran -m64 pr30200-2.f90 
> $ ./a.out
>  Az'

whereas -m32 is printing the right result, I think it is coincidence, at least
to original testcase still yields valgrind errors at runtime if compiled with
-m32


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug libfortran/30200] write(*,myfmt="(1X,a,'xyz')") "A" prints Az' instead of Axyz

[jvdelisle at gcc dot gnu dot org]

------- Comment #8 from jvdelisle at gcc dot gnu dot org  2006-12-15 02:16 -------
I will take this on.


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jvdelisle at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2006-12-13 19:47:50         |2006-12-15 02:16:16
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug libfortran/30200] write(*,myfmt="(1X,a,'xyz')") "A" prints Az' instead of Axyz

[patchapp at dberlin dot org]

------- Comment #9 from patchapp at dberlin dot org  2006-12-15 08:45 -------
Subject: Bug number PR30200

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-12/msg01099.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug libfortran/30200] write(*,myfmt="(1X,a,'xyz')") "A" prints Az' instead of Axyz

[jvdelisle at gcc dot gnu dot org]

------- Comment #10 from jvdelisle at gcc dot gnu dot org  2006-12-15 08:51 -------
Tobias observation in comment #2 is correct.  The submitted patch moves the
memory free actions to after the write transfers have completed.  No more
valgrind errors.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug libfortran/30200] write(*,myfmt="(1X,a,'xyz')") "A" prints Az' instead of Axyz

[jvdelisle at gcc dot gnu dot org]

------- Comment #11 from jvdelisle at gcc dot gnu dot org  2006-12-15 19:48 -------
Subject: Bug 30200

Author: jvdelisle
Date: Fri Dec 15 19:48:08 2006
New Revision: 119940

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=119940
Log:
2006-12-15  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/30200
        * trans-io.c (build_dt): Move post block for format_expr to end.

Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/trans-io.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug libfortran/30200] write(*,myfmt="(1X,a,'xyz')") "A" prints Az' instead of Axyz

[jvdelisle at gcc dot gnu dot org]

------- Comment #12 from jvdelisle at gcc dot gnu dot org  2006-12-15 19:53 -------
Subject: Bug 30200

Author: jvdelisle
Date: Fri Dec 15 19:52:49 2006
New Revision: 119941

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=119941
Log:
2006-12-15  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/30200
        * gfortran.dg/write_fmt_trim.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/write_fmt_trim.f90
Modified:
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug libfortran/30200] [4.2, 4.1 only] write(*,myfmt="(1X,a,'xyz')") "A" prints Az' instead of Axyz

[jvdelisle at gcc dot gnu dot org]

------- Comment #13 from jvdelisle at gcc dot gnu dot org  2006-12-19 06:29 -------
Subject: Bug 30200

Author: jvdelisle
Date: Tue Dec 19 06:28:47 2006
New Revision: 120041

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=120041
Log:
2006-12-18  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/30200
        * trans-io.c (build_dt): Move post block for format_expr to end.

Modified:
    branches/gcc-4_2-branch/gcc/fortran/ChangeLog
    branches/gcc-4_2-branch/gcc/fortran/trans-io.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug libfortran/30200] [4.2, 4.1 only] write(*,myfmt="(1X,a,'xyz')") "A" prints Az' instead of Axyz

[jvdelisle at gcc dot gnu dot org]

------- Comment #14 from jvdelisle at gcc dot gnu dot org  2006-12-19 06:32 -------
Subject: Bug 30200

Author: jvdelisle
Date: Tue Dec 19 06:32:09 2006
New Revision: 120042

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=120042
Log:
2006-12-18  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/30200
        * gfortran.dg/write_fmt_trim.f90: New test.

Added:
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/write_fmt_trim.f90
Modified:
    branches/gcc-4_2-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug libfortran/30200] [4.1 only] write(*,myfmt="(1X,a,'xyz')") "A" prints Az' instead of Axyz

[burnus at gcc dot gnu dot org]

------- Comment #15 from burnus at gcc dot gnu dot org  2006-12-21 15:20 -------
Will this be be fixed for 4.1 too? Or can this PR be closed?


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.2, 4.1 only]             |[4.1 only]
                   |write(*,myfmt="(1X,a,'xyz')"|write(*,myfmt="(1X,a,'xyz')"
                   |) "A"  prints  Az' instead  |) "A"  prints  Az' instead
                   |of Axyz                     |of Axyz


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug libfortran/30200] [4.1 only] write(*,myfmt="(1X,a,'xyz')") "A" prints Az' instead of Axyz

[jvdelisle at gcc dot gnu dot org]

------- Comment #16 from jvdelisle at gcc dot gnu dot org  2006-12-21 16:03 -------
I have the patch ready, I will commit sometime today to 4.1


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug libfortran/30200] [4.1 only] write(*,myfmt="(1X,a,'xyz')") "A" prints Az' instead of Axyz

[jvdelisle at gcc dot gnu dot org]

------- Comment #17 from jvdelisle at gcc dot gnu dot org  2006-12-25 22:53 -------
Subject: Bug 30200

Author: jvdelisle
Date: Mon Dec 25 22:53:29 2006
New Revision: 120199

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=120199
Log:
2006-12-25  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/30200
        * trans-io.c (build_dt): Move post block for format_expr to end.

Modified:
    branches/gcc-4_1-branch/gcc/fortran/ChangeLog
    branches/gcc-4_1-branch/gcc/fortran/trans-io.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug libfortran/30200] [4.1 only] write(*,myfmt="(1X,a,'xyz')") "A" prints Az' instead of Axyz

[jvdelisle at gcc dot gnu dot org]

------- Comment #18 from jvdelisle at gcc dot gnu dot org  2006-12-25 23:08 -------
Subject: Bug 30200

Author: jvdelisle
Date: Mon Dec 25 23:08:17 2006
New Revision: 120201

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=120201
Log:
2006-12-25  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libfortran/30145
        * gfortran.dg/write_zero_array.f90: New test.

2006-12-25  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/30200
        * gfortran.dg/write_fmt_trim.f90: New test.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/write_fmt_trim.f90
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/write_zero_array.f90
Modified:
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200

[Bug libfortran/30200] [4.1 only] write(*,myfmt="(1X,a,'xyz')") "A" prints Az' instead of Axyz

[jvdelisle at gcc dot gnu dot org]

------- Comment #19 from jvdelisle at gcc dot gnu dot org  2006-12-25 23:10 -------
Fixed on 4.1


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30200