[Bug c++/30253] New: ice for legal code

[Bug c++/30253] New: ice for legal code

[dcb314 at hotmail dot com]

I just tried to compile Suse Linux package yast2-perl-bindings-2.14.0-11
with the new GNU C++ compiler version 3.2 snapshot 20061216.

Here is an extract from the build log

 g++ -DHAVE_CONFIG_H -I. -I. -I.. -I./include -I/usr/include/YaST2
-DY2LOG=\"Perl\" -DMODULEDIR=\"/usr/share/YaST2/modules\" -O2 -g
-fmessage-length=0 -D_FORTIFY_SOURCE=2 -DNDEBUG -Wall -Wformat -D_REENTRANT
-D_GNU_SOURCE -DTHREADS_HAVE_PIDS -DDEBUGGING -fno-strict-aliasing -pipe
-Wdeclaration-after-statement -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-I/usr/lib/perl5/5.8.8/x86_64-linux-thread-multi/CORE -MT Y2PerlComponent.lo
-MD -MP -MF .deps/Y2PerlComponent.Tpo -c Y2PerlComponent.cc  -fPIC -DPIC -o
.libs/Y2PerlComponent.o
icc: Command line warning: ignoring option '-W'; no argument required
cc1plus: warning: command line option "-Wdeclaration-after-statement" is valid
for C/ObjC but not for C++
cc1plus: warning: command line option "-Wdeclaration-after-statement" is valid
for C/ObjC but not for C++
YPerlNamespace.cc: In constructor
'YPerlNamespace::YPerlNamespace(std::string)':
YPerlNamespace.cc:406: internal compiler error: in voidify_wrapper_expr, at
gimplify.c:1016
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.

Preprocessed source code attached. No special flags required.


-- 
           Summary: ice for legal code
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dcb314 at hotmail dot com
  GCC host triplet: x86_64-suse-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30253

[Bug c++/30253] ice for legal code

[dcb314 at hotmail dot com]

------- Comment #1 from dcb314 at hotmail dot com  2006-12-18 17:10 -------
Created an attachment (id=12826)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12826&action=view)
gzipped C++ source code


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30253

[Bug c++/30253] ice for legal code

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2006-12-18 18:54 -------
Reducing ...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30253

[Bug c++/30253] ice for legal code

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2006-12-18 19:02 -------
Reduced testcase:
struct xpv {
    int xpv_cur;
};
bool m_all_methods;
void f(bool a)
{
  m_all_methods = ( a ? (({struct xpv *nxpv = 0;(nxpv->xpv_cur > 1  ); }) ? 1 :
0) :1);
}


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30253

[Bug c++/30253] [4.3 Regression] ICE with statement expression inside a conditional

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2006-12-21 18:45 -------
This was introduced between "4.3.0 20061202" and "4.3.0 20061220"


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   GCC host triplet|x86_64-suse-gnu             |
           Keywords|                            |ice-on-valid-code
   Last reconfirmed|0000-00-00 00:00:00         |2006-12-21 18:45:00
               date|                            |
            Summary|ice for legal code          |[4.3 Regression] ICE with
                   |                            |statement expression inside
                   |                            |a conditional
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30253

[Bug c++/30253] [4.3 Regression] ICE with statement expression inside a conditional

[dcb314 at hotmail dot com]

------- Comment #5 from dcb314 at hotmail dot com  2006-12-21 19:55 -------
(In reply to comment #4)
> This was introduced between "4.3.0 20061202" and "4.3.0 20061220"

Strange - is there a possible typo on the last date ?

I found snapshot 4.3-20061216 going wrong, so if the
last date is correct, we can reduce the interval
to 20061202 to 20061216.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30253

[Bug c++/30253] [4.3 Regression] ICE with statement expression inside a conditional

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2006-12-26 22:50 -------
This is obviously caused by the tuple changes.
I am trying to find a simple fix for this bug.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30253

[Bug middle-end/30253] [4.3 Regression] ICE with statement expression inside a conditional

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2006-12-26 22:56 -------
Here is the patch which I am going to test in the new year:
Index: gimplify.c
===================================================================
--- gimplify.c  (revision 120211)
+++ gimplify.c  (working copy)
@@ -1013,8 +1013,9 @@
          /* The wrapper is on the RHS of an assignment that we're pushing
             down.  */
          gcc_assert (TREE_CODE (temp) == INIT_EXPR
-                     || TREE_CODE (temp) == MODIFY_EXPR);
-         TREE_OPERAND (temp, 1) = *p;
+                     || TREE_CODE (temp) == MODIFY_EXPR
+                     || TREE_CODE (temp) == GIMPLE_MODIFY_STMT);
+         GENERIC_TREE_OPERAND (temp, 1) = *p;
          *p = temp;
        }
       else


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
          Component|c++                         |middle-end
   Last reconfirmed|2006-12-21 18:45:00         |2006-12-26 22:56:35
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30253

[Bug middle-end/30253] [4.3 Regression] ICE with statement expression inside a conditional

[pinskia at gcc dot gnu dot org]

------- Comment #8 from pinskia at gcc dot gnu dot org  2006-12-28 01:10 -------
*** Bug 30312 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gerald at pfeifer dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30253

[Bug middle-end/30253] [4.3 Regression] ICE with statement expression inside a conditional

[pinskia at gcc dot gnu dot org]

------- Comment #9 from pinskia at gcc dot gnu dot org  2006-12-28 01:11 -------
Another Testcase (simplier):
  #define f(x) ({ unsigned tmp=x; tmp; })

  unsigned foo(unsigned x) {
        return __builtin_constant_p(x) ? 0 : f(x);
  }


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |blocker
           Keywords|                            |build


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30253

[Bug middle-end/30253] [4.3 Regression] ICE with statement expression inside a conditional

[gerald at pfeifer dot com]

------- Comment #10 from gerald at pfeifer dot com  2006-12-31 14:27 -------
(In reply to comment #9)
> Another Testcase (simplier):
>   #define f(x) ({ unsigned tmp=x; tmp; })
> 
>   unsigned foo(unsigned x) {
>         return __builtin_constant_p(x) ? 0 : f(x);
>   }

Note that this small testcase of mine is destilled from FreeBSD's system
header.  This bug causes bootstrap failure on all FreeBSD systems I am
aware of (which is why Andrew labeled this a blocker, I assume).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30253

[Bug middle-end/30253] [4.3 Regression] ICE with statement expression inside a conditional

[rguenth at gcc dot gnu dot org]

------- Comment #11 from rguenth at gcc dot gnu dot org  2006-12-31 14:40 -------
The patch looks certainly obvious.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenth at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30253

[Bug middle-end/30253] [4.3 Regression] ICE with statement expression inside a conditional

[rguenth at gcc dot gnu dot org]

------- Comment #12 from rguenth at gcc dot gnu dot org  2006-12-31 19:25 -------
Bootstrapped and tested on i686-pc-linux-gnu.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30253

[Bug middle-end/30253] [4.3 Regression] ICE with statement expression inside a conditional

[pinskia at gcc dot gnu dot org]

------- Comment #13 from pinskia at gcc dot gnu dot org  2007-01-01 19:21 -------
I am going to test this and then apply it as obvious once the testing is
finished.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30253

[Bug middle-end/30253] [4.3 Regression] ICE with statement expression inside a conditional

[pinskia at gcc dot gnu dot org]

------- Comment #14 from pinskia at gcc dot gnu dot org  2007-01-01 22:20 -------
Subject: Bug 30253

Author: pinskia
Date: Mon Jan  1 22:19:58 2007
New Revision: 120321

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=120321
Log:
2007-01-01  Andrew Pinski  <pinskia@gmail.com>

        PR middle-end/30253
        * gimplify (voidify_wrapper_expr): Update for
        GIMPLIFY_MODIFY_STMT.

2007-01-01  Andrew Pinski  <pinskia@gmail.com>

        PR middle-end/30253
        * gcc.c-torture/compile/statement-expression-1.c: New test.



Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/statement-expression-1.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gimplify.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30253

[Bug middle-end/30253] [4.3 Regression] ICE with statement expression inside a conditional

[pinskia at gcc dot gnu dot org]

------- Comment #15 from pinskia at gcc dot gnu dot org  2007-01-01 22:21 -------
Fixed.  Thanks both for the report.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30253