public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/19020] libcalls are removed (-ftrapv does not work)
Date: Wed, 17 Jan 2007 15:35:00 -0000	[thread overview]
Message-ID: <20070117153509.9030.qmail@sourceware.org> (raw)
In-Reply-To: <bug-19020-226@http.gcc.gnu.org/bugzilla/>



------- Comment #5 from rguenth at gcc dot gnu dot org  2007-01-17 15:35 -------
There are a few issues, first we use emit_libcall_block to emit the trapping
PLUS
which sets a REG_EQUAL note with a non-trapping PLUS.

Second we analyze iaddv as not possibly throwing so we remove the call from
main()
during tree optimization as the result is unused.

Third, we widen the integer addition to DImode and dispatch to libgcc2
__addvdi3
which looks like

Dump of assembler code for function __addvdi3:
0x0000000000400580 <__addvdi3+0>:       sub    $0x8,%rsp
0x0000000000400584 <__addvdi3+4>:       test   %rsi,%rsi
0x0000000000400587 <__addvdi3+7>:       lea    (%rdi,%rsi,1),%rax
0x000000000040058b <__addvdi3+11>:      js     0x4005a0 <__addvdi3+32>
0x000000000040058d <__addvdi3+13>:      cmp    %rax,%rdi

so it tests for 64bit overflow instead of 32bit one.  Obviously allowind
LIBCALL_WIDEN is wrong for the trapping optabs, too.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenth at gcc dot gnu dot
                   |                            |org
           Keywords|                            |wrong-code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19020


  parent reply	other threads:[~2007-01-17 15:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-19020-226@http.gcc.gnu.org/bugzilla/>
2005-12-14 18:32 ` pinskia at gcc dot gnu dot org
2006-04-22 15:41 ` pinskia at gcc dot gnu dot org
2007-01-17 15:35 ` rguenth at gcc dot gnu dot org [this message]
2007-05-30 19:59 ` rguenth at gcc dot gnu dot org
2008-03-01 10:54 ` steven at gcc dot gnu dot org
2008-03-01 13:53 ` rguenth at gcc dot gnu dot org
2008-03-01 14:30 ` rguenth at gcc dot gnu dot org
2008-03-01 15:24 ` rguenth at gcc dot gnu dot org
2008-03-03 19:36 ` steven at gcc dot gnu dot org
2008-05-31  7:26 ` bonzini at gnu dot org
2008-07-18 18:23 ` rguenth at gcc dot gnu dot org
2008-11-29 22:21 ` ebotcazou at gcc dot gnu dot org
2008-11-29 22:25 ` steven at gcc dot gnu dot org
2008-11-29 22:30 ` ebotcazou at gcc dot gnu dot org
     [not found] <bug-19020-4@http.gcc.gnu.org/bugzilla/>
2014-02-16 13:17 ` jackie.rosen at hushmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070117153509.9030.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).