* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
[not found] <bug-14331-8015@http.gcc.gnu.org/bugzilla/>
@ 2005-11-02 1:43 ` pinskia at gcc dot gnu dot org
2007-01-08 1:22 ` tromey at gcc dot gnu dot org
` (13 subsequent siblings)
14 siblings, 0 replies; 20+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-11-02 1:43 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from pinskia at gcc dot gnu dot org 2005-11-02 01:43 -------
(In reply to comment #6)
> Created an attachment (id=8456)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=8456&action=view) [edit]
> Dave Korn's patch to add a -Wno-eof-newline option
Dave,
This seems like the right patch, could you update it for the changes in
options and the preprocessor sources moving?
If you don't have time to do it, I can do it.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pinskia at gcc dot gnu dot
| |org
Last reconfirmed|2005-06-24 13:34:23 |2005-11-02 01:43:31
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
[not found] <bug-14331-8015@http.gcc.gnu.org/bugzilla/>
2005-11-02 1:43 ` [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file" pinskia at gcc dot gnu dot org
@ 2007-01-08 1:22 ` tromey at gcc dot gnu dot org
2007-01-22 8:52 ` manu at gcc dot gnu dot org
` (12 subsequent siblings)
14 siblings, 0 replies; 20+ messages in thread
From: tromey at gcc dot gnu dot org @ 2007-01-08 1:22 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from tromey at gcc dot gnu dot org 2007-01-08 01:21 -------
What is the status of this patch?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
[not found] <bug-14331-8015@http.gcc.gnu.org/bugzilla/>
2005-11-02 1:43 ` [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file" pinskia at gcc dot gnu dot org
2007-01-08 1:22 ` tromey at gcc dot gnu dot org
@ 2007-01-22 8:52 ` manu at gcc dot gnu dot org
2007-03-06 14:44 ` JBoncek at Hunter dot Com
` (11 subsequent siblings)
14 siblings, 0 replies; 20+ messages in thread
From: manu at gcc dot gnu dot org @ 2007-01-22 8:52 UTC (permalink / raw)
To: gcc-bugs
------- Comment #9 from manu at gcc dot gnu dot org 2007-01-22 08:52 -------
In my opinion the patch is too old, now we have other mechanism for handling
options, and it lacks documentation updates and testcases. Also, it is a
standards conformance warning, so perhaps it should be just moved to -pedantic
(if you look at the code, it is already a pedantic warning, it is just enabled
all the time). This will avoid adding yet another warning option.
--
manu at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |manu at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
[not found] <bug-14331-8015@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2007-01-22 8:52 ` manu at gcc dot gnu dot org
@ 2007-03-06 14:44 ` JBoncek at Hunter dot Com
2007-03-27 15:26 ` dave dot korn at artimi dot com
` (10 subsequent siblings)
14 siblings, 0 replies; 20+ messages in thread
From: JBoncek at Hunter dot Com @ 2007-03-06 14:44 UTC (permalink / raw)
To: gcc-bugs
------- Comment #10 from JBoncek at Hunter dot Com 2007-03-06 14:44 -------
This is just a nuisance at the end of a .c or .cpp file. It is, however, a
serious error that should always be notified at the end of an included (header)
file.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
[not found] <bug-14331-8015@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2007-03-06 14:44 ` JBoncek at Hunter dot Com
@ 2007-03-27 15:26 ` dave dot korn at artimi dot com
2007-03-27 23:22 ` manu at gcc dot gnu dot org
` (9 subsequent siblings)
14 siblings, 0 replies; 20+ messages in thread
From: dave dot korn at artimi dot com @ 2007-03-27 15:26 UTC (permalink / raw)
To: gcc-bugs
------- Comment #11 from dave dot korn at artimi dot com 2007-03-27 16:26 -------
Tom: The status is "Ooops, completely forgot about that one". (Well, to be
fair, it's "Ooops, never even knew about that one as I wasn't on the Cc: list
for this bug until I stumbled across it today purely by chance"; Dan Kegel
added my patch to this PR, Andrew Pinski thought I was on the Cc list at
comment #7 but I wasn't.... so this is the first I know of it!)
The issue just came up on the gcc list today, though, so I think I should
pick it back up. If I forget again, please feel free to drop me private email
to remind me.
Manuel: Yes, the patch is against 3.3 series, I didn't actually formally
submit it but just posted it to the list when someone was in need of a patch.
See
http://gcc.gnu.org/ml/gcc/2004-07/msg00798.html
Before resubmitting I would /of course/ a) up-port to current mainline b) use
the most appropriate of the current options-handling mechanisms and c) add
testcases and docs. Can you advise me what you think the best way to add the
option is? I particularly think I ought to avoid "manually copying a global
in c_common_post_options" (as I wrote at url above).
--
dave dot korn at artimi dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dave dot korn at artimi dot
| |com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
[not found] <bug-14331-8015@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2007-03-27 15:26 ` dave dot korn at artimi dot com
@ 2007-03-27 23:22 ` manu at gcc dot gnu dot org
2007-04-07 13:08 ` dave dot korn at artimi dot com
` (8 subsequent siblings)
14 siblings, 0 replies; 20+ messages in thread
From: manu at gcc dot gnu dot org @ 2007-03-27 23:22 UTC (permalink / raw)
To: gcc-bugs
------- Comment #12 from manu at gcc dot gnu dot org 2007-03-28 00:21 -------
(In reply to comment #11)
> Manuel: Yes, the patch is against 3.3 series, I didn't actually formally
> submit it but just posted it to the list when someone was in need of a patch.
> See
>
> http://gcc.gnu.org/ml/gcc/2004-07/msg00798.html
>
> Before resubmitting I would /of course/ a) up-port to current mainline b) use
> the most appropriate of the current options-handling mechanisms and c) add
> testcases and docs. Can you advise me what you think the best way to add the
> option is? I particularly think I ought to avoid "manually copying a global
> in c_common_post_options" (as I wrote at url above).
>
I was not criticizing your patch. Tom asked and I gave my opinion: that the
patch would need to be updated by someone (not necessarily you) before being
accepted.
To see the proper way to add the option look for endif_labels in c.opt and
c-opts.c. Notice that you don't need to define a global option anymore in
gcc/flags.h (although it seems that you still need it in
libcpp/include/cpplib.h).
To keep current behaviour, you need to enable the option by default. If it were
a front-end option you would need to enable it in c.opt using Init(1) (see
other options in the same file). However, I don't think that setting affects
automatically CPP options, so probably you need to set the option in
libccp/init.c as you do in your original patch. Of course, you also need to
conditionalize the warning on the option, but your patch already does this.
I hope this helps.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
[not found] <bug-14331-8015@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2007-03-27 23:22 ` manu at gcc dot gnu dot org
@ 2007-04-07 13:08 ` dave dot korn at artimi dot com
2007-04-07 15:01 ` pbrook at gcc dot gnu dot org
` (7 subsequent siblings)
14 siblings, 0 replies; 20+ messages in thread
From: dave dot korn at artimi dot com @ 2007-04-07 13:08 UTC (permalink / raw)
To: gcc-bugs
------- Comment #13 from dave dot korn at artimi dot com 2007-04-07 14:07 -------
Manu: "I was not criticizing your patch. [ ... ] "
So sorry, I didn't mean you to think I was offended! I took your comment
completely at face value.
" [ ... ] I hope this helps."
It most certainly does! I am testing a revised and updated patch.
cheers,
DaveK
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
[not found] <bug-14331-8015@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2007-04-07 13:08 ` dave dot korn at artimi dot com
@ 2007-04-07 15:01 ` pbrook at gcc dot gnu dot org
2007-04-10 14:12 ` davek at gcc dot gnu dot org
` (6 subsequent siblings)
14 siblings, 0 replies; 20+ messages in thread
From: pbrook at gcc dot gnu dot org @ 2007-04-07 15:01 UTC (permalink / raw)
To: gcc-bugs
--
pbrook at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |dave dot korn at artimi dot
|dot org |com
Status|NEW |ASSIGNED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
[not found] <bug-14331-8015@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2007-04-07 15:01 ` pbrook at gcc dot gnu dot org
@ 2007-04-10 14:12 ` davek at gcc dot gnu dot org
2007-04-10 15:42 ` patchapp at dberlin dot org
` (5 subsequent siblings)
14 siblings, 0 replies; 20+ messages in thread
From: davek at gcc dot gnu dot org @ 2007-04-10 14:12 UTC (permalink / raw)
To: gcc-bugs
------- Comment #14 from davek at gcc dot gnu dot org 2007-04-10 15:11 -------
Patch posted for review at
http://gcc.gnu.org/ml/gcc-patches/2007-04/msg00457.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
[not found] <bug-14331-8015@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2007-04-10 14:12 ` davek at gcc dot gnu dot org
@ 2007-04-10 15:42 ` patchapp at dberlin dot org
2007-04-17 17:48 ` davek at gcc dot gnu dot org
` (4 subsequent siblings)
14 siblings, 0 replies; 20+ messages in thread
From: patchapp at dberlin dot org @ 2007-04-10 15:42 UTC (permalink / raw)
To: gcc-bugs
------- Comment #15 from patchapp at dberlin dot org 2007-04-10 16:41 -------
Subject: Bug number PR14331
A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-04/msg00457.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
[not found] <bug-14331-8015@http.gcc.gnu.org/bugzilla/>
` (9 preceding siblings ...)
2007-04-10 15:42 ` patchapp at dberlin dot org
@ 2007-04-17 17:48 ` davek at gcc dot gnu dot org
2007-05-07 12:45 ` patchapp at dberlin dot org
` (3 subsequent siblings)
14 siblings, 0 replies; 20+ messages in thread
From: davek at gcc dot gnu dot org @ 2007-04-17 17:48 UTC (permalink / raw)
To: gcc-bugs
------- Comment #16 from davek at gcc dot gnu dot org 2007-04-17 18:47 -------
Oh, BTW, congratulations Tom on being appointed a libcpp maintainer!
<grin-grin-hint-hint-nudge-nudge-wink-wink....>
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
[not found] <bug-14331-8015@http.gcc.gnu.org/bugzilla/>
` (10 preceding siblings ...)
2007-04-17 17:48 ` davek at gcc dot gnu dot org
@ 2007-05-07 12:45 ` patchapp at dberlin dot org
2007-05-28 16:38 ` fxcoudert at gcc dot gnu dot org
` (2 subsequent siblings)
14 siblings, 0 replies; 20+ messages in thread
From: patchapp at dberlin dot org @ 2007-05-07 12:45 UTC (permalink / raw)
To: gcc-bugs
------- Comment #17 from patchapp at dberlin dot org 2007-05-07 13:45 -------
Subject: Bug number preprocessor/14331
A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-05/msg00399.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
[not found] <bug-14331-8015@http.gcc.gnu.org/bugzilla/>
` (11 preceding siblings ...)
2007-05-07 12:45 ` patchapp at dberlin dot org
@ 2007-05-28 16:38 ` fxcoudert at gcc dot gnu dot org
2007-05-31 2:07 ` davek at gcc dot gnu dot org
2007-06-11 22:00 ` pinskia at gcc dot gnu dot org
14 siblings, 0 replies; 20+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2007-05-28 16:38 UTC (permalink / raw)
To: gcc-bugs
------- Comment #18 from fxcoudert at gcc dot gnu dot org 2007-05-28 16:38 -------
Patch was approved...
--
fxcoudert at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fxcoudert at gcc dot gnu dot
| |org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
[not found] <bug-14331-8015@http.gcc.gnu.org/bugzilla/>
` (12 preceding siblings ...)
2007-05-28 16:38 ` fxcoudert at gcc dot gnu dot org
@ 2007-05-31 2:07 ` davek at gcc dot gnu dot org
2007-06-11 22:00 ` pinskia at gcc dot gnu dot org
14 siblings, 0 replies; 20+ messages in thread
From: davek at gcc dot gnu dot org @ 2007-05-31 2:07 UTC (permalink / raw)
To: gcc-bugs
------- Comment #19 from davek at gcc dot gnu dot org 2007-05-31 02:07 -------
Subject: Bug 14331
Author: davek
Date: Thu May 31 02:06:48 2007
New Revision: 125212
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=125212
Log:
2007-05-31 Dave Korn <dave.korn@artimi.com>
PR preprocessor/14331
* lex.c (_cpp_get_fresh_line): Don't warn if no newline at EOF.
Modified:
trunk/libcpp/ChangeLog
trunk/libcpp/lex.c
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
[not found] <bug-14331-8015@http.gcc.gnu.org/bugzilla/>
` (13 preceding siblings ...)
2007-05-31 2:07 ` davek at gcc dot gnu dot org
@ 2007-06-11 22:00 ` pinskia at gcc dot gnu dot org
14 siblings, 0 replies; 20+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-06-11 22:00 UTC (permalink / raw)
To: gcc-bugs
------- Comment #20 from pinskia at gcc dot gnu dot org 2007-06-11 22:00 -------
Fixed.
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
Target Milestone|--- |4.3.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
2004-02-28 10:10 [Bug c/14331] New: " ahrivera at yahoo dot com
@ 2004-02-28 20:35 ` pinskia at gcc dot gnu dot org
2004-06-29 23:57 ` crowder at fiverocks dot com
` (3 subsequent siblings)
4 siblings, 0 replies; 20+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-02-28 20:35 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-02-28 20:35 -------
Confirmed, note that on some C preprocessors will just error out as this is required by the standard.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Component|c |preprocessor
Ever Confirmed| |1
Keywords| |diagnostic
Last reconfirmed|0000-00-00 00:00:00 |2004-02-28 20:35:50
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
2004-02-28 10:10 [Bug c/14331] New: " ahrivera at yahoo dot com
2004-02-28 20:35 ` [Bug preprocessor/14331] " pinskia at gcc dot gnu dot org
@ 2004-06-29 23:57 ` crowder at fiverocks dot com
2004-06-30 13:44 ` bangerth at dealii dot org
` (2 subsequent siblings)
4 siblings, 0 replies; 20+ messages in thread
From: crowder at fiverocks dot com @ 2004-06-29 23:57 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From crowder at fiverocks dot com 2004-06-29 23:56 -------
If there is a way to encourage this bug to achieve higher priority, I would love
to do it. Using GCC and MSVC (and Dev Studio) together, one runs into this one
a lot. A -w flag to turn this warning off would be outstanding.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
2004-02-28 10:10 [Bug c/14331] New: " ahrivera at yahoo dot com
2004-02-28 20:35 ` [Bug preprocessor/14331] " pinskia at gcc dot gnu dot org
2004-06-29 23:57 ` crowder at fiverocks dot com
@ 2004-06-30 13:44 ` bangerth at dealii dot org
2004-06-30 13:51 ` giovannibajo at libero dot it
2005-03-25 18:29 ` dank at kegel dot com
4 siblings, 0 replies; 20+ messages in thread
From: bangerth at dealii dot org @ 2004-06-30 13:44 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From bangerth at dealii dot org 2004-06-30 13:29 -------
I bet it would be a lot more work to add this flag to gcc than to do
something like
for i in * ; do echo >> $i ; done
on the files for which you get this warning. Adding flags to gcc is
complex and has some future maintainance costs, whereas it is really
easy to fix this problem in your own sources.
W.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
2004-02-28 10:10 [Bug c/14331] New: " ahrivera at yahoo dot com
` (2 preceding siblings ...)
2004-06-30 13:44 ` bangerth at dealii dot org
@ 2004-06-30 13:51 ` giovannibajo at libero dot it
2005-03-25 18:29 ` dank at kegel dot com
4 siblings, 0 replies; 20+ messages in thread
From: giovannibajo at libero dot it @ 2004-06-30 13:51 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From giovannibajo at libero dot it 2004-06-30 13:48 -------
I agree with Wolfgang, it's just too easy to fix the source to be worth wasting
developer time. Brian, if you feel strongly about it, why don't you just
prepare a patch yourself? Adding a flag for a warning and an if() before the
warning line isn't that hard.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread* [Bug preprocessor/14331] please add option to suppress warning message "no newline at end of file"
2004-02-28 10:10 [Bug c/14331] New: " ahrivera at yahoo dot com
` (3 preceding siblings ...)
2004-06-30 13:51 ` giovannibajo at libero dot it
@ 2005-03-25 18:29 ` dank at kegel dot com
4 siblings, 0 replies; 20+ messages in thread
From: dank at kegel dot com @ 2005-03-25 18:29 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From dank at kegel dot com 2005-03-25 18:29 -------
A patch to gcc-3.3.3 to do exactly what you're asking for was posted
by Dave Korn a few months ago, and approved in principle:
http://gcc.gnu.org/ml/gcc/2004-07/msg00798.html
I'll attach a copy of the patch here.
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |dank at kegel dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331
^ permalink raw reply [flat|nested] 20+ messages in thread