public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libfortran/30690] New: Clean up m4 files
@ 2007-02-03 12:15 tkoenig at gcc dot gnu dot org
2007-02-03 12:51 ` [Bug libfortran/30690] " fxcoudert at gcc dot gnu dot org
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-02-03 12:15 UTC (permalink / raw)
To: gcc-bugs
Right now, the files from the m4 directory don't follow
a sane nor uniform quoting style. What they do is also
undocumented.
This section of the code needs to be documented better, and
also needs some cleanup. Alternatively, a rewrite
would be in order.
--
Summary: Clean up m4 files
Product: gcc
Version: 4.3.0
Status: UNCONFIRMED
Severity: enhancement
Priority: P3
Component: libfortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: tkoenig at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30690
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libfortran/30690] Clean up m4 files
2007-02-03 12:15 [Bug libfortran/30690] New: Clean up m4 files tkoenig at gcc dot gnu dot org
@ 2007-02-03 12:51 ` fxcoudert at gcc dot gnu dot org
2007-03-03 22:06 ` tkoenig at gcc dot gnu dot org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2007-02-03 12:51 UTC (permalink / raw)
To: gcc-bugs
--
fxcoudert at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2007-02-03 12:51:08
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30690
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libfortran/30690] Clean up m4 files
2007-02-03 12:15 [Bug libfortran/30690] New: Clean up m4 files tkoenig at gcc dot gnu dot org
2007-02-03 12:51 ` [Bug libfortran/30690] " fxcoudert at gcc dot gnu dot org
@ 2007-03-03 22:06 ` tkoenig at gcc dot gnu dot org
2007-03-04 21:00 ` tkoenig at gcc dot gnu dot org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-03-03 22:06 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from tkoenig at gcc dot gnu dot org 2007-03-03 22:05 -------
Created an attachment (id=13137)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=13137&action=view)
example patch for cshift1
This is how a cleanup could look: Quote everything except
for the macros, which need to be unqouted.
Thomas
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30690
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libfortran/30690] Clean up m4 files
2007-02-03 12:15 [Bug libfortran/30690] New: Clean up m4 files tkoenig at gcc dot gnu dot org
2007-02-03 12:51 ` [Bug libfortran/30690] " fxcoudert at gcc dot gnu dot org
2007-03-03 22:06 ` tkoenig at gcc dot gnu dot org
@ 2007-03-04 21:00 ` tkoenig at gcc dot gnu dot org
2007-03-14 19:27 ` tkoenig at gcc dot gnu dot org
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-03-04 21:00 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from tkoenig at gcc dot gnu dot org 2007-03-04 20:59 -------
I'll give this a shot.
--
tkoenig at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |tkoenig at gcc dot gnu dot
|dot org |org
Status|NEW |ASSIGNED
Last reconfirmed|2007-02-03 12:51:08 |2007-03-04 20:59:52
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30690
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libfortran/30690] Clean up m4 files
2007-02-03 12:15 [Bug libfortran/30690] New: Clean up m4 files tkoenig at gcc dot gnu dot org
` (2 preceding siblings ...)
2007-03-04 21:00 ` tkoenig at gcc dot gnu dot org
@ 2007-03-14 19:27 ` tkoenig at gcc dot gnu dot org
2007-03-14 19:40 ` [Bug libfortran/30690] [4.2, 4.1 only] " tkoenig at gcc dot gnu dot org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-03-14 19:27 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from tkoenig at gcc dot gnu dot org 2007-03-14 19:26 -------
Subject: Bug 30690
Author: tkoenig
Date: Wed Mar 14 19:26:38 2007
New Revision: 122927
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=122927
Log:
2007-03-14 Thomas Koenig <Thomas.Koenig@online.de>
PR libfortran/30690
* all.m4: Quote everything, except for m4 macros.
* any.m4: Likewise.
* count.m4: Likewise.
* cshift1.m4: Likewise.
* eoshift1.m4: Likewise.
* eoshift3.m4: Likewise.
* exponent.m4: Likewise.
* fraction.m4: Likewise.
* in_pack.m4: Likewise.
* in_unpack.m4: Likewise.
* matmul.m4: Likewise.
* matmull.m4: Likewise.
* nearest.m4: Likewise.
* pow.m4: Likewise.
* product.m4: Likewise.
* reshape.m4: Likewise.
* rrspacing.m4: Likewise.
* set_exponent.m4: Likewise.
* shape.m4: Likewise.
* spacing.m4: Likewise.
* transpose.m4: Likewise.
Modified:
trunk/libgfortran/ChangeLog
trunk/libgfortran/m4/all.m4
trunk/libgfortran/m4/any.m4
trunk/libgfortran/m4/count.m4
trunk/libgfortran/m4/cshift1.m4
trunk/libgfortran/m4/eoshift1.m4
trunk/libgfortran/m4/eoshift3.m4
trunk/libgfortran/m4/exponent.m4
trunk/libgfortran/m4/fraction.m4
trunk/libgfortran/m4/in_pack.m4
trunk/libgfortran/m4/in_unpack.m4
trunk/libgfortran/m4/matmul.m4
trunk/libgfortran/m4/matmull.m4
trunk/libgfortran/m4/nearest.m4
trunk/libgfortran/m4/pow.m4
trunk/libgfortran/m4/product.m4
trunk/libgfortran/m4/reshape.m4
trunk/libgfortran/m4/rrspacing.m4
trunk/libgfortran/m4/set_exponent.m4
trunk/libgfortran/m4/shape.m4
trunk/libgfortran/m4/spacing.m4
trunk/libgfortran/m4/transpose.m4
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30690
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libfortran/30690] [4.2, 4.1 only] Clean up m4 files
2007-02-03 12:15 [Bug libfortran/30690] New: Clean up m4 files tkoenig at gcc dot gnu dot org
` (3 preceding siblings ...)
2007-03-14 19:27 ` tkoenig at gcc dot gnu dot org
@ 2007-03-14 19:40 ` tkoenig at gcc dot gnu dot org
2007-05-22 13:57 ` burnus at gcc dot gnu dot org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-03-14 19:40 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from tkoenig at gcc dot gnu dot org 2007-03-14 19:40 -------
Waiting for 4.2 to thaw before a backport.
--
tkoenig at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Clean up m4 files |[4.2, 4.1 only] Clean up m4
| |files
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30690
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libfortran/30690] [4.2, 4.1 only] Clean up m4 files
2007-02-03 12:15 [Bug libfortran/30690] New: Clean up m4 files tkoenig at gcc dot gnu dot org
` (4 preceding siblings ...)
2007-03-14 19:40 ` [Bug libfortran/30690] [4.2, 4.1 only] " tkoenig at gcc dot gnu dot org
@ 2007-05-22 13:57 ` burnus at gcc dot gnu dot org
2007-05-22 20:03 ` tkoenig at gcc dot gnu dot org
2007-05-26 3:17 ` pinskia at gcc dot gnu dot org
7 siblings, 0 replies; 9+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-05-22 13:57 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from burnus at gcc dot gnu dot org 2007-05-22 14:56 -------
(In reply to comment #4)
> Waiting for 4.2 to thaw before a backport.
If you think it should be backported to 4.2 (regression, serious bug), you now
may backport it. Otherwise, you can close this PR.
Mark Mitchell: "GCC 4.2 branch open for regression fixes"
http://gcc.gnu.org/ml/gcc-patches/2007-05/msg01018.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30690
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libfortran/30690] [4.2, 4.1 only] Clean up m4 files
2007-02-03 12:15 [Bug libfortran/30690] New: Clean up m4 files tkoenig at gcc dot gnu dot org
` (5 preceding siblings ...)
2007-05-22 13:57 ` burnus at gcc dot gnu dot org
@ 2007-05-22 20:03 ` tkoenig at gcc dot gnu dot org
2007-05-26 3:17 ` pinskia at gcc dot gnu dot org
7 siblings, 0 replies; 9+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-05-22 20:03 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from tkoenig at gcc dot gnu dot org 2007-05-22 21:02 -------
After some thoughts, I don't think it is worth backporting to 4.2.
Closing.
--
tkoenig at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30690
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libfortran/30690] [4.2, 4.1 only] Clean up m4 files
2007-02-03 12:15 [Bug libfortran/30690] New: Clean up m4 files tkoenig at gcc dot gnu dot org
` (6 preceding siblings ...)
2007-05-22 20:03 ` tkoenig at gcc dot gnu dot org
@ 2007-05-26 3:17 ` pinskia at gcc dot gnu dot org
7 siblings, 0 replies; 9+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-05-26 3:17 UTC (permalink / raw)
To: gcc-bugs
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.3.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30690
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2007-05-26 3:17 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-03 12:15 [Bug libfortran/30690] New: Clean up m4 files tkoenig at gcc dot gnu dot org
2007-02-03 12:51 ` [Bug libfortran/30690] " fxcoudert at gcc dot gnu dot org
2007-03-03 22:06 ` tkoenig at gcc dot gnu dot org
2007-03-04 21:00 ` tkoenig at gcc dot gnu dot org
2007-03-14 19:27 ` tkoenig at gcc dot gnu dot org
2007-03-14 19:40 ` [Bug libfortran/30690] [4.2, 4.1 only] " tkoenig at gcc dot gnu dot org
2007-05-22 13:57 ` burnus at gcc dot gnu dot org
2007-05-22 20:03 ` tkoenig at gcc dot gnu dot org
2007-05-26 3:17 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).